Re: [ovs-dev] [PATCH] classifier: Prevent tries vs n_tries race leading to NULL dereference.

2020-04-14 Thread Ilya Maximets
On 4/14/20 6:00 AM, Eiichi Tsukata wrote: > Currently classifier tries and n_tries can be updated not atomically, > there is a race condition which can lead to NULL dereference. > The race can happen when main thread updates a classifier tries and > n_tries in classifier_set_prefix_fields() and at

Re: [ovs-dev] (no subject)

2020-04-14 Thread Bertrand Gabriiel via dev
Dear Friend, I sent you a mail earlier but not sure if you received it, kindly check your email and get back to me for I have a very urgent information to pass to you. Best regards, Bertrand Gabriel ___ dev mailing list d...@openvswitch.org https://mai

[ovs-dev] hi

2020-04-14 Thread Mrs.Roseline Benjamin via dev
Hello, My name is Mrs.Roseline Benjamin. I am living in Madrid Spain,please I want to entrust a huge amount of money in your care €4,5 million Euros for charity work in your country.I have been suffering from cancer I want to know if I can trust you to use this funds for Charity & Orphanage.P

Re: [ovs-dev] [PATCHv4] netdev-afxdp: Add interrupt mode netdev class.

2020-04-14 Thread William Tu
On Mon, Apr 13, 2020 at 3:20 PM Ilya Maximets wrote: > > On 3/25/20 10:44 PM, William Tu wrote: > > The patch adds a new netdev class 'afxdp-nonpmd' to enable afxdp > > interrupt mode. This is similar to 'type=afxdp', except that the > > is_pmd field is set to false. As a result, the packet proces

Re: [ovs-dev] [PATCH] ofp-actions: Fix memory leak on error path.

2020-04-14 Thread William Tu
On Mon, Apr 13, 2020 at 9:26 AM Yifeng Sun wrote: > > Looks good to me, thanks. > > Reviewed-by: Yifeng Sun > Applied to master, thanks ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCHv5] netdev-afxdp: Add interrupt mode netdev class.

2020-04-14 Thread William Tu
The patch adds a new netdev class 'afxdp-nonpmd' to enable afxdp interrupt mode. This is similar to 'type=afxdp', except that the is_pmd field is set to false. As a result, the packet processing is handled by main thread, not pmd thread. This avoids burning the CPU to always 100% when there is no t

Re: [ovs-dev] [PATCHv2] fatal-signal: Remove snprintf.

2020-04-14 Thread William Tu
On Mon, Apr 13, 2020 at 3:37 PM Yifeng Sun wrote: > > Thanks, looks good to me. > > Tested-by: Yifeng Sun > > Reviewed-by: Yifeng Sun > > > On Wed, Mar 25, 2020 at 11:51 AM William Tu wrote: >> >> Function snprintf is not async-signal-safe. Replace it with >> our own implementation. Example o

[ovs-dev] [PATCHv3] fatal-signal: Remove snprintf.

2020-04-14 Thread William Tu
Function snprintf is not async-signal-safe. Replace it with our own implementation. Example ovs-vswitchd.log output: 2020-03-25T01:08:19.673Z|00050|memory|INFO|handlers:2 ports:3 SIGSEGV detected, backtrace: 0x4872d9 0x7f4e2ab974b0 0x7f4e2ac5d74d <__poll+0x2d> 0x531098

[ovs-dev] [PATCH] compat: Fix broken partial backport of extack op parameter

2020-04-14 Thread Greg Rose
A series of commits added support for the extended ack parameter to the newlink, changelink and validate ops in the rtnl_link_ops structure: a8b8a889e369d ("net: add netlink_ext_ack argument to rtnl_link_ops.validate") 7a3f4a185169b ("net: add netlink_ext_ack argument to rtnl_link_ops.newlink") ad7

[ovs-dev] Dev, New Featured Shirts! SALE OFF 10% And Free Shipping Now! Don't Miss Out

2020-04-14 Thread kieuloan5483
NEW FEATURED SHIRTS Explore The New Collection And Find The Perfect T-shirt For This Season: Keeping My Mouth Shut T-shirt. Trust Me On This You Cant Fix Stupid T-Shirt. March Sadness Everythings Cancelled T-shirt. Forgive Me If I Don't Shake Hands T-shirt. == 100

Re: [ovs-dev] [PATCH] AB bonding: Add "primary" interface concept

2020-04-14 Thread Gregory Rose
On 4/13/2020 11:51 AM, Jeff Squyres (jsquyres) via dev wrote: Greetings all. What is the process to get someone to review a patch like the one below? We're using this patch internally (it's a feature that Linux bridges have), and would be happy to do whatever is required to upstream it. Th

Re: [ovs-dev] [PATCH] compat: Fix broken partial backport of extack op parameter

2020-04-14 Thread Gregory Rose
On 4/14/2020 9:52 AM, Greg Rose wrote: A series of commits added support for the extended ack parameter to the newlink, changelink and validate ops in the rtnl_link_ops structure: a8b8a889e369d ("net: add netlink_ext_ack argument to rtnl_link_ops.validate") 7a3f4a185169b ("net: add netlink_ext

[ovs-dev] [PATCH V2] compat: Fix broken partial backport of extack op parameter

2020-04-14 Thread Greg Rose
A series of commits added support for the extended ack parameter to the newlink, changelink and validate ops in the rtnl_link_ops structure: a8b8a889e369d ("net: add netlink_ext_ack argument to rtnl_link_ops.validate") 7a3f4a185169b ("net: add netlink_ext_ack argument to rtnl_link_ops.newlink") ad7

Re: [ovs-dev] [PATCH] ofp-actions: Add delete field action

2020-04-14 Thread Yi-Hung Wei
On Sat, Apr 11, 2020 at 8:10 AM William Tu wrote: > > Hi Yi-Hung, > > I read through the patch and have some questions and comments. > > On Fri, Apr 10, 2020 at 01:05:24PM -0700, Yi-Hung Wei wrote: > > This patch adds a new OpenFlow action, delete field, to delete a > > field in packets. Currentl

[ovs-dev] [PATCH v2] ofp-actions: Add delete field action

2020-04-14 Thread Yi-Hung Wei
This patch adds a new OpenFlow action, delete field, to delete a field in packets. Currently, only the tun_metadata fields are supported. One use case to add this action is to support multiple versions of geneve tunnel metadatas to be exchanged among different versions of networks. For example,

Re: [ovs-dev] [PATCH] AB bonding: Add "primary" interface concept

2020-04-14 Thread Gregory Rose
On 4/14/2020 11:08 AM, Gregory Rose wrote: On 4/13/2020 11:51 AM, Jeff Squyres (jsquyres) via dev wrote: Greetings all. What is the process to get someone to review a patch like the one below?  We're using this patch internally (it's a feature that Linux bridges have), and would be happy to

Re: [ovs-dev] [PATCHv3] fatal-signal: Remove snprintf.

2020-04-14 Thread Yifeng Sun
Thanks for fixing gcc10, looks good to me. Tested-by: Yifeng Sun Reviewed-by: Yifeng Sun On Tue, Apr 14, 2020 at 8:17 AM William Tu wrote: > Function snprintf is not async-signal-safe. Replace it with > our own implementation. Example ovs-vswitchd.log output: > 2020-03-25T01:08:19.673Z|0

Re: [ovs-dev] [PATCH] classifier: Prevent tries vs n_tries race leading to NULL dereference.

2020-04-14 Thread Eiichi Tsukata
Thanks for comments, Ilya. > On Apr 14, 2020, at 21:11, Ilya Maximets wrote: > > On 4/14/20 6:00 AM, Eiichi Tsukata wrote: >> >> >> @@ -1575,11 +1573,16 @@ check_tries(struct trie_ctx trie_ctx[CLS_MAX_TRIES], >> unsigned int n_tries, >> * fields using the prefix tries. The trie checks a

Re: [ovs-dev] [PATCH V2] compat: Fix broken partial backport of extack op parameter

2020-04-14 Thread Yifeng Sun
LGTM, thanks Greg. Reviewed-by: Yifeng Sun On Tue, Apr 14, 2020 at 11:42 AM Greg Rose wrote: > A series of commits added support for the extended ack > parameter to the newlink, changelink and validate ops in > the rtnl_link_ops structure: > a8b8a889e369d ("net: add netlink_ext_ack argument to

[ovs-dev] [PATCH RFC ovn] Support logical switches with multiple localnet ports

2020-04-14 Thread Ihar Hrachyshka
Assuming only a single localnet port is actually plugged mapped on each chassis, this allows to maintain disjoint networks plugged to the same switch. This is useful to simplify resource management for OpenStack "routed provider networks" feature [1] where a single "network" (which traditionally m