Re: [ovs-dev] [PATCH net-next v2 2/5] net: openvswitch: set max limitation to meters

2020-04-20 Thread Pravin Shelar
On Sun, Apr 19, 2020 at 5:28 PM Tonghao Zhang wrote: > > On Mon, Apr 20, 2020 at 1:31 AM Pravin Shelar wrote: > > > > On Sat, Apr 18, 2020 at 10:25 AM wrote: > > > > > > From: Tonghao Zhang > > > > > > Don't allow user to create meter unlimitedly, > > > which may cause to consume a large

Re: [ovs-dev] [PATCH net-next v2 1/5] net: openvswitch: expand the meters supported number

2020-04-20 Thread Pravin Shelar
On Sun, Apr 19, 2020 at 5:23 PM Tonghao Zhang wrote: > > On Mon, Apr 20, 2020 at 1:29 AM Pravin Shelar wrote: > > > > On Sat, Apr 18, 2020 at 10:25 AM wrote: > > > > > > From: Tonghao Zhang > > > > > > In kernel datapath of Open vSwitch, there are only 1024 > > > buckets of meter in one dp. If

[ovs-dev] se former a la maison

2020-04-20 Thread Fabien COUTARIER
* {line-height: inherit;} .ExternalClass * { line-height: 100%; } body, p{margin:0; padding:0; margin-bottom:0; -webkit-text-size-adjust:none; -ms-text-size-adjust:none;} img{line-height:100%; outline:none; text-decoration:none; -ms-interpolation-mode: bicubic;} a img{border: none;} a, a:link,

Re: [ovs-dev] OVS DPDK VF port representors not working

2020-04-20 Thread Ravi Kerur
On Mon, Apr 20, 2020 at 10:37 AM Ravi Kerur wrote: > > > On Mon, Apr 20, 2020 at 3:14 AM Ilya Maximets wrote: > >> On 4/19/20 6:08 PM, Ravi Kerur wrote: >> > >> > >> > On Sun, Apr 19, 2020 at 6:14 AM Ilya Maximets > > wrote: >> > >> > On 4/18/20 2:33 PM, Ravi

Re: [ovs-dev] [PATCH] net: openvswitch: ovs_ct_exit to be done under ovs_lock

2020-04-20 Thread David Miller
From: xiangxia.m@gmail.com Date: Fri, 17 Apr 2020 02:57:31 +0800 > From: Tonghao Zhang > > syzbot wrote: ... > To avoid that warning, invoke the ovs_ct_exit under ovs_lock and add > lockdep_ovsl_is_held as optional lockdep expression. > > Link:

Re: [ovs-dev] [PATCH 1/1] ofproto: Fix ofgroup ref_count in the group stats.

2020-04-20 Thread 0-day Robot
Bleep bloop. Greetings Pier Luigi Ventre, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Pier Luigi Ventre needs to sign off. WARNING: Unexpected sign-offs from

Re: [ovs-dev] [PATCH] Utilities: Add the ovs_dump_ofpacts command to gdb

2020-04-20 Thread William Tu
On Mon, Apr 20, 2020 at 03:37:03PM +0200, Eelco Chaudron wrote: > William, > > Can you try adding this somewhere at the top after the other import section? > > from __future__ import print_function > > And let me know if it works? > > Thanks, > > Eelco Hi Eelco, Thanks, it work, but I have

[ovs-dev] [PATCH ovn] DNS: Make DNS lookups case insensitive.

2020-04-20 Thread Mark Michelson
>From RFC 1035 Section 2.3.3: "For all parts of the DNS that are part of the official protocol, all comparisons between character strings (e.g., labels, domain names, etc.) are done in a case-insensitive manner." OVN was using case-sensitive lookups and therefore was not complying. This change

Re: [ovs-dev] [PATCH ovn] ovn-northd: Limit IPv6 ND NS/RA/RS to the local network.

2020-04-20 Thread Numan Siddique
On Sat, Apr 18, 2020 at 3:24 AM Dumitru Ceara wrote: > > Neighbor solicitation packets for router owned IPs are replied to in > table IN_IP_INPUT at a higher priority than flows relay IPv6 multicast > traffic when needed. All other NS/NA packets received at this point can > be safely dropped. > >

Re: [ovs-dev] [PATCH ovn] DNS: Make DNS lookups case insensitive.

2020-04-20 Thread 0-day Robot
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 84 characters long (recommended limit is 79) #38 FILE:

[ovs-dev] [PATCH 1/1] ofproto: Fix ofgroup ref_count in the group stats.

2020-04-20 Thread Pier Luigi Ventre
Hi everyone. This patch is a followup to this message sent in ovs-discuss: https://mail.openvswitch.org/pipermail/ovs-discuss/2020-April/049897.html This is the brief description of the change: The patch fixes ofgroup

[ovs-dev] [PATCH ovn] DNS: Make DNS lookups case insensitive.

2020-04-20 Thread Mark Michelson
>From RFC 1035 Section 2.3.3: "For all parts of the DNS that are part of the official protocol, all comparisons between character strings (e.g., labels, domain names, etc.) are done in a case-insensitive manner." OVN was using case-sensitive lookups and therefore was not complying. This change

[ovs-dev] [PATCH] ofproto: report coverage on hitting datapath flow limit

2020-04-20 Thread Gowrishankar Muthukrishnan
Whenever the number of flows in the datapath crosses above the flow limit set/autoconfigured, it is helpful to report this event through coverage counter for an operator/devops engineer to know and take proactive corrections in the switch configuration. Today, these events are reported in ovs

Re: [ovs-dev] [PATCH] Utilities: Add the ovs_dump_ofpacts command to gdb

2020-04-20 Thread Eelco Chaudron
William, Can you try adding this somewhere at the top after the other import section? from __future__ import print_function And let me know if it works? Thanks, Eelco On 20 Apr 2020, at 15:27, Eelco Chaudron wrote: On 20 Apr 2020, at 15:06, William Tu wrote: Is this due to

Re: [ovs-dev] [PATCH] Utilities: Add the ovs_dump_ofpacts command to gdb

2020-04-20 Thread Eelco Chaudron
On 20 Apr 2020, at 15:06, William Tu wrote: Is this due to python2/3? My python version: boxes:~/ovs# python Python 3.5.2 (default, Oct 8 2019, 13:06:37) [GCC 5.4.0 20160609] on linux Type "help", "copyright", "credits" or "license" for more information. Hi Eelco, That's the only error

Re: [ovs-dev] [PATCH] AB bonding: Add "primary" interface concept

2020-04-20 Thread Aaron Conole
Hi Jeff, Jeff Squyres via dev writes: > A "primary" slave interface will always become active if it is > enabled. The "primary" concept exists in Linux kernel network > interface bonding, but did not previously exist in OVS bonding. > > Only one "primary" slave inteface is supported per bond,

Re: [ovs-dev] [PATCH] Utilities: Add the ovs_dump_ofpacts command to gdb

2020-04-20 Thread William Tu
On Mon, Apr 20, 2020 at 10:02:15AM +0200, Eelco Chaudron wrote: > > > On 19 Apr 2020, at 17:58, William Tu wrote: > > >On Fri, Apr 17, 2020 at 02:51:34PM +0200, Eelco Chaudron wrote: > >>This adds the ovs_dump_ifpacts command: > >> > >>(gdb) help ovs_dump_ofpacts > >>Dump all actions in an

Re: [ovs-dev] OVS DPDK VF port representors not working

2020-04-20 Thread Ilya Maximets
On 4/19/20 6:08 PM, Ravi Kerur wrote: > > > On Sun, Apr 19, 2020 at 6:14 AM Ilya Maximets > wrote: > > On 4/18/20 2:33 PM, Ravi Kerur wrote: > > > > > > On Fri, Apr 17, 2020 at 9:57 AM Ilya Maximets

Re: [ovs-dev] [PATCH] Utilities: Add the ovs_dump_ofpacts command to gdb

2020-04-20 Thread Eelco Chaudron
On 19 Apr 2020, at 17:58, William Tu wrote: On Fri, Apr 17, 2020 at 02:51:34PM +0200, Eelco Chaudron wrote: This adds the ovs_dump_ifpacts command: (gdb) help ovs_dump_ofpacts Dump all actions in an ofpacts set Usage: ovs_dump_ofpacts : Pointer to set of ofpact structures.

Re: [ovs-dev] [PATCH 1/1] vswitchd: Allow setting MAC on DPDK interfaces

2020-04-20 Thread Roni Bar Yanai
Hi Ben, Ilya Going back to this thread. We've tried app-ctl approach and it fails on consistency problem. Orchestrator can configure on full system init, but now executing local restart will lose the configuration (again for bifurcated driver it is not problem). The requirement for setting

Re: [ovs-dev] [PATCH] ofproto: Fix for frequent invalidation of flows due to mismatch in mask bits

2020-04-20 Thread Vishal Deep Ajmera via dev
> > > > Any thoughts on this? Should I write an equivalent of flow_wc_map() and > use > > it in xlate_wc_finish() > > or we use a stricter version i.e. flow_wildcards_init_for_packet() and use > > in revalidate_ukey__? > > My big problem for review here is that I don't understand the motivation >