[ovs-dev] [PATCH ovn] ovn-controller: Configure hwaddr for the integration bridge

2020-04-30 Thread numans
From: Numan Siddique When a first non-local port is added to the integration bridge, it results in the recalculation of datapath-id by ovs-vswitchd forcing all active connections to the controllers to reconnect. This patch avoids these reconnections between ovs-vswitchd and ovn-controller by set

Re: [ovs-dev] [PATCH ovn 0/2] Make ovn-northd recover from NB/SB inconsistencies.

2020-04-30 Thread Numan Siddique
On Thu, Apr 30, 2020 at 8:43 AM Han Zhou wrote: > On Wed, Apr 29, 2020 at 4:50 PM Han Zhou wrote: > > > > > > > > On Wed, Apr 29, 2020 at 2:45 PM Dumitru Ceara wrote: > > > > > > On 4/29/20 9:57 PM, Han Zhou wrote: > > > > > > > > > > > > On Wed, Apr 29, 2020 at 12:17 PM Numan Siddique > > > <

Re: [ovs-dev] [PATCH ovn 0/2] Make ovn-northd recover from NB/SB inconsistencies.

2020-04-30 Thread Numan Siddique
On Thu, Apr 30, 2020 at 1:41 PM Numan Siddique wrote: > > > On Thu, Apr 30, 2020 at 8:43 AM Han Zhou wrote: > >> On Wed, Apr 29, 2020 at 4:50 PM Han Zhou wrote: >> > >> > >> > >> > On Wed, Apr 29, 2020 at 2:45 PM Dumitru Ceara >> wrote: >> > > >> > > On 4/29/20 9:57 PM, Han Zhou wrote: >> > >

[ovs-dev] PRIVATE...

2020-04-30 Thread khuedm
I have a business Proposal for you and I need your mutual respect, trust, honesty and adequate support.Kindly contact me on qiquanzh...@gmail.com should this be of interest to you. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/

[ovs-dev] [PATCH OVS 0/4] expand the meter table and fix bug

2020-04-30 Thread xiangxia . m . yue
From: Tonghao Zhang The patch set expand or shrink the meter table when necessary. and other patches fix bug or improve codes. Tonghao Zhang (4): dpif-netdev: Expand the meters supported number dpif-netdev: Add burst size to buckets dpif-netdev: Use the u32 instead of u64 for buckets rev

[ovs-dev] [PATCH OVS 3/4] dpif-netdev: Use the u32 instead of u64 for buckets

2020-04-30 Thread xiangxia . m . yue
From: Tonghao Zhang When setting the meter rate to 4+Gbps, there is an overflow, the meters don't work as expected. Cc: Ilya Maximets Cc: William Tu Cc: Jarno Rajahalme Cc: Ben Pfaff Cc: Andy Zhou Signed-off-by: Tonghao Zhang --- include/openvswitch/ofp-meter.h | 2 +- lib/dpif-netdev.c

[ovs-dev] [PATCH OVS 1/4] dpif-netdev: Expand the meters supported number

2020-04-30 Thread xiangxia . m . yue
From: Tonghao Zhang For now, ovs-vswitchd use the array of the dp_meter struct to store meter's data, and at most, there are only 65536 (defined by MAX_METERS) meters that can be used. But in some case, for example, in the edge gateway, we should use 200,000, at least, meters for IP address bandw

[ovs-dev] [PATCH OVS 2/4] dpif-netdev: Add burst size to buckets

2020-04-30 Thread xiangxia . m . yue
From: Tonghao Zhang For now, the meter of the userspace datapath, don't include the bucket burst size to buckets. This patch includes it now. Cc: Ilya Maximets Cc: William Tu Cc: Jarno Rajahalme Cc: Ben Pfaff Cc: Andy Zhou Signed-off-by: Tonghao Zhang --- lib/dpif-netdev.c | 7 +-- 1

[ovs-dev] [PATCH OVS 4/4] revert: dpif-netdev: includes microsecond delta in meter bucket calculation

2020-04-30 Thread xiangxia . m . yue
From: Tonghao Zhang Use the pktgen-dpdk to test the commit 5c41c31ebd64 ("dpif-netdev: includes microsecond delta in meter bucket calculation"), it does't work as expected. And it broken the meter function (e.g. set rate 200Mbps, the rate watched was 400Mbps). To reproduce it: $ ovs-vsctl add-br

Re: [ovs-dev] [PATCH ovn 0/2] Make ovn-northd recover from NB/SB inconsistencies.

2020-04-30 Thread Dumitru Ceara
On 4/30/20 12:06 PM, Numan Siddique wrote: > On Thu, Apr 30, 2020 at 1:41 PM Numan Siddique wrote: > >> >> >> On Thu, Apr 30, 2020 at 8:43 AM Han Zhou wrote: >> >>> On Wed, Apr 29, 2020 at 4:50 PM Han Zhou wrote: On Wed, Apr 29, 2020 at 2:45 PM Dumitru Ceara >>> wrote:

Re: [ovs-dev] [PATCH ovn 0/2] Make ovn-northd recover from NB/SB inconsistencies.

2020-04-30 Thread Dumitru Ceara
On 4/30/20 1:07 PM, Dumitru Ceara wrote: >> >> I found another issue with the below commands (tested in sandbox env) >> >> $ovn-nbctl ls-add ls1 >> $ovn-nbctl ls-add ls2 >> $ovn-nbctl lsp-add ls1 lsp1 >> $ovn-nbctl lsp-add ls2 lsp2 >> $ovn-nbctl lsp-set-type lsp2 external >> $ovn-nbctl ha-chassis-

Re: [ovs-dev] [PATCH ovn 0/2] IPv6 PD: stop processing if necessary

2020-04-30 Thread Numan Siddique
On Wed, Apr 29, 2020 at 9:36 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Lorenzo Bianconi (2): > controller: add garbage collector for ipv6_prefixd > IPv6 PD: disable pd processing if the router port is disabled > > Thanks Lorenzo. I applied this series to master. I modified th

[ovs-dev] tunneling: RFC: Handle fully specified VxLAN tunnel port

2020-04-30 Thread Vasu Dasari
Hi, I am trying to implement a functionality, where in if user specifies port through which a VxLAN encapsulated packet can be sent out, then use that port rather than going through routing procedure. ovs-vsctl add-port br0 at_vxlan_fp1 -- \ set int at_vxlan_fp1 type=vxlan \ optio

Re: [ovs-dev] tunneling: RFC: Handle fully specified VxLAN tunnel port

2020-04-30 Thread Vasu Dasari
This email is with the technical difficulty I am having with supporting above feature. I have implemented all infrastructure necessary to support the CLI, netdev-vport, netdev-native-tnl, etc, and currently debugging my way through this. I am stuck in ofproto-dpif-xlate::native_tunnel_output(). W

[ovs-dev] [PATCH v2 ovn 0/3] Make ovn-northd recover from NB/SB inconsistencies.

2020-04-30 Thread Dumitru Ceara
The patches in this series address the following issues: - patch 1: ovn-northd generates transactions that trigger referential integrity violations due to stale Datapath_Binding records in the SB database. - patch 2: ovn-northd generates transactions that trigger index uniqueness constraint v

[ovs-dev] [PATCH v2 ovn 3/3] ovn-northd: Remove Port_Binding stale references to HA_Chassis_Group.

2020-04-30 Thread Dumitru Ceara
If a logical switch port of type "external" that has ha_chassis_group set is deleted from a logical switch and a port with the same name is added to a different logical switch in the same transaction, the SB Port_Binding record corresponding to the logical port is reused but the ha_chassis_group fi

[ovs-dev] [PATCH v2 ovn 1/3] ovn-northd: Clear SB records depending on stale datapaths.

2020-04-30 Thread Dumitru Ceara
When purging stale SB Datapath_Binding records ovn-northd doesn't properly clean records from other tables that might refer the datapaths being deleted. One way to reproduce the issue is: $ ovn-nbctl lr-add lr $ ovn-nbctl lrp-add lr p 00:00:00:00:00:01 1.1.1.1/24 $ ovn-nbctl --wait=sb sync $ dp=$(

[ovs-dev] [PATCH v2 ovn 2/3] ovn-northd: Fix tunnel_key allocation for SB records.

2020-04-30 Thread Dumitru Ceara
When generating SB records that have tunnel_keys (e.g., Datapath, Port_Binding, Multicast_Group) ovn-northd tries to reuse the tunnel_key value from the original SB record, if any available. However, there's no check for tunnel_keys that would conflict with newly allocated keys for new records. In

Re: [ovs-dev] [PATCH ovn 0/2] Make ovn-northd recover from NB/SB inconsistencies.

2020-04-30 Thread Dumitru Ceara
On 4/30/20 1:07 PM, Dumitru Ceara wrote: > On 4/30/20 12:06 PM, Numan Siddique wrote: >> On Thu, Apr 30, 2020 at 1:41 PM Numan Siddique wrote: >> >>> >>> >>> On Thu, Apr 30, 2020 at 8:43 AM Han Zhou wrote: >>> On Wed, Apr 29, 2020 at 4:50 PM Han Zhou wrote: > > > > On Wed, A

Re: [ovs-dev] 答复: 答复: [PATCH] netdev-linux: remove sum of vport stats and kernel netdev stats

2020-04-30 Thread William Tu
On Wed, Apr 29, 2020 at 10:42:41PM -0700, Pravin Shelar wrote: > On Wed, Apr 29, 2020 at 11:07 AM William Tu wrote: > > > > On Tue, Apr 28, 2020 at 03:29:10AM +, 姜立东 wrote: > > > Hi William, > > > > > > > -/* Use kernel netdev's packet and byte counts since vport's > > > > counters >

Re: [ovs-dev] [PATCH] netdev-linux: remove sum of vport stats and kernel netdev stats

2020-04-30 Thread William Tu
On Thu, Apr 23, 2020 at 05:35:14AM +, 姜立东 via dev wrote: > From df9ff3b67f11e467928ca0873031d81b87f3d0c5 Mon Sep 17 00:00:00 2001 > From: Jiang Lidong > Date: Thu, 23 Apr 2020 11:07:28 +0800 > Subject: [PATCH] netdev-linux: remove sum of vport stats and kernel netdev > stats > When using

Re: [ovs-dev] [RFC v2 PATCH 2/4] netdev-offload: Add "offload-driver" other_config to specify offload driver

2020-04-30 Thread William Tu
On Tue, Apr 21, 2020 at 11:47:02PM +0900, Toshiaki Makita wrote: > The following commit will introduce another offload driver using XDP. > When using afxdp netdev, either of TC or XDP will be supported, so let's > add an other_config to specify which offload driver is preferable. > When not specifi

Re: [ovs-dev] [PATCH 1/1] ofproto: Fix ofgroup ref_count in the group stats.

2020-04-30 Thread Pier Luigi Ventre
Can someone help with this ? Thanks Pier > On Apr 20, 2020, at 4:57 PM, Pier Luigi Ventre wrote: > > Hi everyone. > > This patch is a followup to this message sent in ovs-discuss: > https://mail.openvswitch.org/pipermail/ovs-discuss/2020-April/049897.html >

[ovs-dev] [PATCH v4 00/10] Incremental processing improvements.

2020-04-30 Thread numans
From: Numan Siddique This patch series handles port binding, datapath binding, ovs interface changes, runtime data changes, sb chassis changes incrementally. Below are the results of some testing I did with ovn-fake-multinode setup Test setup -- 1. ovn-central fake node running OVN dbs and

[ovs-dev] [PATCH v4 02/10] ovn-controller: Store the local port bindings in the runtime data I-P state.

2020-04-30 Thread numans
From: Numan Siddique This patch adds a new data structure - 'struct local_binding' which represents a probable local port binding. A new object of this structure is creared for each interface present in the integration bridge (br-int) with the external_ids:iface-id set. This struct has 2 main fie

[ovs-dev] [PATCH v4 01/10] Refactor binding_run() to take two context argument - binding_ctx_in and binding_ctx_out.

2020-04-30 Thread numans
From: Numan Siddique No functional changes are introduced in this patch. Signed-off-by: Numan Siddique --- controller/binding.c| 263 +--- controller/binding.h| 39 -- controller/ovn-controller.c | 120 +--- 3 files changed, 217

[ovs-dev] [PATCH v4 03/10] ovn-controller: I-P for SB port binding and OVS interface in runtime_data.

2020-04-30 Thread numans
From: Numan Siddique This patch handles SB port binding changes and OVS interface changes incrementally in the runtime_data stage which otherwise would have resulted in calls to binding_run(). Prior to this patch, port binding changes were handled differently. The changes were only evaluated to

[ovs-dev] [PATCH v4 04/10] ovn-controller: I-P for datapath binding

2020-04-30 Thread numans
From: Numan Siddique This patch adds partial support of incremental processing of datapath binding. If a datapath is deleted, then a full recompute is triggered if that datapath is present in the 'local_datapaths' hmap of runtime data. Signed-off-by: Numan Siddique --- controller/ovn-controlle

[ovs-dev] [PATCH v4 06/10] ovn-controller: I-P for ct zone and OVS interface changes in flow output stage.

2020-04-30 Thread numans
From: Numan Siddique This patch handles ct zone changes and OVS interface changes incrementally in the flow output stage. Any changes to ct zone can be handled by running physical_run() instead of running flow_output_run(). And any changes to OVS interfaces can be either handled incrementally (

[ovs-dev] [PATCH v4 05/10] ofctrl_check_and_add_flow: Replace the actions of an existing flow if actions have changed.

2020-04-30 Thread numans
From: Numan Siddique If ofctrl_check_and_add_flow(F') is called where flow F' has match-actions (M, A2) and if there already exists a flow F with match-actions (M, A1) in the desired flow table, then this function doesn't update the existing flow F with new actions actions A2. This patch is r

[ovs-dev] [PATCH v4 08/10] I-P engine: Handle runtime data changes in flow output engine

2020-04-30 Thread numans
From: Numan Siddique In order to handle runtime data changes incrementally, the flow outut runtime data handle should know the changed runtime data. Runtime data now tracks the changed data for any OVS interface and SB port binding changes. The tracked data contains a hmap of tracked datapaths (w

[ovs-dev] [PATCH v4 09/10] I-P: Use the tracked runtime data changes for flow calculation.

2020-04-30 Thread numans
From: Venkata Anil This patch processes the logical flows of tracked datapaths and tracked logical ports. To handle the tracked logical port changes, reference of logical flows to port bindings is maintained. Co-Authored-by: Numan Siddique Signed-off-by: Venkata Anil Signed-off-by: Numan Siddi

[ovs-dev] [PATCH v4 07/10] I-P engine: Provide the option for an engine to store changed data

2020-04-30 Thread numans
From: Numan Siddique With this patch, an engine node which is an input to another engine node can provide the tracked data. The parent of this engine node can handle this tracked data incrementally. At the end of the engine_run(), the tracked data of the nodes are cleared. Signed-off-by: Numan

[ovs-dev] [PATCH v4 10/10] I-P: Handle sbrec_chassis changes

2020-04-30 Thread numans
From: Numan Siddique When ovn-controller updates the nb_cfg column of its chassis, this results in full recomputation on all the nodes. This results in wastage of CPU cycles. To address this, this patch handles sbrec_chassis changes incrementally. We don't need to handle any sbrec_chassis change

Re: [ovs-dev] [PATCH ovn 0/2] Make ovn-northd recover from NB/SB inconsistencies.

2020-04-30 Thread Han Zhou
On Thu, Apr 30, 2020 at 4:07 AM Dumitru Ceara wrote: > > On 4/30/20 12:06 PM, Numan Siddique wrote: > > On Thu, Apr 30, 2020 at 1:41 PM Numan Siddique wrote: > > > >> > >> > >> On Thu, Apr 30, 2020 at 8:43 AM Han Zhou wrote: > >> > >>> On Wed, Apr 29, 2020 at 4:50 PM Han Zhou wrote: > > >>

[ovs-dev] [PATCH ovn 1/2] controller: Use OpenFlow version 1.5

2020-04-30 Thread numans
From: Numan Siddique When adding flows to the group table, we need to use OFP15_VERSION to set the selection_method. Right now ovn-controller is setting select_method=dp_hash for OVN load balancers, but when encoding the group mod, it is ignored. Signed-off-by: Numan Siddique --- controller/of

[ovs-dev] [PATCH ovn 2/2] Support selection fields in load balancer.

2020-04-30 Thread numans
From: Numan Siddique This patch add a new column 'selection_fields' in Load_Balancer table in NB DB. CMS can define a set of packet headers to use while selecting a backend. If this column is set, OVN will add the flow in group table with selection method as 'hash' with the set fields. Otherwise

Re: [ovs-dev] [PATCH] compat: Fix ipv6_dst_lookup build error

2020-04-30 Thread Gregory Rose
On 4/29/2020 5:53 PM, William Tu wrote: On Wed, Apr 29, 2020 at 2:41 PM Yi-Hung Wei wrote: The geneve/vxlan compat code base invokes ipv6_dst_lookup() which is recently replaced by ipv6_dst_lookup_flow() in the stable kernel tree. This causes travis build failure: * https://travis-ci.

Re: [ovs-dev] [PATCH v4 01/10] Refactor binding_run() to take two context argument - binding_ctx_in and binding_ctx_out.

2020-04-30 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (controller/binding.c). error: could not build fake

[ovs-dev] OVN Meeting Logs 30 April, 2020

2020-04-30 Thread Mark Michelson
Here is the IRC log for the OVN meeting for 30 April, 2020 http://eavesdrop.openstack.org/meetings/ovn_community_development_discussion/2020/ovn_community_development_discussion.2020-04-30-17.16.log.html If you are interested in attending this meeting, it happens every Thursday at 13:15 EDT (18:

Re: [ovs-dev] [PATCH ovn 2/2] Support selection fields in load balancer.

2020-04-30 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 95 characters long (recommended limit is 79) #137 FILE: lib/actions.c:1135:

Re: [ovs-dev] [PATCH ovn 0/2] Make ovn-northd recover from NB/SB inconsistencies.

2020-04-30 Thread Dumitru Ceara
On 4/30/20 7:05 PM, Han Zhou wrote: > > > On Thu, Apr 30, 2020 at 4:07 AM Dumitru Ceara > wrote: >> >> On 4/30/20 12:06 PM, Numan Siddique wrote: >> > On Thu, Apr 30, 2020 at 1:41 PM Numan Siddique > wrote: >> > >> >> >> >> >> >> On Thu, Apr 30,

[ovs-dev] [PATCH v3 ovn 0/2] Make ovn-northd recover from NB/SB inconsistencies.

2020-04-30 Thread Dumitru Ceara
The patches in this series address the following issues: - patch 1: ovn-northd generates transactions that trigger referential integrity violations due to stale Datapath_Binding records in the SB database. - patch 2: ovn-northd generates transactions that trigger index uniqueness constraint v

[ovs-dev] [PATCH v3 ovn 2/2] ovn-northd: Fix tunnel_key allocation for SB Port_Bindings.

2020-04-30 Thread Dumitru Ceara
When generating Port_Binding records ovn-northd tries to reuse the tunnel_key value from the original SB record, if any available. However, there's no check for tunnel_keys that would conflict with newly allocated keys for new records. In order to avoid that, we don't reuse stale Port_Binding entr

[ovs-dev] [PATCH v3 ovn 1/2] ovn-northd: Clear SB records depending on stale datapaths.

2020-04-30 Thread Dumitru Ceara
When purging stale SB Datapath_Binding records ovn-northd doesn't properly clean records from other tables that might refer the datapaths being deleted. One way to reproduce the issue is: $ ovn-nbctl lr-add lr $ ovn-nbctl lrp-add lr p 00:00:00:00:00:01 1.1.1.1/24 $ ovn-nbctl --wait=sb sync $ dp=$(

Re: [ovs-dev] [PATCH] compat: Fix ipv6_dst_lookup build error

2020-04-30 Thread William Tu
On Thu, Apr 30, 2020 at 10:36:20AM -0700, Gregory Rose wrote: > > > On 4/29/2020 5:53 PM, William Tu wrote: > >On Wed, Apr 29, 2020 at 2:41 PM Yi-Hung Wei wrote: > >> > >>The geneve/vxlan compat code base invokes ipv6_dst_lookup() which is > >>recently replaced by ipv6_dst_lookup_flow() in the s

Re: [ovs-dev] [PATCHv5] userspace: Add conntrack timeout policy support.

2020-04-30 Thread Yi-Hung Wei
On Wed, Apr 29, 2020 at 12:25 PM William Tu wrote: > > Commit 1f1613183733 ("ct-dpif, dpif-netlink: Add conntrack timeout > policy support") adds conntrack timeout policy for kernel datapath. > This patch enables support for the userspace datapath. I tested > using the 'make check-system-userspac

[ovs-dev] Hi there

2020-04-30 Thread Asia Foundation
This is to inform you that you have been randomly selected as one of the beneficiaries of The Bill and Melinda Gates Foundation's "COVID-19 Relief Fund", in collaboration with The Asia Foundation; which was setup to help business owners and individuals during and after the corona virus pandemic.