[ovs-dev] Vous avez un nouveau message de sécurité important.

2020-05-14 Thread Société Générale
Vous avez un nouveau message de scurit important. Pour lire ce message, veuillez cliquer sur: connexion Ceci est un email gnr automatiquement, merci de ne pas y rpondre. Votre conseiller.SG, ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v3] Bareudp Tunnel Support

2020-05-14 Thread Martin Varghese
On Thu, May 14, 2020 at 10:47:30AM -0700, Gregory Rose wrote: > > On 5/14/2020 9:49 AM, Martin Varghese wrote: > >From: Martin Varghese > > > >UDP encapsulation support for tunnelling different protocols like > >MPLS, IP, NSH etc. > > > >Upstream commit: > > > > commit

Re: [ovs-dev] [PATCH OV v2] ovn-nbctl.c: Fix lr-policy-del command

2020-05-14 Thread 0-day Robot
Bleep bloop. Greetings taoyunxi...@cmss.chinamobile.com, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (utilities/ovn-nbctl.c). error:

Re: [ovs-dev] [PATCH OVN] ovn-nbctl.c: Fix lr-policy-del command

2020-05-14 Thread taoyunxi...@cmss.chinamobile.com
Hi Dumitru,                 I have fixed it , and summit v2. Thanks for your review. Regards, Yun -- taoyunxi...@cmss.chinamobile.com >On 5/13/20 4:03 AM, Tao YunXiang wrote: >> This change will check the existence of lr-policy uuid. >> If not, it will print "uuid is not found". >>

[ovs-dev] [PATCH OV v2] ovn-nbctl.c: Fix lr-policy-del command

2020-05-14 Thread Tao YunXiang
This change will check the existence of lr-policy uuid. If not, it will print "uuid is not found". Fixes: 1b030874c32("ovn-nbctl.c: Add an optional way to delete router policy by uuid") Author: Tao YunXiang Signed-off-by: Tao YunXiang CC: Dumitru Ceara --- utilities/ovn-nbctl.c | 4

Re: [ovs-dev] [PATCH ovn v5 1/9] ovn-controller: Store the local port bindings in the runtime data I-P state.

2020-05-14 Thread Mark Michelson
On 5/11/20 5:45 AM, num...@ovn.org wrote: From: Numan Siddique This patch adds a new data structure - 'struct local_binding' which represents a probable local port binding. A new object of this structure is creared for each interface present in the integration bridge (br-int) with the

Re: [ovs-dev] [PATCH ovn v5 4/9] ofctrl_check_and_add_flow: Replace the actions of an existing flow if actions have changed.

2020-05-14 Thread Mark Michelson
On 5/11/20 5:46 AM, num...@ovn.org wrote: From: Numan Siddique If ofctrl_check_and_add_flow(F') is called where flow F' has match-actions (M, A2) and if there already exists a flow F with match-actions (M, A1) in the desired flow table, then this function doesn't update the existing flow F

Re: [ovs-dev] [PATCH] metaflow: Fix maskable conntrack orig tuple fields

2020-05-14 Thread William Tu
On Thu, May 14, 2020 at 10:21:23AM -0700, Yi-Hung Wei wrote: > On Thu, May 14, 2020 at 8:37 AM William Tu wrote: > > > > On Wed, May 13, 2020 at 01:11:17PM -0700, Yi-Hung Wei wrote: > > > From man ovs-fields(7), the conntrack origin tuple fields > > > ct_nw_src/dst, ct_ipv6_src/dst, and

Re: [ovs-dev] [PATCH] debian: Fix package dependencies

2020-05-14 Thread Ansis
On Thu, May 14, 2020 at 6:25 AM Roi Dayan wrote: > > In python2 package was python-twisted-conch but it looks like > for python3 it's just python3-twisted. > For zope interface the python3 package name is python3-zope.interface. > > Fixes: 1ca0323e7c29 ("Require Python 3 and remove support for

[ovs-dev] Prise de contact (Discretion )

2020-05-14 Thread AMOUSSOU FAUSTIN
Bonjour Je m'appel MR AMOUSSOU FAUSTIN et je travail au sein d'une banque de la place qualité d'auditeur Interne . J'ai la souscription d'un nos clients expatriés décédés suite au CORONA VIRUSet je vous contact dans le but de vous faire intervenir en tant qu'un membre de la famille

Re: [ovs-dev] [PATCH] ofproto: Fix statistics of removed flow.

2020-05-14 Thread Roi Dayan
On 2020-05-14 9:33 PM, Ilya Maximets wrote: > 'fr' is a new variable on the stack. '+=' here adds the real statistics > to a random stack memory. > > Fixes: 164413156cf9 ("Add offload packets statistics") > Signed-off-by: Ilya Maximets > --- > ofproto/ofproto.c | 4 ++-- > 1 file changed, 2

Re: [ovs-dev] [PATCH ovn] pinctrl: Fix possible use of uninitialized eth address.

2020-05-14 Thread Mark Michelson
On 5/14/20 7:34 AM, Dumitru Ceara wrote: On 5/14/20 12:53 PM, Ilya Maximets wrote: Not sure if this could happen in a real usecase, but below loop over mac addresses could never reach initialization of 'ea'. In this case it will be used uninitialized by the later code. Setting it to zero

[ovs-dev] [PATCH] ofproto: Fix statistics of removed flow.

2020-05-14 Thread Ilya Maximets
'fr' is a new variable on the stack. '+=' here adds the real statistics to a random stack memory. Fixes: 164413156cf9 ("Add offload packets statistics") Signed-off-by: Ilya Maximets --- ofproto/ofproto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ofproto/ofproto.c

[ovs-dev] OVN Meeting Logs 14 May, 2020

2020-05-14 Thread Mark Michelson
Here is the IRC log for the OVN meeting for 7 May, 2020 http://eavesdrop.openstack.org/meetings/ovn_community_development_discussion/2020/ovn_community_development_discussion.2020-05-14-17.14.log.html If you are interested in attending this meeting, it happens every Thursday at 13:15 EDT (18:15

Re: [ovs-dev] [PATCH] faq: Mention Linux kernel versions supported by 2.13.x.

2020-05-14 Thread Gregory Rose
On 5/14/2020 10:36 AM, Ben Pfaff wrote: This is based on acinclude.m4 in branch-2.13, which rejects anything newer than 5.0. Reported-by: Han Zhou Signed-off-by: Ben Pfaff --- Documentation/faq/releases.rst | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [ovs-dev] [PATCH v3] Bareudp Tunnel Support

2020-05-14 Thread Gregory Rose
On 5/14/2020 9:49 AM, Martin Varghese wrote: From: Martin Varghese UDP encapsulation support for tunnelling different protocols like MPLS, IP, NSH etc. Upstream commit: commit 571912c69f0ed731bd1e071ade9dc7ca4aa52065 Author: Martin Varghese Date: Mon Feb 24 10:57:50 2020

[ovs-dev] [PATCH] faq: Mention Linux kernel versions supported by 2.13.x.

2020-05-14 Thread Ben Pfaff
This is based on acinclude.m4 in branch-2.13, which rejects anything newer than 5.0. Reported-by: Han Zhou Signed-off-by: Ben Pfaff --- Documentation/faq/releases.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index

Re: [ovs-dev] [PATCH] metaflow: Fix maskable conntrack orig tuple fields

2020-05-14 Thread Yi-Hung Wei
On Thu, May 14, 2020 at 8:37 AM William Tu wrote: > > On Wed, May 13, 2020 at 01:11:17PM -0700, Yi-Hung Wei wrote: > > From man ovs-fields(7), the conntrack origin tuple fields > > ct_nw_src/dst, ct_ipv6_src/dst, and ct_tp_src/dst are supposed > > to be bitwise maskable, but they are not. This

Re: [ovs-dev] [PATCH ovn] ovn-northd: Increase ECMP route priority with 400.

2020-05-14 Thread Lorenzo Bianconi
> > On Thu, May 14, 2020 at 1:12 AM Dumitru Ceara wrote: > > > > On 5/13/20 11:51 PM, Han Zhou wrote: > > > In commit c0bf32d the priorities of the regular routes were increased by > > > 400, but ECMP routes were not updated. This patch fixes it. Since > > > for ECMP routes the outport is unknown

[ovs-dev] [PATCH v3] Bareudp Tunnel Support

2020-05-14 Thread Martin Varghese
From: Martin Varghese UDP encapsulation support for tunnelling different protocols like MPLS, IP, NSH etc. Upstream commit: commit 571912c69f0ed731bd1e071ade9dc7ca4aa52065 Author: Martin Varghese Date: Mon Feb 24 10:57:50 2020 +0530 net: UDP tunnel encapsulation module for

Re: [ovs-dev] [PATCH ovn] ovn-northd: Increase ECMP route priority with 400.

2020-05-14 Thread Han Zhou
On Thu, May 14, 2020 at 1:12 AM Dumitru Ceara wrote: > > On 5/13/20 11:51 PM, Han Zhou wrote: > > In commit c0bf32d the priorities of the regular routes were increased by > > 400, but ECMP routes were not updated. This patch fixes it. Since > > for ECMP routes the outport is unknown (there can be

Re: [ovs-dev] [PATCH ovn] conf.py: Fix flake8 error in build.

2020-05-14 Thread Han Zhou
On Wed, May 13, 2020 at 3:40 PM Ben Pfaff wrote: > > On Wed, May 13, 2020 at 02:50:07PM -0700, Han Zhou wrote: > > In commit 8fcbcca9649f it made the line > 79, which causes build error. > > > > Fixes: 8fcbcca9649f ("docs: update various OVS references to OVN") > > Cc: Dan Williams > >

Re: [ovs-dev] [PATCH 2/2] oss-fuzz: Fix miniflow_target.c.

2020-05-14 Thread William Tu
On Tue, May 12, 2020 at 04:31:58PM -0700, Yifeng Sun wrote: > LGTM, thanks. > > Reviewed-by: Yifeng Sun > > Applied, thanks. William ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] metaflow: Fix maskable conntrack orig tuple fields

2020-05-14 Thread William Tu
On Wed, May 13, 2020 at 01:11:17PM -0700, Yi-Hung Wei wrote: > From man ovs-fields(7), the conntrack origin tuple fields > ct_nw_src/dst, ct_ipv6_src/dst, and ct_tp_src/dst are supposed > to be bitwise maskable, but they are not. This patch enables > those fields to be maskable, and adds a

Re: [ovs-dev] [PATCH ovs v2 0/4] expand the meter table and fix bug

2020-05-14 Thread William Tu
On Wed, May 13, 2020 at 09:31:31PM +0800, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > The patch set expand or shrink the meter table when necessary. > and other patches fix bug or improve codes. > > Tonghao Zhang (4): > dpif-netdev: Expand the meters supported number >

Re: [ovs-dev] [PATCH] ofproto: report coverage on hitting datapath flow limit

2020-05-14 Thread William Tu
On Mon, Apr 20, 2020 at 07:13:42PM +0530, Gowrishankar Muthukrishnan wrote: > Whenever the number of flows in the datapath crosses above > the flow limit set/autoconfigured, it is helpful to report > this event through coverage counter for an operator/devops > engineer to know and take proactive

Re: [ovs-dev] [PATCHv9 1/2] userspace: Enable TSO support for non-DPDK.

2020-05-14 Thread William Tu
On Thu, May 14, 2020 at 01:42:21PM +0200, Ilya Maximets wrote: > On 3/24/20 11:10 PM, William Tu wrote: > > This patch enables TSO support for non-DPDK use cases, and > > also add check-system-tso testsuite. Before TSO, we have to > > disable checksum offload, allowing the kernel to calculate the

[ovs-dev] [PATCH] dpif-netdev: Add miniflow bits to dump-flows.

2020-05-14 Thread William Tu
The 'dpctl/dump-flows -m' only shows the number of 1-bit in the miniflow map, the patch outputs additional miniflow bits after it. The format will be dp-extra-info:miniflow_bits(count_1bit(unit0):unit0, count_1bit(unit1):unit1) Example:

[ovs-dev] [PATCH] ovs-bugtool: Add -m option to dump-flows.

2020-05-14 Thread William Tu
This patch adds 'ovs-appctl dpctl/dump-flows -m' to bugtool, the output will include wildcarded fields and the miniflow bits, such as 'dp-extra-info:miniflow_bits(4,1)'. Cc: Emma Finn Signed-off-by: William Tu --- utilities/bugtool/plugins/network-status/openvswitch.xml | 1 + 1 file changed,

[ovs-dev] Ultimos 3 Lugares - Confirme o Descarte

2020-05-14 Thread Guía de Acción en los centros de trabajo
Buenos días, Con el gusto de saludarte, te invitamos al siguiente curso en línea con transmisión en vivo: “Guías de acción en los centros de trabajo ante COVID 19” Detalles del evento: Fecha: Martes 19 de mayo de 9:00 am a 11:30 am Lugar: En línea Impartido por: El experto Lic. Gerardo

[ovs-dev] [PATCH] netdev-dpdk: don't set rx mq mode for net_virtio

2020-05-14 Thread Jaime Caamaño Ruiz
Since DPDK 19.11 [1], it is not allowed to set any RX mq mode for virtio driver. [1] https://github.com/DPDK/dpdk/commit/13b3137f3b7c8f866947a9b34e06a8aec0d084f7 Signed-off-by: Jaime Caamaño Ruiz --- lib/netdev-dpdk.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/netdev-dpdk.c

[ovs-dev] [PATCH] debian: Fix package dependencies

2020-05-14 Thread Roi Dayan
In python2 package was python-twisted-conch but it looks like for python3 it's just python3-twisted. For zope interface the python3 package name is python3-zope.interface. Fixes: 1ca0323e7c29 ("Require Python 3 and remove support for Python 2.") Signed-off-by: Roi Dayan --- debian/control | 4

Re: [ovs-dev] [PATCH] debian: Fix broken build after some man pages became generated from RST

2020-05-14 Thread Roi Dayan
On 2020-05-14 2:41 AM, Ansis wrote: > Thanks, pushed to master branch. > > On Wed, May 13, 2020 at 3:04 PM Ben Pfaff wrote: >> >> On Wed, May 13, 2020 at 12:35:03PM -0700, Ansis Atteka wrote: >>> As far as I know, the official way to build debian packages is by invoking >>> following command:

Re: [ovs-dev] [PATCH] debian: Fix broken build after some man pages became generated from RST

2020-05-14 Thread Roi Dayan
On 2020-05-14 2:41 AM, Ansis wrote: > Thanks, pushed to master branch. > > On Wed, May 13, 2020 at 3:04 PM Ben Pfaff wrote: >> >> On Wed, May 13, 2020 at 12:35:03PM -0700, Ansis Atteka wrote: >>> As far as I know, the official way to build debian packages is by invoking >>> following command:

Re: [ovs-dev] [PATCH ovn v2] Avoid case sensitive comparisons for MAC and IPv6 addresses

2020-05-14 Thread Mark Michelson
On 5/14/20 4:42 AM, Dumitru Ceara wrote: On 5/13/20 9:39 PM, Mark Michelson wrote: MAC addresses and IPv6 addresses use hex digits which are appropriate to express with either uppercase or lowercase letters. strcmp() detects two MAC or IPv6 addresses as different if theier capitalization

Re: [ovs-dev] [PATCH] ofproto: report coverage on hitting datapath flow limit

2020-05-14 Thread Gowrishankar Muthukrishnan
I see this change fixing a commit b4c632526b pushed a few years back, but still there is room for instrumentation like below. Could this patch be reviewed ?. Thanks, Gowrishankar On Mon, Apr 20, 2020 at 7:13 PM Gowrishankar Muthukrishnan < gmuth...@redhat.com> wrote: > Whenever the number of

[ovs-dev] [PATCH 1/3] system-dpdk: cleanup stale hugepage files after tests

2020-05-14 Thread Gowrishankar Muthukrishnan
After dpdk tests completes, cleaning up hugepage map files created by tests is helpful to release used memory into hugepage memory allocator. Signed-off-by: Gowrishankar Muthukrishnan --- tests/system-dpdk-macros.at | 13 + tests/system-dpdk.at| 7 +++ 2 files changed,

[ovs-dev] [PATCH 3/3] system-dpdk: add negotiation check for userspace-tso

2020-05-14 Thread Gowrishankar Muthukrishnan
This patch adds minimal check for userspace-tso in system-dpdk tests, starting with verification on virtio negotiation. Signed-off-by: Gowrishankar Muthukrishnan --- tests/system-dpdk-macros.at | 16 +-- tests/system-dpdk.at| 102 2

[ovs-dev] [PATCH 2/3] system-dpdk: use optimum hugepages for dpdk tests

2020-05-14 Thread Gowrishankar Muthukrishnan
Today we need 1GB from hugepages for running dpdk tests (i.e 512MB for ovs-vswitchd including phy ports and 512MB for testpmd app). This patch optimize the usage as: - 1GB for dpdk tests including phy ports, vhu ports and testpmd - 512MB for dpdk tests including vhu ports and testpmd

[ovs-dev] [PATCH 0/3] system-dpdk: add userspace-tso tests

2020-05-14 Thread Gowrishankar Muthukrishnan
This series adds test cases for TSO feature in OVS-DPDK, along with few improvements and cleanup in testing mechanism. Gowrishankar Muthukrishnan (3): system-dpdk: cleanup stale hugepage files after tests system-dpdk: use optimum hugepages for dpdk tests system-dpdk: add negotiation check

Re: [ovs-dev] [PATCHv9 1/2] userspace: Enable TSO support for non-DPDK.

2020-05-14 Thread Ilya Maximets
On 3/24/20 11:10 PM, William Tu wrote: > This patch enables TSO support for non-DPDK use cases, and > also add check-system-tso testsuite. Before TSO, we have to > disable checksum offload, allowing the kernel to calculate the > TCP/UDP packet checsum. With TSO, we can skip the checksum >

Re: [ovs-dev] [PATCH ovn] pinctrl: Fix possible use of uninitialized eth address.

2020-05-14 Thread Dumitru Ceara
On 5/14/20 12:53 PM, Ilya Maximets wrote: > Not sure if this could happen in a real usecase, but below loop > over mac addresses could never reach initialization of 'ea'. > > In this case it will be used uninitialized by the later code. > Setting it to zero ethernet address to avoid that

[ovs-dev] Sir

2020-05-14 Thread malik_usman204--- via dev
Sir, My name is Malik Usman of Continental Exchange Solutions London U.K. I am an independent external auditor for IFC SERVE and the World Bank handling the Foreign Banks Debt Management Office for all transactions in the year 2013/2014 and later. I have in front of me an abandoned transfer

[ovs-dev] [PATCH ovn] pinctrl: Fix possible use of uninitialized eth address.

2020-05-14 Thread Ilya Maximets
Not sure if this could happen in a real usecase, but below loop over mac addresses could never reach initialization of 'ea'. In this case it will be used uninitialized by the later code. Setting it to zero ethernet address to avoid that condition. Fixes: e3a398e9146e ("controller: Add ipv6

Re: [ovs-dev] [PATCH ovn 0/6 v7] Support logical switches with multiple localnet ports

2020-05-14 Thread Dumitru Ceara
On 5/13/20 3:38 PM, Ihar Hrachyshka wrote: > Hi all, > > This series is to allow for multiple localnet ports to be present in a > logical switch. Even before the series, it was allowed to create > multiple ports of this kind but they were handled inconsistently. > > This series uses logical

Re: [ovs-dev] [RFC v2 PATCH 4/4] bpf: Add reference XDP program implementation for netdev-offload-xdp

2020-05-14 Thread Toshiaki Makita
Hi Tonghao, On 2020/05/14 13:08, Tonghao Zhang wrote: On Tue, Apr 21, 2020 at 10:48 PM Toshiaki Makita wrote: This adds a reference program, flowtable_afxdp.o, which can be used to offload flows to XDP through netdev-offload-xdp. The program will be compiled when using --enable-bpf switch.

Re: [ovs-dev] [PATCH] rhel: Fix reload of OVS_USER_ID on startup

2020-05-14 Thread Jaime Caamaño Ruiz
Similar to [1] and there were already fixes related to it [2]. I did not track the cause of this specific bit but could be just the same thing. [1] https://github.com/systemd/systemd/issues/12713 [2] https://github.com/openvswitch/ovs/commit/7a65e5a9252ac06df62707a571931f501747ecfc

Re: [ovs-dev] [PATCH ovn v2] Avoid case sensitive comparisons for MAC and IPv6 addresses

2020-05-14 Thread Dumitru Ceara
On 5/13/20 9:39 PM, Mark Michelson wrote: > MAC addresses and IPv6 addresses use hex digits which are appropriate to > express with either uppercase or lowercase letters. strcmp() detects two > MAC or IPv6 addresses as different if theier capitalization differs. > > This fixes the issue by

Re: [ovs-dev] [PATCH ovn] ovn-northd: Increase ECMP route priority with 400.

2020-05-14 Thread Dumitru Ceara
On 5/13/20 11:51 PM, Han Zhou wrote: > In commit c0bf32d the priorities of the regular routes were increased by > 400, but ECMP routes were not updated. This patch fixes it. Since > for ECMP routes the outport is unknown (there can be many different > outports) the condition check of whether the

Re: [ovs-dev] [PATCH ovn v3] ovn-controller to no longer monitor Chassis' external_ids

2020-05-14 Thread Dumitru Ceara
On 5/13/20 12:49 PM, lmart...@redhat.com wrote: > From: Lucas Alvares Gomes > > Prior to this patch, the external_ids column from the Chassis table were > being used for two purposes: > > 1. Holding configuration for the OVN (copied by ovn-controller from the > local OVS database) > > 2.

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix memory leak in case of distributed NAT.

2020-05-14 Thread Numan Siddique
On Wed, May 13, 2020 at 4:57 PM Ilya Maximets wrote: > On 5/13/20 12:19 PM, Dumitru Ceara wrote: > > In function get_nat_addresses(), memory reserved for c_addresses is not > > freed in case of distributed NAT (i.e., central_ip_address == false): > > > > ==22493== 36 bytes in 2 blocks are

Re: [ovs-dev] [PATCH ovn] ovn-nbctl: Fix using uninitialized direction while removing qos.

2020-05-14 Thread Numan Siddique
On Thu, May 14, 2020 at 1:36 AM Mark Michelson wrote: > Acked-by: Mark Michelson > > Thanks Ilya and Mark. I applied this patch to master. Numan > On 5/13/20 1:12 PM, Ilya Maximets wrote: > > GCC 9 complains: > > utilities/ovn-nbctl.c: In function 'nbctl_qos_del': > >

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix leak of the ipv6_prefix_set array.

2020-05-14 Thread Numan Siddique
On Wed, May 13, 2020 at 6:53 PM Dumitru Ceara wrote: > On 5/13/20 2:56 PM, Ilya Maximets wrote: > > 'sset_array' allocates new array that must be freed by the caller: > > > > 640 bytes in 40 blocks are definitely lost in loss record 73 of 74 > > at 0x483980B: malloc

Re: [ovs-dev] [PATCH ovn] pinctrl: Fix various leaks of lport addresses.

2020-05-14 Thread Numan Siddique
On Thu, May 14, 2020 at 2:15 AM Mark Michelson wrote: > Acked-by: Mark Michelson > > Thanks Ilya and Mark. I applied this patch to master. Numan > On 5/13/20 12:50 PM, Ilya Maximets wrote: > > Example of one of the valgrind reports: > > > > 4,012 bytes in 59 blocks are definitely lost in