[ovs-dev] [PATCH v2 3/3] system-dpdk: add negotiation check for userspace-tso

This patch adds minimal check for userspace-tso in system-dpdk tests, starting with verification on virtio negotiation. Signed-off-by: Gowrishankar Muthukrishnan --- v2: - removed tso check in existing tests (added in v1) - improved validations in host and guest end - added tests for non-tso

[ovs-dev] [PATCH v2 2/3] system-dpdk: use optimum hugepages for dpdk tests

Today we need 1GB from hugepages for running dpdk tests (i.e 512MB for ovs-vswitchd including phy ports and 512MB for testpmd app). This patch optimize the usage as: - 1GB for dpdk tests including phy ports, vhu ports and testpmd - 512MB for dpdk tests including vhu ports and testpmd

[ovs-dev] [PATCH v2 1/3] system-dpdk: cleanup stale hugepage files after tests

After dpdk tests completes, cleaning up hugepage map files created by tests is helpful to release used memory into hugepage memory allocator. Signed-off-by: Gowrishankar Muthukrishnan --- tests/system-dpdk-macros.at | 13 + tests/system-dpdk.at| 7 +++ 2 files changed,

[ovs-dev] [PATCH v2 0/3] system-dpdk: add userspace-tso tests

This series adds test cases for TSO feature in OVS-DPDK, along with few improvements and cleanup in testing mechanism. Please find comments section in patch 3 for the testing info. Gowrishankar Muthukrishnan (3): system-dpdk: cleanup stale hugepage files after tests system-dpdk: use optimum

Re: [ovs-dev] [PATCH v2 0/5] DPCLS Subtable ISA Optimization

Hi Harry, Thanks for the patch, I learn a lot from them. On Wed, May 6, 2020 at 6:05 AM Harry van Haaren wrote: > > This patchset implements the changes as proposed during the > OVS Conf '19, in the talk "Next steps for SW Datapath". > Youtube link: https://youtu.be/x0bOpojnpmU > > The talk

Re: [ovs-dev] [PATCH v3] Bareudp Tunnel Support

On 5/14/2020 8:08 PM, Martin Varghese wrote: On Thu, May 14, 2020 at 10:47:30AM -0700, Gregory Rose wrote: On 5/14/2020 9:49 AM, Martin Varghese wrote: From: Martin Varghese UDP encapsulation support for tunnelling different protocols like MPLS, IP, NSH etc. Upstream commit: commit

[ovs-dev] Plan de atención y Estrategias de control

Ante la situación de emergencia ocasionada por la pandemia del COVID-19, la STPS ha publicado una Guía de Acción en los Centros de Trabajo con una serie de recomendaciones prácticas para la planeación, capacitación, implementación, protección y monitoreo de las medidas adoptadas para la

Re: [ovs-dev] OvS-DPDK change interface MAC

DPDK team, Kindly let me know if there is a way to change Mac address of dpdk ports? I am using 2.13.90/19.11 combination. I looked at following patch and I used the command ovs-vsctl set Interface mac="xx:xx:xx:xx:xx:xx"

Re: [ovs-dev] [PATCH] debian: Add python3-sphinx to ovs build dependencies

On Fri, May 15, 2020 at 1:32 PM Gregory Rose wrote: > > > On 5/15/2020 12:17 PM, Ansis Atteka wrote: > > python3-sphinx has become mandatory build dependency since patch > > 39b5e46 ("Documentation: Convert multiple manpages to ReST."), because, > > otherwise, packaging of OVS debian packages

[ovs-dev] [PATCH v2 2/2] netdev-offload-tc: re-fetch block ID after probing

It's possible that block_id could changes after the probe for block support. Therefore, fetch the block_id again after the probe. Fixes: edc2055a2bf7 ("netdev-offload-tc: Flush rules on ingress block when init tc flow api") Cc: Dmytro Linkin Co-authored-by: Marcelo Leitner Acked-by: Roi Dayan

[ovs-dev] [PATCH v2 0/2] TC fixes

The following fixes are for TC offload support: 1. Race w/ipv6 code 2. Block id support issue with ordering v1->v2: - Incorporate a suggestion from Ilya Aaron Conole (2): netdev-linux: update LAG in all cases netdev-offload-tc: re-fetch block ID after probing lib/netdev-linux.c | 11

[ovs-dev] [PATCH v2 1/2] netdev-linux: update LAG in all cases

In some cases, when processing a netlink change event, it's possible for an alternate part of OvS (like the IPv6 endpoint processing) to hold an active netdev interface. This creates a race-condition, where sometimes the OvS change processing will take the normal path. This doesn't work because

Re: [ovs-dev] [PATCH] debian: Add python3-sphinx to ovs build dependencies

On 5/15/2020 12:17 PM, Ansis Atteka wrote: python3-sphinx has become mandatory build dependency since patch 39b5e46 ("Documentation: Convert multiple manpages to ReST."), because, otherwise, packaging of OVS debian packages fails with an error that generated man pages can't be foundl. Fixes:

Re: [ovs-dev] [PATCH 2/2] netdev-offload-tc: re-fetch block ID after probing

On Fri, May 15, 2020 at 09:49:15PM +0200, Ilya Maximets wrote: > On 5/7/20 5:54 PM, Aaron Conole wrote: > > It's possible that port ordering could cause the block ID to change > > after enabling / detecting TC Flower support. Therefore, fetch the > > block_id again after probing. > > > > Fixes:

Re: [ovs-dev] [PATCH 2/2] netdev-offload-tc: re-fetch block ID after probing

On 5/7/20 5:54 PM, Aaron Conole wrote: > It's possible that port ordering could cause the block ID to change > after enabling / detecting TC Flower support. Therefore, fetch the > block_id again after probing. > > Fixes: edc2055a2bf7 ("netdev-offload-tc: Flush rules on ingress block when > init

[ovs-dev] [PATCH] debian: Add python3-sphinx to ovs build dependencies

python3-sphinx has become mandatory build dependency since patch 39b5e46 ("Documentation: Convert multiple manpages to ReST."), because, otherwise, packaging of OVS debian packages fails with an error that generated man pages can't be foundl. Fixes: 39b5e46312 ("Documentation: Convert multiple

Re: [ovs-dev] [PATCH] odp-util.c: Fix dp_hash execution with slowpath actions.

On Fri, May 15, 2020 at 12:18 AM Han Zhou wrote: > > When dp_hash is executed with slowpath actions, it results in endless > recirc loop in kernel datapath, and finally drops the packet, with > kernel logs: > > openvswitch: ovs-system: deferred action limit reached, drop recirc action > > The

Re: [ovs-dev] [PATCH ovn] ovn-northd: Increase ECMP route priority with 400.

On Fri, May 15, 2020 at 9:01 AM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > > > > On Thu, May 14, 2020 at 1:12 AM Dumitru Ceara wrote: > > > > > > > > On 5/13/20 11:51 PM, Han Zhou wrote: > > > > > In commit c0bf32d the priorities of the regular routes were increased by > > > > >

Re: [ovs-dev] [PATCH] ofproto: Fix statistics of removed flow.

On 5/14/20 9:43 PM, Roi Dayan wrote: > > > On 2020-05-14 9:33 PM, Ilya Maximets wrote: >> 'fr' is a new variable on the stack. '+=' here adds the real statistics >> to a random stack memory. >> >> Fixes: 164413156cf9 ("Add offload packets statistics") >> Signed-off-by: Ilya Maximets >> --- >>

[ovs-dev] Cursos privados en línea para tu empresa

Cursos privados en línea para tu empresa. Capacita a tu área de Logística, Operaciones y Compras con cursos privados personalizados, en línea, en vivo y de la mano de expertos con amplia experiencia profesional en empresas de renombre. Solicita nuestro catálogo para conocer nuestra oferta

Re: [ovs-dev] [RFC ovn] ovn: introduce IP_SRC_POLICY stage in ingress router pipeline

On 5/15/20 5:49 PM, Lorenzo Bianconi wrote: > In order to fix the issues introduced by commit > c0bf32d72f8b ("Manage ARP process locally in a DVR scenario "), restore > previous configuration of table 9 in ingress router pipeline and > introduce a new stage called 'ip_src_policy' used to set the

Re: [ovs-dev] OVN 20.06 Soft Freeze Today

On 5/15/20 1:12 PM, Ihar Hrachyshka wrote: On 5/15/20 12:24 PM, Numan Siddique wrote: On Fri, May 15, 2020 at 8:23 PM Ihar Hrachyshka wrote: On 5/11/20 10:15 AM, Ihar Hrachyshka wrote: On 5/8/20 2:17 PM, Numan Siddique wrote: On Fri, May 8, 2020 at 9:58 PM Ihar Hrachyshka

Re: [ovs-dev] OVN 20.06 Soft Freeze Today

On Fri, May 15, 2020 at 10:42 PM Ihar Hrachyshka wrote: > On 5/15/20 12:24 PM, Numan Siddique wrote: > > On Fri, May 15, 2020 at 8:23 PM Ihar Hrachyshka > wrote: > > > >> On 5/11/20 10:15 AM, Ihar Hrachyshka wrote: > >>> On 5/8/20 2:17 PM, Numan Siddique wrote: > > On Fri, May 8, 2020

Re: [ovs-dev] [PATCH ovs v2 0/4] expand the meter table and fix bug

On 5/13/20 3:31 PM, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > The patch set expand or shrink the meter table when necessary. > and other patches fix bug or improve codes. > > Tonghao Zhang (4): > dpif-netdev: Expand the meters supported number > dpif-netdev: Add burst size

Re: [ovs-dev] OVN 20.06 Soft Freeze Today

On 5/15/20 12:24 PM, Numan Siddique wrote: On Fri, May 15, 2020 at 8:23 PM Ihar Hrachyshka wrote: On 5/11/20 10:15 AM, Ihar Hrachyshka wrote: On 5/8/20 2:17 PM, Numan Siddique wrote: On Fri, May 8, 2020 at 9:58 PM Ihar Hrachyshka mailto:ihrac...@redhat.com>> wrote: Hi all, I

Re: [ovs-dev] [PATCH ovs v2 1/4] dpif-netdev: Expand the meters supported number

On 5/13/20 3:31 PM, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > For now, ovs-vswitchd use the array of the dp_meter struct > to store meter's data, and at most, there are only 65536 > (defined by MAX_METERS) meters that can be used. But in some > case, for example, in the edge

[ovs-dev] [PATCH] ovsdb-server: Fix schema leak while reading db.

parse_txn() function doesn't always take ownership of the 'schema' passed. So, if the schema of the clustered db has same version as the one that already in use, parse_txn() will not use it, resulting with a memory leak: 7,827 (56 direct, 7,771 indirect) bytes in 1 blocks are definitely lost

Re: [ovs-dev] OVN 20.06 Soft Freeze Today

On Fri, May 15, 2020 at 8:23 PM Ihar Hrachyshka wrote: > On 5/11/20 10:15 AM, Ihar Hrachyshka wrote: > > On 5/8/20 2:17 PM, Numan Siddique wrote: > >> > >> > >> On Fri, May 8, 2020 at 9:58 PM Ihar Hrachyshka >> > wrote: > >> > >> Hi all, > >> > >> I would

Re: [ovs-dev] [PATCH ovn 0/6 v7] Support logical switches with multiple localnet ports

On Thu, May 14, 2020 at 4:00 PM Dumitru Ceara wrote: > On 5/13/20 3:38 PM, Ihar Hrachyshka wrote: > > Hi all, > > > > This series is to allow for multiple localnet ports to be present in a > > logical switch. Even before the series, it was allowed to create > > multiple ports of this kind but

Re: [ovs-dev] [PATCH OVN v3] ovn-nbctl.c: Fix lr-policy-del command

On Fri, May 15, 2020 at 1:45 PM Tao YunXiang < taoyunxi...@cmss.chinamobile.com> wrote: > This change will check the existence of lr-policy uuid. > If not, it will print "uuid is not found". > > Fixes: 1b030874c32("ovn-nbctl.c: Add an optional way to delete router > policy by uuid") > > > Author:

Re: [ovs-dev] [PATCH ovn] ovn-northd: Increase ECMP route priority with 400.

> > On Thu, May 14, 2020 at 1:12 AM Dumitru Ceara wrote: > > > > > > On 5/13/20 11:51 PM, Han Zhou wrote: > > > > In commit c0bf32d the priorities of the regular routes were increased by > > > > 400, but ECMP routes were not updated. This patch fixes it. Since > > > > for ECMP routes the outport

Re: [ovs-dev] [PATCH ovn] ovn-northd: Increase ECMP route priority with 400.

> On Thu, May 14, 2020 at 1:12 AM Dumitru Ceara wrote: > > > > On 5/13/20 11:51 PM, Han Zhou wrote: > > > In commit c0bf32d the priorities of the regular routes were increased by > > > 400, but ECMP routes were not updated. This patch fixes it. Since > > > for ECMP routes the outport is unknown

Re: [ovs-dev] [PATCH ovn] controller: Free the qos hmap built in binding_run().

On Fri, May 15, 2020 at 5:22 PM Dumitru Ceara wrote: > On 5/15/20 12:17 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > Fixes the memory leak because of this. > > > > Signed-off-by: Numan Siddique > > Looks good to me. > > Acked-by: Dumitru Ceara > Thanks Dumitru. I applied this

[ovs-dev] [RFC ovn] ovn: introduce IP_SRC_POLICY stage in ingress router pipeline

In order to fix the issues introduced by commit c0bf32d72f8b ("Manage ARP process locally in a DVR scenario "), restore previous configuration of table 9 in ingress router pipeline and introduce a new stage called 'ip_src_policy' used to set the src address info in order to not distribute FIP

Re: [ovs-dev] Windows OVS issue

Hello Wenying, Trimming the email a bit. Please see my comments inlined. > Hi, > > I am using OVS on Windows Server 2019 to provide container networking. > OpenFlow is used to support both container and host networking, and OVS > conntrack feature is also used on my setup. I find a lot of

Re: [ovs-dev] OVN 20.06 Soft Freeze Today

On 5/11/20 10:15 AM, Ihar Hrachyshka wrote: On 5/8/20 2:17 PM, Numan Siddique wrote: On Fri, May 8, 2020 at 9:58 PM Ihar Hrachyshka > wrote:     Hi all,     I would like the series to support multiple localnet ports per switch     ("routed provider networks

[ovs-dev] [PATCHv2] ovsdb-idl: Fix NULL deref reported by Coverity.

When 'datum.values' or 'datum.keys' is NULL, some code path calling into ovsdb_idl_txn_write__ triggers NULL deref. An example: ovsrec_open_vswitch_set_cur_cfg(const struct ovsrec_open_vswitch { struct ovsdb_datum datum; union ovsdb_atom key; datum.n = 1; datum.keys =

Re: [ovs-dev] [PATCH ovn v5 4/9] ofctrl_check_and_add_flow: Replace the actions of an existing flow if actions have changed.

On 5/15/20 2:23 PM, Numan Siddique wrote: > > > On Wed, May 13, 2020 at 7:24 PM Dumitru Ceara > wrote: > > On 5/11/20 11:46 AM, num...@ovn.org wrote: > > From: Numan Siddique mailto:num...@ovn.org>> > > > > If

Re: [ovs-dev] [PATCH ovn v5 4/9] ofctrl_check_and_add_flow: Replace the actions of an existing flow if actions have changed.

On Wed, May 13, 2020 at 7:24 PM Dumitru Ceara wrote: > On 5/11/20 11:46 AM, num...@ovn.org wrote: > > From: Numan Siddique > > > > If ofctrl_check_and_add_flow(F') is called where flow F' has > match-actions (M, A2) > > and if there already exists a flow F with match-actions (M, A1) in the >

Re: [ovs-dev] [PATCH ovn v5 4/9] ofctrl_check_and_add_flow: Replace the actions of an existing flow if actions have changed.

On Fri, May 15, 2020 at 6:50 AM Mark Michelson wrote: > On 5/11/20 5:46 AM, num...@ovn.org wrote: > > From: Numan Siddique > > > > If ofctrl_check_and_add_flow(F') is called where flow F' has > match-actions (M, A2) > > and if there already exists a flow F with match-actions (M, A1) in the >

Re: [ovs-dev] [PATCH] ofproto: report coverage on hitting datapath flow limit

On Thu, May 14, 2020 at 8:06 PM William Tu wrote: > On Mon, Apr 20, 2020 at 07:13:42PM +0530, Gowrishankar Muthukrishnan wrote: > > Whenever the number of flows in the datapath crosses above > > the flow limit set/autoconfigured, it is helpful to report > > this event through coverage counter

Re: [ovs-dev] [PATCH ovn] controller: Free the qos hmap built in binding_run().

On 5/15/20 12:17 PM, num...@ovn.org wrote: > From: Numan Siddique > > Fixes the memory leak because of this. > > Signed-off-by: Numan Siddique Looks good to me. Acked-by: Dumitru Ceara Thanks, Dumitru > --- > controller/binding.c | 13 - > 1 file changed, 12 insertions(+), 1

[ovs-dev] [PATCH] ovsdb: Remove duplicated include.

From: Yunjian Wang Signed-off-by: Yunjian Wang --- ovsdb/monitor.c | 1 - ovsdb/rbac.c| 1 - 2 files changed, 2 deletions(-) diff --git a/ovsdb/monitor.c b/ovsdb/monitor.c index 1c66b42..532dedc 100644 --- a/ovsdb/monitor.c +++ b/ovsdb/monitor.c @@ -31,7 +31,6 @@ #include "simap.h"

[ovs-dev] [PATCH] ofproto: Remove duplicated include.

From: pandongyang Signed-off-by: pandongyang --- ofproto/ofproto-dpif.h | 1 - ofproto/tunnel.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/ofproto/ofproto-dpif.h b/ofproto/ofproto-dpif.h index aee61d6..2de8060 100644 --- a/ofproto/ofproto-dpif.h +++ b/ofproto/ofproto-dpif.h @@

[ovs-dev] [PATCH ovn] controller: Free the qos hmap built in binding_run().

From: Numan Siddique Fixes the memory leak because of this. Signed-off-by: Numan Siddique --- controller/binding.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/controller/binding.c b/controller/binding.c index 9d37a23cc..a5525a310 100644 ---

[ovs-dev] [PATCH OVN v3] ovn-nbctl.c: Fix lr-policy-del command

This change will check the existence of lr-policy uuid. If not, it will print "uuid is not found". Fixes: 1b030874c32("ovn-nbctl.c: Add an optional way to delete router policy by uuid") Author: Tao YunXiang Signed-off-by: Tao YunXiang CC: Dumitru Ceara --- utilities/ovn-nbctl.c | 4

[ovs-dev] [PATCH] odp-util.c: Fix dp_hash execution with slowpath actions.

When dp_hash is executed with slowpath actions, it results in endless recirc loop in kernel datapath, and finally drops the packet, with kernel logs: openvswitch: ovs-system: deferred action limit reached, drop recirc action The root cause is that the dp_hash value calculated by slowpath is not