Re: [ovs-dev] [PATCH ovn] Fix selection fields for UDP and SCTP load balancers.

2020-06-29 Thread Numan Siddique
On Mon, Jun 29, 2020 at 9:29 PM Numan Siddique wrote: > > > On Mon, Jun 29, 2020 at 8:48 PM Mark Michelson > wrote: > >> On 6/22/20 1:41 PM, num...@ovn.org wrote: >> > From: Numan Siddique >> > >> > The commit 5af304e7478a ("Support selection fields in load balancer.") >> > didn't handle the

[ovs-dev] [PATCH ovn v2] Fix selection fields for UDP and SCTP load balancers.

2020-06-29 Thread numans
From: Numan Siddique The commit 5af304e7478a ("Support selection fields in load balancer.") didn't handle the selection fields for UDP and SCTP protocol. If CMS has set the selection fields - tp_src and tp_dst for UDP or SCTP load balancers, ovn-northd was adding lflows as ct_lb(backends=,

Re: [ovs-dev] [PATCH v2] tc: Changes to netlink message population for OVS-TC Flower Offload

2020-06-29 Thread Satish
Hi Simon, We decided to withdraw this patch for the time being. We'll resubmit this patch along with the linux net-next patch(with driver code) in future". On Sat, Jun 20, 2020 at 12:17 AM dsatish wrote: > > From: Satish Dhote > > OVS-TC offload sends only fields that are not completely masked

Re: [ovs-dev] [PATCH V3 12/12] netdev-offload-dpdk: Fix Ethernet matching for type only

2020-06-29 Thread Eli Britstein
On 6/29/2020 9:10 PM, Ilya Maximets wrote: While calling from the userspace datapath, we always have a match on dl_type. This means that it's not possible to hit the 'else' condition. I'm worried about the usecase described there.  It's hard to track changes in i40e_flow.c.  Can someone test

Re: [ovs-dev] [PATCH RESEND ovs-dev v1 0/2] dpif-netdev: avoid ovs-vswitchd crash

2020-06-29 Thread Tonghao Zhang
On Fri, Jun 12, 2020 at 9:39 AM Tonghao Zhang wrote: > > On Tue, Jun 9, 2020 at 8:54 AM wrote: > > > > From: Tonghao Zhang > > > > This patchset add more robust error handling. > > Tested-at: > > https://travis-ci.com/github/ovn-open-virtual-networks/ovs/builds/170300796 > ping > > Tonghao

[ovs-dev] Test Mail

2020-06-29 Thread svc . eng . git-patch
___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 2/5] stream: Add record/replay functionality.

2020-06-29 Thread Ilya Maximets
For debugging purposes it is useful to be able to record all the incoming transactions and commands and replay them locally under debugger or with additional logging enabled. This patch introduces ability to record all the incoming stream data and replay it via new stream provider named

[ovs-dev] [PATCH 1/5] ovsdb-server: Allow using predictable UUIDs.

2020-06-29 Thread Ilya Maximets
In some cases for debugability it is useful to be able to generate exactly same UUIDs in different runs of the application. For example, this is required for the future stream record/replay functionality of ovsdb-server. With predictable UUIDs we could record all incoming transactions and replay

[ovs-dev] [PATCH 3/5] ovsdb-server: Integrate stream replay engine.

2020-06-29 Thread Ilya Maximets
This change adds support of stream record/replay functionality to ovsdb-server. Since current replay engine doesn't work well with time-based events generated locally, it will work only with standalone databases for now (raft heavily depends on time). To use this functionality run: # record:

[ovs-dev] [PATCH 4/5] ovsdb-server: Don't update manager status if replay engine is active.

2020-06-29 Thread Ilya Maximets
Current version or replay engine doesn't handle correctly internal time-based events that ends up in stream events. For example, updates of a database status that happens each 2.5 seconds reults in updates on client monitors. Disable updates for now if replay engine is active. The very first

[ovs-dev] [PATCH 5/5] jsonrpc: Disable inactivity probes if replay engine is active.

2020-06-29 Thread Ilya Maximets
Current version of replay engine doesn't handle time-based internal events that results in stream send/receive. Disabling jsonrpc inactivity probes for now to not block process waiting for probe being sent. The proper solution whould be to implement correct record/replay of time, probably, by

[ovs-dev] [PATCH 0/5] Stream Record/Replay.

2020-06-29 Thread Ilya Maximets
This patch set adds new stream provider and other functionality in order to record all the incoming data on all the steams (ssl, tcp, unixctl) of openvswitch library based applications and replay these streams later for debugging purposes or performance tests. For example, these changes allowed

[ovs-dev] Tell me I'm dreaming

2020-06-29 Thread 2nd Amendment
Maybe you heard the news report. . . the Democrats are taking aim at Concealed Carry Permits like this site promotes. Currently the #1 CCW Permit available today is in the crossfire of New Lawmakers that want to abolish our rights to carry! Luckily, it's still very easy to Download Your

Re: [ovs-dev] OVS needs to release new stable versions.

2020-06-29 Thread Ben Pfaff
On Tue, Jun 30, 2020 at 12:43:48AM +0200, Ilya Maximets wrote: > On 6/29/20 10:47 PM, Ben Pfaff wrote: > > On Fri, Jun 26, 2020 at 12:18:37PM +0200, Ilya Maximets wrote: > >> So, what is the proposed plan: > >> > >> 1. We should add missed git tags to 2.11.3 and 2.11.4 releases. > >> > >>

Re: [ovs-dev] OVS needs to release new stable versions.

2020-06-29 Thread Ilya Maximets
On 6/29/20 10:47 PM, Ben Pfaff wrote: > On Fri, Jun 26, 2020 at 12:18:37PM +0200, Ilya Maximets wrote: >> So, what is the proposed plan: >> >> 1. We should add missed git tags to 2.11.3 and 2.11.4 releases. >> >> Ben could you, please, take care of this? (Alternatively, I could do >> that,

Re: [ovs-dev] OVS needs to release new stable versions.

2020-06-29 Thread Ben Pfaff
On Fri, Jun 26, 2020 at 12:18:37PM +0200, Ilya Maximets wrote: > So, what is the proposed plan: > > 1. We should add missed git tags to 2.11.3 and 2.11.4 releases. > > Ben could you, please, take care of this? (Alternatively, I could do > that, > but I'm not sure what with the keys

[ovs-dev] Clima Laboral - Herramientas para mejorar el entorno

2020-06-29 Thread Salario emocional y compensación al personal
Jueves 16 de Julio | Horario de 10:00 a 14:00 hrs. | (hora del centro de México) - Salario emocional y otras estrategias de compensación al personal - El salario emocional juega un papel importante en la motivación e implicación de la persona respecto a la organización. Garantizar el

[ovs-dev] Dr Grace H Admas

2020-06-29 Thread perfect cash finance
Congratulation!!! Dear winner, Please kindly view the mail attachment and contact the Claim Manager with the required details for payment Verification/Release. If this Notification Letter hits your Junk/Spam folder, simply move it from your Spam/Junk folder to your inbox for better viewing and

Re: [ovs-dev] [PATCH v2 1/2 ovn] External IP based NAT: Add Columns and CLI

2020-06-29 Thread svc . mail . git
Hi Mark, Thanks a lot for the feedback. a. Address Set is used to make sure that we don't have to configure common set of endpoint ips again and again. In a deployment, peered physical subnets will be common across all the logical routers, hence using address set looked better. As more IPs

[ovs-dev] (no subject)

2020-06-29 Thread Mrs. Daborah Raymond
Dear friend, I have a business container transaction what that some of( $13million dollars) I would like to discuss with you. If you are interested, please contact my email address (mrs.victoria.alexand...@gmail.com) My WhatsApp number but only message (+19293737780) Please do not reply if

[ovs-dev] CALLING FOR HELP

2020-06-29 Thread Mrs Elizabeth Edwards
Dear Friend, Greetings! Please forgive me for stressing you with my predicaments as I know that this letter may come to you as big surprise. Actually, a prophesy came to me 3 days ago through my pastor to reject earthly reward and riches by handing to a person I have not seen and known the

Re: [ovs-dev] [ovs-discuss] OVS 2.12/2.13 compilation on Ubuntu Bionic

2020-06-29 Thread Gregory Rose
On 6/26/2020 4:57 AM, Maciej Jozefczyk wrote: Hello! I would like to kindly ask You if there is a possibility to cherry-pick patch [1] to stable branches OVS 2.12, OVS 2.13 and release new tags for it? Without this patch we're now unable to compile OVS 2.12 in OpenStack Neutron stable

Re: [ovs-dev] [PATCH v2 2/2 ovn] External IP based NAT: NORTHD changes to use allowed/disallowed external ip

2020-06-29 Thread Mark Michelson
On 6/28/20 9:34 PM, Ankur Sharma wrote: From: Ankur Sharma This patch has northd changes which consumes allowed/disallowed external ip configuration per NAT rule in logical flow. Allowed/Disallowed external ip range adds an additional match criteria in snat/dnat/unsnat/undant logical flow

Re: [ovs-dev] [PATCH v2 1/2 ovn] External IP based NAT: Add Columns and CLI

2020-06-29 Thread Mark Michelson
Hi Ankur, Why is it required to use an address set here? Typically in the northbound database, we allow for an arbitrary list of IP addresses to be accepted, rather than requiring the use of an address set. We already use the term "external IP" in NAT documentation, so I think the changes

Re: [ovs-dev] [PATCH V3 00/12] netdev datapath offload: Support IPv6 and VXLAN encap

2020-06-29 Thread Ilya Maximets
On 6/29/20 4:56 PM, Eli Britstein wrote: > Hi > > I have rebased, changed the order of commits to do testpmd format first and > addressed the comments. > > I also added the acked-by of Harsha (though a bit changed since v2). Thanks > again. > > As far as I see the only open issue is if to

Re: [ovs-dev] [PATCH V3 12/12] netdev-offload-dpdk: Fix Ethernet matching for type only

2020-06-29 Thread Ilya Maximets
On 6/29/20 2:21 PM, Eli Britstein wrote: > > On 6/29/2020 3:38 AM, Ilya Maximets wrote: >> On 6/21/20 1:19 PM, Eli Britstein wrote: >>> For OVS rule of the form "eth type is 0x1234 / end", rule is offloaded >>> in the form of "eth / end", which is incorrect. Fix it. >>> >>> Fixes: e8a2b5bf92bb

[ovs-dev] [PATCH] netdev-offload-dpdk: Set transfer attribute to zero for mark/rss offload

2020-06-29 Thread Sriharsha Basavapatna via dev
The offload layer doesn't initialize the 'transfer' attribute for mark/rss offload (partial offload). It should be set to 0. Fixes: 60e778c7533a ("netdev-offload-dpdk: Framework for actions offload.") Signed-off-by: Sriharsha Basavapatna --- lib/netdev-offload-dpdk.c | 3 ++- 1 file changed, 2

Re: [ovs-dev] [PATCH ovn] ovn-northd: Make it harder to specify a bad database remote.

2020-06-29 Thread Ben Pfaff
On Mon, Jun 29, 2020 at 12:38:02PM +0530, Numan Siddique wrote: > On Sat, Jun 27, 2020 at 1:19 AM Ben Pfaff wrote: > > > Without this change, --ovnnb-db='' produces bad results, such as an > > assertion failure. With it, ovn-northd uses the default database. The > > latter seems preferable.

Re: [ovs-dev] [PATCH] jsonrpc: Don't assert for 0 remotes in jsonrpc_session_open_multiple().

2020-06-29 Thread Ben Pfaff
On Mon, Jun 29, 2020 at 12:40:01PM +0530, Numan Siddique wrote: > On Sat, Jun 27, 2020 at 1:17 AM Ben Pfaff wrote: > > > It's pretty easy to get 0 remotes here from ovn-northd if you specify > > --ovnnb-db='' or --ovnnb-db=' ' on the command line. The internals > > of jsonrpc_session aren't

Re: [ovs-dev] [PATCH v3 4/4] bpf: Add reference XDP program implementation for netdev-offload-xdp

2020-06-29 Thread 0-day Robot
Bleep bloop. Greetings Toshiaki Makita, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 83 characters long (recommended limit is 79) ERROR: Improper whitespace

Re: [ovs-dev] [PATCH V3 02/12] netdev-offload-dpdk: Add IPv6 pattern matching

2020-06-29 Thread Eli Britstein
On 6/29/2020 10:45 AM, Eli Britstein wrote: On 6/29/2020 1:42 AM, Ilya Maximets wrote: On 6/21/20 1:19 PM, Eli Britstein wrote: Add support for IPv6 pattern matching for offloading flows. Signed-off-by: Eli Britstein Reviewed-by: Roni Bar Yanai ---   Documentation/howto/dpdk.rst |  2 +-  

Re: [ovs-dev] [PATCH v3 3/4] netdev-offload: Add xdp flow api provider

2020-06-29 Thread 0-day Robot
Bleep bloop. Greetings Toshiaki Makita, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #252 FILE: lib/netdev-afxdp.c:329: /* XXX: close

Re: [ovs-dev] [PATCH v3 1/4] netdev-afxdp: Enable loading XDP program.

2020-06-29 Thread 0-day Robot
Bleep bloop. Greetings Toshiaki Makita, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #164 FILE:

Re: [ovs-dev] [PATCH ovn] Fix selection fields for UDP and SCTP load balancers.

2020-06-29 Thread Numan Siddique
On Mon, Jun 29, 2020 at 8:48 PM Mark Michelson wrote: > On 6/22/20 1:41 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > The commit 5af304e7478a ("Support selection fields in load balancer.") > > didn't handle the selection fields for UDP and SCTP protocol. > > If CMS has set the

[ovs-dev] [PATCH v3 1/4] netdev-afxdp: Enable loading XDP program.

2020-06-29 Thread Toshiaki Makita
From: William Tu Now netdev-afxdp always forwards all packets to userspace because it is using libbpf's default XDP program, see 'xsk_load_xdp_prog'. There are some cases when users want to keep packets in kernel instead of sending to userspace, for example, management traffic such as SSH should

[ovs-dev] [PATCH v3 4/4] bpf: Add reference XDP program implementation for netdev-offload-xdp

2020-06-29 Thread Toshiaki Makita
This adds a reference program, flowtable_afxdp.o, which can be used to offload flows to XDP through netdev-offload-xdp. The program can be compiled with --enable-bpf switch. Signed-off-by: Toshiaki Makita --- Makefile.am | 9 +- acinclude.m4 | 57 bpf/.gitignore

[ovs-dev] [PATCH v3 2/4] netdev-offload: Add "offload-driver" other_config to specify offload driver

2020-06-29 Thread Toshiaki Makita
The following commit will introduce another offload driver using XDP. When using afxdp netdev, both of TC and XDP will be supported, so let's add an other_config to specify which offload driver is preferable. When not specified and multiple offload drivers can be used, TC will be used if netdev

[ovs-dev] [PATCH v3 0/4] XDP offload using flow API provider

2020-06-29 Thread Toshiaki Makita
This patch adds an XDP-based flow cache using the OVS netdev-offload flow API provider. When an OVS device with XDP offload enabled, packets first are processed in the XDP flow cache (with parse, and table lookup implemented in eBPF) and if hits, the action processing are also done in the context

[ovs-dev] [PATCH v3 3/4] netdev-offload: Add xdp flow api provider

2020-06-29 Thread Toshiaki Makita
This provider offloads classifier to software XDP. It works only when a custom XDP object is loaded by afxdp netdev. The BPF program needs to implement classifier with array-of-maps for subtable hashmaps and arraymap for subtable masks. The flow api provider detects classifier support in the

Re: [ovs-dev] [PATCH ovn] Split SB Port_Group per datapath.

2020-06-29 Thread Dumitru Ceara
On 6/29/20 9:39 AM, Numan Siddique wrote: > > > On Fri, Jun 26, 2020 at 6:50 PM Dumitru Ceara > wrote: > > In order to avoid ovn-controller reinstalling all logical flows that > refer a port_group when some ports are added/removed from the port group > we

[ovs-dev] [PATCH ovn v2] Split SB Port_Group per datapath.

2020-06-29 Thread Dumitru Ceara
In order to avoid ovn-controller reinstalling all logical flows that refer a port_group when some ports are added/removed from the port group we now change the way ovn-northd populates the Southbound DB Port_Group table. Instead of copying NB.Port_Group.name to SB.Port_Group.name we now create

Re: [ovs-dev] [PATCH ovn] Fix selection fields for UDP and SCTP load balancers.

2020-06-29 Thread Mark Michelson
On 6/22/20 1:41 PM, num...@ovn.org wrote: From: Numan Siddique The commit 5af304e7478a ("Support selection fields in load balancer.") didn't handle the selection fields for UDP and SCTP protocol. If CMS has set the selection fields - tp_src and tp_dst for UDP or SCTP load balancers, ovn-northd

Re: [ovs-dev] [PATCH V3 00/12] netdev datapath offload: Support IPv6 and VXLAN encap

2020-06-29 Thread Eli Britstein
Hi I have rebased, changed the order of commits to do testpmd format first and addressed the comments. I also added the acked-by of Harsha (though a bit changed since v2). Thanks again. As far as I see the only open issue is if to drop the comment about XL710 or not. Please address it

[ovs-dev] [PATCH v6] Bareudp Tunnel Support

2020-06-29 Thread Martin Varghese
From: Martin Varghese There are various L3 encapsulation standards using UDP being discussed to leverage the UDP based load balancing capability of different networks. MPLSoUDP (__ https://tools.ietf.org/html/rfc7510) is one among them. The Bareudp tunnel provides a generic L3 encapsulation

Re: [ovs-dev] [PATCH V3 12/12] netdev-offload-dpdk: Fix Ethernet matching for type only

2020-06-29 Thread Eli Britstein
On 6/29/2020 3:38 AM, Ilya Maximets wrote: On 6/21/20 1:19 PM, Eli Britstein wrote: For OVS rule of the form "eth type is 0x1234 / end", rule is offloaded in the form of "eth / end", which is incorrect. Fix it. Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow")

Re: [ovs-dev] [PATCH V3 09/12] dpif-netdev: Don't use zero flow mark

2020-06-29 Thread Eli Britstein
On 6/29/2020 2:47 AM, Ilya Maximets wrote: On 6/21/20 1:19 PM, Eli Britstein wrote: Zero flow mark is used to indicate the HW to remove the mark. A packet marked with zero mark is received in SW without a mark at all, so it cannot be used as a valid mark. Change the pool range to fix it.

Re: [ovs-dev] [PATCH V3 08/12] netdev-offload-dpdk: Support tnl/push using vxlan encap attribute

2020-06-29 Thread Eli Britstein
On 6/29/2020 2:45 AM, Ilya Maximets wrote: On 6/21/20 1:19 PM, Eli Britstein wrote: For DPDK, there is the RAW_ENCAP attribute which gets raw buffer of the encapsulation header. For specific protocol, such as vxlan, there is a more specific attribute, VXLAN_ENCAP, which gets the parsed fields

Re: [ovs-dev] [PATCH V3 07/12] netdev-offload-dpdk: Support offload of clone tnl_push/output actions

2020-06-29 Thread Eli Britstein
On 6/29/2020 2:12 AM, Ilya Maximets wrote: On 6/21/20 1:19 PM, Eli Britstein wrote: Tunnel encapsulation is done by tnl_push and output actions nested in a clone action. Support offloading of such flows with RTE_FLOW_ACTION_TYPE_RAW_ENCAP attribute. Signed-off-by: Eli Britstein Reviewed-by:

Re: [ovs-dev] [PATCH ovn] chassis.c: Add comment to SB DB transaction only when needed.

2020-06-29 Thread Dumitru Ceara
On 6/29/20 9:35 AM, Numan Siddique wrote: > > > On Thu, Jun 25, 2020 at 1:28 PM Dumitru Ceara > wrote: > > The chassis_run() function incorrectly adds a "ovn-controller: > registering chassis" comment to every SB transaction. This should be > done >

[ovs-dev] [PATCH ovn v2] chassis.c: Add comment to SB DB transaction only when needed.

2020-06-29 Thread Dumitru Ceara
The chassis_run() function incorrectly adds a "ovn-controller: registering chassis" comment to every SB transaction. This should be done only when the chassis record is created or updated. If nothing changes in the chassis record we shouldn't add useless extra information to the transaction

[ovs-dev] [PATCH v4 4/5] dpif-netdev: Support flow_get() with partial-action-offload

2020-06-29 Thread Sriharsha Basavapatna via dev
For flows that offload partial actions in egress direction, provide the right netdev to fetch statistics. Signed-off-by: Sriharsha Basavapatna --- lib/dpif-netdev.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index

[ovs-dev] [PATCH v4 3/5] dpif-netdev: Skip encap action during datapath execution

2020-06-29 Thread Sriharsha Basavapatna via dev
In this patch we check if action processing (apart from OUTPUT action), should be skipped for a given dp_netdev_flow. Specifically, we check if the action is TNL_PUSH and if it has been offloaded to HW, then we do not push the tunnel header in SW. The datapath only executes the OUTPUT action. The

[ovs-dev] [PATCH v4 0/5] netdev datapath: Partial action offload

2020-06-29 Thread Sriharsha Basavapatna via dev
Hi, This patchset extends the "Partial HW acceleration" mode to offload a part of the action processing to HW, instead of offloading just lookup (MARK/RSS), for "vhost-user" ports. This is referred to as "Partial Action Offload". This mode does not require SRIOV/switchdev configuration. In this

[ovs-dev] [PATCH v4 5/5] dpif-netdev: Support partial-action-offload of VXLAN encap flow

2020-06-29 Thread Sriharsha Basavapatna via dev
In this patch, we support offloading of VXLAN_ENCAP action for a vhost-user port (aka "partial-action-offload"). At the time of offloading the flow, we determine if the flow can be offloaded to an egress device, if the input port is not offload capable such as a vhost-user port. We then offload

[ovs-dev] [PATCH v4 1/5] dpif-netdev: Refactor dp_netdev_flow_offload_put()

2020-06-29 Thread Sriharsha Basavapatna via dev
This patch refactors dp_netdev_flow_offload_put() to prepare for changes to support partial action offload, in subsequent patches. - Move mark allocation code into a separate wrapper function, outside of dp_netdev_flow_offload_put() to improve readability and to facilitate more changes in

[ovs-dev] [PATCH v4 2/5] netdev-dpdk: provide a function to identify dpdk-vhost netdevs

2020-06-29 Thread Sriharsha Basavapatna via dev
This patch adds a function to determine if a given netdev belongs to the dpdk-vhost class, using the netdev_class specific data. Signed-off-by: Sriharsha Basavapatna --- lib/netdev-dpdk.c | 5 + lib/netdev-dpdk.h | 1 + 2 files changed, 6 insertions(+) diff --git a/lib/netdev-dpdk.c

Re: [ovs-dev] [RFC v3 PATCH 3/5] dpif-netdev: Skip encap action during datapath execution

2020-06-29 Thread Sriharsha Basavapatna via dev
On Tue, Jun 2, 2020 at 11:47 AM Eli Britstein wrote: > > > On 6/1/2020 8:29 PM, Sriharsha Basavapatna wrote: > > On Mon, Jun 1, 2020 at 9:18 PM Eli Britstein wrote: > >> > >> On 6/1/2020 6:15 PM, Sriharsha Basavapatna wrote: > >>> On Mon, Jun 1, 2020 at 7:58 PM Eli Britstein wrote: > On

[ovs-dev] [PATCH] lib/tc: only update the stats for non-empty counter

2020-06-29 Thread wenxu
From: wenxu A packet with first frag and execute act_ct action. The packet will stole by defrag. So the stats counter for "gact action goto chain" will always 0. The openvswitch update each action in order. So the flower stats finally alway be zero. The rule will be delete adter max-idle time

Re: [ovs-dev] [PATCH V3 10/12] dpif-netdev: Add mega ufid in flow add log

2020-06-29 Thread Ilya Maximets
On 6/29/20 7:33 AM, Sriharsha Basavapatna wrote: > On Mon, Jun 29, 2020 at 5:30 AM Ilya Maximets wrote: >> >> On 6/21/20 1:19 PM, Eli Britstein wrote: >>> As offload is done using the mega ufid of a flow, for better >>> debugability, add it in the log message. >> >> Could you, please, tell me why

Re: [ovs-dev] [PATCH V3 02/12] netdev-offload-dpdk: Add IPv6 pattern matching

2020-06-29 Thread Ilya Maximets
On 6/29/20 9:45 AM, Eli Britstein wrote: > > On 6/29/2020 1:42 AM, Ilya Maximets wrote: >> On 6/21/20 1:19 PM, Eli Britstein wrote: >>> Add support for IPv6 pattern matching for offloading flows. >>> >>> Signed-off-by: Eli Britstein >>> Reviewed-by: Roni Bar Yanai >>> --- >>>  

Re: [ovs-dev] [PATCH V3 01/12] netdev-offload-dpdk: Remove pre-validate of patterns function

2020-06-29 Thread Sriharsha Basavapatna via dev
On Mon, Jun 29, 2020 at 2:27 PM Ilya Maximets wrote: > > On 6/29/20 9:11 AM, Eli Britstein wrote: > > > > On 6/29/2020 1:01 AM, Ilya Maximets wrote: > >> On 6/21/20 1:19 PM, Eli Britstein wrote: > >>> The function of adding patterns by requested matches checks that it > >>> consumed all the

Re: [ovs-dev] [PATCH V3 01/12] netdev-offload-dpdk: Remove pre-validate of patterns function

2020-06-29 Thread Ilya Maximets
On 6/29/20 9:11 AM, Eli Britstein wrote: > > On 6/29/2020 1:01 AM, Ilya Maximets wrote: >> On 6/21/20 1:19 PM, Eli Britstein wrote: >>> The function of adding patterns by requested matches checks that it >>> consumed all the required matches, and err if not. This nullify the >>> purpose of the

Re: [ovs-dev] [PATCH V3 03/12] netdev-offload-dpdk: Support offload of set IPv6 actions

2020-06-29 Thread Eli Britstein
On 6/29/2020 2:02 AM, Ilya Maximets wrote: On 6/21/20 1:19 PM, Eli Britstein wrote: Some trivial commit message here? OK. Signed-off-by: Eli Britstein Reviewed-by: Roni Bar Yanai --- Documentation/howto/dpdk.rst | 1 + NEWS | 2 ++ lib/netdev-offload-dpdk.c

Re: [ovs-dev] [PATCH V3 01/12] netdev-offload-dpdk: Remove pre-validate of patterns function

2020-06-29 Thread Eli Britstein
On 6/29/2020 1:01 AM, Ilya Maximets wrote: On 6/21/20 1:19 PM, Eli Britstein wrote: The function of adding patterns by requested matches checks that it consumed all the required matches, and err if not. This nullify the purpose of the validation function. Future supported matches will only

Re: [ovs-dev] [PATCH V3 02/12] netdev-offload-dpdk: Add IPv6 pattern matching

2020-06-29 Thread Eli Britstein
On 6/29/2020 1:42 AM, Ilya Maximets wrote: On 6/21/20 1:19 PM, Eli Britstein wrote: Add support for IPv6 pattern matching for offloading flows. Signed-off-by: Eli Britstein Reviewed-by: Roni Bar Yanai --- Documentation/howto/dpdk.rst | 2 +- NEWS | 1 +

Re: [ovs-dev] [PATCH ovn] Split SB Port_Group per datapath.

2020-06-29 Thread Numan Siddique
On Fri, Jun 26, 2020 at 6:50 PM Dumitru Ceara wrote: > In order to avoid ovn-controller reinstalling all logical flows that > refer a port_group when some ports are added/removed from the port group > we now change the way ovn-northd populates the Southbound DB Port_Group > table. > > Instead of

Re: [ovs-dev] [PATCH ovn] chassis.c: Add comment to SB DB transaction only when needed.

2020-06-29 Thread Numan Siddique
On Thu, Jun 25, 2020 at 1:28 PM Dumitru Ceara wrote: > The chassis_run() function incorrectly adds a "ovn-controller: > registering chassis" comment to every SB transaction. This should be done > only when the chassis record is created or updated. If nothing changes in > the chassis record we

Re: [ovs-dev] [PATCH] jsonrpc: Don't assert for 0 remotes in jsonrpc_session_open_multiple().

2020-06-29 Thread Numan Siddique
On Sat, Jun 27, 2020 at 1:17 AM Ben Pfaff wrote: > It's pretty easy to get 0 remotes here from ovn-northd if you specify > --ovnnb-db='' or --ovnnb-db=' ' on the command line. The internals > of jsonrpc_session aren't equipped to cope with that, so just add a > dummy remote instead. > >

Re: [ovs-dev] [PATCH ovn] ovn-northd: Make it harder to specify a bad database remote.

2020-06-29 Thread Numan Siddique
On Sat, Jun 27, 2020 at 1:19 AM Ben Pfaff wrote: > Without this change, --ovnnb-db='' produces bad results, such as an > assertion failure. With it, ovn-northd uses the default database. The > latter seems preferable. Similarly for --ovnsb-db=''. > > Signed-off-by: Ben Pfaff > Acked-by:

Re: [ovs-dev] [PATCH] dpif-netdev-unixctl.man: document bond-show command

2020-06-29 Thread Vishal Deep Ajmera via dev
> . > .IP "\fBdpif-netdev/pmd-rxq-rebalance\fR [\fIdp\fR]" > Reassigns rxqs to pmds in the datapath \fIdp\fR based on their current > usage. > +. > +.IP "\fBdpif-netdev/bond-show\fR [\fIdp\fR]" > +When "other_config:lb-output-action" is set to "true", the userspace > datapath > +handles the