Re: [ovs-dev] [PATCH ovs-dev v3 4/4] Revert "dpif-netdev: includes microsecond delta in meter bucket calculation".

2020-07-27 Thread Tonghao Zhang
On Tue, Jul 28, 2020 at 12:36 AM Ilya Maximets wrote: > > On 5/23/20 12:33 PM, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > This reverts commit 5c41c31ebd64fda821fb733a5784a7a440a794f8. > > > > Use the pktgen-dpdk to test the commit 5c41c31ebd64 > > ("dpif-netdev: includes

Re: [ovs-dev] [PATCH v3 3/4] netdev-offload: Add xdp flow api provider

2020-07-27 Thread Toshiaki Makita
On 2020/07/28 3:14, William Tu wrote: On Sun, Jul 26, 2020 at 9:55 AM Toshiaki Makita wrote: snip How about doing s.t like: --enable-afxdp: the current one on master without the xdp offload program --enable-afxdp-with-bpf: the afxdp one plus your xdp offload program So that when users

Re: [ovs-dev] [PATCH ovn v3 5/5] Add ECMP symmetric replies.

2020-07-27 Thread 0-day Robot
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (tests/ovn.at). error: could not build fake

Re: [ovs-dev] [PATCH] tests: Refactor the iptables accept rule.

2020-07-27 Thread William Tu
On Fri, Jul 24, 2020 at 10:03 AM Gregory Rose wrote: > > > On 7/23/2020 9:35 AM, William Tu wrote: > > Certain Linux distributions, like CentOS, have default iptable > > rules to reject input traffic from br-underlay. Refactor by > > creating a macro 'IPTABLES_ACCEPT([bridge])' for adding the >

Re: [ovs-dev] [PATCH ovn v3 4/5] Used nested actions in ct_commit

2020-07-27 Thread 0-day Robot
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 111 characters long (recommended limit is 79) #297 FILE: ovn-sb.xml:1267:

[ovs-dev] [PATCH ovn v3 5/5] Add ECMP symmetric replies.

2020-07-27 Thread Mark Michelson
When traffic arrives over an ECMP route, there is no guarantee that the reply traffic will egress over the same route. Sometimes, the nature of the traffic (or the intervening equipment) means that it is important for reply traffic to go out the same route it came in. This commit introduces

[ovs-dev] [PATCH ovn v3 2/5] Don't check for writeability of rhs during assignment.

2020-07-27 Thread Mark Michelson
The only condition under which the right-hand side of an assignment needs to be checked for writeability is if it is an exchange (<->) operation. Signed-off-by: Mark Michelson --- lib/actions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/actions.c b/lib/actions.c

[ovs-dev] [PATCH ovn v3 4/5] Used nested actions in ct_commit

2020-07-27 Thread Mark Michelson
ct_commit allows for ct_label and ct_mark to be set within. However, there are some restrictions with the current implementation: * It is not possible to address the indiviual bits within the ct_mark or ct_label. * It is not possible to set these to the value of a register. Only explicit

[ovs-dev] [PATCH ovn v3 1/5] Add IP address normalization to ovn-utils.

2020-07-27 Thread Mark Michelson
This moves a couple of existing IP address normalization routines from ovn-nbctl.c to ovn-util.c. It also adds a new normalization function for a v46_address. This new function is not used in this commit but will be used in a future commit in this series. Signed-off-by: Mark Michelson ---

[ovs-dev] [PATCH ovn v3 3/5] Add expression writeability scopes.

2020-07-27 Thread Mark Michelson
Logical fields are defined as either being writeable or read-only. There is no way to make fields writeable only in specific scenarios. This commit changes the boolean writeability field to a field of flags indicating contexts where a field is writeable. Any time that nested actions are used

[ovs-dev] [PATCH ovn v3 0/5] Add ECMP symmetric replies

2020-07-27 Thread Mark Michelson
In some cases, it is important that traffic that arrived over an ECMP route has its replies sent out over that same route. This series of commits adds some prerequisite changes in order to facilitate using conntrack labels to store information about the incoming traffic. The final commit adds the

[ovs-dev] OVN nb-db and sb-db election timer

2020-07-27 Thread Tony Liu
Hi, During scaling test, when sb-db is busy, followers believe the leader is dead and started election request. Some inconsistency happens during such leader switch. Two datapath bindings are created for the same logical switch. To avoid such case, I was recommended to increase election timer

[ovs-dev] NOM 035 - Implementación efectiva

2020-07-27 Thread Claves para una implementación efectiva
Buenos día Quise aprovechar la oportunidad de hacerte una invitación para tomar nuestro: Nombre: NOM 035. Claves para una implementación efectiva. Fecha: 13 de Agosto Horario: 10:00 am a 13:00 pm Formato: En línea con interacción en vivo. Lugar: En Vivo desde su computadora

Re: [ovs-dev] [PATCH ovn] ovn-controller: Clear flows not associated with db rows in physical flow change handler.

2020-07-27 Thread Numan Siddique
On Mon, Jul 27, 2020 at 11:45 PM Mark Michelson wrote: > Acked-by: Mark Michelson > > There's one small comment in your test. You can just fix it when you > merge, though. > Thanks for the review. I addressed your comment and applied this patch to master and branch-20.06 Numan > > On

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Fix the missing flows when logical router port is added after its peer.

2020-07-27 Thread Numan Siddique
On Mon, Jul 27, 2020 at 11:35 PM Mark Michelson wrote: > Acked-by: Mark Michelson > > On 7/24/20 5:02 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > When the logical router port is created by CMS after its peer port is > created like > > below, ovn-controller doesn't add the

Re: [ovs-dev] [PATCH] odp-util: Fix clearing match mask if set action is partially unnecessary.

2020-07-27 Thread Ilya Maximets
On 7/27/20 6:59 PM, Adrian Moreno wrote: > Hi, > > I can confirm that this patch fixes the issue described in > https://bugzilla.redhat.com/show_bug.cgi?id=1854376 > > Thanks > > > On 7/27/20 6:01 PM, Ilya Maximets wrote: >> While committing set() actions, commit() could wildcard all the

[ovs-dev] [PATCH v2] odp-util: Fix clearing match mask if set action is partially unnecessary.

2020-07-27 Thread Ilya Maximets
While committing set() actions, commit() could wildcard all the fields that are same in match key and in the set action. This leads to situation where mask after commit could actually contain less bits than it was before. And if set action was partially committed, all the fields that was the

Re: [ovs-dev] [PATCH ovn] ovn-controller: Clear flows not associated with db rows in physical flow change handler.

2020-07-27 Thread Mark Michelson
Acked-by: Mark Michelson There's one small comment in your test. You can just fix it when you merge, though. On 7/27/20 12:57 PM, num...@ovn.org wrote: From: Numan Siddique The commit in the Fixes tag while handling changes for OVS interface changes and ct zone changes, called

Re: [ovs-dev] [PATCH v3 3/4] netdev-offload: Add xdp flow api provider

2020-07-27 Thread William Tu
On Sun, Jul 26, 2020 at 9:55 AM Toshiaki Makita wrote: > snip > >> How about doing s.t like: > >> --enable-afxdp: the current one on master without the xdp offload program > >> --enable-afxdp-with-bpf: the afxdp one plus your xdp offload program > >> > >> So that when users only --enable-afxdp,

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Fix the missing flows when logical router port is added after its peer.

2020-07-27 Thread Mark Michelson
Acked-by: Mark Michelson From: Numan Siddique When the logical router port is created by CMS after its peer port is created like below, ovn-controller doesn't add the logical router to the local_datapaths and hence misses programming the flows for the router datapath if the logical switch

Re: [ovs-dev] [PATCH v3 0/4] XDP offload using flow API provider

2020-07-27 Thread William Tu
On Mon, Jul 27, 2020 at 3:02 AM Toshiaki Makita wrote: > > Hi William, > > On 2020/07/16 23:05, Toshiaki Makita wrote: > > Hi William, > > > > Thank you for taking a look! > > > > On 2020/07/16 0:49, William Tu wrote: > >> Hi Toshiaki, > >> > >> Thanks for the interesting patch series! > >> I

Re: [ovs-dev] [ovs-discuss] OVN scale

2020-07-27 Thread Tony Liu
Hi Han, Just some updates here. I tried with 4K networks on single router. Configuration was done without any issues. I checked both nb-db and sb-db, they all look good. It's just that router configuration is huge (in Neutron DB, nb-db and flow table in sb-db), because it contains all 4K

Re: [ovs-dev] [PATCH v3 1/4] netdev-afxdp: Enable loading XDP program.

2020-07-27 Thread William Tu
> > So BTF should not have anything to do with this problem... > > I'll test it with a program without BTF. > > Tested it with a program without BTF nor maps. > > ``` > $ readelf -S noop.o | grep map > $ readelf -S noop.o | grep BTF > $ > ``` > > Even with this program, reconfiguration loop did

Re: [ovs-dev] [PATCH] odp-util: Fix clearing match mask if set action is partially unnecessary.

2020-07-27 Thread Adrian Moreno
Hi, I can confirm that this patch fixes the issue described in https://bugzilla.redhat.com/show_bug.cgi?id=1854376 Thanks On 7/27/20 6:01 PM, Ilya Maximets wrote: > While committing set() actions, commit() could wildcard all the fields > that are same in match key and in the set action. This

[ovs-dev] [PATCH ovn] ovn-controller: Clear flows not associated with db rows in physical flow change handler.

2020-07-27 Thread numans
From: Numan Siddique The commit in the Fixes tag while handling changes for OVS interface changes and ct zone changes, called physical_run() without clearing the flow table. This works ok for existing flows in the flow table which are associated with ovsdb rows. physical_run() ensures that

Re: [ovs-dev] [PATCH ovs-dev v3 4/4] Revert "dpif-netdev: includes microsecond delta in meter bucket calculation".

2020-07-27 Thread Ilya Maximets
On 5/23/20 12:33 PM, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > This reverts commit 5c41c31ebd64fda821fb733a5784a7a440a794f8. > > Use the pktgen-dpdk to test the commit 5c41c31ebd64 > ("dpif-netdev: includes microsecond delta in meter bucket calculation"), it > does't work as

Re: [ovs-dev] [PATCHv2] python: fixed package dependency

2020-07-27 Thread Ilya Maximets
On 7/24/20 6:46 PM, Gregory Rose wrote: > > > On 7/23/2020 11:24 AM, Ilya Maximets wrote: >> On 7/23/20 6:40 PM, Gregory Rose wrote: >>> >>> >>> On 7/23/2020 7:36 AM, William Tu wrote: On Wed, Jul 22, 2020 at 3:22 PM Gregory Rose wrote: > > > On 7/22/2020 2:25 PM, Toms Atteka

[ovs-dev] [PATCH] odp-util: Fix clearing match mask if set action is partially unnecessary.

2020-07-27 Thread Ilya Maximets
While committing set() actions, commit() could wildcard all the fields that are same in match key and in the set action. This leads to situation where mask after commit could actually contain less bits than it was before. And if set action was partially committed, all the fields that was the

Re: [ovs-dev] [PATCH v3 1/4] netdev-afxdp: Enable loading XDP program.

2020-07-27 Thread Toshiaki Makita
Hi William, On 2020/07/16 23:09, Toshiaki Makita wrote: On 2020/07/16 10:30, William Tu wrote: On Mon, Jun 29, 2020 at 8:30 AM Toshiaki Makita wrote: From: William Tu Now netdev-afxdp always forwards all packets to userspace because it is using libbpf's default XDP program, see

[ovs-dev] question about userspace flow stats with meter

2020-07-27 Thread ychen
hi, I want to know how datapath stats mapped to userspace flow stats? is there any documents? example: table=0,in_port=1, meter=11,goto_table:2 table=2,in_port=1,output:2 meter: rate=1Mbps when I send packets with 2Mbps from port1, and totally 1 packets transmited first I

[ovs-dev] [PATCH] datapath-windows: Update flow key in SET action

2020-07-27 Thread Jinjun Gao
The flow key is not updated when process OVS_ACTION_ATTR_SET action. It will impact follow-up actions, such as, conntrack module cannot find created conntrack entry if passing older flow key to it. Reported-by: Rui Cao Signed-off-by: Jinjun Gao --- datapath-windows/ovsext/Actions.c | 41

[ovs-dev] [PATCH 1/2] configure: fix binutils check not disabling avx512 compilation

2020-07-27 Thread Harry van Haaren
This commit avoids compiling and linking of avx512 code into the vswitch_la library if the binutils check fails. Signed-off-by: Harry van Haaren --- lib/automake.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/automake.mk b/lib/automake.mk index 920c958e3..218dc7313 100644 ---

[ovs-dev] [PATCH 2/2] configure: explicitly disable avx512 if bintuils check fails

2020-07-27 Thread Harry van Haaren
This commit explicitly disables avx512f if the binutils assembler check fails to correctly assemble its input. Without this fix, there is a possibility that users can see undefined behaviour when compiling with -march=native on a CPU which supports avx512 and with a buggy binutils version (v2.30

[ovs-dev] (no subject)

2020-07-27 Thread Cheyrie Mary. Solis Solis via dev
Ich bin ein privater Finanzberater für Prime Lending und arbeite mit Großkredite, die an einen Betreiber einer Unternehmenskonsortialgruppe angeschlossen sind, I. Sichern Sie gewerbliche Geschäftskredite und Privatkredite für alle Zweck, von 5.000 bis 500.000,00, für Privatkredit und bis zu

Re: [ovs-dev] [PATCH v3 0/4] XDP offload using flow API provider

2020-07-27 Thread Toshiaki Makita
Hi William, On 2020/07/16 23:05, Toshiaki Makita wrote: Hi William, Thank you for taking a look! On 2020/07/16 0:49, William Tu wrote: Hi Toshiaki, Thanks for the interesting patch series! I haven't finished reviewing, but I went through a couple of steps to make sure it works in my

[ovs-dev] Whatever your illness or disorder is it's better to be sure of the medications you take!

2020-07-27 Thread 24-7-Drugstore
Reliable delivery. Very efficient service! "Very good service as usual!" - By Aiden ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev