[ovs-dev] [Linux-kernel-mentees] [PATCH net] openvswitch: Prevent kernel-infoleak in ovs_ct_put_key()

ovs_ct_put_key() is potentially copying uninitialized kernel stack memory into socket buffers, since the compiler may leave a 3-byte hole at the end of `struct ovs_key_ct_tuple_ipv4` and `struct ovs_key_ct_tuple_ipv6`. Fix it by initializing `orig` with memset(). Cc: sta...@vger.kernel.org Fixes:

Re: [ovs-dev] [PATCH v4 4/5] bpf: Add reference XDP program implementation for netdev-offload-xdp

Bleep bloop. Greetings Toshiaki Makita, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Improper whitespace around control block #494 FILE: bpf/bpf_netlink.h:57: #define

[ovs-dev] [PATCH v4 3/5] netdev-offload: Add xdp flow api provider

This provider offloads classifier to software XDP. It works only when a custom XDP object is loaded by afxdp netdev. The BPF program needs to implement classifier with array-of-maps for subtable hashmaps and arraymap for subtable masks. The flow api provider detects classifier support in the

[ovs-dev] [PATCH v4 2/5] netdev-offload: Add "offload-driver" other_config to specify offload driver

The following commit will introduce another offload driver using XDP. When using afxdp netdev, both of TC and XDP will be supported, so let's add an other_config to specify which offload driver is preferable. When not specified and multiple offload drivers can be used, TC will be used if netdev

[ovs-dev] [PATCH v4 4/5] bpf: Add reference XDP program implementation for netdev-offload-xdp

This adds a reference program, flowtable_afxdp.o, which can be used to offload flows to XDP through netdev-offload-xdp. The program can be compiled with --enable-xdp-offload switch. Signed-off-by: Toshiaki Makita --- Makefile.am | 9 +- acinclude.m4 | 37 ++-

[ovs-dev] [PATCH v4 5/5] bpf: Add dummy program for veth devices

When we use XDP_REDIRECT on veth, the peer device needs to load some XDP program to make XDP_REDIRECT work. For convenience we add xdp_noop.o in bpf directory, which does nothing but returns XDP_PASS. Example command to use xdp_noop: Assume you use veth0 for OVS port and veth1 is its peer.

[ovs-dev] [PATCH v4 0/5] XDP offload using flow API provider

This patch adds an XDP-based flow cache using the OVS netdev-offload flow API provider. When an OVS device with XDP offload enabled, packets first are processed in the XDP flow cache (with parse, and table lookup implemented in eBPF) and if hits, the action processing are also done in the context

[ovs-dev] [PATCH v4 1/5] netdev-afxdp: Enable loading XDP program.

From: William Tu Now netdev-afxdp always forwards all packets to userspace because it is using libbpf's default XDP program, see 'xsk_load_xdp_prog'. There are some cases when users want to keep packets in kernel instead of sending to userspace, for example, management traffic such as SSH should

Re: [ovs-dev] OVN: Two datapath-bindings are created for the same logical-switch

resend as plain text, since I got "The message's content type was not explicitly allowed" reply from ovs-dev-owner. On Thu, Jul 30, 2020 at 7:30 PM Han Zhou wrote: > > > > On Thu, Jul 30, 2020 at 7:24 PM Tony Liu wrote: >> >> Hi Han, >> >> >> >> Continue with this thread. Regarding to your

Re: [ovs-dev] [ovs-discuss] [OVN] DB backup and restore

On Thu, Jul 30, 2020 at 7:04 PM Tony Liu wrote: > Hi, > > > > Just update, finally make this snapshot/rollback work for me. > > The rollback is not live though. Here is what I did. > > > > 1. Make a snapshot by ovsdb-client. Assuming no ongoing > >Transactions, and data is consistent on all

Re: [ovs-dev] [ovs-discuss] [OVN] DB backup and restore

Mmm... nb-db rolled back, but sb-db is not re-synced, ovn-northd complaints "clustered database server has stale data; trying another server". Any way to workaround it or I need to snapshot and rollback sb-db as well? Thanks! Tony From: Tony Liu Sent: Thursday,

Re: [ovs-dev] [ovs-discuss] [OVN] DB backup and restore

Hi, Just update, finally make this snapshot/rollback work for me. The rollback is not live though. Here is what I did. 1. Make a snapshot by ovsdb-client. Assuming no ongoing Transactions, and data is consistent on all nodes. The Snapshot can be done on any node. It doesn't include any

Re: [ovs-dev] [ovs-dev v1] odp-util: clearing padding in the nd_extension

Bleep bloop. Greetings hepeng.0320, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 83 characters long (recommended limit is 79) #35 FILE: lib/odp-util.c:6360:

[ovs-dev] [ovs-dev v1] odp-util: clearing padding in the nd_extension

From: Peng He Silimar to the patch fffd3ae2866255cb740457b50a217c0b586f9223, when change from flow into the netlink format, the tail padding of nd_extension should be cleared. this fixes the following warning logs:

Re: [ovs-dev] [ovs-discuss] [OVN] DB backup and restore

Hi Numan, I found this comment you made a few years back. - At neutron-server startup, OVN ML2 driver syncs the neutron DB and OVN DB if sync mode is set to repair. - Admin can run the "neutron-ovn-db-sync-util" to sync the DBs. Could you share the details to try those two options? Thanks!

[ovs-dev] BUSINESS PROPOSAL

Hello, Apply for a loan, at a 3% interest rate. Do you need a personal loan? Do you need a business loan? Do you need a consolidation loan? Do you need a secure loan? Do you need an unsecured loan? Do you need a mortgage loan? Do you need a pay off debt loan?

Re: [ovs-dev] [ovs-discuss] [OVN] DB backup and restore

Hi, I have another thought after some diggings. Since I am with OpenStack, all networking configurations are from OpenStack. I could snapshot OpenStack MariaDB, restore and run neutron-ovn-db-sync to update OVN DB. Would that be a cleaner solution? BTW, I got this error when restore the OVN DB.

Re: [ovs-dev] [ovs-discuss] [OVN] DB backup and restore

Hi, A quick question here. Given this man page. http://www.openvswitch.org/support/dist-docs/ovsdb-client.1.txt It says backup and restore commands are for OVSDB standalone and active-backup databases. Can they be used for RAFT cluster? If not, what would be the concern, like inconsistency?

[ovs-dev] urgent please,

Attn: Sir/Madam, My names are Prince Egobia Okon's ,I have packaged a transaction that will be of mutual benefit to both of us. I want you to help my family received and invest the sum of USD$10.5Million dollars my late father deposited in a bank here before his sudden death. My father died early

Re: [ovs-dev] [ovs-discuss] [OVN] DB backup and restore

On Thu, Jul 30, 2020 at 10:56 AM Tony Liu wrote: > Hi Han, > > > > That doc helps. I will run some tests and update here. The use case I want > > to cover is snapshot/rollback and backup/restore. > > > > > > Actually, "at-least-once" consistency, because OVSDB does not have a > session

[ovs-dev] OVN Meeting Logs 30 July, 2020

Here is the IRC log for the OVN meeting for 30 July, 2020 http://eavesdrop.openstack.org/meetings//ovn_community_development_discussion/2020/ovn_community_development_discussion.2020-07-30-17.14.log.html If you are interested in attending this meeting, it happens every Thursday in the

[ovs-dev] RFC: ct action ofproto/trace improvements

Hi all, Below is a short proposal for improving the results of ofproto/trace in regards to ct actions. Feedback welcome. Eric. --->8--- ### Problem statement - ofproto/trace fails in regard to conntrack states and address/port translations - conntrack is used heavily in OVN - makes debugging

Re: [ovs-dev] [ovs-discuss] [OVN] DB backup and restore

Hi Han, That doc helps. I will run some tests and update here. The use case I want to cover is snapshot/rollback and backup/restore. Actually, "at-least-once" consistency, because OVSDB does not have a session mechanism to drop duplicate transactions if a connection drops after the

Re: [ovs-dev] [PATCH net-next v3 2/2] net: openvswitch: make masks cache size configurable

On 30 Jul 2020, at 16:23, Tonghao Zhang wrote: On Thu, Jul 30, 2020 at 9:52 PM Eelco Chaudron wrote: On 30 Jul 2020, at 15:25, Tonghao Zhang wrote: On Thu, Jul 30, 2020 at 8:33 PM Eelco Chaudron wrote: Thanks Tonghao for the review, see comments inline below! If I get no more

Re: [ovs-dev] [PATCH net-next v3 2/2] net: openvswitch: make masks cache size configurable

On Thu, Jul 30, 2020 at 9:52 PM Eelco Chaudron wrote: > > > > On 30 Jul 2020, at 15:25, Tonghao Zhang wrote: > > > On Thu, Jul 30, 2020 at 8:33 PM Eelco Chaudron > > wrote: > >> > >> Thanks Tonghao for the review, see comments inline below! > >> > >> If I get no more reviews by the end of the

Re: [ovs-dev] [PATCH ovn] expr.c: Fix argument type of expr_write_scope().

Thanks, Han. I guess I need to upgrade gcc since I didn't see this locally. On 7/29/20 9:44 PM, Han Zhou wrote: There is compile error introduced by the commit 2054d01247. *** ../lib/expr.c:3328:6: error: symbol 'expr_type_check' redeclared with different type (originally declared at

[ovs-dev] [PATCH 1/1] netdev-offload-dpdk: Preserve HW statistics for modified flows

In case of a flow modification, preserve the HW statistics of the old HW flow to the new one. Signed-off-by: Eli Britstein Reviewed-by: Gaetan Rivet --- lib/netdev-offload-dpdk.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git

Re: [ovs-dev] [PATCH net-next v3 2/2] net: openvswitch: make masks cache size configurable

On 30 Jul 2020, at 15:25, Tonghao Zhang wrote: On Thu, Jul 30, 2020 at 8:33 PM Eelco Chaudron wrote: Thanks Tonghao for the review, see comments inline below! If I get no more reviews by the end of the week I’ll send out a v4. //Eelco On 30 Jul 2020, at 7:07, Tonghao Zhang wrote: On

Re: [ovs-dev] [PATCH net-next v3 2/2] net: openvswitch: make masks cache size configurable

On Thu, Jul 30, 2020 at 8:33 PM Eelco Chaudron wrote: > > Thanks Tonghao for the review, see comments inline below! > > If I get no more reviews by the end of the week I’ll send out a v4. > > //Eelco > > > On 30 Jul 2020, at 7:07, Tonghao Zhang wrote: > > > On Wed, Jul 29, 2020 at 9:27 PM Eelco

Re: [ovs-dev] [PATCH v3] odp-util: Fix clearing match mask if set action is partially unnecessary.

On 7/29/20 3:47 PM, Adrian Moreno wrote: > Verified that v3 also solves the issue reported. > > Tested-by: Adrián Moreno > > On 7/29/20 12:37 PM, Eli Britstein wrote: >> Thanks! >> >> Acked-by: Eli Britstein >> >> On 7/29/2020 12:13 PM, Ilya Maximets wrote: >>> While committing set() actions,

Re: [ovs-dev] [PATCH net-next v3 2/2] net: openvswitch: make masks cache size configurable

Thanks Tonghao for the review, see comments inline below! If I get no more reviews by the end of the week I’ll send out a v4. //Eelco On 30 Jul 2020, at 7:07, Tonghao Zhang wrote: On Wed, Jul 29, 2020 at 9:27 PM Eelco Chaudron wrote: This patch makes the masks cache size configurable, or

Re: [ovs-dev] [PATCH 1/1] netdev-offload-dpdk: Support vxlan encap offload with load actions

Bleep bloop. Greetings Eli Britstein, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

[ovs-dev] [PATCH 1/1] netdev-offload-dpdk: Support vxlan encap offload with load actions

From: Lei Wang Struct match has the tunnel values/masks in match->flow.tunnel/match->wc.masks.tunnel. Load actions such as load:0xa566c10->NXM_NX_TUN_IPV4_DST[], load:0xbba->NXM_NX_TUN_ID[] are utilizing the tunnel masks fields, but those should not be used for matching. Offloading fails if

[ovs-dev] [PATCH v4] ovsdb-tool: Add a db consistency check to the ovsdb-tool check-cluster command

There are some occurrences where the database ends up in an inconsistent state. This happened in ovn-k8s and is described in [0]. Here we are adding a supported way to check that a given db is consistent, which is less error prone than checking the logs. Tested against both a valid db and a

Re: [ovs-dev] [PATCH ovn v2] Avoid nb_cfg update notification flooding

On Wed, Jul 29, 2020 at 8:03 PM Han Zhou wrote: > > > > On Wed, Jul 29, 2020 at 2:46 AM Lucas Alvares Gomes > wrote: > > > > Hi Han, > > > > > > > > Just to follow up. I didn't find any new versions for this patch and it > > > doesn't seem to be merged. Did you send any new versions or do you

Re: [ovs-dev] [PATCH ovn] expr.c: Fix argument type of expr_write_scope().

On Wed, Jul 29, 2020 at 10:21 PM Numan Siddique wrote: > > > On Thu, Jul 30, 2020 at 9:58 AM Han Zhou wrote: > >> On Wed, Jul 29, 2020 at 9:03 PM Ankur Sharma >> wrote: >> > >> > Hi Han, >> > >> > Changes look fine. >> > >> > Acked-by: Ankur Sharma >> > >> > Regards, >> > Ankur >> >> Thanks

Re: [ovs-dev] [PATCH ovn 6/7] ovn-northd.c: Remove the use of the REGBIT_SKIP_LOOKUP_NEIGHBOR bit.

On Wed, Jul 29, 2020 at 10:37 AM Numan Siddique wrote: > > > > On Thu, Jul 23, 2020 at 10:57 AM Han Zhou wrote: >> >> In LR ingress stage LOOKUP_NEIGHBOR and LEARN_NEIGHBOR, the flag >> REGBIT_SKIP_LOOKUP_NEIGHBOR was used to indicate if mac-binding >> lookup can be skipped. This patch avoid

Re: [ovs-dev] [ovs-discuss] [OVN] DB backup and restore

On Wed, Jul 29, 2020 at 10:58 PM Tony Liu wrote: > > Hi, > > > > There is any guidance to backup and restore OVN nb-db and sb-db? > > > > Is /var/lib/openvswitch/ovn-[ns]b/ovn[ns]b.db the only database file? > > > > For 3-node DB cluster, is replication 3 (the data is replicated onto > > All 3