Re: [ovs-dev] [PATCH v2] connmgr: support changing openflow versions without restarting

2020-08-12 Thread Numan Siddique
On Thu, Aug 13, 2020 at 1:55 AM Flavio Leitner wrote: > > On Wed, Aug 12, 2020 at 04:07:55PM -0400, Aaron Conole wrote: > > When commit a0baa7dfa4fe ("connmgr: Make treatment of active and passive > > connections more uniform") was applied, it did not take into account > > that a reconfiguration o

Re: [ovs-dev] [PATCH v4 2/2 ovn] External IP based NAT: NORTHD changes to use applied/exempted external ip

2020-08-12 Thread svc . mail . git
Hi Numan, Sure, yes thats a valid concern. I will try to address this in V5. Regards, Ankur From: Numan Siddique Sent: Friday, August 7, 2020 2:37 AM To: svc.mail.git Cc: ovs-dev Subject: Re: [ovs-dev] [PATCH v4 2/2 ovn] External IP based NAT: NORTHD changes t

Re: [ovs-dev] [PATCH v1] ovn-controller: Fix the CT zone assignment logic for logical routers

2020-08-12 Thread Ankur Sharma
Hi Dumitru, Thanks a lot for looking at the change. It my mistake, LB use case totally slipped through my mind. Cross product based approach is not generic enough to address LB as well (and future use cases for CT ZONE). Please ignore this patch, i will submit a new one with a more generic appr

[ovs-dev] Programa Especial NOM

2020-08-12 Thread NOM 035 - Factores de Riesgo Psicosocial.
Programa Especial: Programa de implementación de la NOM-035 ¿Te gustaría asegurarte de que tu empresa cumpla cabalmente con lo dispuesto en la NOM-035 STPS? Las inspecciones se aproximan, para apoyarte en este reto, hemos desarrollado un programa que busca guiarte paso a paso en la correcta y

Re: [ovs-dev] [PATCH v2] connmgr: support changing openflow versions without restarting

2020-08-12 Thread 0-day Robot
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 109 characters long (recommended limit is 79) #49 FILE: ofproto/connmgr.c:607:

Re: [ovs-dev] [PATCH v2] connmgr: support changing openflow versions without restarting

2020-08-12 Thread Flavio Leitner
On Wed, Aug 12, 2020 at 04:07:55PM -0400, Aaron Conole wrote: > When commit a0baa7dfa4fe ("connmgr: Make treatment of active and passive > connections more uniform") was applied, it did not take into account > that a reconfiguration of the allowed_versions setting would require a > reload of the of

[ovs-dev] [PATCH v2] connmgr: support changing openflow versions without restarting

2020-08-12 Thread Aaron Conole
When commit a0baa7dfa4fe ("connmgr: Make treatment of active and passive connections more uniform") was applied, it did not take into account that a reconfiguration of the allowed_versions setting would require a reload of the ofservice object (only accomplished via a restart of OvS). For now, dur

Re: [ovs-dev] [PATCH 1/1] dpdk: Deprecate vhost-user dequeue zero-copy.

2020-08-12 Thread Flavio Leitner
On Wed, Aug 12, 2020 at 06:11:30PM +, Stokes, Ian wrote: > > On Thu, Aug 06, 2020 at 06:18:37PM +0100, Ian Stokes wrote: > > > Dequeue zero-copy is no longer supported for vhost-user client mode in > > > DPDK due to commit [1]. > > > > > > In addition to this, zero-copy mode has been proposed t

Re: [ovs-dev] [PATCH] Remove manpages.mk from git

2020-08-12 Thread Flavio Leitner
On Wed, Aug 05, 2020 at 01:38:47PM +0200, Timothy Redaelli wrote: > manpages.mk is generated at build-time using sodepends.py and so there is no > need to keep it in git. > > Signed-off-by: Timothy Redaelli > --- > .gitignore | 1 + > Makefile.am | 2 +- > manpages.mk | 266

Re: [ovs-dev] [PATCH] Revert "ovsdb-idl: Fix NULL deref reported by Coverity."

2020-08-12 Thread Ilya Maximets
On 8/11/20 9:08 PM, Han Zhou wrote: > > > On Tue, Aug 11, 2020 at 11:35 AM Ilya Maximets > wrote: >> >> On 8/11/20 8:15 AM, Han Zhou wrote: >> > This reverts commit 68bc6f88a3a36549fcd3b6248c25c5e2e6deb8f3. >> > The commit causes a regression in OVN scale test. ovn-nor

Re: [ovs-dev] [PATCH 1/1] dpdk: Deprecate vhost-user dequeue zero-copy.

2020-08-12 Thread Stokes, Ian
> On Thu, Aug 06, 2020 at 06:18:37PM +0100, Ian Stokes wrote: > > Dequeue zero-copy is no longer supported for vhost-user client mode in > > DPDK due to commit [1]. > > > > In addition to this, zero-copy mode has been proposed to be marked > > deprecated in [2] with removal in the next DPDK LTS rel

Re: [ovs-dev] [PATCH 1/1] dpdk: Deprecate vhost-user dequeue zero-copy.

2020-08-12 Thread Stokes, Ian
> On 8/6/20 7:18 PM, Ian Stokes wrote: > > Dequeue zero-copy is no longer supported for vhost-user client mode in > > DPDK due to commit [1]. > > > > In addition to this, zero-copy mode has been proposed to be marked > > deprecated in [2] with removal in the next DPDK LTS release. > > > > This comm

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: linear buffer check with zero-copy

2020-08-12 Thread Stokes, Ian
> On 8/12/20 6:16 PM, Stokes, Ian wrote: > >> From: Sivaprasad Tummala > >> > > > > Just a quick one here folks, I spotted this issue when testing the > > deprecation > notice patch for vhost zero copy. > > > > Siva had previously submitted an RFC patch to work around the issue in OVS > > as > i

Re: [ovs-dev] [PATCH 1/1] dpdk: Deprecate vhost-user dequeue zero-copy.

2020-08-12 Thread Flavio Leitner
On Thu, Aug 06, 2020 at 06:18:37PM +0100, Ian Stokes wrote: > Dequeue zero-copy is no longer supported for vhost-user client mode > in DPDK due to commit [1]. > > In addition to this, zero-copy mode has been proposed to be marked > deprecated in [2] with removal in the next DPDK LTS release. > >

Re: [ovs-dev] [PATCH 1/1] dpdk: Deprecate vhost-user dequeue zero-copy.

2020-08-12 Thread Ilya Maximets
On 8/6/20 7:18 PM, Ian Stokes wrote: > Dequeue zero-copy is no longer supported for vhost-user client mode > in DPDK due to commit [1]. > > In addition to this, zero-copy mode has been proposed to be marked > deprecated in [2] with removal in the next DPDK LTS release. > > This commit deprecates

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: linear buffer check with zero-copy

2020-08-12 Thread Ilya Maximets
On 8/12/20 6:16 PM, Stokes, Ian wrote: >> From: Sivaprasad Tummala >> > > Just a quick one here folks, I spotted this issue when testing the > deprecation notice patch for vhost zero copy. > > Siva had previously submitted an RFC patch to work around the issue in OVS as > it had not been decid

Re: [ovs-dev] [PATCH v2] acinclude: Fix build with kernels with prandom* moved to prandom.h.

2020-08-12 Thread Ilya Maximets
On 8/12/20 6:23 PM, Gregory Rose wrote: > > > On 8/12/2020 8:51 AM, Ilya Maximets wrote: >> Recent commit c0842fbc1b18 ("random32: move the pseudo-random 32-bit >> definitions to prandom.h") in upstream kernel moved the definition >> of prandom_* functions from random.h to prandom.h.  This change

Re: [ovs-dev] [PATCH] faq: Mention Linux kernel versions supported by 2.13.x.

2020-08-12 Thread Ilya Maximets
On 5/14/20 7:36 PM, Ben Pfaff wrote: > This is based on acinclude.m4 in branch-2.13, which rejects anything > newer than 5.0. > > Reported-by: Han Zhou > Signed-off-by: Ben Pfaff > --- > Documentation/faq/releases.rst | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/faq/r

Re: [ovs-dev] [PATCH] releases: Add missed kernel versions for 2.13.

2020-08-12 Thread Ilya Maximets
On 8/12/20 6:52 PM, Ilya Maximets wrote: > Signed-off-by: Ilya Maximets > --- > Documentation/faq/releases.rst | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst > index 9a7a6444c..9d5d2c3e1 100644 > --- a/Documentation/faq/re

[ovs-dev] [PATCH] releases: Add missed kernel versions for 2.13.

2020-08-12 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- Documentation/faq/releases.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index 9a7a6444c..9d5d2c3e1 100644 --- a/Documentation/faq/releases.rst +++ b/Documentation/faq/releases.rst @@ -70,6

Re: [ovs-dev] [PATCH v2] acinclude: Fix build with kernels with prandom* moved to prandom.h.

2020-08-12 Thread Gregory Rose
On 8/12/2020 8:51 AM, Ilya Maximets wrote: Recent commit c0842fbc1b18 ("random32: move the pseudo-random 32-bit definitions to prandom.h") in upstream kernel moved the definition of prandom_* functions from random.h to prandom.h. This change was also backported to stable kernels. Fixing our

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: linear buffer check with zero-copy

2020-08-12 Thread Stokes, Ian
> From: Sivaprasad Tummala > Just a quick one here folks, I spotted this issue when testing the deprecation notice patch for vhost zero copy. Siva had previously submitted an RFC patch to work around the issue in OVS as it had not been decided at the time whether it should be resolved at the

[ovs-dev] [PATCH 1/1] netdev-dpdk: linear buffer check with zero-copy

2020-08-12 Thread Ian Stokes
From: Sivaprasad Tummala As of DPDK 19.11, in order to use dequeue-zero-copy in DPDK Vhost library, the application has to disable the linear buffer option. Hence dequeue-zero-copy is not supported for vhost application that requires linear buffers. An alternative DPDK based approach to disable

[ovs-dev] [PATCH v2] acinclude: Fix build with kernels with prandom* moved to prandom.h.

2020-08-12 Thread Ilya Maximets
Recent commit c0842fbc1b18 ("random32: move the pseudo-random 32-bit definitions to prandom.h") in upstream kernel moved the definition of prandom_* functions from random.h to prandom.h. This change was also backported to stable kernels. Fixing our configure script to look for these functions in

Re: [ovs-dev] [PATCH] acinclude: Fix build with kernels with prandom* moved to prandom.h.

2020-08-12 Thread Gregory Rose
On 8/12/2020 8:39 AM, Ilya Maximets wrote: On 8/12/20 5:25 PM, Gregory Rose wrote: On 8/12/2020 2:26 AM, Ilya Maximets wrote: Recent commit c0842fbc1b18 ("random32: move the pseudo-random 32-bit definitions to prandom.h") in upstream kernel moved the definition of prandom_* functions from r

Re: [ovs-dev] [PATCH] acinclude: Fix build with kernels with prandom* moved to prandom.h.

2020-08-12 Thread Ilya Maximets
On 8/12/20 5:25 PM, Gregory Rose wrote: > > > On 8/12/2020 2:26 AM, Ilya Maximets wrote: >> Recent commit c0842fbc1b18 ("random32: move the pseudo-random 32-bit >> definitions to prandom.h") in upstream kernel moved the definition >> of prandom_* functions from random.h to prandom.h.  This change

Re: [ovs-dev] [PATCH] acinclude: Fix build with kernels with prandom* moved to prandom.h.

2020-08-12 Thread Gregory Rose
On 8/12/2020 2:26 AM, Ilya Maximets wrote: Recent commit c0842fbc1b18 ("random32: move the pseudo-random 32-bit definitions to prandom.h") in upstream kernel moved the definition of prandom_* functions from random.h to prandom.h. This change was also backported to stable kernels. Fixing our

[ovs-dev] [PATCH ovn] ovn-northd: Support mixing stateless/stateful ACLs with acl-stateful-bypass.

2020-08-12 Thread Dumitru Ceara
A new configuration option is added to Logical_Switch: other_config:acl-stateful-bypass. This optional value determines which traffic should completely bypass connection tracking when ACLs are processed. In specific scenarios CMSs can predetermine which traffic must be firewalled statefully or not

[ovs-dev] [RFC ovn 207/207] [WIP] optimize port groups and address sets

2020-08-12 Thread vkommadi
From: venkata anil ovn-controller recalculates flows for all the members of a PG or AS when a new member is added or deleted. Instead, this patch identifies the changed members and only process their related flows. Also this patch maintains constant sets for only local ports of a port group (ins

Re: [ovs-dev] [PATCH 1/1] releases: Add OVS 2.14 to DPDK mapping.

2020-08-12 Thread Stokes, Ian
> On Tue, Aug 11, 2020 at 06:21:44PM +0100, Ian Stokes wrote: > > Add an entry for OVS 2.14 to map to the validated DPDK release. > > > > Signed-off-by: Ian Stokes > > --- > > Acked-by: Flavio Leitner Thanks Flavio, Applied to master and 2.14. BR Ian _

[ovs-dev] [PATCH v2] net: openvswitch: introduce common code for flushing flows

2020-08-12 Thread xiangxia . m . yue
From: Tonghao Zhang To avoid some issues, for example RCU usage warning and double free, we should flush the flows under ovs_lock. This patch refactors table_instance_destroy and introduces table_instance_flow_flush which can be invoked by __dp_destroy or ovs_flow_tbl_flush. Fixes: 50b0e61b32ee

Re: [ovs-dev] [PATCH ovn] Fix an issue with may-exist flag for lr_nat_add

2020-08-12 Thread Dumitru Ceara
On 8/7/20 6:11 PM, Aniket Bhat wrote: > This commit fixes a case where may-exist flag was not honored. > When the nat type and logical ip both match for snat, but the > external_ip is not the same, the may-exist flag was being ignored. > > Signed-off-by: Aniket Bhat > --- Hi Aniket, Thanks for

[ovs-dev] To Your Notice

2020-08-12 Thread xpyzone
Dear sir, Please ship the order Thank you ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] acinclude: Fix build with kernels with prandom* moved to prandom.h.

2020-08-12 Thread Ilya Maximets
Recent commit c0842fbc1b18 ("random32: move the pseudo-random 32-bit definitions to prandom.h") in upstream kernel moved the definition of prandom_* functions from random.h to prandom.h. This change was also backported to stable kernels. Fixing our configure script to look for these functions in

Re: [ovs-dev] [PATCH] connmgr: support changing openflow versions without restarting

2020-08-12 Thread Aaron Conole
Flavio Leitner writes: > On Tue, Aug 11, 2020 at 03:58:44PM -0400, Aaron Conole wrote: >> Flavio Leitner writes: >> >> > Hi Aaron, >> > >> > Thanks for the patch, see my comments below. >> > >> > On Fri, Aug 07, 2020 at 05:32:03PM -0400, Aaron Conole wrote: >> >> When commit a0baa7dfa4fe ("conn