Re: [ovs-dev] [PATCH] ovn-controller: Add unix reconnect command

2020-08-26 Thread Zhen Wang (SW-CLOUD)
Hi Han, Thanks for reviewing my code. Please my reply inline. From: Han Zhou Date: Wednesday, August 26, 2020 at 4:55 PM To: "Zhen Wang (SW-CLOUD)" Cc: ovs-dev , Han Zhou Subject: Re: [PATCH] ovn-controller: Add unix reconnect command External email: Use caution opening links or attachments

Re: [ovs-dev] [PATCH] ovsdb-idl: Add function to set next_remote in jsonrpc session.

2020-08-26 Thread Han Zhou
On Thu, Aug 13, 2020 at 1:51 PM Zhen Wang wrote: > > OVN SouthBound DB in clustered mode, when one raft node down and > online. All the ovn-controller clients will not migirate back which > cause RAFT DB clients unbalanced state. > > This function provides a way to set the IDL jsonrpc session

Re: [ovs-dev] [PATCH] ovn-controller: Add unix reconnect command

2020-08-26 Thread Han Zhou
On Thu, Aug 13, 2020 at 1:56 PM Zhen Wang wrote: > > OVN SB in clustered mode, all the ovn-controller clients connect > across all the nodes in a balanced state. When one raft node down and > online. All the ovn-controller clients will not migirate back which > cause RAFT DB clients unbalanced

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Support mixing stateless/stateful ACLs with Stateless_Filter.

2020-08-26 Thread Han Zhou
Hi Dumitru, Please see my comments below. Thanks, Han On Thu, Aug 20, 2020 at 4:19 AM Dumitru Ceara wrote: > > A new table is added to OVN_Northbound: Stateless_Filter. Users can > populate this table with records consisting of . These > records generate logical flows in the PRE_ACL stages of

[ovs-dev] Checking status of [PATCH v7] Bareudp Tunnel Support

2020-08-26 Thread Varghese, Martin (Nokia - IN/Bangalore)
Hi Ben & Ilya, Sorry to bother you. I had sent the 7th version of bareudp patch to d...@openvswitch.org a while ago. I didn't see any progress after that. Is there anything missing from my side. Please let me know. Regards, Martin

Re: [ovs-dev] [PATCH] meta-flow: fix a typo in "MPLS Bottom of Stack Field" paragraph

2020-08-26 Thread Ilya Maximets
On 8/6/20 9:32 PM, Gregory Rose wrote: > > > On 8/6/2020 9:33 AM, Timothy Redaelli wrote: >> In the ovs-fields.7 manual page, the "MPLS Bottom of Stack Field" paragraph >> says: >>   * When mpls_bos is 1, there is another MPLS label following this one, >>     so the Ethertype passed to pop_mpls

Re: [ovs-dev] [PATCH v2] ovs-dpctl-top: Skip "eth()" element

2020-08-26 Thread Ilya Maximets
On 8/7/20 4:38 PM, Flavio Leitner wrote: > On Fri, Jun 19, 2020 at 03:53:52PM +0200, Timothy Redaelli wrote: >> With commit efde188622ae ("odp-util: Print eth() for Ethernet flows if >> packet_type is absent.") "eth()" is printed for Ethernet flows if packet_type >> is absent, but this broke

Re: [ovs-dev] [PATCH] travis: Merge matrix entries.

2020-08-26 Thread Ilya Maximets
On 8/26/20 7:45 PM, Aaron Conole wrote: > Ilya Maximets writes: > >> It's not possible to use 'matrix' twice. This makes travis to use >> the latest one dropping all the osx and arm64 jobs. >> >> Fixes: 00d3374d8d54 ("travis: Test build of debian packages.") >> Signed-off-by: Ilya Maximets >>

Re: [ovs-dev] [PATCH] test-conntrack: Fix conntrack benchmark by clearing conntrack metadata.

2020-08-26 Thread Ilya Maximets
On 8/25/20 5:07 PM, Aaron Conole wrote: > Ilya Maximets writes: > >> Packets in the benchmark must be treated as new packets, i.e. they >> should not have conntrack metadata set. Current code will set up >> 'pkt->md.conn' after the first run and all subsequent calls will hit >> the 'fast'

Re: [ovs-dev] [PATCH] python: Fixup python shebangs to python3

2020-08-26 Thread Ilya Maximets
On 8/25/20 4:53 PM, Aaron Conole wrote: > Greg Rose writes: > >> Builds on RHEL 8.2 systems are failing due to this issue. >> >> See [1] as to why this is necessary. >> >> I used the following command to identify files that need this fix: >> find . -type f -executable |

Re: [ovs-dev] [PATCH ovn] Fix some words spell error

2020-08-26 Thread Han Zhou
On Wed, Aug 26, 2020 at 1:40 AM Yi Li wrote: > > Signed-off-by: Yi Li > --- > AUTHORS.rst| 1 + > northd/ovn-northd.c| 2 +- > ovn-architecture.7.xml | 8 > ovn-nb.xml | 2 +- > 4 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/AUTHORS.rst

Re: [ovs-dev] [PATCH net-next v3 3/3] net: openvswitch: remove unnused keep_flows

2020-08-26 Thread Pravin Shelar
On Mon, Aug 24, 2020 at 10:08 PM wrote: > > From: Tonghao Zhang > > keep_flows was introduced by [1], which used as flag to delete flows or not. > When rehashing or expanding the table instance, we will not flush the flows. > Now don't use it anymore, remove it. > > [1] - >

Re: [ovs-dev] [PATCH net-next v3 2/3] net: openvswitch: refactor flow free function

2020-08-26 Thread Pravin Shelar
On Mon, Aug 24, 2020 at 10:08 PM wrote: > > From: Tonghao Zhang > > Decrease table->count and ufid_count unconditionally, > because we only don't use count or ufid_count to count > when flushing the flows. To simplify the codes, we > remove the "count" argument of table_instance_flow_free. > >

Re: [ovs-dev] [PATCH net-next v2 1/3] net: openvswitch: improve coding style

2020-08-26 Thread Pravin Shelar
On Mon, Aug 24, 2020 at 12:37 AM wrote: > > From: Tonghao Zhang > > Not change the logic, just improve coding style. > > Cc: Pravin B Shelar > Signed-off-by: Tonghao Zhang Acked-by: Pravin B Shelar ___ dev mailing list d...@openvswitch.org

[ovs-dev] Dev, Limited Edition - Vote Biden Harris 2020 Election T-Shirt Collection!

2020-08-26 Thread sieunhan618n
Vote Biden Harris 2020 Election T-Shirt Presidential Election 2020 gift Ideas for Men Women and Youths. Vice President Joe Biden and Kamala Harris are the perfect candidates to stand against Donald Trump and the Republican policies. Wear this to a political rally, campaigning and on

Re: [ovs-dev] [PATCH] travis: Merge matrix entries.

2020-08-26 Thread Aaron Conole
Ilya Maximets writes: > It's not possible to use 'matrix' twice. This makes travis to use > the latest one dropping all the osx and arm64 jobs. > > Fixes: 00d3374d8d54 ("travis: Test build of debian packages.") > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole

[ovs-dev] [PATCH v4 ovn] Add VXLAN support for non-VTEP datapath bindings

2020-08-26 Thread Ihar Hrachyshka
Because of limited space in VXLAN VNI to pass over all three of - datapath id, ingress port, egress port - the implementation ignores ingress; and splits the remaining 24 bits of VNI into two chunks, 12 bits each - one for datapath and one for egress port. Limitations: because ingress port is not

[ovs-dev] [PATCH] travis: Merge matrix entries.

2020-08-26 Thread Ilya Maximets
It's not possible to use 'matrix' twice. This makes travis to use the latest one dropping all the osx and arm64 jobs. Fixes: 00d3374d8d54 ("travis: Test build of debian packages.") Signed-off-by: Ilya Maximets --- .travis.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.travis.yml

Re: [ovs-dev] [PATCH v2] dpif-netdev: add parameters to configure autolb

2020-08-26 Thread Kevin Traynor
Hi Christophe, Thanks for sending the patch. Few comments below. On 13/08/2020 10:07, cfont...@redhat.com wrote: > From: Christophe Fontaine > > ALB_ACCEPTABLE_IMPROVEMENT and ALB_PMD_LOAD_THRESHOLD default values > can be overriden with "pmd-auto-lb-acc-improvement" and >

Re: [ovs-dev] Checking status of [PATCH v7] Bareudp Tunnel Support

2020-08-26 Thread Varghese, Martin (Nokia - IN/Bangalore)
Hi Ilya, No Problem. Thanks Regards, Martin -Original Message- From: Ilya Maximets Sent: Wednesday, August 26, 2020 8:34 PM To: Varghese, Martin (Nokia - IN/Bangalore) ; Ben Pfaff ; Ilya Maximets Cc: d...@openvswitch.org; Greg Rose Subject: Re: Checking status of [PATCH v7] Bareudp

Re: [ovs-dev] [PATCH v2] travis: Test build of debian packages.

2020-08-26 Thread Ilya Maximets
On 8/21/20 2:51 PM, Aaron Conole wrote: > Ilya Maximets writes: > >> We had a lot of issues with debian packaging lately. This job will >> check build and installation of debian packages to avoid most of such >> issues in the future. >> >> Installing only minimal set of tools, most of

Re: [ovs-dev] Checking status of [PATCH v7] Bareudp Tunnel Support

2020-08-26 Thread Ilya Maximets
On 8/26/20 2:44 PM, Varghese, Martin (Nokia - IN/Bangalore) wrote: > Hi  Ben & Ilya, > > Sorry to bother you. > > I had sent the 7^th version of bareudp patch to d...@openvswitch.org > a while ago. > I didn’t see any progress after that. Is there anything missing

Re: [ovs-dev] [PATCH branch-2.13 0/3] Backport debian fixes to branch-2.13

2020-08-26 Thread Ilya Maximets
On 8/25/20 5:55 PM, Aaron Conole wrote: > Reported at: https://github.com/openvswitch/ovs-issues/issues/194 > > Ansis Atteka (2): > debian: Add python3-sphinx to ovs build dependencies > debian: Fix broken build after some man pages became generated from > RST > > Roi Dayan (1): >

Re: [ovs-dev] [PATCH] Fix ovn-controller crash when a lport of type 'virtual' is deleted.

2020-08-26 Thread Numan Siddique
On Wed, Aug 26, 2020 at 6:28 PM Mark Michelson wrote: > Acked-by: Mark Michelson > > Is this bug severe enough that a 20.06.3 release is necessary? > Thanks Mark. I applied this patch to master and branch-20.06. I think this is definitely a severe bug. The issue is seen when virtual ports are

[ovs-dev] From Joyce Davis

2020-08-26 Thread SFC Joyce Davis
-- Hello dear, I am very sorry to intrude your privacy with my message,but if you don't mind, i will like to inform you, that i am in need of your assistance for the relocation of $USD2.5 Million Dollars currently in my custody. I am Sergeant First Class Joyce Davis, a US army currently

Re: [ovs-dev] [PATCH] Fix ovn-controller crash when a lport of type 'virtual' is deleted.

2020-08-26 Thread Mark Michelson
Acked-by: Mark Michelson Is this bug severe enough that a 20.06.3 release is necessary? On 8/26/20 7:41 AM, num...@ovn.org wrote: From: Numan Siddique The below bt is seen when a lport of type 'virtual' is deleted. (gdb) bt 0x1470c0708655 in __strlen_avx2 () from /lib64/libc.so.6

[ovs-dev] Reply if you are interested.

2020-08-26 Thread info
Dearest Beloved, I am Fabio Antonio, A Portuguese national, I was browsing and I saw your e-mail, So i decided to write you if your e-mail is real, I have been diagnosed with esophageal cancer. It has defiled all forms of medical treatment , and right now I have only about a few months to

Re: [ovs-dev] [PATCH] checkpatch: Ignore macro definitions of FOR_EACH

2020-08-26 Thread Ilya Maximets
On 8/25/20 5:42 PM, Aaron Conole wrote: > Aaron Conole writes: > >> When defining a FOR_EACH macro, checkpatch freaks out and generates a >> control block whitespace error. Create an exception so that it doesn't >> generate errors for this case. >> >> Reported-at: >>

Re: [ovs-dev] [PATCH] Fix ovn-controller crash when a lport of type 'virtual' is deleted.

2020-08-26 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (controller/binding.c). error: could not build

[ovs-dev] [PATCH] Fix ovn-controller crash when a lport of type 'virtual' is deleted.

2020-08-26 Thread numans
From: Numan Siddique The below bt is seen when a lport of type 'virtual' is deleted. (gdb) bt 0x1470c0708655 in __strlen_avx2 () from /lib64/libc.so.6 0x563340037449 in hash_string (basis=0, s=s@entry=0x0) at lib/hash.h:342 hash_name (name=name@entry=0x0) at lib/shash.c:28

[ovs-dev] My sincere apology for invading into your privacy for this proposal

2020-08-26 Thread Sr Agueda Aloisio
My sincere apology for invading into your privacy for this proposal My Name is Sr Agueda Aloisio I am from Portugal I have been diagnosed with cancer. It has defiled all forms of medical treatment, and right now I have only about a few months to live, according to medical experts. I have

[ovs-dev] [PATCH ovn] Introduce DHCPDECLINE msg support to OVN DHCP server

2020-08-26 Thread Lorenzo Bianconi
According to the RFC2131 (https://tools.ietf.org/html/rfc2131), if the server server receives a DHCPDECLINE message, the client has discovered through some other means that the suggested network address is already in use. The server SHOULD notify the local system administrator of a possible

[ovs-dev] [PATCH ovn] Fix some words spell error

2020-08-26 Thread Yi Li
Signed-off-by: Yi Li --- AUTHORS.rst| 1 + northd/ovn-northd.c| 2 +- ovn-architecture.7.xml | 8 ovn-nb.xml | 2 +- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/AUTHORS.rst b/AUTHORS.rst index 2a642be2..a0ca9bb2 100644 --- a/AUTHORS.rst +++

Re: [ovs-dev] [PATCH net-next v3 0/3] net: openvswitch: improve codes

2020-08-26 Thread Pravin Shelar
On Tue, Aug 25, 2020 at 9:37 AM David Miller wrote: > > From: xiangxia.m@gmail.com > Date: Tue, 25 Aug 2020 13:06:33 +0800 > > > From: Tonghao Zhang > > > > This series patches are not bug fix, just improve codes. > > Pravin, please review this patch series. > Sorry for delay. I will have a