Re: [ovs-dev] OVN 20.09 Soft freeze

2020-09-14 Thread Ihar Hrachyshka
Hi Mark and all, Sorry for this late reply, I have my head in the wrong place lately. I would like these two bits considered for freeze inclusion: 1. VXLAN support: https://patchwork.ozlabs.org/project/openvswitch/patch/20200826171253.1010528-1-ihrac...@redhat.com/ 2. Multibridge / colocated cha

Re: [ovs-dev] [PATCH v4 ovn] Allow to run multiple controllers on the same machine

2020-09-14 Thread 0-day Robot
Bleep bloop. Greetings Ihar Hrachyshka, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch' to see the failed

Re: [ovs-dev] [PATCH v3 ovn] Allow to run multiple controllers on the same machine

2020-09-14 Thread Ihar Hrachyshka
Resubmitted rebased and with all comments (hopefully) addressed. See v5. Thanks, Ihar On Tue, Sep 8, 2020 at 7:52 AM Numan Siddique wrote: > > On Wed, Sep 2, 2020 at 6:54 AM Ihar Hrachyshka wrote: > > > > User stories: > > 1) NFV: an admin wants to run two separate instances of OVN controller >

[ovs-dev] [PATCH v5 ovn] Allow to run multiple controllers on the same machine

2020-09-14 Thread Ihar Hrachyshka
User stories: 1) NFV: an admin wants to run two separate instances of OVN controller using the same database but configuring ports on different bridges. Some of these bridges may use DPDK while others may not. 2) Parallel OVN instances: an admin wants to run two separate instances of OVN

[ovs-dev] [PATCH v4 ovn] Allow to run multiple controllers on the same machine

2020-09-14 Thread Ihar Hrachyshka
User stories: 1) NFV: an admin wants to run two separate instances of OVN controller using the same database but configuring ports on different bridges. Some of these bridges may use DPDK while others may not. 2) Parallel OVN instances: an admin wants to run two separate instances of OVN

Re: [ovs-dev] [PATCH ovn v2 0/9] Incremental processing for flow installation.

2020-09-14 Thread Han Zhou
On Mon, Sep 14, 2020 at 9:54 AM Ilya Maximets wrote: > > On 9/14/20 6:45 PM, Dumitru Ceara wrote: > > On 9/14/20 6:36 PM, Han Zhou wrote: > >> > >> > >> On Mon, Sep 14, 2020 at 6:04 AM Dumitru Ceara >> > wrote: > >>> > >>> On 9/11/20 9:16 PM, Dumitru Ceara wrote: >

[ovs-dev] [PATCH ovn] build: Fix broken check-lcov target.

2020-09-14 Thread Dumitru Ceara
Without this, the following fails: $ make check-lcov [...] Cannot open source file lib/dirs.c.in [...] make: *** [check-lcov] Error 2 CC: Ilya Maximets Signed-off-by: Dumitru Ceara --- lib/ovn-dirs.c.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ovn-dirs.c.in b/lib

Re: [ovs-dev] Status of upstreaming of "add transport ports in route lookup for geneve" patch into kernel

2020-09-14 Thread Gregory Rose
On 9/14/2020 2:01 PM, Mark Gray wrote: Hi, This patch does not seem to be in the in-kernel tree and I am unable to get IPsec with Geneve working without it. I ported it to the in-tree kernel module and it seems to work. I still need to rebase and test on net-next. Greg, I will add your review

Re: [ovs-dev] Status of upstreaming of "add transport ports in route lookup for geneve" patch into kernel

2020-09-14 Thread Mark Gray
Hi, This patch does not seem to be in the in-kernel tree and I am unable to get IPsec with Geneve working without it. I ported it to the in-tree kernel module and it seems to work. I still need to rebase and test on net-next. Greg, I will add your reviewed-by and Qiuyu's signed-off-by. Mark On

Re: [ovs-dev] [PATCH 2/2] datapath: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode

2020-09-14 Thread Gregory Rose
On 9/14/2020 10:24 AM, Ilya Maximets wrote: On 9/11/20 5:37 PM, Gregory Rose wrote: On 10/14/2019 9:51 PM, wenxu wrote: On 10/15/2019 5:14 AM, Gregory Rose wrote: On 10/8/2019 4:51 PM, Greg Rose wrote: From: wenxu Upstream commit:   commit 18b6f717483a835fb98de9f0df6c724df9324e78

Re: [ovs-dev] [PATCH ovn v2] chassis.c: Fix the possible NULL pointer deference in chassis_cleanup().

2020-09-14 Thread Numan Siddique
On Sat, Sep 12, 2020 at 11:19 AM Han Zhou wrote: > If chassis_rec is NULL but chassis_private_rec is not, chassis_rec->name > is a NULL pointer deference. This patch fixes it. > > Fixes: 4adc10f581 ("Avoid nb_cfg update notification flooding") > Signed-off-by: Han Zhou > Acked-by: Numan Siddiqu

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Handle changes in requested-tnl-key

2020-09-14 Thread Numan Siddique
On Mon, Sep 14, 2020 at 10:18 PM Dumitru Ceara wrote: > On 9/12/20 9:10 AM, Mark Gray wrote: > > runtime_data_sb_datapath_binding_handler() only handles deletion of rows > > in the Datapath_Binding table in OVN-SB. The user can update the > > requested-tnl-key by the following command: > > > > ov

[ovs-dev] Congratulation, Your Compensation ATM visa card is ready now, Contact our Bank Manager with Whatsapp(+1(347)518-7318) Inbox

2020-09-14 Thread SANTANDER CONSUMER BANK USA via dev
Consumer USA Corporate Headquarters Address: 1601 Elm St, Dallas, TX 75201, United States Tel: +1(347)518-7318 Attention:ATM Visa card owner/Beneficiary. This message is from the Santander Consumer Bank United State of America 1601 Elm St, Dallas, TX 75201, United States, We believed that

Re: [ovs-dev] [PATCH ovn v3] ovn-northd: Fix multiple ARP replies for SNAT entries configured on a distributed router.

2020-09-14 Thread Numan Siddique
On Mon, Sep 14, 2020 at 10:26 PM Dumitru Ceara wrote: > On 9/14/20 5:46 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > The commit in the Fixes tag, while addressing the issue to send ARP > replies for > > the SNAT entries, didn't take into account the gateway router port > scenario.

Re: [ovs-dev] [PATCH v2] ovs-dpctl-top: Open stdin in binary mode

2020-09-14 Thread Ilya Maximets
On 8/7/20 4:17 PM, Flavio Leitner wrote: > On Fri, Jun 19, 2020 at 03:53:51PM +0200, Timothy Redaelli wrote: >> On Python3 buffering can only be disabled on files opened in binary mode. >> >> Signed-off-by: Timothy Redaelli >> --- >> v2: >> - Added missing Signed-off-by >> >> utilities/ovs-dpctl-

Re: [ovs-dev] [PATCH 2/2] datapath: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode

2020-09-14 Thread Ilya Maximets
On 9/11/20 5:37 PM, Gregory Rose wrote: > > On 10/14/2019 9:51 PM, wenxu wrote: >> >> On 10/15/2019 5:14 AM, Gregory Rose wrote: >>> >>> >>> On 10/8/2019 4:51 PM, Greg Rose wrote: From: wenxu Upstream commit:   commit 18b6f717483a835fb98de9f0df6c724df9324e78   Aut

Re: [ovs-dev] [PATCH ovn v3] ovn-northd: Fix multiple ARP replies for SNAT entries configured on a distributed router.

2020-09-14 Thread Dumitru Ceara
On 9/14/20 5:46 PM, num...@ovn.org wrote: > From: Numan Siddique > > The commit in the Fixes tag, while addressing the issue to send ARP replies > for > the SNAT entries, didn't take into account the gateway router port scenario. > Because of this, all the chassis which have bridge mappings conf

Re: [ovs-dev] [PATCH ovn v2 0/9] Incremental processing for flow installation.

2020-09-14 Thread Ilya Maximets
On 9/14/20 6:45 PM, Dumitru Ceara wrote: > On 9/14/20 6:36 PM, Han Zhou wrote: >> >> >> On Mon, Sep 14, 2020 at 6:04 AM Dumitru Ceara > > wrote: >>> >>> On 9/11/20 9:16 PM, Dumitru Ceara wrote: On 9/11/20 8:39 PM, Han Zhou wrote: > > > On Fri, Sep 11, 2020

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Handle changes in requested-tnl-key

2020-09-14 Thread Dumitru Ceara
On 9/12/20 9:10 AM, Mark Gray wrote: > runtime_data_sb_datapath_binding_handler() only handles deletion of rows > in the Datapath_Binding table in OVN-SB. The user can update the > requested-tnl-key by the following command: > > ovn-nbctl set logical_switch sw0 other_config:requested-tnl-key= > >

Re: [ovs-dev] [PATCH ovn v2 0/9] Incremental processing for flow installation.

2020-09-14 Thread Dumitru Ceara
On 9/14/20 6:36 PM, Han Zhou wrote: > > > On Mon, Sep 14, 2020 at 6:04 AM Dumitru Ceara > wrote: >> >> On 9/11/20 9:16 PM, Dumitru Ceara wrote: >> > On 9/11/20 8:39 PM, Han Zhou wrote: >> >> >> >> >> >> On Fri, Sep 11, 2020 at 6:17 AM Dumitru Ceara

Re: [ovs-dev] [PATCH ovn v2 0/9] Incremental processing for flow installation.

2020-09-14 Thread Han Zhou
On Mon, Sep 14, 2020 at 6:04 AM Dumitru Ceara wrote: > > On 9/11/20 9:16 PM, Dumitru Ceara wrote: > > On 9/11/20 8:39 PM, Han Zhou wrote: > >> > >> > >> On Fri, Sep 11, 2020 at 6:17 AM Dumitru Ceara >> > wrote: > >>> > >>> On 9/9/20 11:13 PM, Han Zhou wrote: > On We

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Fix multiple ARP replies for SNAT entries configured on a distributed router.

2020-09-14 Thread Numan Siddique
On Mon, Sep 14, 2020 at 8:58 PM Numan Siddique wrote: > > > On Mon, Sep 14, 2020 at 8:47 PM Dumitru Ceara wrote: > >> On 9/14/20 12:24 PM, num...@ovn.org wrote: >> > From: Numan Siddique >> > >> > The commit in the Fixes tag, while addressing the issue to send ARP >> replies for >> > the SNAT e

[ovs-dev] [PATCH ovn v3] ovn-northd: Fix multiple ARP replies for SNAT entries configured on a distributed router.

2020-09-14 Thread numans
From: Numan Siddique The commit in the Fixes tag, while addressing the issue to send ARP replies for the SNAT entries, didn't take into account the gateway router port scenario. Because of this, all the chassis which have bridge mappings configured reply to ARP request for SNAT entries. This patc

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Fix multiple ARP replies for SNAT entries configured on a distributed router.

2020-09-14 Thread Numan Siddique
On Mon, Sep 14, 2020 at 8:47 PM Dumitru Ceara wrote: > On 9/14/20 12:24 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > The commit in the Fixes tag, while addressing the issue to send ARP > replies for > > the SNAT entries, didn't take into account the gateway router port > scenario.

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Fix multiple ARP replies for SNAT entries configured on a distributed router.

2020-09-14 Thread Dumitru Ceara
On 9/14/20 12:24 PM, num...@ovn.org wrote: > From: Numan Siddique > > The commit in the Fixes tag, while addressing the issue to send ARP replies > for > the SNAT entries, didn't take into account the gateway router port scenario. > Because of this, all the chassis which have bridge mappings con

[ovs-dev] From Department Of Treasury Direct-Account

2020-09-14 Thread Department Of Treasury
UNITED STATES DEPARTMENT OF THE TREASURY. TREASURY BUILDING 1500 PENNSYLVANIA AVENUE, NW WASHINGTON, D.C., U.S Attention: Sir/Madam, After our board meeting United State Government including European Parliament, Asian and Arab League they already gave us instruction to release your Compensatio

Re: [ovs-dev] [PATCH v2 8/8] netdev-offload-tc: Add offload support for sFlow

2020-09-14 Thread 0-day Robot
Bleep bloop. Greetings Chris Mi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Remove Gerrit Change-Id's before submitting upstream. 9: Change-Id: I71ef18c70c86f030cae91594

Re: [ovs-dev] [PATCH ovn v2 0/9] Incremental processing for flow installation.

2020-09-14 Thread Dumitru Ceara
On 9/11/20 9:16 PM, Dumitru Ceara wrote: > On 9/11/20 8:39 PM, Han Zhou wrote: >> >> >> On Fri, Sep 11, 2020 at 6:17 AM Dumitru Ceara > > wrote: >>> >>> On 9/9/20 11:13 PM, Han Zhou wrote: On Wed, Sep 9, 2020 at 6:39 AM Mark Michelson > > w

Re: [ovs-dev] DONATION

2020-09-14 Thread schiller
A donation of $1,500,000(Million) has been made to you from Manuel Franco,winner of $768 million Powerball jackpot 2019, please contact via email: for more details.Thanks. -- This email has been checked for viruses by AVG. https://www.avg.com ___ dev

Re: [ovs-dev] [PATCH 1/3] dpif-netlink: Generate ufids for installing TC flowers

2020-09-14 Thread Eelco Chaudron
On 14 Sep 2020, at 7:54, Tonghao Zhang wrote: On Fri, Sep 11, 2020 at 5:46 PM Eelco Chaudron wrote: Hi Tonghao, at al. This patch is breaking basic flow adding/deletion with ovs-dpctl. I did not look at the root cause yet, maybe you can take a peek. This is present since 13.0, so the pot

[ovs-dev] [PATCH v2 4/8] dpif: Introduce psample offload API

2020-09-14 Thread Chris Mi
Introduce offload API to receive sampled packet from psample netlink socket. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/dpif-netdev.c | 3 +++ lib/dpif-netlink.c | 3 +++ lib/dpif-provider.h | 11 +++ lib/dpif.c | 24 lib/dpif.h

[ovs-dev] [PATCH v2 8/8] netdev-offload-tc: Add offload support for sFlow

2020-09-14 Thread Chris Mi
Create a unique group ID to map the sFlow info when offloading sFlow action to TC. When showing the offloaded datapath flows, translate the group ID from TC sample action to sFlow info using the mapping. Change-Id: I71ef18c70c86f030cae9159485e5ae11bc608301 Signed-off-by: Chris Mi Reviewed-by: Eli

[ovs-dev] [PATCH v2 7/8] netdev-offload-tc: Introduce group ID management API

2020-09-14 Thread Chris Mi
When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to kernel instead of the sFlow info. psample will send this ID and sampled packet to userspace. Using the ID, userspace can recover the sFlow info and send sampled packet to the

[ovs-dev] [PATCH v2 2/8] dpif-netlink: Create psample netlink socket

2020-09-14 Thread Chris Mi
Create psample netlink socket as a pre-step towards receiving sampled packets. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/dpif-netlink.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c in

[ovs-dev] [PATCH v2 0/8] Add offload support for sFlow

2020-09-14 Thread Chris Mi
This patch set adds offload support for sFlow. Psample is a genetlink channel for packet sampling. TC action act_sample uses psample to send sampled packets to userspace. When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to k

[ovs-dev] [PATCH v2 6/8] ofproto: Add psample receive handler

2020-09-14 Thread Chris Mi
Create a dedicated thread to poll psample netlink socket, receive sampled packet, parse it to sFlow format and send it to sFlow monitoring host. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- ofproto/ofproto-dpif-upcall.c | 78 +++ 1 file changed, 78 inse

[ovs-dev] [PATCH v2 1/8] ovs-kmod-ctl: Load kernel module psample

2020-09-14 Thread Chris Mi
Load kernel module psample to receive sampled packets from TC. Before removing kernel module psample, remove act_sample first. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- utilities/ovs-kmod-ctl.in | 9 + 1 file changed, 9 insertions(+) diff --git a/utilities/ovs-kmod-ctl.in

[ovs-dev] [PATCH v2 5/8] dpif-netlink: Implement psample offload API

2020-09-14 Thread Chris Mi
Implement offload API to receive sampled packet from psample netlink socket. Parse sampled packet to ovs format. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/dpif-netlink.c | 133 - 1 file changed, 130 insertions(+), 3 deletions(-) diff

[ovs-dev] [PATCH v2 3/8] netdev-offload: Introduce sFlow attributes query by group ID API

2020-09-14 Thread Chris Mi
OVS maintains a group ID to sFlow attribute mapping when offloading sFlow action to TC. Introduce sFlow attributes query by group ID API. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/netdev-offload-provider.h | 5 + lib/netdev-offload.c | 11 +++ lib/netdev-o

[ovs-dev] Spende von 2.000.000,00 Euro.

2020-09-14 Thread manuel franco
Sie haben eine Spende von 2.000.000,00 Euro. Mein Name ist Manuel Franco aus den USA. Ich habe die America-Lotterie im Wert von 768 Millionen US-Dollar gewonnen und spende einen Teil davon an nur 5 glückliche Menschen und einige Waisenhäuser als Wohlwollen für die Menschheit. __

Re: [ovs-dev] [PATCH 8/8] netdev-offload-tc: Add offload support for sFlow

2020-09-14 Thread 0-day Robot
Bleep bloop. Greetings Chris Mi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Improper whitespace around control block #52 FILE: lib/netdev-offload-tc.c:1682: NL_NESTE

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix multiple ARP replies for SNAT entries configured on a distributed router.

2020-09-14 Thread Numan Siddique
On Mon, Sep 14, 2020 at 3:47 PM Dumitru Ceara wrote: > On 9/14/20 12:11 PM, Numan Siddique wrote: > > > > > > On Mon, Sep 14, 2020 at 3:17 PM Dumitru Ceara > > wrote: > > > > On 9/14/20 11:20 AM, num...@ovn.org wrote: > > > From: Numan Si

[ovs-dev] [PATCH ovn v2] ovn-northd: Fix multiple ARP replies for SNAT entries configured on a distributed router.

2020-09-14 Thread numans
From: Numan Siddique The commit in the Fixes tag, while addressing the issue to send ARP replies for the SNAT entries, didn't take into account the gateway router port scenario. Because of this, all the chassis which have bridge mappings configured reply to ARP request for SNAT entries. This patc

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix multiple ARP replies for SNAT entries configured on a distributed router.

2020-09-14 Thread Dumitru Ceara
On 9/14/20 12:11 PM, Numan Siddique wrote: > > > On Mon, Sep 14, 2020 at 3:17 PM Dumitru Ceara > wrote: > > On 9/14/20 11:20 AM, num...@ovn.org wrote: > > From: Numan Siddique mailto:num...@ovn.org>> > > > > The commit in the Fix

[ovs-dev] [PATCH 5/8] dpif-netlink: Implement psample offload API

2020-09-14 Thread Chris Mi
Implement offload API to receive sampled packet from psample netlink socket. Parse sampled packet to ovs format. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/dpif-netlink.c | 133 - 1 file changed, 130 insertions(+), 3 deletions(-) diff

[ovs-dev] [PATCH 0/8] Add offload support for sFlow

2020-09-14 Thread Chris Mi
This patch set adds offload suport for sFlow. Psample is a genetlink channel for packet sampling. TC action act_sample uses psample to send sampled packets to userspace. When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to ke

[ovs-dev] [PATCH 4/8] dpif: Introduce psample offload API

2020-09-14 Thread Chris Mi
Introduce offload API to receive sampled packet from psample netlink socket. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/dpif-netdev.c | 3 +++ lib/dpif-netlink.c | 3 +++ lib/dpif-provider.h | 11 +++ lib/dpif.c | 24 lib/dpif.h

[ovs-dev] [PATCH 8/8] netdev-offload-tc: Add offload support for sFlow

2020-09-14 Thread Chris Mi
Create a unique group ID to map the sFlow info when offloading sFlow action to TC. When showing the offloaded datapath flows, translate the group ID from TC sample action to sFlow info using the mapping. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/netdev-offload-tc.c | 131 ++

[ovs-dev] [PATCH 1/8] ovs-kmod-ctl: Load kernel module psample

2020-09-14 Thread Chris Mi
Load kernel module psample to receive sampled packets from TC. Before removing kernel module psample, remove act_sample first. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- utilities/ovs-kmod-ctl.in | 9 + 1 file changed, 9 insertions(+) diff --git a/utilities/ovs-kmod-ctl.in

[ovs-dev] [PATCH 6/8] ofproto: Add psample receive handler

2020-09-14 Thread Chris Mi
Create a dedicated thread to poll psample netlink socket, receive sampled packet, parse it to sFlow format and send it to sFlow monitoring host. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- ofproto/ofproto-dpif-upcall.c | 78 +++ 1 file changed, 78 inse

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix multiple ARP replies for SNAT entries configured on a distributed router.

2020-09-14 Thread Numan Siddique
On Mon, Sep 14, 2020 at 3:17 PM Dumitru Ceara wrote: > On 9/14/20 11:20 AM, num...@ovn.org wrote: > > From: Numan Siddique > > > > The commit in the Fixes tag, while addressing the issue to send ARP > replies for > > the SNAT entries, didn't take into account the gateway router port > scenario.

[ovs-dev] [PATCH 3/8] netdev-offload: Introduce sFlow attributes query by group ID API

2020-09-14 Thread Chris Mi
OVS maintains a group ID to sFlow attribute mapping when offloading sFlow action to TC. Introduce sFlow attributes query by group ID API. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/netdev-offload-provider.h | 5 + lib/netdev-offload.c | 11 +++ lib/netdev-o

[ovs-dev] [PATCH 7/8] netdev-offload-tc: Introduce group ID management API

2020-09-14 Thread Chris Mi
When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to kernel instead of the sFlow info. psample will send this ID and sampled packet to userspace. Using the ID, userspace can recover the sFlow info and send sampled packet to the

[ovs-dev] [PATCH 2/8] dpif-netlink: Create psample netlink socket

2020-09-14 Thread Chris Mi
Create psample netlink socket as a pre-step towards receiving sampled packets. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/dpif-netlink.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c in

Re: [ovs-dev] [PATCH ovn 02/14] ovn-northd: move pre-acl and acl processing to a separate function

2020-09-14 Thread 0-day Robot
Bleep bloop. Greetings Anton Ivanov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (northd/ovn-northd.c). error: could not build fake an

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix multiple ARP replies for SNAT entries configured on a distributed router.

2020-09-14 Thread Dumitru Ceara
On 9/14/20 11:20 AM, num...@ovn.org wrote: > From: Numan Siddique > > The commit in the Fixes tag, while addressing the issue to send ARP replies > for > the SNAT entries, didn't take into account the gateway router port scenario. > Because of this, all the chassis which have bridge mappings con

[ovs-dev] [PATCH ovn 10/14] ovn-northd: move external port arp handling to a function

2020-09-14 Thread anton . ivanov
From: Anton Ivanov Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 39 +++ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index b1c12e9e4..8454dc8bc 100644 --- a/northd/ovn-northd.c +++ b/northd

[ovs-dev] [PATCH ovn 12/14] ovn-northd: move mcast flow learned from IGMP/MLD to a function

2020-09-14 Thread anton . ivanov
From: Anton Ivanov Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 144 1 file changed, 79 insertions(+), 65 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 48ca45742..2c6b167fb 100644 --- a/northd/ovn-northd.c +++ b/

[ovs-dev] [PATCH ovn 14/14] ovn-northd: convert output port security to iterators

2020-09-14 Thread anton . ivanov
From: Anton Ivanov 1. Convert output port security to iterators 2. Switch to reusing the match and action scrathcpads from build_lswitch_flows Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 92 +++-- 1 file changed, 48 insertions(+), 44 deletions(

[ovs-dev] [PATCH ovn 11/14] ovn-northd: move destination lookup b/mcast handling to a function

2020-09-14 Thread anton . ivanov
From: Anton Ivanov Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 169 1 file changed, 91 insertions(+), 78 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 8454dc8bc..48ca45742 100644 --- a/northd/ovn-northd.c +++ b/

[ovs-dev] [PATCH ovn 13/14] ovn-northd: move destination lookup and unicast to a function

2020-09-14 Thread anton . ivanov
From: Anton Ivanov Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 289 +++- 1 file changed, 152 insertions(+), 137 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 2c6b167fb..0f890dbcc 100644 --- a/northd/ovn-northd.c +++

[ovs-dev] [PATCH ovn] ovn-northd: Fix multiple ARP replies for SNAT entries configured on a distributed router.

2020-09-14 Thread numans
From: Numan Siddique The commit in the Fixes tag, while addressing the issue to send ARP replies for the SNAT entries, didn't take into account the gateway router port scenario. Because of this, all the chassis which have bridge mappings configured reply to ARP request for SNAT entries. This patc

[ovs-dev] [PATCH ovn 07/14] ovn-northd: move out DHCP response into a function

2020-09-14 Thread anton . ivanov
From: Anton Ivanov Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 101 1 file changed, 55 insertions(+), 46 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 352f135f8..f0769142e 100644 --- a/northd/ovn-northd.c +++ b/

[ovs-dev] [PATCH ovn 04/14] ovn-northd: move admission control to a separate function

2020-09-14 Thread anton . ivanov
From: Anton Ivanov Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 43 +++ 1 file changed, 27 insertions(+), 16 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index de1245489..06699b332 100644 --- a/northd/ovn-northd.c +++ b/no

[ovs-dev] [PATCH ovn 08/14] ovn-northd: move lswitch dns lookup/response into a function

2020-09-14 Thread anton . ivanov
From: Anton Ivanov Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 51 ++--- 1 file changed, 29 insertions(+), 22 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index f0769142e..a4955eed0 100644 --- a/northd/ovn-northd.c +++ b/

[ovs-dev] [PATCH ovn 03/14] ovn-northd: move logical flows for forwardig groups to a function

2020-09-14 Thread anton . ivanov
From: Anton Ivanov Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 94b9e2906..de1245489 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -660

[ovs-dev] [PATCH ovn 06/14] ovn-northd: move arp/nd responder to functions

2020-09-14 Thread anton . ivanov
From: Anton Ivanov 1. move arp/nd responder for unkown ips to a function 2. move arp/nd responder for known ips to a function 3. move default to a function Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 489 1 file changed, 269 insertions(+),

[ovs-dev] [PATCH ovn 05/14] ovn-northd: replace build_lswitch_input_port_sec with iterators

2020-09-14 Thread anton . ivanov
From: Anton Ivanov Replace build_lswitch_input_port_sec with two separate op and od iterators. Reuse the match and actions allocated in build_lswitch_flows to avoid extra allocs and frees. Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 58 ++--- 1

[ovs-dev] [PATCH ovn 01/14] ovn-northd: add marker for ovn-northd changes

2020-09-14 Thread anton . ivanov
From: Anton Ivanov Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 5 + 1 file changed, 5 insertions(+) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index b95d6cd8a..1fe970d1d 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -6601,6 +6601,11 @@ build_drop_arp_n

[ovs-dev] [PATCH ovn 09/14] ovn-northd: move per datapath dhcp response to a function

2020-09-14 Thread anton . ivanov
From: Anton Ivanov Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 42 ++ 1 file changed, 26 insertions(+), 16 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index a4955eed0..b1c12e9e4 100644 --- a/northd/ovn-northd.c +++ b/nor

[ovs-dev] Lswitch ovn-northd: separation into functions

2020-09-14 Thread anton . ivanov
Hi all, Apologies for the broken series on Friday, this is the fixed set of changes for lswitch. It splits lswitch flow processing in a way which: 1. Makes it easier to maintain 2. Makes it possible to parallelise it 3. Reduces (somewhat) the number of allocs and frees for dynamic strings.

[ovs-dev] [PATCH ovn 02/14] ovn-northd: move pre-acl and acl processing to a separate function

2020-09-14 Thread anton . ivanov
From: Anton Ivanov Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 39 +-- 1 file changed, 25 insertions(+), 14 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 1fe970d1d..94b9e2906 100644 --- a/northd/ovn-northd.c +++ b/northd