[ovs-dev] [PATCH v7 ovn] Allow to run multiple controllers on the same machine

User stories: 1) NFV: an admin wants to run two separate instances of OVN controller using the same database but configuring ports on different bridges. Some of these bridges may use DPDK while others may not. 2) Parallel OVN instances: an admin wants to run two separate instances of OVN

Re: [ovs-dev] [PATCH v6 ovn] Allow to run multiple controllers on the same machine

Hi Han, thanks a lot for the review! I addressed most comments below, listing here the questions not immediately addressed in the next version I am about to push: 1. why is file_system_id array static? there are drawbacks in switching it to local: we would need to do a lot more xstrdup / free wor

[ovs-dev] [PATCH AUTOSEL 4.19 205/206] net: openvswitch: use div_u64() for 64-by-32 divisions

From: Tonghao Zhang [ Upstream commit 659d4587fe7233bfdff303744b20d6f41ad04362 ] Compile the kernel for arm 32 platform, the build warning found. To fix that, should use div_u64() for divisions. | net/openvswitch/meter.c:396: undefined reference to `__udivdi3' [add more commit msg, change repor

[ovs-dev] [PATCH AUTOSEL 4.19 149/206] net: openvswitch: use u64 for meter bucket

From: Tonghao Zhang [ Upstream commit e57358873bb5d6caa882b9684f59140912b37dde ] When setting the meter rate to 4+Gbps, there is an overflow, the meters don't work as expected. Cc: Pravin B Shelar Cc: Andy Zhou Signed-off-by: Tonghao Zhang Acked-by: Pravin B Shelar Signed-off-by: David S. M

[ovs-dev] Project Funding Program!!

Our Company is inviting you to partner with us and benefit in our new Loan and Partnership Project funding program. We offer flexible loans and funding for various projects bypassing the usual rigorous procedures. This Funding program allows a client to enjoy low interest payback for as low a

[ovs-dev] 答复: 答复: [PATCH v2 0/3] userspace: enable tap interface?statistics and status update support

To be clarified, tap socket isn't created in netns currently because OVS doesn't have such info, current way is: # Step 1, add tap interface into ovs bridge in root netns, tap socket is created at this point. # step 2, move tap interface to specified netns. So question, how do you get netns id

[ovs-dev] [PATCH AUTOSEL 5.4 329/330] net: openvswitch: use div_u64() for 64-by-32 divisions

From: Tonghao Zhang [ Upstream commit 659d4587fe7233bfdff303744b20d6f41ad04362 ] Compile the kernel for arm 32 platform, the build warning found. To fix that, should use div_u64() for divisions. | net/openvswitch/meter.c:396: undefined reference to `__udivdi3' [add more commit msg, change repor

[ovs-dev] [PATCH AUTOSEL 5.4 244/330] net: openvswitch: use u64 for meter bucket

From: Tonghao Zhang [ Upstream commit e57358873bb5d6caa882b9684f59140912b37dde ] When setting the meter rate to 4+Gbps, there is an overflow, the meters don't work as expected. Cc: Pravin B Shelar Cc: Andy Zhou Signed-off-by: Tonghao Zhang Acked-by: Pravin B Shelar Signed-off-by: David S. M

[ovs-dev] 答复: 答复: [PATCH v2] userspace: fix bad UDP performance issue of veth

Good idea, but I don't have BSD to check it, maybe somebody can port it to BSD if he/she really care performance on BSD, I think it makes sense to use a separate patch to handle this. -邮件原件- 发件人: Aaron Conole [mailto:acon...@redhat.com] 发送时间: 2020年9月17日 22:34 收件人: Yi Yang (杨燚)-云服务集团 抄

Re: [ovs-dev] [PATCH ovn] debian/changelog: Fix data format

On Thu, Sep 17, 2020 at 6:21 PM wrote: > From: Artem Teleshev > Hi Artem, Thanks for the PR. I applied this patch to master and branch-20.09. Please note, I didn't test building the package for debian. Numan > > Reported-at: https://github.com/ovn-org/ovn/issues/54 > Submitted-at: https://

Re: [ovs-dev] [PATCH ovn] binding: fix localnet QoS configuration after I-P

On Thu, Sep 17, 2020 at 2:41 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > > On Sep 17, Han Zhou wrote: > > On Thu, Sep 17, 2020 at 6:40 AM Lorenzo Bianconi < > > lorenzo.bianc...@redhat.com> wrote: > > > > > > After the I-P has been introduced in commit 354bdba51a ("ovn-controller: >

Re: [ovs-dev] [PATCH ovn] binding: fix localnet QoS configuration after I-P

On Sep 17, Han Zhou wrote: > On Thu, Sep 17, 2020 at 6:40 AM Lorenzo Bianconi < > lorenzo.bianc...@redhat.com> wrote: > > > > After the I-P has been introduced in commit 354bdba51a ("ovn-controller: > > I-P for SB port binding and OVS interface in runtime_data"), the QoS on > > localnet ports is no

[ovs-dev] Medidas de seguridad y privacidad

Buenas tardes Quise aprovechar la oportunidad de hacerte una invitación para tomar nuestro curso: Nombre: Uso de Zoom para reuniones y clases virtuales Horario: de 16:00 am a 18:30 pm. ¿Cuándo?: 25 de Septiembre Precio: 290.00 + IVA Formato: En línea con interacción en vivo. Lugar: En Vivo desde

Re: [ovs-dev] [PATCH ovn] debian/changelog: Fix data format

Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committer

Re: [ovs-dev] [PATCH] rhel: move conf.db to /var/lib/openvswitch, using symlinks

On Thu, Sep 10, 2020 at 03:38:04PM +0200, Timothy Redaelli wrote: > conf.db is by default at /etc/openvswitch, but it should be at > /var/lib/openvswitch like on Debian or like ovnnb_db.db and ovnsb_db.db. > > If conf.db already exists in /etc/openvswitch then it's moved to > /var/lib/openvswitch.

Re: [ovs-dev] [PATCH v7 ovn] Add VXLAN support for non-VTEP datapath bindings

Bleep bloop. Greetings Ihar Hrachyshka, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch' to see the failed

Re: [ovs-dev] [PATCH 2/3] datapath: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode

On 9/17/2020 1:16 PM, 0-day Robot wrote: Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author wenxu needs to sign off. WARNING: Unex

Re: [ovs-dev] [PATCH 2/3] datapath: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode

Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author wenxu needs to sign off. WARNING: Unexpected sign-offs from developers who are not a

Re: [ovs-dev] [PATCH 1/3] ip_tunnels: new IP_TUNNEL_INFO_BRIDGE flag for ip_tunnel_info mode

Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Roopa Prabhu needs to sign off. WARNING: Unexpected sign-offs from developers who ar

[ovs-dev] [PATCH] compat: Replace the HAVE_L4_RXHASH define with HAVE_L4_HASH

The skb now uses l4_hash and it is easier to check for it. Also fixes a compile error for RHEL 7.7. Signed-off-by: Greg Rose --- acinclude.m4 | 4 ++-- datapath/datapath.c | 6 +++--- datapath/linux/compat/include/linux/skbuff.h | 4 ++--

Re: [ovs-dev] [PATCH v8] dpif-netlink: distribute polling to discreet handlers

Ilya Maximets writes: > On 9/9/20 7:08 PM, Mark Gray wrote: >> From: Aaron Conole >> >> Currently, the channel handlers are polled globally. On some >> systems, this causes a thundering herd issue where multiple >> handler threads become active, only to do no work and immediately >> sleep. >>

Re: [ovs-dev] [PATCH] ofproto:ipv6 mld report error send to fports

I missed this one, but the comments to the previous patch remains the same here. fbl On Thu, Sep 10, 2020 at 03:49:00PM +0800, XiaoXiong Ding wrote: > when mld report come(same as mld done), will do funciton > xlate_normal_mcast_send_rports, and because of no return, > will doforwarding to grou

Re: [ovs-dev] [PATCH] ofproto:ipv6 mld report error send to fports

On Thu, Sep 10, 2020 at 03:51:34AM +, dingxiaoxiong wrote: > when mld report come(same as mld done), will do funciton Please start with Capital. > xlate_normal_mcast_send_rports, and because of no return, > will doforwarding to group base ports logic,and if two spaces needed > other_config:

Re: [ovs-dev] [PATCH ovn] binding: fix localnet QoS configuration after I-P

On Thu, Sep 17, 2020 at 6:40 AM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > > After the I-P has been introduced in commit 354bdba51a ("ovn-controller: > I-P for SB port binding and OVS interface in runtime_data"), the QoS on > localnet ports is not properly configured if the ovs interf

Re: [ovs-dev] [PATCH v8] dpif-netlink: distribute polling to discreet handlers

On Thu, Sep 17, 2020 at 08:43:38PM +0200, Ilya Maximets wrote: > On 9/9/20 7:08 PM, Mark Gray wrote: > > From: Aaron Conole > > > > Currently, the channel handlers are polled globally. On some > > systems, this causes a thundering herd issue where multiple > > handler threads become active, only

Re: [ovs-dev] [PATCH v6 ovn] Allow to run multiple controllers on the same machine

Bleep bloop. Greetings Ihar Hrachyshka, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch' to see the failed

Re: [ovs-dev] [PATCH ovn v3 1/2] lflow.c: Avoid adding redundant resource refs for port-bindings.

Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch' to see the failed patch P

Re: [ovs-dev] [PATCH ovn v2 1/2] lflow.c: Avoid adding redundant resource refs for port-bindings.

On Thu, Sep 17, 2020 at 12:49 AM Dumitru Ceara wrote: > > On 9/16/20 10:05 PM, Han Zhou wrote: > >> > Same as above. In addition, I prefer fewer functions because it is > >> > easier (slightly) to tell from the prototypes that those are the only > >> > operations possible for this data structure.

Re: [ovs-dev] Improved OVN CI

On 3/27/20 7:24 PM, Mark Michelson wrote: > Hi everyone, > > I've taken some time recently to look into the current CI for OVS/OVN, > and I think there is room for improvement. Here I will outline a 4 part > plan for improving CI for OVN. > > > Part 1: Report travis build failures as replies to

Re: [ovs-dev] [PATCH v8] dpif-netlink: distribute polling to discreet handlers

On 9/9/20 7:08 PM, Mark Gray wrote: > From: Aaron Conole > > Currently, the channel handlers are polled globally. On some > systems, this causes a thundering herd issue where multiple > handler threads become active, only to do no work and immediately > sleep. > > The approach here is to push t

Re: [ovs-dev] [PATCH ovn v2] lflow.c: Rename function convert_acts_to_expr to convert_match_to_expr.

On Thu, Sep 17, 2020 at 3:26 AM Numan Siddique wrote: > > > > On Thu, Sep 17, 2020 at 1:01 PM Han Zhou wrote: >> >> On Thu, Sep 17, 2020 at 12:25 AM Dumitru Ceara wrote: >> > >> > On 9/16/20 6:05 PM, Han Zhou wrote: >> > > The name was misleading because it in fact parses lflow match instead >>

Re: [ovs-dev] [PATCH ovn v3 2/2] lflow.c: Release ref_lflow_node as soon as it is not needed.

On Thu, Sep 17, 2020 at 5:45 AM Numan Siddique wrote: > > > > On Thu, Sep 17, 2020 at 1:15 PM Dumitru Ceara wrote: >> >> On 9/16/20 8:01 PM, Han Zhou wrote: >> > If a resource doesn't have any lflows referencing it any more, the >> > node ref_lflow_node in lflow_resource_ref.ref_lflow_table shoul

Re: [ovs-dev] [PATCH ovn v3 1/2] lflow.c: Avoid adding redundant resource refs for port-bindings.

On Thu, Sep 17, 2020 at 5:44 AM Numan Siddique wrote: > > > > On Thu, Sep 17, 2020 at 1:14 PM Dumitru Ceara wrote: >> >> On 9/16/20 8:01 PM, Han Zhou wrote: >> > When a lport is referenced by a logical flow where port-binding refs >> > needs to be added, currently it can add the same reference pa

Re: [ovs-dev] [PATCH] rhel: fix logrotate group when dpdk is enabled

On 9/17/20 7:46 PM, Aaron Conole wrote: > Ilya Maximets writes: > >> On 4/30/19 7:10 PM, Jaime Caamaño Ruiz wrote: >>> Otherwise logrotate will fail to generate the rotated log files. >>> >>> Signed-off-by: Jaime Caamaño Ruiz >>> --- >> >> Hi. I'm looking through old patches after the patchwork

Re: [ovs-dev] [PATCH] rhel: fix logrotate group when dpdk is enabled

Ilya Maximets writes: > On 4/30/19 7:10 PM, Jaime Caamaño Ruiz wrote: >> Otherwise logrotate will fail to generate the rotated log files. >> >> Signed-off-by: Jaime Caamaño Ruiz >> --- > > Hi. I'm looking through old patches after the patchwork cleanup and this > one seems to be still valid an

[ovs-dev] [PATCH 3/3] vxlan: Make vxlan tunnel work in IP_TUNNEL_INFO_BRIDGE mode

From: wenxu There is currently no support for the multicast/broadcast aspects of VXLAN in ovs. In the datapath flow the tun_dst must specific. But in the IP_TUNNEL_INFO_BRIDGE mode the tun_dst can not be specific. And the packet can forward through the fdb table of vxlan devcice. In this mode the

[ovs-dev] [PATCH 1/3] ip_tunnels: new IP_TUNNEL_INFO_BRIDGE flag for ip_tunnel_info mode

From: Roopa Prabhu Upstream commit: commit f35581d64e55fc65753a62957b3b98127d560d07 Author: Roopa Prabhu Date: Tue Jan 31 22:59:51 2017 -0800 ip_tunnels: new IP_TUNNEL_INFO_BRIDGE flag for ip_tunnel_info mode New ip_tunnel_info flag to represent bridged tunnel metadata.

[ovs-dev] [PATCH 2/3] datapath: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode

From: wenxu Upstream commit: commit 18b6f717483a835fb98de9f0df6c724df9324e78 Author: wenxu Date: Thu Mar 28 12:43:23 2019 +0800 openvswitch: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode There is currently no support for the multicast/broadcast aspects o

[ovs-dev] [PATCH 0/3] Add IP_TUNNEL_INFO_BRIDGE mode feature

Let's pick these patches up. Submitted some time ago but then dropped. Enables the IP_TUNNEL_INFO_BRIDGE feature from upstream Linux and then pulls in to patches from wenxu to complete the feature enablement for openvswitch. Passes Travis here: https://travis-ci.org/github/gvrose8192/ovs-experim

Re: [ovs-dev] [PATCH v2] conntrack: add generic IP protocol support

On Thu, Sep 17, 2020 at 04:41:33AM -0400, Eelco Chaudron wrote: > Currently, userspace conntrack only tracks TCP, UDP, and ICMP, and all > other IP protocols are discarded, and the +inv state is returned. This > is not in line with the kernel conntrack. Where if no L4 information can > be extracted

[ovs-dev] [PATCH ovn] ovn-northd: Fix router policy pkt mark over flow if the value is greater than signed int.

From: Numan Siddique If the value of pkt_mark in the router policy options is greater than 2147483647, we are ignoring it. This is because we use smap_get_int(). This patch fixes this issue by using str_to_uint(). Fixes: a123ef0fb8fd("Support packet metadata marking for logical router policie

[ovs-dev] [PATCH v3 9/9] netdev-offload-tc: Add offload support for sFlow

Create a unique group ID to map the sFlow info when offloading sFlow action to TC. When showing the offloaded datapath flows, translate the group ID from TC sample action to sFlow info using the mapping. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/netdev-offload-tc.c | 131 ++

Re: [ovs-dev] 答复: [PATCH v2] userspace: fix bad UDP performance issue of veth

"Yi Yang (杨燚)-云服务集团" writes: > Aaron, thank you so much for comments, I'll update it to fix your comment in > v3, replies for comments inline, please check them. Thanks. I have one more comment to consider. SO_SNDBUF / SO_RCVBUF are available on many OSes - does it make sense to make a simila

[ovs-dev] [PATCH v3 1/9] compat: Add psample and tc sample action defines for older kernels

Update kernel UAPI to support psample and the tc sample action. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- include/linux/automake.mk| 4 ++- include/linux/psample.h | 58 include/linux/tc_act/tc_sample.h | 25 ++ 3 files

[ovs-dev] [PATCH v3 2/9] ovs-kmod-ctl: Load kernel module psample

Load kernel module psample to receive sampled packets from TC. Before removing kernel module psample, remove act_sample first. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- utilities/ovs-kmod-ctl.in | 14 ++ 1 file changed, 14 insertions(+) diff --git a/utilities/ovs-kmod-

[ovs-dev] [PATCH v3 6/9] dpif-netlink: Implement psample offload API

Implement offload API to receive sampled packet from psample netlink socket. Parse sampled packet to ovs format. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/dpif-netlink.c | 133 - 1 file changed, 130 insertions(+), 3 deletions(-) diff

[ovs-dev] (no subject)

Subject: [ovs-dev][PATCH v3 0/9] Add offload support for sFlow This patch set adds offload support for sFlow. Psample is a genetlink channel for packet sampling. TC action act_sample uses psample to send sampled packets to userspace. When offloading sample action to TC, userspace creates a uniqu

[ovs-dev] [PATCH v3 8/9] netdev-offload-tc: Introduce group ID management API

When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to kernel instead of the sFlow info. psample will send this ID and sampled packet to userspace. Using the ID, userspace can recover the sFlow info and send sampled packet to the

[ovs-dev] [PATCH v3 4/9] netdev-offload: Introduce sFlow attributes query by group ID API

OVS maintains a group ID to sFlow attribute mapping when offloading sFlow action to TC. Introduce sFlow attributes query by group ID API. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/netdev-offload-provider.h | 5 + lib/netdev-offload.c | 11 +++ lib/netdev-o

[ovs-dev] [PATCH v3 5/9] dpif: Introduce psample offload API

Introduce offload API to receive sampled packet from psample netlink socket. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/dpif-netdev.c | 3 +++ lib/dpif-netlink.c | 3 +++ lib/dpif-provider.h | 11 +++ lib/dpif.c | 24 lib/dpif.h

[ovs-dev] [PATCH v3 7/9] ofproto: Add psample receive handler

Create a dedicated thread to poll psample netlink socket, receive sampled packet, parse it to sFlow format and send it to sFlow monitoring host. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- ofproto/ofproto-dpif-upcall.c | 78 +++ 1 file changed, 78 inse

[ovs-dev] [PATCH v3 3/9] dpif-netlink: Create psample netlink socket

Create psample netlink socket as a pre-step towards receiving sampled packets. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/dpif-netlink.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c in

[ovs-dev] ovs+dpdk build：Could not find DPDK libraries

hi all， i am building ovs + dpdk， the operations is following： build dpdk： declare -x DPDK_BUILD="/home/sda3/dpdk-stable-19.11.4/x86_64-native-linuxapp-gcc" declare -x DPDK_DIR="/home/sda3/dpdk-stable-19.11.4" declare -x DPDK_TARGET="x86_64-native-linuxapp-gcc" make install T=$DPDK_TARGET DESTDI

[ovs-dev] [PATCH ovn] binding: fix localnet QoS configuration after I-P

After the I-P has been introduced in commit 354bdba51a ("ovn-controller: I-P for SB port binding and OVS interface in runtime_data"), the QoS on localnet ports is not properly configured if the ovs interface is marked with "ovn-egress-iface" flag after the related record in the logical_switch_port

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Drop IP packets destined to router owned IPs (after NAT).

On Thu, Sep 17, 2020 at 6:25 PM Dumitru Ceara wrote: > On 9/8/20 8:39 PM, Dumitru Ceara wrote: > > On 9/8/20 3:42 PM, Numan Siddique wrote: > >> On Tue, Sep 8, 2020 at 6:48 PM Dumitru Ceara wrote: > >>> > >>> On 9/8/20 2:06 PM, Numan Siddique wrote: > On Tue, Sep 8, 2020 at 4:54 PM Dumitru

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Drop IP packets destined to router owned IPs (after NAT).

On 9/8/20 8:39 PM, Dumitru Ceara wrote: > On 9/8/20 3:42 PM, Numan Siddique wrote: >> On Tue, Sep 8, 2020 at 6:48 PM Dumitru Ceara wrote: >>> >>> On 9/8/20 2:06 PM, Numan Siddique wrote: On Tue, Sep 8, 2020 at 4:54 PM Dumitru Ceara wrote: > > On 9/8/20 12:58 PM, Numan Siddique wrote:

[ovs-dev] [PATCH v3 ovn 4/4] ovn-northd: Refactor processing of SNAT IPs.

Instead of building string sets every time we need to generate logical flows for unique SNAT IPs we now prebuild the set of unique SNAT IPs and store the list of NAT entries that refer it. Signed-off-by: Dumitru Ceara --- northd/ovn-northd.c | 326 ---

[ovs-dev] [PATCH v3 ovn 3/4] ovn-northd: Refactor parsing of *_force_snat_ip.

Avoid reparsing the *_force_snat_ip addresses for every logical router port. These addresses are defined once for the whole router. Signed-off-by: Dumitru Ceara --- lib/ovn-util.c |6 lib/ovn-util.h |2 + northd/ovn-northd.c | 69 -

[ovs-dev] [PATCH ovn] debian/changelog: Fix data format

From: Artem Teleshev Reported-at: https://github.com/ovn-org/ovn/issues/54 Submitted-at: https://github.com/ovn-org/ovn/pull/55 Signed-off-by: Artem Teleshev Signed-off-by: Numan Siddique --- debian/changelog | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/de

[ovs-dev] [PATCH v3 ovn 1/4] ovn-northd: Drop IP packets destined to router owned IPs (after NAT).

OVN was dropping IP packets destined to IPs owned by logical routers but only if those IPs are not used for SNAT rules. However, if a packet doesn't match an existing NAT session and its destination is still a router owned IP, it can be safely dropped. Otherwise it will trigger an unnecessary packe

[ovs-dev] [PATCH v3 ovn 2/4] ovn-northd: Move NAT ARP/ND resolution to separate functions.

To avoid duplicating code later on, move out the code that generates ARP/ND replies for NAT external IPs to separate functions. Signed-off-by: Dumitru Ceara --- northd/ovn-northd.c | 172 --- 1 file changed, 94 insertions(+), 78 deletions(-) diff

[ovs-dev] [PATCH v3 ovn 0/4] Drop packets destined to own IPs and refactor SNAT processing.

The first patch of the series is a bug fix for: https://bugzilla.redhat.com/1876174 If accepted, the first patch should also be backported to stable branches. The following three patches are a series of refactoring to make logical flow processing for SNAT a bit more efficient while reducing code

[ovs-dev] Amazonセキュリティ警告: サインインが検出されました

あなたのアカウントは停止されました 新しいデバイスからアカウントサービスへのサインインが検出されました。 誰かがあなたのAmazonアカウントで他のデバイスから購入しようとしました。Amazonの保護におけるセキュリティと整合性の問題により、セキュリティ上の理由からアカウントがロックされます。 アカウントを引き続き使用するには、24時間前に情報を更新することをお勧めします。それ以外の場合、あなたのアカウントは永久ロック。 確認用アカウント © 2020 Amazon.com, Inc. or its affiliates. All rights reserved.

Re: [ovs-dev] [PATCH ovn v3 2/2] lflow.c: Release ref_lflow_node as soon as it is not needed.

On Thu, Sep 17, 2020 at 1:15 PM Dumitru Ceara wrote: > On 9/16/20 8:01 PM, Han Zhou wrote: > > If a resource doesn't have any lflows referencing it any more, the > > node ref_lflow_node in lflow_resource_ref.ref_lflow_table should > > be removed and released. Otherwise, the table could keep growi

Re: [ovs-dev] [PATCH ovn v3 1/2] lflow.c: Avoid adding redundant resource refs for port-bindings.

On Thu, Sep 17, 2020 at 1:14 PM Dumitru Ceara wrote: > On 9/16/20 8:01 PM, Han Zhou wrote: > > When a lport is referenced by a logical flow where port-binding refs > > needs to be added, currently it can add the same reference pair multiple > > times in below situations (introduced in commit ade4

Re: [ovs-dev] 答复: [PATCH v2 0/3] userspace: enable tap interface?statistics and status update support

On Thu, Sep 17, 2020 at 01:05:22AM +, Yi Yang (杨燚)-云服务集团 wrote: > Aaron, any caller thread just binds it to netns on calling enter_netns, once > it has entered netns, it won't disappear, so exit_netns caller thread must be > current thread, once it exits netns, it returns back to original roo

Re: [ovs-dev] OVS-DPDK public meeting

Next meeting October 14th 1600 UTC Minutes: Sept 16 Attendees: Ameer, David, Flavio, Fouad, Gaetan, Gregory, Ilya, Majd, Oz, Scott, Simon, Thomas, William, Roni, Harsha, Hemal, Ajit, Anurag, Kevin Agenda: - OVS LTS -- Discussion on OVS LTS upstream -- Aims to clarify and document a default LTS

Re: [ovs-dev] [PATCH ovn v2] lflow.c: Rename function convert_acts_to_expr to convert_match_to_expr.

On Thu, Sep 17, 2020 at 1:01 PM Han Zhou wrote: > On Thu, Sep 17, 2020 at 12:25 AM Dumitru Ceara wrote: > > > > On 9/16/20 6:05 PM, Han Zhou wrote: > > > The name was misleading because it in fact parses lflow match instead > > > of actions. > > > > > > Fixes: 1213bc8270 ("ovn-controller: Cache

Re: [ovs-dev] [PATCH ovn] build: Fix broken check-lcov target.

On Wed, Sep 16, 2020 at 5:13 PM Mark Gray wrote: > On 14/09/2020 23:04, Dumitru Ceara wrote: > > Without this, the following fails: > > > > $ make check-lcov > > [...] > > Cannot open source file lib/dirs.c.in > > [...] > > make: *** [check-lcov] Error 2 > > > > CC: Ilya Maximets > > Signed-off-

Re: [ovs-dev] [PATCH] conntrack: add generic IP protocol support

On 16 Sep 2020, at 17:45, Aaron Conole wrote: Eelco Chaudron writes: Currently, userspace conntrack only tracks TCP, UDP, and ICMP, and all other IP protocols are discarded, and the +inv state is returned. This is not in line with the kernel conntrack. Where if no L4 information can be e

[ovs-dev] [PATCH v2] conntrack: add generic IP protocol support

Currently, userspace conntrack only tracks TCP, UDP, and ICMP, and all other IP protocols are discarded, and the +inv state is returned. This is not in line with the kernel conntrack. Where if no L4 information can be extracted it's treated as generic L3. The change below mimics the behavior of the

Re: [ovs-dev] [PATCH ovn v2 1/2] lflow.c: Avoid adding redundant resource refs for port-bindings.

On 9/16/20 10:05 PM, Han Zhou wrote: >> > Same as above. In addition, I prefer fewer functions because it is >> > easier (slightly) to tell from the prototypes that those are the only >> > operations possible for this data structure. In this case, it tells that >> > this is the only interface that

Re: [ovs-dev] [PATCH ovn v3 1/2] lflow.c: Avoid adding redundant resource refs for port-bindings.

On 9/16/20 8:01 PM, Han Zhou wrote: > When a lport is referenced by a logical flow where port-binding refs > needs to be added, currently it can add the same reference pair multiple > times in below situations (introduced in commit ade4e77): > > 1) In add_matches_to_flow_table(), different matches

Re: [ovs-dev] [PATCH ovn v3 2/2] lflow.c: Release ref_lflow_node as soon as it is not needed.

On 9/16/20 8:01 PM, Han Zhou wrote: > If a resource doesn't have any lflows referencing it any more, the > node ref_lflow_node in lflow_resource_ref.ref_lflow_table should > be removed and released. Otherwise, the table could keep growing > in some scenarios, until a recompute is triggered. Now tha

Re: [ovs-dev] [PATCH ovn v2] lflow.c: Rename function convert_acts_to_expr to convert_match_to_expr.

On Thu, Sep 17, 2020 at 12:25 AM Dumitru Ceara wrote: > > On 9/16/20 6:05 PM, Han Zhou wrote: > > The name was misleading because it in fact parses lflow match instead > > of actions. > > > > Fixes: 1213bc8270 ("ovn-controller: Cache logical flow expr matches.") > > Cc: Numan Siddique > > Acked-b

Re: [ovs-dev] [PATCH v6 ovn] Allow to run multiple controllers on the same machine

Hi Ihar, Please see my comments below. Thanks, Han On Wed, Sep 16, 2020 at 7:16 PM Ihar Hrachyshka wrote: > > User stories: > 1) NFV: an admin wants to run two separate instances of OVN controller >using the same database but configuring ports on different bridges. >Some of these bridge

Re: [ovs-dev] [PATCH ovn] lflow.c: Rename function convert_acts_to_expr to convert_match_to_expr.

On 9/16/20 6:14 PM, Han Zhou wrote: > > > On Wed, Sep 16, 2020 at 7:28 AM Dumitru Ceara > wrote: >> >> On 9/16/20 4:04 PM, Numan Siddique wrote: >> > >> > >> > >> > On Wed, Sep 16, 2020 at 3:56 PM Dumitru Ceara >> >

Re: [ovs-dev] [PATCH ovn v2] lflow.c: Rename function convert_acts_to_expr to convert_match_to_expr.

On 9/16/20 6:05 PM, Han Zhou wrote: > The name was misleading because it in fact parses lflow match instead > of actions. > > Fixes: 1213bc8270 ("ovn-controller: Cache logical flow expr matches.") > Cc: Numan Siddique > Acked-by: Numan Siddique > Signed-off-by: Han Zhou > --- > v1 -> v2: Addres

Re: [ovs-dev] OVN 20.09 Soft freeze

On Thu, Sep 17, 2020 at 8:55 AM Ihar Hrachyshka wrote: > On Wed, Sep 16, 2020 at 2:13 PM Numan Siddique wrote: > > > > Hi All, > > > > branch-20.09 has been created. Please note that after the soft freeze, > there have been few bug fixes > > and Anton's most of the build_lrouter_flows refactor p

Re: [ovs-dev] [PATCH v7 ovn] Add VXLAN support for non-VTEP datapath bindings

On Thu, Sep 17, 2020 at 8:52 AM Ihar Hrachyshka wrote: > Because of limited space in VXLAN VNI to pass over all three of - > datapath id, ingress port, egress port - the implementation ignores > ingress; and splits the remaining 24 bits of VNI into two chunks, 12 > bits each - one for datapath an