[ovs-dev] Spende.

2020-09-24 Thread Andrew Clark
Dies ist eine persönliche E-Mail an Sie. Mein Name ist Andrew Clark, ein Lottogewinner des EuroMillions-Jackpots. Ich spende Ihnen und Ihrer Familie den Betrag von 950.000,00 Euro. Kontaktieren Sie mich unter meiner E-Mail-Adresse: andrewclark0...@yahoo.com für Verzeichnisse und Ansprüche. _

Re: [ovs-dev] 回复:[External] Re: [PATCH] ofproto-dpif: remove checking setting nd_ext field

2020-09-24 Thread Flavio Leitner
Hi, Right, it will be forced to slow path if the action actually changes the value otherwise just omitted. The problem is with the matching side where an error will happen if the data path doesn't support nd extension. I will continue to review the patch and follow up later, but in the meantim

[ovs-dev] [PATCH ovn v2 1/1] controller: Check for tunnel change in multi-vtep case is incorrect

2020-09-24 Thread venugopali
From: venu iyer Prior to multi-vtep, there was one tunnel for each type, since there was only one encap-ip. So, the check in chassis_tunnels_changed(): sset_count(encap_type_set) != encap_type_count worked. However, with multiple IPs per tunnel type, the above check won't work. So, once

[ovs-dev] OVN meeting minutes for Sept. 24, 2020

2020-09-24 Thread Ben Pfaff
Here are notes and the log from today's OVN meeting Minutes: http://eavesdrop.openstack.org/meetings/ovn_community_development_discussion/2020/ovn_community_development_discussion.2020-09-24-17.21.html Minutes (text): http://eavesdrop.openstack.org/meetings/ovn_community_development_discu

[ovs-dev] [PATCH ovn] ovn-northd: Optimize logical flow generation for reject ACLs.

2020-09-24 Thread numans
From: Numan Siddique ovn-northd adds below lflows for a reject ACL with a match - M match = (ip4 && tcp && 'M') action = tcp_reject{} match = (ip6 && tcp && 'M') action = tcp_reject{} match = (ip4 && 'M') action = icmp4{} match = (ip6 && 'M') action = icmp6{} This approach has a couple of probl

Re: [ovs-dev] [PATCH v4 0/9] Add offload support for sFlow

2020-09-24 Thread Ilya Maximets
On 9/24/20 12:24 PM, Chris Mi wrote: > This patch set adds offload support for sFlow. > > Psample is a genetlink channel for packet sampling. TC action act_sample > uses psample to send sampled packets to userspace. > > When offloading sample action to TC, userspace creates a unique ID to > map s

Re: [ovs-dev] [PATCH ovn v3 1/6] ovn-northd: reorganize processing of lflows

2020-09-24 Thread Ilya Maximets
On 9/24/20 11:27 AM, Anton Ivanov wrote: > > > On 23/09/2020 21:50, Ilya Maximets wrote: >> On 9/23/20 8:00 PM, anton.iva...@cambridgegreys.com wrote: >>> From: Anton Ivanov >>> >>> 1. Merge lrouter and lswitch processing. >>> 2. Move lrouter and lswitch lflow generation which uses the >>> same

Re: [ovs-dev] [PATCH] ofproto:ipv6 mld report error send to fports

2020-09-24 Thread Flavio Leitner
Hi XiaoXiong, Thanks again for the patch. Could you please follow the guidelines to post patches? https://github.com/openvswitch/ovs/blob/master/Documentation/internals/contributing/submitting-patches.rst The Subject for instance is a bit confusing as I think you don't want reports forwarded t

Re: [ovs-dev] [PATCH] userspace: Switch default cache from EMC to SMC.

2020-09-24 Thread Flavio Leitner
On Tue, Sep 22, 2020 at 06:46:40PM +0100, Kevin Traynor wrote: > On 19/09/2020 14:07, Flavio Leitner wrote: > > The EMC is not large enough for current production cases > > and they are scaling up, so this change switches over from > > EMC to SMC by default, which provides better results. > > > >

[ovs-dev] [PATCH v4 ovn] binding: fix localnet QoS configuration after I-P

2020-09-24 Thread Lorenzo Bianconi
After the I-P has been introduced in commit 354bdba51a ("ovn-controller: I-P for SB port binding and OVS interface in runtime_data"), the QoS on localnet ports is not properly configured if the ovs interface is marked with "ovn-egress-iface" flag after the related record in the logical_switch_port

Re: [ovs-dev] [PATCH] compat: Replace the HAVE_L4_RXHASH define with HAVE_L4_HASH

2020-09-24 Thread Flavio Leitner
On Tue, Sep 22, 2020 at 12:45:03PM +0200, Ilya Maximets wrote: > On 9/17/20 9:59 PM, Greg Rose wrote: > > The skb now uses l4_hash and it is easier to check for it. Also > > fixes a compile error for RHEL 7.7. > > > > Signed-off-by: Greg Rose > > --- > > acinclude.m4

[ovs-dev] [PATCH v4 9/9] netdev-offload-tc: Add offload support for sFlow

2020-09-24 Thread Chris Mi
Create a unique group ID to map the sFlow info when offloading sFlow action to TC. When showing the offloaded datapath flows, translate the group ID from TC sample action to sFlow info using the mapping. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/netdev-offload-tc.c | 159 ++

[ovs-dev] [PATCH v4 4/9] netdev-offload: Introduce sFlow attributes query by group ID API

2020-09-24 Thread Chris Mi
OVS maintains a group ID to sFlow attribute mapping when offloading sFlow action to TC. Introduce sFlow attributes query by group ID API. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/netdev-offload-provider.h | 5 + lib/netdev-offload.c | 11 +++ lib/netdev-o

[ovs-dev] [PATCH v4 5/9] dpif: Introduce psample offload API

2020-09-24 Thread Chris Mi
Introduce offload API to receive sampled packet from psample netlink socket. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/dpif-netdev.c | 3 +++ lib/dpif-netlink.c | 3 +++ lib/dpif-provider.h | 11 +++ lib/dpif.c | 24 lib/dpif.h

[ovs-dev] [PATCH v4 6/9] dpif-netlink: Implement psample offload API

2020-09-24 Thread Chris Mi
Implement offload API to receive sampled packet from psample netlink socket. Parse sampled packet to ovs format. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/dpif-netlink.c | 133 - 1 file changed, 130 insertions(+), 3 deletions(-) diff

[ovs-dev] [PATCH v4 7/9] ofproto: Add psample receive handler

2020-09-24 Thread Chris Mi
Create a dedicated thread to poll psample netlink socket, receive sampled packet, parse it to sFlow format and send it to sFlow monitoring host. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- ofproto/ofproto-dpif-upcall.c | 78 +++ 1 file changed, 78 inse

[ovs-dev] [PATCH v4 3/9] dpif-netlink: Create psample netlink socket

2020-09-24 Thread Chris Mi
Create psample netlink socket as a pre-step towards receiving sampled packets. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/dpif-netlink.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c in

[ovs-dev] [PATCH v4 0/9] Add offload support for sFlow

2020-09-24 Thread Chris Mi
This patch set adds offload support for sFlow. Psample is a genetlink channel for packet sampling. TC action act_sample uses psample to send sampled packets to userspace. When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to k

[ovs-dev] [PATCH v4 2/9] ovs-kmod-ctl: Load kernel module psample

2020-09-24 Thread Chris Mi
Load kernel module psample to receive sampled packets from TC. Before removing kernel module psample, remove act_sample first. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- utilities/ovs-kmod-ctl.in | 14 ++ 1 file changed, 14 insertions(+) diff --git a/utilities/ovs-kmod-

[ovs-dev] [PATCH v4 1/9] compat: Add psample and tc sample action defines for older kernels

2020-09-24 Thread Chris Mi
Update kernel UAPI to support psample and the tc sample action. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- include/linux/automake.mk| 4 ++- include/linux/psample.h | 58 include/linux/tc_act/tc_sample.h | 25 ++ 3 files

[ovs-dev] [PATCH v4 8/9] netdev-offload-tc: Introduce group ID management API

2020-09-24 Thread Chris Mi
When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to kernel instead of the sFlow info. psample will send this ID and sampled packet to userspace. Using the ID, userspace can recover the sFlow info and send sampled packet to the

Re: [ovs-dev] [PATCH ovn v3 1/6] ovn-northd: reorganize processing of lflows

2020-09-24 Thread Anton Ivanov
On 23/09/2020 21:50, Ilya Maximets wrote: On 9/23/20 8:00 PM, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov 1. Merge lrouter and lswitch processing. 2. Move lrouter and lswitch lflow generation which uses the same iterator variables into common helpers 3. Set up structures to be

[ovs-dev] 回复:[External] Re: [PATCH] ofproto-dpif: remove checking setting nd_ext field

2020-09-24 Thread 范开喜
Hi Aaron conole and Flavio Leitner, I am just trying to fix the bug. When I am trying to put ipv6 nd proxy flows into ovs (with kernel), ovs emits error message like this: "Only userspace datapath support OVS_KEY_ATTR_ND_EXTENSIONS in keys." So the flows could not be inserted into ovs by ovs-ofctl.

Re: [ovs-dev] [PATCH v3 ovn] binding: fix localnet QoS configuration after I-P

2020-09-24 Thread Numan Siddique
On Thu, Sep 24, 2020 at 2:37 AM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > After the I-P has been introduced in commit 354bdba51a ("ovn-controller: > I-P for SB port binding and OVS interface in runtime_data"), the QoS on > localnet ports is not properly configured if the ovs interfa

Re: [ovs-dev] [PATCH v3 8/8] appveyor: Bump outdated links and add artifacts

2020-09-24 Thread 0-day Robot
Bleep bloop. Greetings Alin Gabriel Serdean, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 397 characters long (recommended limit is 79) #80 FILE: appveyor.yml:4

Re: [ovs-dev] [PATCH v3 7/8] windows, installer: Bundle Windows 10 driver

2020-09-24 Thread 0-day Robot
Bleep bloop. Greetings Alin Gabriel Serdean, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 128 characters long (recommended limit is 79) #64 FILE: windows/ovs-wi

Re: [ovs-dev] [PATCH v2 2/8] windows: Add default value for VSTUDIO_CONFIG

2020-09-24 Thread Alin Serdean
On 9/21/20 3:32 AM, Alin Gabriel Serdean wrote: > VSTUDIO_CONFIG is used when generating the windows installer. > > If the parameter passed to configure `--with-vstudiotarget` is not specified > to configure we default it to `Default`. > > Fixes bug: vstudiotarget/vstudiotargetver should be avail

Re: [ovs-dev] [PATCH v3 6/8] windows: Update build with latest pthread project

2020-09-24 Thread 0-day Robot
Bleep bloop. Greetings Alin Gabriel Serdean, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 99 characters long (recommended limit is 79) #77 FILE: appveyor.yml:36

Re: [ovs-dev] [PATCH v3 5/8] windows, installer: Bundle latest runtime version

2020-09-24 Thread 0-day Robot
Bleep bloop. Greetings Alin Gabriel Serdean, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 115 characters long (recommended limit is 79) #40 FILE: windows/ovs-wi