Re: [ovs-dev] [PATCH ovn] Clear port binding flows when datapath CT zone changes.

2020-11-23 Thread Numan Siddique
On Fri, Nov 20, 2020 at 5:44 AM Mark Michelson wrote: > > In commit f9cab11d5fabe2ae321a3b4bad5972b61df958c0, a LOG_TO_PHY flow > was changed so that it was no longer associated with a particular port > binding. The logic there was that the particular flow contains data > pertaining to the port bi

[ovs-dev] [PATCH] lib/tc: fix parse act pedit for tos rewrite

2020-11-23 Thread wenxu
From: wenxu Check overlap between current pedit key, which is always 4 bytes (range [off, off + 3]), and a map entry in flower_pedit_map sf = ROUND_DOWN(mf, 4) (range [sf|mf, (mf + sz - 1)|ef]). So for the tos the rewite the off + 3(3) is greater than mf, and should less than ef(4) but not mf+sz

[ovs-dev] 在线挖掘采购信息

2020-11-23 Thread huntt . marcy . u28968
我已邀请您填写以下表单: 在线挖掘采购信息 要填写此表单,请访问: https://docs.google.com/forms/d/e/1FAIpQLSd2yJxTOYWWewvfJO9rjD6EDLUVymvM9_iQDGH_NXwQvuOcuQ/viewform?vc=0&c=0&w=1&flr=0&usp=mail_form_link 我已邀请您填写表单: Google表单:创建调查问卷并分析调查结果。 ___ dev mailing list d...@openvswitch.org ht

Re: [ovs-dev] [PATCH net] net: openvswitch: fix TTL decrement action netlink message format

2020-11-23 Thread Jakub Kicinski
On Mon, 23 Nov 2020 20:36:39 +0100 Matteo Croce wrote: > On Fri, Nov 20, 2020 at 10:12 PM Jakub Kicinski wrote: > > On Thu, 19 Nov 2020 04:04:04 -0500 Eelco Chaudron wrote: > > > Currently, the openvswitch module is not accepting the correctly formated > > > netlink message for the TTL decrement

[ovs-dev] 答复: [PATCH V3 1/4] Enable VXLAN TSO for DPDK datapath

2020-11-23 Thread 杨燚
Flavio, thank you so much for clarification, I'll push "Enable VXLAN TSO for DPDK datapath" first, replies for your comments inline, please check them in the later part. -邮件原件- 发件人: dev [mailto:ovs-dev-boun...@openvswitch.org] 代表 Flavio Leitner 发送时间: 2020年11月24日 3:10 收件人: yang_y_yi 抄送:

Re: [ovs-dev] (no subject)

2020-11-23 Thread Jean IKOUNGA via dev
-- The corona virus outbreak isn't just a major health crisis it's also a large economic disruption leading to people losing their jobs and making it harder to take care of their families. We've heard that a little financial support can go a long way. I'm Sheryll Goedert from Florida the Wi

[ovs-dev] [PATCH branch-2.11] stream-ssl: Make 'stream_ssl_set_key_and_cert' atomic

2020-11-23 Thread Thomas Neuman
From 417ed338179d9856334e9b738abd71952581785a Mon Sep 17 00:00:00 2001 From: Thomas Neuman Date: Mon, 23 Nov 2020 21:02:08 + Subject: [PATCH branch-2.11] stream-ssl: Make 'stream_ssl_set_key_and_cert' atomic When attempting to set the SSL key and cert via this function, first we check wheth

Re: [ovs-dev] TravisCI needs to be replaced.

2020-11-23 Thread Ben Pfaff
On Mon, Nov 23, 2020 at 08:03:08PM +0100, Ilya Maximets wrote: > TL;DR OVS can not use Travis CI anymore. So, we need a new CI provider. > GitHub Actions looks like a sane replacement. Ilya, thank you for doing all of the research here and presenting all of it so thoroughly and clearly. It sound

Re: [ovs-dev] [PATCH net] net: openvswitch: fix TTL decrement action netlink message format

2020-11-23 Thread Matteo Croce
On Fri, Nov 20, 2020 at 10:12 PM Jakub Kicinski wrote: > > On Thu, 19 Nov 2020 04:04:04 -0500 Eelco Chaudron wrote: > > Currently, the openvswitch module is not accepting the correctly formated > > netlink message for the TTL decrement action. For both setting and getting > > the dec_ttl action, t

Re: [ovs-dev] TravisCI needs to be replaced.

2020-11-23 Thread Aaron Conole
Ilya Maximets writes: > Hi. > > TL;DR OVS can not use Travis CI anymore. So, we need a new CI provider. > GitHub Actions looks like a sane replacement. > > > As you, probably, noticed our Travis CI builds are taking lots of time to > start > and work. This is because of reduced capacity for tr

Re: [ovs-dev] [PATCH V3 1/4] Enable VXLAN TSO for DPDK datapath

2020-11-23 Thread Flavio Leitner
Hi Yi, On Mon, Nov 02, 2020 at 11:16:49AM +0800, yang_y_yi wrote: > > > Thanks a lot, Flavio, please check inline comments for more discussion. > > > > At 2020-10-31 01:55:57, "Flavio Leitner" wrote: > > > >Hi Yi, > > > >Thanks for the patch and sorry the delay to review it. > >See my comm

[ovs-dev] TravisCI needs to be replaced.

2020-11-23 Thread Ilya Maximets
Hi. TL;DR OVS can not use Travis CI anymore. So, we need a new CI provider. GitHub Actions looks like a sane replacement. As you, probably, noticed our Travis CI builds are taking lots of time to start and work. This is because of reduced capacity for travic-ci.org users. What happened to tr

Re: [ovs-dev] [PATCH v3] python: Update build system to ensure dirs.py is created

2020-11-23 Thread Mark Gray
On 19/11/2020 08:44, Mark Gray wrote: > Update build system to ensure dirs.py is created when it is a > dependency for a build target. Also, update setup.py to > check for that dependency. > > Signed-off-by: Mark Gray FWIW: Here is a link to a passing travis build: https://travis-ci.com/github/

Re: [ovs-dev] [PATCH ovn] binding: Cleanup gateway port local binding in runtime data.

2020-11-23 Thread Numan Siddique
On Fri, Nov 20, 2020 at 9:08 PM Dumitru Ceara wrote: > > When a port binding of type "l3gateway" is claimed its remote peer > port_binding is also stored in local_datapath.peer_ports[].remote. > > If the remote peer port_binding is deleted first (i.e., before the local > "l3gateway" one) then we n

Re: [ovs-dev] [PATCH] tests: Add overflow test for the sha1 library.

2020-11-23 Thread Paolo Valerio
Ilya Maximets writes: > This is a unit test for the overflow detection issue fixed by commit > a1d2c5f5d9ed ("sha1: Fix algorithm for data bigger than 512 megabytes.") > > Signed-off-by: Ilya Maximets > --- Acked-by: Paolo Valerio Tested-by: Paolo Valerio

Re: [ovs-dev] [PATCH] netlink: removed incorrect optimization

2020-11-23 Thread Cpp Code
I would expect such checks to be commented as indeed it was not clear why it was there. I looked in similar places where FLOW_TNL_F_UDPIF is used and there is no such check. The commit which created this condition is quite large so I am not able to conclude from that. I assume this is an optimizat

[ovs-dev] [PATCH] odp-util: Fix netlink message overflow with userdata.

2020-11-23 Thread Ilya Maximets
Too big userdata could overflow netlink message leading to out-of-bound memory accesses or assertion while formatting nested actions. Fix that by checking the saize and returning correct error code. Credit to OSS-Fuzz. Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=27640 Fixe

Re: [ovs-dev] [PATCH] ovsdb-idl: Fix iteration over tracked rows with no actual data.

2020-11-23 Thread Dumitru Ceara
On 11/23/20 9:37 AM, Ilya Maximets wrote: > When idl removes orphan rows, those rows are inserted into the > 'track_list'. This allows iterators such as *_FOR_EACH_TRACKED () to > return orphan rows that never had any data to the IDL user. In this > case, it is difficult for the user to understan

Re: [ovs-dev] [PATCH ovn 13/14] ovn-nbctl: Fix IP leak on failure of lr policy addition.

2020-11-23 Thread Numan Siddique
On Fri, Nov 20, 2020 at 11:35 PM Dumitru Ceara wrote: > > On 11/20/20 6:52 PM, Ilya Maximets wrote: > > On 11/20/20 6:12 PM, Dumitru Ceara wrote: > >> On 11/20/20 1:17 AM, Ilya Maximets wrote: > >>> Fixes: 742474bad730 ("ovn-nbctl: Enhance lr-policy-add to set the > >>> options.") > >>> Signed-of

[ovs-dev] [PATCH] ovsdb-idl: Fix iteration over tracked rows with no actual data.

2020-11-23 Thread Ilya Maximets
When idl removes orphan rows, those rows are inserted into the 'track_list'. This allows iterators such as *_FOR_EACH_TRACKED () to return orphan rows that never had any data to the IDL user. In this case, it is difficult for the user to understand whether it is a row with no data (there was no "