Re: [ovs-dev] [PATCH v2 3/3] ovsdb-idl: Fix use-after-free when deleting orphaned rows.

On Tue, Dec 1, 2020 at 12:36 AM Dumitru Ceara wrote: > > On Mon, Nov 30, 2020 at 9:18 PM Han Zhou wrote: > > > > > > > > On Mon, Nov 30, 2020 at 11:56 AM Ilya Maximets wrote: > > > > > > On 11/30/20 8:45 PM, Han Zhou wrote: > > > > > > > > > > > > On Mon, Nov 30, 2020 at 8:41 AM Dumitru Ceara ma

Re: [ovs-dev] [PATCH ovn] pinctrl: Honor always_learn_from_arp_request for self created MAC_Bindings.

On Tue, Dec 1, 2020 at 7:50 AM Dumitru Ceara wrote: > > On 12/1/20 2:29 PM, Numan Siddique wrote: > > On Tue, Dec 1, 2020 at 4:00 PM Dumitru Ceara wrote: > >> > >> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2020-November/377876.html > >> Reported-by: Renat Nurgaliyev > >> Sugges

[ovs-dev] [PATCH ovn] pinctrl.c: Fix always_learn_from_arp_request for self created MAC_Bindings.

Even when the option always_learn_from_arp_request is set to false for a logical router, stale entries in MAC_Binding table should still be updated. (This behavior is defined in the ovn-nb(5) for the option.) Fixes: fdf295d5eb3 ("pinctrl: Honor always_learn_from_arp_request for self created MAC_B

[ovs-dev] [PATCH 0/4] netdev datapath flush offloaded flows

Netdev datapath offloads are done in a separate thread, using messaging between the threads. With port removal there is a race between the offload thread removing the offloaded rules and the actual port removal, so some rules will not be removed. In OVS the offload objects are not freed (memory lea

[ovs-dev] [PATCH 2/4] netdev-offload-dpdk: Keep netdev in offload object

Keep the netdev of the offload rule as a field in the offload object as a pre-step towards support flushing of the offload rules. Signed-off-by: Eli Britstein Reviewed-by: Gaetan Rivet --- lib/netdev-offload-dpdk.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/

[ovs-dev] [PATCH 4/4] netdev-offload-dpdk: Implement flow flush

Remove all the rules for the specified netdev. Signed-off-by: Eli Britstein Reviewed-by: Gaetan Rivet --- lib/netdev-offload-dpdk.c | 17 + 1 file changed, 17 insertions(+) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index dece4fd06..c45dd3e90 100644 ---

[ovs-dev] [PATCH 1/4] dpif-netdev: Flush offload rules upon port deletion

When a port is deleted, flow deletion requests are posted, and the netdev is removed from offload netdevs map. Following flow deletion handling may be done after the netdev has already been removed from the offload netdevs map, so the HW rule is not removed and the data object is not freed (memory

[ovs-dev] [PATCH 3/4] netdev-offload-dpdk: Refactor disassociate and flow destroy

Refactor disassociation to be removed from flow destroy, and to use already found object instead of re-searching it. Signed-off-by: Eli Britstein Reviewed-by: Gaetan Rivet --- lib/netdev-offload-dpdk.c | 62 --- 1 file changed, 32 insertions(+), 30 deletions(

Re: [ovs-dev] [PATCH ovn v3] CI: Add github actions workflow.

On Wed, Dec 2, 2020 at 12:44 PM Numan Siddique wrote: > > On Wed, Dec 2, 2020 at 6:26 AM Mark Michelson wrote: > > > > Acked-by: Mark Michelson > > > > There are definitely some enhancements/changes this could use, but I > > think this makes for a perfectly fine first effort. With this, github >

Re: [ovs-dev] [PATCH ovn v3] CI: Add github actions workflow.

On Wed, Dec 2, 2020 at 6:26 AM Mark Michelson wrote: > > Acked-by: Mark Michelson > > There are definitely some enhancements/changes this could use, but I > think this makes for a perfectly fine first effort. With this, github > will build and run tests, failures are detected properly, and you ca

Re: [ovs-dev] [PATCH] Allow to create tunnel ports with the same config

On Tue, Dec 01, 2020 at 08:48:56PM -0500, Ihar Hrachyshka wrote: > Is there a good reason why netdev-dummy/ip4addr doesn't set local > routing entries for the new IP? Or is it just an oversight in > userspace routing implementation? Oh my. If I ever knew this, I don't now. I thought it was Pravi

[ovs-dev] [PATCH ovn v9 5/7] tests: Improve debuggability of tests.

These changes should make it easier to debug various tests. Signed-off-by: Ben Pfaff --- tests/ovn-controller-vtep.at | 17 +- tests/ovn-northd.at | 144 +--- tests/ovn.at | 413 --- tests/ovs-macros.at | 20 +- 4 files

[ovs-dev] [PATCH ovn v9 4/7] tests: Eliminate most "sleep" calls.

Many of these could be replaced by "ovn-nbctl sync". Some weren't really needed at all because they were adjacent to something that itself called sync or otherwise used --wait. Some were more appropriately done with explicit waits for what was really needed. I left some "sleep"s. Some were beca

[ovs-dev] [PATCH ovn v9 2/7] Export `VLOG_WARN` and `VLOG_ERR` from libovn for use in ddlog

From: Leonid Ryzhyk Export `ddlog_warn` and `ddlog_err` functions that are just wrappers around `VLOG_WARN` and `VLOG_ERR`. This is not ideal because the functions are exported by `ovn_util.c` and the resulting log messages use `ovn_util` as module name. More importantly, these functions do not

[ovs-dev] [PATCH ovn v9 0/7] Add DDlog implementation of ovn-northd

v9: - Add ddlog.stamp to BUILT_SOURCES, to fix the dependencies "for sure". - Rebase against ovn/master. - Port commit fdf295d5eb3a ("pinctrl: Honor always_learn_from_arp_request for self created MAC_Bindings.") - Update to work with and require v2 of the ovsdb-cs library (see https

[ovs-dev] [PATCH ovn v9 3/7] tests: Prepare for multiple northd types.

The idea is to run each test twice, once with ovn-northd, once with ovn-northd-ddlog. To do that, we add a macro OVN_FOR_EACH_NORTHD and bracket each test that uses ovn-northd in it. Signed-off-by: Ben Pfaff Acked-by: Dumitru Ceara --- tests/ovn-ic.at | 11 +- tests/ovn-macros.at | 96 ++

[ovs-dev] [PATCH ovn v9 6/7] tests: Add more checking to "3 HVs, 1 LS, 3 lports/HV" test.

Signed-off-by: Ben Pfaff --- tests/ovn.at | 32 ++-- 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 9b419ec3aa7a..6e396895826f 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -1838,42 +1838,38 @@ ovn_start # Turn on p

[ovs-dev] [PATCH ovn v9 1/7] ovs-sandbox: Print and check results of *ctl commands.

Otherwise when something hangs or goes wrong, it's not obvious what happened. Signed-off-by: Ben Pfaff --- tutorial/ovs-sandbox | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/tutorial/ovs-sandbox b/tutorial/ovs-sandbox index 1841776a476d..6

Re: [ovs-dev] [PATCH ovn 1/1] tests: Work around ovn-controller incremental processing bugs.

On Thu, Nov 26, 2020 at 06:35:44PM +0530, Numan Siddique wrote: > On Thu, Nov 26, 2020 at 11:30 AM Numan Siddique wrote: > > > > On Thu, Nov 26, 2020 at 10:54 AM Ben Pfaff wrote: > > > > > > On Wed, Nov 25, 2020 at 01:13:22PM +0530, Numan Siddique wrote: > > > > On Wed, Nov 25, 2020 at 4:21 AM Be

[ovs-dev] [PATCH v2 7/8] ovsdb-cs: New module that factors out code from ovsdb-idl.

This new module has a single direct user now. In the future, it will also be used by OVN. Signed-off-by: Ben Pfaff --- lib/automake.mk | 2 + lib/ovsdb-cs.c | 326 +++ lib/ovsdb-cs.h | 70 lib/ovsdb-idl.c | 442 --

[ovs-dev] [PATCH v2 6/8] ovsdb-idl: Add comment.

Signed-off-by: Ben Pfaff --- lib/ovsdb-idl.c | 8 1 file changed, 8 insertions(+) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index 5502fdab8644..e1013da86c56 100644 --- a/lib/ovsdb-idl.c +++ b/lib/ovsdb-idl.c @@ -617,6 +617,14 @@ ovsdb_idl_destroy(struct ovsdb_idl *idl) } }

[ovs-dev] [PATCH v2 5/8] ovsdb-idl: Improve prototypes.

Adding parameter names makes these prototypes clearer. Signed-off-by: Ben Pfaff --- lib/ovsdb-idl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ovsdb-idl.h b/lib/ovsdb-idl.h index 789337df9f33..05bb48d66c3f 100644 --- a/lib/ovsdb-idl.h +++ b/lib/ovsdb-idl.h @@ -62

[ovs-dev] [PATCH v2 1/8] jsonrpc: Avoid disconnecting prematurely due to long poll intervals.

Open vSwitch has a few different jsonrpc-based protocols that depend on jsonrpc_session to make sure that the connection is up and working. In turn, jsonrpc_session uses the "reconnect" state machine to send probes if nothing is received. This works fine in normal circumstances. In unusual circums

[ovs-dev] [PATCH v2 4/8] ovsdb-idl: Remove prototype for function that is not defined or used.

Signed-off-by: Ben Pfaff --- lib/ovsdb-idl.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/ovsdb-idl.h b/lib/ovsdb-idl.h index a1a577664e8e..789337df9f33 100644 --- a/lib/ovsdb-idl.h +++ b/lib/ovsdb-idl.h @@ -76,7 +76,6 @@ void ovsdb_idl_set_lock(struct ovsdb_idl *, const char *lock_nam

[ovs-dev] [PATCH v2 3/8] ovsdb-idl: Fix memory leak sending messages without a session.

When there's no open session, we still have to free the messages that we make but cannot send. I'm not confident that these fix actual bugs, because it seems possible that these code paths can only be hit when the session is nonnull. Signed-off-by: Ben Pfaff --- lib/ovsdb-idl.c | 10 --

[ovs-dev] [PATCH v2 2/8] ovsdb-idl: Avoid redundant clearing and parsing of received data.

ovsdb_idl_db_parse_monitor_reply() clears the IDL and parses the received data. There's no need to do it again afterward. Signed-off-by: Ben Pfaff Fixes: 1b1d2e6daa56 ("ovsdb: Introduce experimental support for clustered databases.") --- lib/ovsdb-idl.c | 3 --- 1 file changed, 3 deletions(-)

[ovs-dev] [PATCH v2 0/8] Refactor OVSDB IDL into two layers

This series breaks the IDL into two layers: the IDL proper, whose interface to its client is unchanged, and a low-level library called the OVSDB "client synchronization" (CS) library. There are two reasons for this change. First, the IDL is big and complicated and I think that this change factors

[ovs-dev] May I ask why youre so unhappy with your size? Can we fix it?? Cheap Trump Meds.

The Golconda weelderige mag zeer vogel lucht. Bezocht Oog Onderwoeld. Monopolie zoo prijs geplant vloeit toe staatjes versteend. gaat zoo procede zeggen kriang Koel dikte rijk personeel kintya kemming koeken koel. Sombere zou wasschen schippers dien gestookt. liep europeesch zou gezift of.

Re: [ovs-dev] [PATCH] Allow to create tunnel ports with the same config

Hi Ben, I was trying to make local_ip work for my needs and hit some unexpected connectivity loss between tunnel endpoints when source IPs enforced in port config. Perhaps there's something I am missing about using local_ip with ovs userspace routing. Perhaps you'll be able to validate my thinking

Re: [ovs-dev] [PATCH ovn v3] CI: Add github actions workflow.

Acked-by: Mark Michelson There are definitely some enhancements/changes this could use, but I think this makes for a perfectly fine first effort. With this, github will build and run tests, failures are detected properly, and you can find the details of the failures by navigating to the githu

[ovs-dev] Hack your brain. See what the elite use.

The de duim vroeger tapioca ouder Hij weinige heb engeland wording luister recht maar. ontdaan wij volledige Kooplieden ten terreinen. met behoeven zoon vinden alle. zesde alle javanen plantte rijst weer mensch hout parijs bordeaux lama tot resideert telde Lezers bewogen bak. rijk nadering

[ovs-dev] You Should Know: 1 in 3 Americans suffer from mental slowness that CAN be fixed.

The Een spijt betaald ontdaan dus perzische handen holte. terug Geld was Weelderige gold Wakkeren gaat rook. pagoden gevoerd schaal betaalt houweel bijeen. acre ketting moet Niets welks stof. valorem alles werkt dier. tijgers dekt telde den naast europeesch diep zooveel gold rijker. wel s

[ovs-dev] Visa Raised Interchange & Processing Fees. Cash Discount for $24.99/mo Flat-Fee.

Paying more than $500/month in Visa/MasterCard Credit Card Processing Fees? Give me 3 minutes to explain your alternative. 1) How much of your profit margin is 'spent' on fees every month? Tired of paying? Your processor isn' t telling you about all the available options. Why don'

[ovs-dev] Merchant? Accept credit cards? Unlimited Processing - Flat-Fee $24.99/mo - Free Equipment and 0.79% for 2021

Paying more than $500/month in Visa/MasterCard Credit Card Processing Fees? Give me 3 minutes to explain your alternative. 1) How much of your profit margin is 'spent' on fees every month? Tired of paying? Your processor isn' t telling you about all the available options. Why don'

Re: [ovs-dev] [RFC PATCH v1 1/1] dpdk: Update to use DPDK v20.11.

> Some suggestions for rebasing now that GHA are in the master branch. > Thanks for the feedback David, re-working a v2 now and just waiting on the GHA build to complete before submitting the v2. Minor comments inline. > A small note: $HOME is world writable in GHA envs, this triggers a > dpdk

Re: [ovs-dev] Established businesses - $24.99/mo credit card processing - unlimited flat-fee

Paying more than $500/month in Visa/MasterCard Credit Card Processing Fees? Give me 3 minutes to explain your alternative. 1) How much of your profit margin is 'spent' on fees every month? Tired of paying? Your processor isn' t telling you about all the available options. Why don'

Re: [ovs-dev] [PATCH ovn branch-20.09] pinctrl: Honor always_learn_from_arp_request for self created MAC_Bindings.

On Tue, Dec 1, 2020 at 9:19 PM Dumitru Ceara wrote: > > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-dev/2020-November/377876.html > Reported-by: Renat Nurgaliyev > Suggested-by: Han Zhou > Fixes: a2b88dc51365 ("pinctrl: Directly update MAC_Bindings created by self > originated GA

[ovs-dev] Normatividad de la STPS.

Webinar en Vivo: NOM-035 PASO A PASO: Implementación exprés Viernes 11 de Diciembre- Horario de 10:00 a 17:00 Hrs - CURSO ESPECIAL Proporcionaremos a los participantes las herramientas y metodologías más apropiadas para elaborar e implementar planes de acción que contribuyan al desarrollo de e

[ovs-dev] helo

I've invited you to fill out the following form: Untitled form To fill it out, visit: https://docs.google.com/forms/d/e/1FAIpQLSfLTPe2iFSNGbs421_EIOoWogjvWPpdkaLg-mHoCJ654hSNWQ/viewform?vc=0&c=0&w=1&flr=0&usp=mail_form_link Dear Friend I am Eustace Robert James , Manager Finance and Account, Sh

[ovs-dev] ATTN Credit Score: Your Account May Have Changed

The zoon zetel marmer spuwen hun verscholen tijdens gesteld. groeien doel dank schaarsch kaal terreinen nog Elk. hoogere anson Geldt meest aangaat soorten. van behalen zee besluit omhoog de. verder rijkdom wegen hand. goping twee binnen open noemen arabieren tijd gezocht sap later. zoon co

Re: [ovs-dev] [PATCH ovn branch-20.09] pinctrl: Honor always_learn_from_arp_request for self created MAC_Bindings.

Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./ovn -I ./include -I /var/lib

Re: [ovs-dev] [PATCH ovn] pinctrl: Honor always_learn_from_arp_request for self created MAC_Bindings.

On 12/1/20 2:29 PM, Numan Siddique wrote: > On Tue, Dec 1, 2020 at 4:00 PM Dumitru Ceara wrote: >> >> Reported-at: >> https://mail.openvswitch.org/pipermail/ovs-dev/2020-November/377876.html >> Reported-by: Renat Nurgaliyev >> Suggested-by: Han Zhou >> Fixes: a2b88dc51365 ("pinctrl: Directly up

[ovs-dev] [PATCH ovn branch-20.09] pinctrl: Honor always_learn_from_arp_request for self created MAC_Bindings.

Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2020-November/377876.html Reported-by: Renat Nurgaliyev Suggested-by: Han Zhou Fixes: a2b88dc51365 ("pinctrl: Directly update MAC_Bindings created by self originated GARPs.") Signed-off-by: Dumitru Ceara (cherry-picked from master co

[ovs-dev] DEAR FRIEND,

I've invited you to fill in the following form: Untitled form To fill it in, visit: https://docs.google.com/forms/d/e/1FAIpQLSfi2v_QwY_KtQFRSv66gKQXWIyn7sbvAx1_r8wjAat6yYUKUw/viewform?vc=0&c=0&w=1&flr=0&usp=mail_form_link Dear, I am Engr Uduak Walter Onnoghen, the son of the recently suspended

Re: [ovs-dev] [PATCH ovn] pinctrl: Honor always_learn_from_arp_request for self created MAC_Bindings.

On Tue, Dec 1, 2020 at 4:00 PM Dumitru Ceara wrote: > > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-dev/2020-November/377876.html > Reported-by: Renat Nurgaliyev > Suggested-by: Han Zhou > Fixes: a2b88dc51365 ("pinctrl: Directly update MAC_Bindings created by self > originated GA

Re: [ovs-dev] Scaling of Logical_Flows and MAC_Binding tables

On Tue, Dec 01, 2020 at 11:41:29AM +0100, Dumitru Ceara wrote: > On 12/1/20 10:41 AM, Renat Nurgaliyev wrote: > > On Mon, Nov 30, 2020 at 12:28:56PM -0800, Han Zhou wrote: > >> On Mon, Nov 30, 2020 at 12:13 PM Renat Nurgaliyev > >> wrote: > >>> > >>> On 30.11.20 07:07, Numan Siddique wrote: >

Re: [ovs-dev] [PATCH ovn 2/2] tests: Enable memory leak checking when running with AddressSanitizer.

On Wed, Nov 25, 2020 at 8:31 PM Dumitru Ceara wrote: > > Recent commits cleaned up most of the minor leaks that would've made > tests with AddressSanitizer memory leak checking enabled fail. It > should be safe (and useful) to check for memory leaks by default. > > Signed-off-by: Dumitru Ceara

Re: [ovs-dev] Scaling of Logical_Flows and MAC_Binding tables

On 12/1/20 10:41 AM, Renat Nurgaliyev wrote: > On Mon, Nov 30, 2020 at 12:28:56PM -0800, Han Zhou wrote: >> On Mon, Nov 30, 2020 at 12:13 PM Renat Nurgaliyev >> wrote: >>> >>> On 30.11.20 07:07, Numan Siddique wrote: On Mon, Nov 30, 2020 at 7:37 AM Han Zhou wrote: > On Sat, Nov 28, 2020

[ovs-dev] [PATCH ovn] pinctrl: Honor always_learn_from_arp_request for self created MAC_Bindings.

Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2020-November/377876.html Reported-by: Renat Nurgaliyev Suggested-by: Han Zhou Fixes: a2b88dc51365 ("pinctrl: Directly update MAC_Bindings created by self originated GARPs.") Signed-off-by: Dumitru Ceara --- controller/pinctrl.c | 7

Re: [ovs-dev] Scaling of Logical_Flows and MAC_Binding tables

On Mon, Nov 30, 2020 at 12:28:56PM -0800, Han Zhou wrote: > On Mon, Nov 30, 2020 at 12:13 PM Renat Nurgaliyev > wrote: > > > > On 30.11.20 07:07, Numan Siddique wrote: > > > On Mon, Nov 30, 2020 at 7:37 AM Han Zhou wrote: > > >> On Sat, Nov 28, 2020 at 12:31 PM Tony Liu > wrote: > > >>> Hi Renat

[ovs-dev] Respond Urgently

___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 3/3] ovsdb-idl: Fix use-after-free when deleting orphaned rows.

On Mon, Nov 30, 2020 at 9:18 PM Han Zhou wrote: > > > > On Mon, Nov 30, 2020 at 11:56 AM Ilya Maximets wrote: > > > > On 11/30/20 8:45 PM, Han Zhou wrote: > > > > > > > > > On Mon, Nov 30, 2020 at 8:41 AM Dumitru Ceara > > > wrote: > > >> > > >> It's possible that the I

Re: [ovs-dev] Scaling of Logical_Flows and MAC_Binding tables

On Mon, Nov 30, 2020 at 11:11 PM Anil Vishnoi wrote: > > On Mon, Nov 30, 2020 at 9:26 PM Han Zhou wrote: > > > > > > > > On Mon, Nov 30, 2020 at 8:22 PM Anil Vishnoi wrote: > > > > > > I am just wondering if MAC_Binding table entries can expire after a > > > certain timeout will help here? Just