[ovs-dev] STPS - Seguridad y Salud en el trabajo.

2020-12-11 Thread Norma Oficial Mexicana - 030
Buenos días: Quise aprovechar la oportunidad de hacerle una invitación para tomar nuestro curso: Nombre: NOM-030, Servicios preventivos de Seguridad y Salud en el trabajo. Horario: 10 a 14 Hrs. ¿Cuándo?: Jueves 28 de enero Formato: En línea con interacción en vivo. Lugar: En Vivo desde su comput

Re: [ovs-dev] Votre Carte Cadeau !

2020-12-11 Thread SHEIN
___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] ovsdb: Use column diffs for ovsdb and raft log entries.

2020-12-11 Thread Ilya Maximets
Currently, ovsdb-server stores complete value for the column in a database file and in a raft log in case this column changed. This means that transaction that adds, for example, one new acl to a port group creates a log entry with all UUIDs of all existing acls + one new. Same for ports in logic

[ovs-dev] I need your urgent help

2020-12-11 Thread liliyohans200
I've invited you to fill out the following form: Untitled form To fill it out, visit: https://docs.google.com/forms/d/e/1FAIpQLSfh7_PKeUfO34aELmeQQ5av02Sb42IKA6numrt9IM8EsbdnEQ/viewform?vc=0&c=0&w=1&flr=0&usp=mail_form_link Hello Please excuse this humble email if it offends your sensibilities;

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Add ECMP support to router policies.

2020-12-11 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #680 FILE: utilities/ovn-nbctl.c:710: lr-pol

[ovs-dev] [PATCH ovn v3 2/2] northd: Add ECMP support to router policies.

2020-12-11 Thread numans
From: Numan Siddique A user can add a policy now like: ovn-nbctl lr-policy-add 100 "ip4.src == 10.0.0.4" reroute 172.0.0.5,172.0.0.6 We do have ECMP support for logical router static routes, but since policies are applied after the routing stage, ECMP support for policies is desired by ovn-ku

[ovs-dev] [PATCH ovn v3 1/2] Add missing documentation for router policy and ecmp sym reply stage.

2020-12-11 Thread numans
From: Numan Siddique Fixes: df4f37ea7f82("Policy-based routing (PBR) in OVN.) Fixes: a123ef0fb8fd("Support packet metadata marking for logical router policies.") Fixes: 4fdca656857d("Add ECMP symmetric replies.") Signed-off-by: Numan Siddique --- v1 -> v2 -> v3 -- * No changes.

Re: [ovs-dev] [PATCH ovn v2 2/2] northd: Add ECMP support to router policies.

2020-12-11 Thread Numan Siddique
On Fri, Dec 11, 2020 at 9:50 PM Mark Michelson wrote: > > Hi Numan, > > In general, this looks good, but there is some "hardening" this could > stand to have. I'll detail it more below. > > On 12/11/20 9:32 AM, num...@ovn.org wrote: > > From: Numan Siddique > > > > A user can add a policy now lik

[ovs-dev] [PATCH ovn v3] northd: Fix datapath swapping in logical flows.

2020-12-11 Thread Ilya Maximets
Commit that introduced support for logical datapath groups removed the 'logical_datapath' column from the lflow hash. If datapath groups disabled, there will be many flows that are same except for the 'logical_datapath' column, so they will have exactly same hash. Since 'logical_datapath' is not i

Re: [ovs-dev] [PATCH ovn v2] northd: Fix datapath swapping in logical flows.

2020-12-11 Thread Ilya Maximets
On 12/11/20 6:27 PM, Dumitru Ceara wrote: > On 12/11/20 12:36 PM, Ilya Maximets wrote: >> Commit that introduced support for logical datapath groups removed >> the 'logical_datapath' column from the lflow hash. If datapath groups >> disabled, there will be many flows that are same except for the >

Re: [ovs-dev] [PATCH ovn v2] northd: Fix datapath swapping in logical flows.

2020-12-11 Thread Dumitru Ceara
On 12/11/20 12:36 PM, Ilya Maximets wrote: > Commit that introduced support for logical datapath groups removed > the 'logical_datapath' column from the lflow hash. If datapath groups > disabled, there will be many flows that are same except for the > 'logical_datapath' column, so they will have e

Re: [ovs-dev] [PATCH ovn v2 2/2] northd: Add ECMP support to router policies.

2020-12-11 Thread Mark Michelson
Hi Numan, In general, this looks good, but there is some "hardening" this could stand to have. I'll detail it more below. On 12/11/20 9:32 AM, num...@ovn.org wrote: From: Numan Siddique A user can add a policy now like: ovn-nbctl lr-policy-add 100 "ip4.src == 10.0.0.4" reroute 172.0.0.5,

Re: [ovs-dev] [PATCH 1/2] dpif_netlink: Add struct dp_netlink in dpif netlink layer

2020-12-11 Thread Ilya Maximets
On 12/10/20 9:43 AM, Roi Dayan wrote: > From: Jianbo Liu > > Add sturct dp_netlink, and globally used varibles in dpif_netlik layer > can be stored in it. The implementation is just like dp_netdev. > > Signed-off-by: Jianbo Liu > Reviewed-by: Roi Dayan > --- > lib/dpif-netlink.c | 72 > +

Re: [ovs-dev] [PATCH ovn v2 2/2] northd: Add ECMP support to router policies.

2020-12-11 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #679 FILE: utilities/ovn-nbctl.c:710: lr-pol

Re: [ovs-dev] [PATCH ovn 2/2] northd: Add ECMP support to router policies.

2020-12-11 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #679 FILE: utilities/ovn-nbctl.c:710: lr-pol

Re: [ovs-dev] [PATCH ovn] debian: fix debian packaging and remove ovs files

2020-12-11 Thread 0-day Robot
Bleep bloop. Greetings 万俊杰, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: corrupt patch at line 249 error: could not build fake ancestor hint: Use 'git am --show-current-patch'

Re: [ovs-dev] [PATCH ovn v9 7/7] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.

2020-12-11 Thread Dumitru Ceara
On 12/2/20 7:50 AM, Ben Pfaff wrote: > From: Leonid Ryzhyk > > This implementation is incremental, meaning that it only recalculates > what is needed for the southbound database when northbound changes > occur. It is expected to scale better than the C implementation, > for large deployments. (

[ovs-dev] [PATCH ovn v2 2/2] northd: Add ECMP support to router policies.

2020-12-11 Thread numans
From: Numan Siddique A user can add a policy now like: ovn-nbctl lr-policy-add 100 "ip4.src == 10.0.0.4" reroute 172.0.0.5,172.0.0.6 We do have ECMP support for logical router static routes, but since policies are applied after the routing stage, ECMP support for policies is desired by ovn-ku

[ovs-dev] [PATCH ovn v2 1/2] Add missing documentation for router policy and ecmp sym reply stage.

2020-12-11 Thread numans
From: Numan Siddique Fixes: df4f37ea7f82("Policy-based routing (PBR) in OVN.) Fixes: a123ef0fb8fd("Support packet metadata marking for logical router policies.") Fixes: 4fdca656857d("Add ECMP symmetric replies.") Signed-off-by: Numan Siddique --- northd/ovn-northd.8.xml | 86 +

[ovs-dev] [PATCH ovn 2/2] northd: Add ECMP support to router policies.

2020-12-11 Thread numans
From: Numan Siddique A user can add a policy now like: ovn-nbctl lr-policy-add 100 "ip4.src == 10.0.0.4" reroute 172.0.0.5,172.0.0.6 We do have ECMP support for logical router static routes, but since policies are applied after the routing stage, ECMP support for policies is desired by ovn-ku

[ovs-dev] [PATCH ovn 1/2] Add missing documentation for router policy and ecmp sym reply stage.

2020-12-11 Thread numans
From: Numan Siddique Fixes: df4f37ea7f82("Policy-based routing (PBR) in OVN.) Fixes: a123ef0fb8fd("Support packet metadata marking for logical router policies.") Fixes: 4fdca656857d("Add ECMP symmetric replies.") Signed-off-by: Numan Siddique --- northd/ovn-northd.8.xml | 86 +

Re: [ovs-dev] [PATCH 2/2] dpif-netlink: Fix issues of the offloaded flows counter

2020-12-11 Thread Ilya Maximets
On 12/10/20 9:43 AM, Roi Dayan wrote: > From: Jianbo Liu > Hi. This is not a full review. Some comments inline. Best regards, Ilya Maximets. > The n_offloaded_flows counter is saved in dpif, and this is the > first one when ofproto is created. When flow operation is done by > ovs-appctl comma

[ovs-dev] [PATCH ovn] debian: fix debian packaging and remove ovs files

2020-12-11 Thread 万俊杰
Remove all openvswitch package files and rename the packages with prefix ovn-. Ovs debs would not be packed in ovn anymore. Add a build option DATAPATH_CONFIGURE_OPTS. Like openvswitch, use '-with-ovs-source=' to pass the ovs source directory. To get ovn deb packages, you should build ovs source

Re: [ovs-dev] [PATCH v2 ovn 5/5] ovn: integrate bfd for static routes

2020-12-11 Thread 0-day Robot
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operat

Re: [ovs-dev] [PATCH ovn v9 6/7] tests: Add more checking to "3 HVs, 1 LS, 3 lports/HV" test.

2020-12-11 Thread Dumitru Ceara
On 12/2/20 7:50 AM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- Looks good to me, thanks! Acked-by: Dumitru Ceara ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn v9 5/7] tests: Improve debuggability of tests.

2020-12-11 Thread Dumitru Ceara
On 12/2/20 7:50 AM, Ben Pfaff wrote: > These changes should make it easier to debug various tests. > > Signed-off-by: Ben Pfaff > --- Looks good to me, thanks! Acked-by: Dumitru Ceara ___ dev mailing list d...@openvswitch.org https://mail.openvswitc

Re: [ovs-dev] [PATCH ovn v9 4/7] tests: Eliminate most "sleep" calls.

2020-12-11 Thread Dumitru Ceara
On 12/2/20 7:50 AM, Ben Pfaff wrote: > Many of these could be replaced by "ovn-nbctl sync". Some weren't > really needed at all because they were adjacent to something that itself > called sync or otherwise used --wait. Some were more appropriately > done with explicit waits for what was really n

Re: [ovs-dev] [PATCH ovn v9 2/7] Export `VLOG_WARN` and `VLOG_ERR` from libovn for use in ddlog

2020-12-11 Thread Dumitru Ceara
On 12/2/20 7:50 AM, Ben Pfaff wrote: > From: Leonid Ryzhyk > > Export `ddlog_warn` and `ddlog_err` functions that are just wrappers > around `VLOG_WARN` and `VLOG_ERR`. This is not ideal because the > functions are exported by `ovn_util.c` and the resulting log messages use > `ovn_util` as modul

Re: [ovs-dev] [PATCH ovn v9 1/7] ovs-sandbox: Print and check results of *ctl commands.

2020-12-11 Thread Dumitru Ceara
On 12/2/20 7:50 AM, Ben Pfaff wrote: > Otherwise when something hangs or goes wrong, it's not obvious what > happened. > > Signed-off-by: Ben Pfaff > --- Looks good to me, thanks! Acked-by: Dumitru Ceara ___ dev mailing list d...@openvswitch.org htt

[ovs-dev] [PATCH v2 ovn 3/5] controller: bfd: introduce BFD state machine

2020-12-11 Thread Lorenzo Bianconi
Introduce BFD state machine for BFD packet parsing according to RFC880 https://tools.ietf.org/html/rfc5880. Introduce BFD logical flows in ovn-northd. Add BFD tests in system-ovn.at. Signed-off-by: Lorenzo Bianconi --- NEWS| 2 + controller/pinctrl.c| 281 ++

[ovs-dev] [PATCH v2 ovn 4/5] bfp: support demand mode on rx side

2020-12-11 Thread Lorenzo Bianconi
Introduce rx demand mode support according to RFC5880 [0]. Demand mode on tx side is not supported yet. [0] https://tools.ietf.org/html/rfc5880 Signed-off-by: Lorenzo Bianconi --- controller/pinctrl.c | 106 +++ 1 file changed, 68 insertions(+), 38 deletio

[ovs-dev] [PATCH v2 ovn 5/5] ovn: integrate bfd for static routes

2020-12-11 Thread Lorenzo Bianconi
Introduce the --bfd option for ovn static routes in order to check if the next-hop is properly running using the BFD protocol. E.g: $ovn-nbctl --bfd lr-route-add lr0 10.0.0.0/8 172.16.0.50 Add BFD static routes tests in system-ovn.at/ovn-nbctl.at. Signed-off-by: Lorenzo Bianconi --- NEWS

[ovs-dev] [PATCH v2 ovn 1/5] controller: introduce BFD tx path in ovn-controller

2020-12-11 Thread Lorenzo Bianconi
Introduce the capability to transmit BFD packets in ovn-controller. Introduce BFD tables in nb/sb dbs in order to configure BFD parameters (e.g. min_tx, min_rx, ..) for ovn-controller. Signed-off-by: Lorenzo Bianconi --- controller/ovn-controller.c | 1 + controller/pinctrl.c| 288

[ovs-dev] [PATCH v2 ovn 2/5] action: introduce handle_bfd_msg() action

2020-12-11 Thread Lorenzo Bianconi
Add handle_bfd_msg() action to parse BFD packets received by the controller. handle_bfd_msg() logic is currently empty and it will be implemented adding BFD state machine in the following patches. Signed-off-by: Lorenzo Bianconi --- controller/pinctrl.c | 15 +++ include/ovn/actions

[ovs-dev] [PATCH v2 ovn 0/5] introduce BFD support in ovn-controller

2020-12-11 Thread Lorenzo Bianconi
Introduce BFD protocol in ovn-controller according to RFC5880 [0] We added BFD implementation in ovn since layered protocols usually request to enable it on ovn entities (e.g. logical router ports) while ovs implementation relies on physical entities (e.g. ovs interfaces). Moreover we would establi

Re: [ovs-dev] [PATCH ovn] chassis: Do not try to guess system-id changes.

2020-12-11 Thread Numan Siddique
On Thu, Dec 10, 2020 at 3:28 AM Mark Michelson wrote: > > Acked-by: Mark Michelson Thanks Dumitru and Mark. I applied this patch to the main branch and backported to branch-20.12. Can you please submit backport patches for the remaining branches. It doesn't apply cleanly. Thanks Numan > > On

[ovs-dev] TKX

2020-12-11 Thread miss MAA
Good morning, Please this message is about a Billionaire your country who I presume to be your relative because of the similarities in your last names.He happened to be one of the personalities I have worked with while he was an investor with our bank. In 2003 the subject matter came to our

[ovs-dev] [PATCH ovn v2] northd: Fix datapath swapping in logical flows.

2020-12-11 Thread Ilya Maximets
Commit that introduced support for logical datapath groups removed the 'logical_datapath' column from the lflow hash. If datapath groups disabled, there will be many flows that are same except for the 'logical_datapath' column, so they will have exactly same hash. Since 'logical_datapath' is not i

[ovs-dev] [PATCH ovn v2 2/3] nbctl: Use partial set updates instead of re-setting the whole column.

2020-12-11 Thread Ilya Maximets
Northbound database has many tables that could contain columns with very large sets. For example 'ports' column of the 'Logical_Switch' table could contain thousands of ports in a set. Current strategy of nbctl while adding a new port to the set is to copy all existing ports, add one and set the

[ovs-dev] [PATCH ovn v2 3/3] nbctl: Remove column verification for partial updates.

2020-12-11 Thread Ilya Maximets
Since this is not a read-modify-write sequence, it's not strictly necessary to verify that current value is exactly same while performing mutations. Verification removal will allow to significantly reduce size of ovsdb transaction, because it will no longer contain all the data from the mutated co

[ovs-dev] [PATCH ovn v2 1/3] nbctl: Cache to which switch or router particular port belongs.

2020-12-11 Thread Ilya Maximets
nbctl always iterates over all ports in all logical switches or routers to find to which logical router/switch current port belongs. This could be optimized by iterating only once and caching the current state. This should improve a little bit performance of this utility in case where many update

[ovs-dev] [PATCH ovn v2 0/3] nbctl: Use mutations to update sets.

2020-12-11 Thread Ilya Maximets
Version 2: * Hash maps renamed to avoid name collision: lsp_to_ls --> lsp_to_ls_map lrp_to_lr --> lrp_to_lr_map * Removed unused variable from the patch #2. * Added ACK from Dumitru to the patch #1 and from Mark to the patch #2. * Added patch #3 to remove unnecessary

[ovs-dev] [PATCH ovn] lflow: Relax the condition that detects Load_Balancer hairpin.

2020-12-11 Thread Dumitru Ceara
Commit fc219d84b667 [0] optimized Load Balancer hairpin support from an OVN Southbound perspective by moving generation of flows to detect hairpin traffic in ovn-controller. However, this can be further optimized by relaxing the condition for flows that detect hairpin traffic in the "original" dir

Re: [ovs-dev] [PATCH v2 1/1] dpdk: Update to use DPDK v20.11.

2020-12-11 Thread Richardson, Bruce
> -Original Message- > From: Ilya Maximets > Sent: Thursday, December 10, 2020 4:26 PM > To: Luca Boccassi ; Ilya Maximets ; > Richardson, Bruce ; Stokes, Ian > ; d...@openvswitch.org > Cc: ktray...@redhat.com; david.march...@redhat.com; Pai G, Sunil > ; el...@nvidia.com; > christian.eh

Re: [ovs-dev] [PATCH v3 ovn] northd: add reject action for lb with no backends

2020-12-11 Thread Numan Siddique
On Thu, Dec 10, 2020 at 3:18 AM Mark Michelson wrote: > > Acked-by: Mark Michelson Thanks Lorenzo for v2 and Mark. I applied this patch to master. Numan > > On 12/9/20 6:25 AM, Lorenzo Bianconi wrote: > > Introduce the capability to create a load balancer with no backends and > > with --reject