[ovs-dev] [PATCH] dpctl: fix dpctl process command parameter error

2020-12-14 Thread Mao YingMing
fix the following error: """ $ ovs-appctl dpctl/dump-conntrack -m -s system@ovs-system zone=0 "dpctl/dump-conntrack" command takes at most 2 arguments ovs-appctl: ovs-vswitchd: server returned an error $ ovs-appctl dpctl/dump-flows -m --names system@ovs-system filter=in_port\(2\) type=ovs

[ovs-dev] [PATCH] dpctl: fix dpctl process command parameter error

2020-12-14 Thread Mao,Yingming
From: Mao YingMing mailto:maoyingm...@baidu.com>> fix the following error: """ $ ovs-appctl dpctl/dump-conntrack -m -s system@ovs-system zone=0 "dpctl/dump-conntrack" command takes at most 2 arguments ovs-appctl: ovs-vswitchd: server returned an error $ ovs-appctl dpctl/dump-flows -m

Re: [ovs-dev] [PATCH ovn 3/3] utilities: add conditional {start/stop}_ic_ovsdb on start_ic command

2020-12-14 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 87 characters long (recommended limit is 79) #56 FILE:

Re: [ovs-dev] [PATCH ovn 2/3] rhel: add systemd-unit for ovn-ic

2020-12-14 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 143 characters long (recommended limit is 79) #145 FILE:

[ovs-dev] [PATCH ovn 3/3] utilities: add conditional {start/stop}_ic_ovsdb on start_ic command

2020-12-14 Thread numans
From: Vladislav Odintsov This commit adds capability to start and stop ovsdb-server for OVN interconnection when {start,stop}_ic is called. It changes previous behavior where {start,stop}_ic only started/stopped ovn-ic daemon without ovn-ic DBs. If one wants to save previous behavior,

[ovs-dev] [PATCH ovn 2/3] rhel: add systemd-unit for ovn-ic

2020-12-14 Thread numans
From: Vladislav Odintsov This commit adds new systemd-unit `ovn-ic.service` to manage OVN Interconnection daemons using systemd. Signed-off-by: Vladislav Odintsov --- rhel/automake.mk | 1 + rhel/ovn-fedora.spec.in| 20 --

[ovs-dev] [PATCH ovn 1/3] utilities: fix typo in ovn-ctl

2020-12-14 Thread numans
From: Vladislav Odintsov Signed-off-by: Vladislav Odintsov --- utilities/ovn-ctl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl index c44201ccf..111930886 100755 --- a/utilities/ovn-ctl +++ b/utilities/ovn-ctl @@ -937,7 +937,7 @@

Re: [ovs-dev] [PATCH v2] dpif-netlink: Fix issues of the offloaded flows counter

2020-12-14 Thread Jianbo Liu
The 12/15/2020 04:50, Jianbo Liu wrote: > The n_offloaded_flows counter is saved in dpif, and this is the first > one when ofproto is created. When flow operation is done by ovs-appctl > commands, such as, dpctl/add-flow, a new dpif is opened, and the > n_offloaded_flows in it can't be used. So,

Re: [ovs-dev] [PATCH ovn v3 1/2] Add missing documentation for router policy and ecmp sym reply stage.

2020-12-14 Thread Numan Siddique
On Mon, Dec 14, 2020 at 11:35 PM Mark Michelson wrote: > > For the series, > > Acked-by: Mark Michelson > > I think patch 1 should go into the 20.12 branch in addition to going > into master. > Thanks for the reviews. I applied the series to master and the 1st patch to branch-20.12. I also

[ovs-dev] [PATCH v2] dpif-netlink: Fix issues of the offloaded flows counter

2020-12-14 Thread Jianbo Liu
The n_offloaded_flows counter is saved in dpif, and this is the first one when ofproto is created. When flow operation is done by ovs-appctl commands, such as, dpctl/add-flow, a new dpif is opened, and the n_offloaded_flows in it can't be used. So, instead of using counter, the number of offloaded

Re: [ovs-dev] [PATCH dpdk-latest v4] build: Add support for DPDK meson build.

2020-12-14 Thread Tonghao Zhang
On Thu, Sep 3, 2020 at 2:06 AM Sunil Pai G wrote: > > Make based build is deprecated in DPDK. Meson based > build to be used for future DPDK releases. > > This updates travis, configure script and documentation > for using DPDK Meson with OVS. > > Tested-at:

[ovs-dev] [PATCH v9 08/11] netdev-offload-tc: Introduce group ID management API

2020-12-14 Thread Chris Mi
When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to kernel instead of the sFlow info. psample will send this ID and sampled packet to userspace. Using the ID, userspace can recover the sFlow info and send sampled packet to

[ovs-dev] [PATCH v9 11/11] netdev-offload-tc: Add offload support for sFlow

2020-12-14 Thread Chris Mi
Create a unique group ID to map the sFlow info when offloading sFlow action to TC. When showing the offloaded datapath flows, translate the group ID from TC sample action to sFlow info using the mapping. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/netdev-offload-tc.c | 171

[ovs-dev] [PATCH v9 10/11] netdev-offload-tc: Add psample receive handler

2020-12-14 Thread Chris Mi
Create a dedicated thread to poll psample netlink socket, receive sampled packet, parse it to sFlow format and send it to sFlow monitoring host. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/netdev-offload-tc.c | 127 +++- 1 file changed, 126

[ovs-dev] [PATCH v9 09/11] netdev-offload-tc: Create psample netlink socket

2020-12-14 Thread Chris Mi
Create psample netlink socket as a pre-step towards receiving sampled packets. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/netdev-offload-tc.c | 43 + 1 file changed, 43 insertions(+) diff --git a/lib/netdev-offload-tc.c

[ovs-dev] [PATCH v9 05/11] netdev-offload: Introduce register sFlow upcall callback API

2020-12-14 Thread Chris Mi
Introduce register sFlow upcall callback API as a pre-step towards saving the upcall callback. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/dpif-netlink.h| 4 lib/netdev-offload-provider.h | 3 +++ lib/netdev-offload.c | 12

[ovs-dev] [PATCH v9 06/11] netdev-offload-tc: Implement register sFlow upcall callback API

2020-12-14 Thread Chris Mi
Save the upcall callback as a pre-step towards offloading sample action to TC. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/netdev-offload-tc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c index

[ovs-dev] [PATCH v9 04/11] ofproto: Add upcall callback to process sFlow packet

2020-12-14 Thread Chris Mi
When offloading sample action, dpif provider may receive packets for sFlow in a seperate channel. That means the sFlow packets will not be processed by usual upcall. Add an upcall callback, so the dpif thread polling the channel can call it to process the sFlow packet. Signed-off-by: Chris Mi

[ovs-dev] [PATCH v9 07/11] dpif-netlink: Implement register sFlow upcall callback API

2020-12-14 Thread Chris Mi
Implement dpif netlink register sFlow upcall callback API. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/dpif-netlink.c | 28 +++- lib/netdev-offload.c | 18 ++ lib/netdev-offload.h | 1 + 3 files changed, 46 insertions(+), 1 deletion(-)

[ovs-dev] [PATCH v9 02/11] ovs-kmod-ctl: Load kernel module psample

2020-12-14 Thread Chris Mi
Load kernel module psample to receive sampled packets from TC. Before removing kernel module psample, remove act_sample first. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- utilities/ovs-kmod-ctl.in | 14 ++ 1 file changed, 14 insertions(+) diff --git

[ovs-dev] [PATCH v9 00/11] Add offload support for sFlow

2020-12-14 Thread Chris Mi
This patch set adds offload support for sFlow. Psample is a genetlink channel for packet sampling. TC action act_sample uses psample to send sampled packets to userspace. When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to

[ovs-dev] [PATCH v9 03/11] dpif: Introduce register sFlow upcall callback API

2020-12-14 Thread Chris Mi
When offloading sample action to TC, psample sends the sampled packets to userspace by a netlink message. The thread polling psample socket will translate the psample netlink message to an sFlow format and call the sFlow upcall callback to send the sFlow packet to right monitoring host. Introduce

[ovs-dev] [PATCH v9 01/11] compat: Add psample and tc sample action defines for older kernels

2020-12-14 Thread Chris Mi
Update kernel UAPI to support psample and the tc sample action. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- include/linux/automake.mk| 4 ++- include/linux/psample.h | 58 include/linux/tc_act/tc_sample.h | 25 ++ 3

Re: [ovs-dev] [PATCH v7 11/11] netdev-offload-tc: Add offload support for sFlow

2020-12-14 Thread Chris Mi
Hi Eelco, Thanks for your review. On 12/14/2020 7:46 PM, Eelco Chaudron wrote: Hi Chris, Noticed your v8, will try to fully review it before the year is over ;) //Eelco On 14 Dec 2020, at 10:33, Chris Mi wrote: diff --git a/lib/dpif.h b/lib/dpif.h index ed4257210..150162034 100644 ---

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix TTL decrement exception action execution

2020-12-14 Thread Jakub Kicinski
On Mon, 7 Dec 2020 05:08:39 -0500 Eelco Chaudron wrote: > Currently, the exception actions are not processed correctly as the wrong > dataset is passed. This change fixes this, including the misleading > comment. > > In addition, a check was added to make sure we work on an IPv4 packet, > and

[ovs-dev] Re

2020-12-14 Thread Gerencia - Caderode Brasília
Attn;Your names are linked to an unclaimed benefits. for claims please contact;jhaske...@gmail.com ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] Spende

2020-12-14 Thread support
Ich heiße Sheryll Goedert. Ich habe einen Lotterie-Jackpot von 396,9 Millionen US-Dollar gewonnen. Ich gebe der Nation etwas zurück, indem ich 5.000.000 Euro an die ersten 10 Menschen auf der ganzen Welt gebe. Ein Lob an diejenigen, die dies zuerst sehen, Gott segne Sie. Ich gebe diese Spende

Re: [ovs-dev] [PATCH v2 1/1] dpdk: Update to use DPDK v20.11.

2020-12-14 Thread Luca Boccassi
On Mon, 2020-12-14 at 19:11 +0100, Ilya Maximets wrote: > On 12/14/20 3:35 PM, Luca Boccassi wrote: > > On Mon, 2020-12-14 at 15:24 +0100, Ilya Maximets wrote: > > > On 12/14/20 3:17 PM, Luca Boccassi wrote: > > > > On Mon, 2020-12-14 at 15:05 +0100, David Marchand wrote: > > > > > On Mon, Dec 14,

[ovs-dev] (no subject)

2020-12-14 Thread MAVIS WANCZYK
-- -- Ich bin Frau Mavis Wanczyk, die Mega-Gewinnerin des Mega Millions Jackpots in Höhe von 758,7 Millionen US-Dollar. Ich spende an 100 zufällige Personen. Wenn Sie diese E-Mail erhalten, wurde Ihr Name nach einem Spinball ausgewählt. Ich habe den größten Teil meines Vermögens auf eine

Re: [ovs-dev] [PATCH v2 1/1] dpdk: Update to use DPDK v20.11.

2020-12-14 Thread Stokes, Ian
> On 12/14/20 3:35 PM, Luca Boccassi wrote: > > On Mon, 2020-12-14 at 15:24 +0100, Ilya Maximets wrote: > >> On 12/14/20 3:17 PM, Luca Boccassi wrote: > >>> On Mon, 2020-12-14 at 15:05 +0100, David Marchand wrote: > On Mon, Dec 14, 2020 at 12:45 PM Ilya Maximets > wrote: > >> On DPDK

[ovs-dev] [PATCH v3 1/1] dpdk: Update to use DPDK v20.11.

2020-12-14 Thread Ian Stokes
This commit adds support for DPDK v20.11, it includes the following changes. 1. travis: Remove explicit DPDK kmods configuration. 2. sparse: Fix build with 20.05 DPDK tracepoints. 3. netdev-dpdk: Remove experimental API flag.

Re: [ovs-dev] [PATCH v2 1/1] dpdk: Update to use DPDK v20.11.

2020-12-14 Thread Ilya Maximets
On 12/14/20 3:35 PM, Luca Boccassi wrote: > On Mon, 2020-12-14 at 15:24 +0100, Ilya Maximets wrote: >> On 12/14/20 3:17 PM, Luca Boccassi wrote: >>> On Mon, 2020-12-14 at 15:05 +0100, David Marchand wrote: On Mon, Dec 14, 2020 at 12:45 PM Ilya Maximets wrote: >> On DPDK side, it should

Re: [ovs-dev] [PATCH ovn v3 1/2] Add missing documentation for router policy and ecmp sym reply stage.

2020-12-14 Thread Mark Michelson
For the series, Acked-by: Mark Michelson I think patch 1 should go into the 20.12 branch in addition to going into master. On 12/11/20 2:10 PM, num...@ovn.org wrote: From: Numan Siddique Fixes: df4f37ea7f82("Policy-based routing (PBR) in OVN.) Fixes: a123ef0fb8fd("Support packet metadata

[ovs-dev] [PATCH] stt: fix dst_entry use-after-free in rcv_list for GSO skb

2020-12-14 Thread Vitaly Mayatskikh via dev
rcv_list assigns next->dst which is later released in skb_scrub_packet and then assigns the same dst_entry again in ovs_ip_tunnel_rcv, but it was freed already. Signed-off-by: Vitaly Mayatskikh --- datapath/linux/compat/stt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[ovs-dev] [PATCH ovn] ovn-controller: Use partial map updates for ct zones.

2020-12-14 Thread Ilya Maximets
There could be hundreds or thousands of ct zones in external-ids map. Iteration over all of them and reconstruction of the whole new map is unnecessary and only hurts performance of both ovn-controller and ovsdb-server on the node. Replacing with partial map updates to avoid unnecessary work.

Re: [ovs-dev] [PATCH v2 1/1] dpdk: Update to use DPDK v20.11.

2020-12-14 Thread Luca Boccassi
On Mon, 2020-12-14 at 15:24 +0100, Ilya Maximets wrote: > On 12/14/20 3:17 PM, Luca Boccassi wrote: > > On Mon, 2020-12-14 at 15:05 +0100, David Marchand wrote: > > > On Mon, Dec 14, 2020 at 12:45 PM Ilya Maximets wrote: > > > > > On DPDK side, it should only be a couple of headers that are

Re: [ovs-dev] [PATCH v2 1/1] dpdk: Update to use DPDK v20.11.

2020-12-14 Thread Ilya Maximets
On 12/14/20 3:17 PM, Luca Boccassi wrote: > On Mon, 2020-12-14 at 15:05 +0100, David Marchand wrote: >> On Mon, Dec 14, 2020 at 12:45 PM Ilya Maximets wrote: On DPDK side, it should only be a couple of headers that are causing compilation issues, and we can investigate what we can

Re: [ovs-dev] [PATCH v2 1/1] dpdk: Update to use DPDK v20.11.

2020-12-14 Thread Luca Boccassi
On Mon, 2020-12-14 at 15:05 +0100, David Marchand wrote: > On Mon, Dec 14, 2020 at 12:45 PM Ilya Maximets wrote: > > > On DPDK side, it should only be a couple of headers that are causing > > > compilation > > > issues, and we can investigate what we can do with them - at least some > > > of

Re: [ovs-dev] [PATCH v2 1/1] dpdk: Update to use DPDK v20.11.

2020-12-14 Thread David Marchand
On Mon, Dec 14, 2020 at 12:45 PM Ilya Maximets wrote: > > On DPDK side, it should only be a couple of headers that are causing > > compilation > > issues, and we can investigate what we can do with them - at least some of > > them > > can be reworked to support a non-SSE4.2 fallback, I believe.

Re: [ovs-dev] [PATCH ovn v3] debian: fix debian packaging and remove ovs files

2020-12-14 Thread Numan Siddique
On Sun, Dec 13, 2020 at 7:12 PM Wan Junjie wrote: > > Remove all openvswitch package files and rename the packages > with prefix ovn-. Ovs debs would not be packed in ovn anymore. > > Add a build option DATAPATH_CONFIGURE_OPTS. Like openvswitch, > use '-with-ovs-source=' to pass the ovs source

Re: [ovs-dev] [PATCH ovn v2 0/3] nbctl: Use mutations to update sets.

2020-12-14 Thread Numan Siddique
On Fri, Dec 11, 2020 at 4:29 PM Ilya Maximets wrote: > > Version 2: > * Hash maps renamed to avoid name collision: > lsp_to_ls --> lsp_to_ls_map > lrp_to_lr --> lrp_to_lr_map > * Removed unused variable from the patch #2. > * Added ACK from Dumitru to the patch #1 and

Re: [ovs-dev] [PATCH ovn branch-20.03] chassis: Do not try to guess system-id changes.

2020-12-14 Thread 0-day Robot
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./ovn -I ./include -I

Re: [ovs-dev] [PATCH ovn] chassis: Do not try to guess system-id changes.

2020-12-14 Thread Dumitru Ceara
On 12/11/20 12:53 PM, Numan Siddique wrote: > On Thu, Dec 10, 2020 at 3:28 AM Mark Michelson wrote: >> >> Acked-by: Mark Michelson > > Thanks Dumitru and Mark. > > I applied this patch to the main branch and backported to branch-20.12. > > Can you please submit backport patches for the

[ovs-dev] [PATCH v9] Bareudp Tunnel Support

2020-12-14 Thread Martin Varghese
From: Martin Varghese There are various L3 encapsulation standards using UDP being discussed to leverage the UDP based load balancing capability of different networks. MPLSoUDP (__ https://tools.ietf.org/html/rfc7510) is one among them. The Bareudp tunnel provides a generic L3 encapsulation

Re: [ovs-dev] [PATCH ovn] lflow: Relax the condition that detects Load_Balancer hairpin.

2020-12-14 Thread Dumitru Ceara
On 12/14/20 10:34 AM, Numan Siddique wrote: > On Fri, Dec 11, 2020 at 3:46 PM Dumitru Ceara wrote: >> >> Commit fc219d84b667 [0] optimized Load Balancer hairpin support from an >> OVN Southbound perspective by moving generation of flows to detect >> hairpin traffic in ovn-controller. >> >>

[ovs-dev] [PATCH ovn branch-20.03] chassis: Do not try to guess system-id changes.

2020-12-14 Thread Dumitru Ceara
When the OVS system-id changes ovn-controller needs external (CMS) help in order to update its own Chassis/Chassis_private records, i.e., the CMS has to ensure that either ovn-controller is stopped (so that ovn-controller cleans up its old Chassis/Chassis_private records) or that after the

[ovs-dev] [PATCH ovn branch-20.06] chassis: Do not try to guess system-id changes.

2020-12-14 Thread Dumitru Ceara
When the OVS system-id changes ovn-controller needs external (CMS) help in order to update its own Chassis/Chassis_private records, i.e., the CMS has to ensure that either ovn-controller is stopped (so that ovn-controller cleans up its old Chassis/Chassis_private records) or that after the

Re: [ovs-dev] [PATCH v7 11/11] netdev-offload-tc: Add offload support for sFlow

2020-12-14 Thread Eelco Chaudron
Hi Chris, Noticed your v8, will try to fully review it before the year is over ;) //Eelco On 14 Dec 2020, at 10:33, Chris Mi wrote: diff --git a/lib/dpif.h b/lib/dpif.h index ed4257210..150162034 100644 --- a/lib/dpif.h +++ b/lib/dpif.h @@ -878,6 +878,7 @@ void

Re: [ovs-dev] [PATCH v2 1/1] dpdk: Update to use DPDK v20.11.

2020-12-14 Thread Ilya Maximets
On 12/11/20 11:15 AM, Richardson, Bruce wrote: > > >> -Original Message- >> From: Ilya Maximets >> Sent: Thursday, December 10, 2020 4:26 PM >> To: Luca Boccassi ; Ilya Maximets ; >> Richardson, Bruce ; Stokes, Ian >> ; d...@openvswitch.org >> Cc: ktray...@redhat.com;

[ovs-dev] [PATCH ovn branch-20.09] chassis: Do not try to guess system-id changes.

2020-12-14 Thread Dumitru Ceara
When the OVS system-id changes ovn-controller needs external (CMS) help in order to update its own Chassis/Chassis_private records, i.e., the CMS has to ensure that either ovn-controller is stopped (so that ovn-controller cleans up its old Chassis/Chassis_private records) or that after the

[ovs-dev] !!!!!EMAIL ADDRESS: madinerita...@gmail.com

2020-12-14 Thread RITA MADINE. via dev
AM MRS. RITA MADINE FROM REPUBLIC OF IRELAND, BORN IN THE STATE OF OHIO USA. I AM LEGALLY MARRIED TO MR. HILARY MADINE , A SOUTH AFRICA CITIZEN BORN BROUGHT UP IN SWITZERLAND, I LIVE IN SWITZERLAND WITH MY HUSBAND FOR 32 YEARS BEFORE WE MOVE DOWN TO SOUTH AFRICA IN 1985 AFTER MY HUSBAND RETIREMENT

[ovs-dev] [PATCH v8 10/11] netdev-offload-tc: Add psample receive handler

2020-12-14 Thread Chris Mi
Create a dedicated thread to poll psample netlink socket, receive sampled packet, parse it to sFlow format and send it to sFlow monitoring host. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/netdev-offload-tc.c | 127 +++- 1 file changed, 126

[ovs-dev] [PATCH v8 07/11] dpif-netlink: Implement register sFlow upcall callback API

2020-12-14 Thread Chris Mi
Implement dpif netlink register sFlow upcall callback API. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/dpif-netlink.c | 28 +++- lib/netdev-offload.c | 18 ++ lib/netdev-offload.h | 1 + 3 files changed, 46 insertions(+), 1 deletion(-)

[ovs-dev] [PATCH v8 06/11] netdev-offload-tc: Implement register sFlow upcall callback API

2020-12-14 Thread Chris Mi
Save the upcall callback as a pre-step towards offloading sample action to TC. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/netdev-offload-tc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c index

[ovs-dev] [PATCH v8 08/11] netdev-offload-tc: Introduce group ID management API

2020-12-14 Thread Chris Mi
When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to kernel instead of the sFlow info. psample will send this ID and sampled packet to userspace. Using the ID, userspace can recover the sFlow info and send sampled packet to

[ovs-dev] [PATCH v8 11/11] netdev-offload-tc: Add offload support for sFlow

2020-12-14 Thread Chris Mi
Create a unique group ID to map the sFlow info when offloading sFlow action to TC. When showing the offloaded datapath flows, translate the group ID from TC sample action to sFlow info using the mapping. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/netdev-offload-tc.c | 170

[ovs-dev] [PATCH v8 09/11] netdev-offload-tc: Create psample netlink socket

2020-12-14 Thread Chris Mi
Create psample netlink socket as a pre-step towards receiving sampled packets. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/netdev-offload-tc.c | 43 + 1 file changed, 43 insertions(+) diff --git a/lib/netdev-offload-tc.c

[ovs-dev] [PATCH v8 04/11] ofproto: Add upcall callback to process sFlow packet

2020-12-14 Thread Chris Mi
When offloading sample action, dpif provider may receive packets for sFlow in a seperate channel. That means the sFlow packets will not be processed by usual upcall. Add an upcall callback, so the dpif thread polling the channel can call it to process the sFlow packet. Signed-off-by: Chris Mi

[ovs-dev] [PATCH v8 03/11] dpif: Introduce register sFlow upcall callback API

2020-12-14 Thread Chris Mi
When offloading sample action to TC, psample sends the sampled packets to userspace by a netlink message. The thread polling psample socket will translate the psample netlink message to an sFlow format and call the sFlow upcall callback to send the sFlow packet to right monitoring host. Introduce

[ovs-dev] [PATCH v8 05/11] netdev-offload: Introduce register sFlow upcall callback API

2020-12-14 Thread Chris Mi
Introduce register sFlow upcall callback API as a pre-step towards saving the upcall callback. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/dpif-netlink.h| 4 lib/netdev-offload-provider.h | 3 +++ lib/netdev-offload.c | 12

[ovs-dev] [PATCH v8 01/11] compat: Add psample and tc sample action defines for older kernels

2020-12-14 Thread Chris Mi
Update kernel UAPI to support psample and the tc sample action. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- include/linux/automake.mk| 4 ++- include/linux/psample.h | 58 include/linux/tc_act/tc_sample.h | 25 ++ 3

[ovs-dev] [PATCH v8 00/11] Add offload support for sFlow

2020-12-14 Thread Chris Mi
This patch set adds offload support for sFlow. Psample is a genetlink channel for packet sampling. TC action act_sample uses psample to send sampled packets to userspace. When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to

[ovs-dev] [PATCH v8 02/11] ovs-kmod-ctl: Load kernel module psample

2020-12-14 Thread Chris Mi
Load kernel module psample to receive sampled packets from TC. Before removing kernel module psample, remove act_sample first. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- utilities/ovs-kmod-ctl.in | 14 ++ 1 file changed, 14 insertions(+) diff --git

Re: [ovs-dev] [PATCH ovn] lflow: Relax the condition that detects Load_Balancer hairpin.

2020-12-14 Thread Numan Siddique
On Fri, Dec 11, 2020 at 3:46 PM Dumitru Ceara wrote: > > Commit fc219d84b667 [0] optimized Load Balancer hairpin support from an > OVN Southbound perspective by moving generation of flows to detect > hairpin traffic in ovn-controller. > > However, this can be further optimized by relaxing the

Re: [ovs-dev] [PATCH v7 11/11] netdev-offload-tc: Add offload support for sFlow

2020-12-14 Thread Chris Mi
On 12/4/2020 7:34 PM, Eelco Chaudron wrote: On 4 Dec 2020, at 6:34, Chris Mi wrote: On 12/2/2020 11:08 PM, Eelco Chaudron wrote: On 30 Nov 2020, at 5:48, Chris Mi wrote: Create a unique group ID to map the sFlow info when offloading sFlow action to TC. When showing the offloaded

[ovs-dev] US Federal Reserve Bank Corporate Office.

2020-12-14 Thread barrannrlyossy56
I've invited you to fill out the following form: Untitled form To fill it out, visit: https://docs.google.com/forms/d/e/1FAIpQLSdwD0Psxb4gJ0GUpU4HfaQ5HvCmWacK_2wEmnWT8vSw7iD2CA/viewform?vc=0c=0w=1flr=0usp=mail_form_link US Federal Reserve Bank Corporate Office. 33

Re: [ovs-dev] [PATCH ovn v3] northd: Fix datapath swapping in logical flows.

2020-12-14 Thread Numan Siddique
On Fri, Dec 11, 2020 at 11:31 PM Ilya Maximets wrote: > > Commit that introduced support for logical datapath groups removed > the 'logical_datapath' column from the lflow hash. If datapath groups > disabled, there will be many flows that are same except for the > 'logical_datapath' column, so