Signed-off-by: Mark Gray
Acked-by: Eelco Chaudron
Acked-by: Flavio Leitner
---
v3: Add Flavio's ack
v4: Rebased and added NEWS section
NEWS | 2 ++
ipsec/ovs-monitor-ipsec.in | 11 ---
utilities/ovs-ctl.in | 8
3 files changed, 18 insertions(+),
When 'ovs-monitor-ipsec' exits, it clears all persistent state (i.e.
active ipsec connections, /etc/ipsec.conf, certs/keys). In some
use-cases, we may want to exit and maintain state so that ipsec
connectivity is maintained. One example of this is during an
upgrade. This will require the caller to
This patchset contains a number of fixes and
improvements to the OVS IPsec daemon.
v4:
* Some commits that were in a previous version of this patchset
have already been committed so this series was rebased.
Mark Gray (2):
ovs-monitor-ipsec: Allow exit of ipsec daemon maintaining state
On 05/01/2021 20:30, Ilya Maximets wrote:
> On 1/4/21 9:45 AM, Mark Gray wrote:
>> This patchset contains a number of fixes and
>> improvements to the OVS IPsec daemon.
>>
>> Mark Gray (4):
>> ovs-monitor-ipsec: Fix active connection regex
>> ovs-ctl: Use 'stop_daemon' to stop ovs-monitor-ipsec
On 1/1/2021 3:07 PM, Ilya Maximets wrote:
Hi. As described in Documentation/internals/release-process.rst, we are
in a "soft freeze" state:
During the freeze, we ask committers to refrain from applying patches that
add new features unless those patches were already being publicly dis
On 12/22/20 1:21 AM, Ben Pfaff wrote:
> This follows up on commit 4241d652e465 ("jsonrpc: Avoid disconnecting
> prematurely due to long poll intervals."), which implemented the same
> thing in C.
>
> Requested-by: Ilya Maximets
> Signed-off-by: Ben Pfaff
> ---
> python/ovs/jsonrpc.py | 5 +++
On 1/4/21 9:45 AM, Mark Gray wrote:
> This patchset contains a number of fixes and
> improvements to the OVS IPsec daemon.
>
> Mark Gray (4):
> ovs-monitor-ipsec: Fix active connection regex
> ovs-ctl: Use 'stop_daemon' to stop ovs-monitor-ipsec
> ovs-monitor-ipsec: Allow exit of ipsec daemo
On 12/24/20 8:41 PM, Flavio Leitner wrote:
> On Thu, Dec 24, 2020 at 07:59:38AM -0500, Mark Gray wrote:
>> In Libreswan case, 'ovs-monitor-ipsec' incorrectly configures
>> 'leftcert' and 'rightcert' names for self-signed certificates.
>> This patch resolves that.
>>
>> Reported-at: https://bugzilla
On 12/24/20 8:41 PM, Flavio Leitner wrote:
> On Thu, Dec 24, 2020 at 07:57:01AM -0500, Mark Gray wrote:
>> In the libreswan case, 'ovs-monitor-ipsec' sets
>> 'left' to '%defaultroute' which will use the local address
>> of the default route interface as the source IP address. In
>> multihomed envir
On 12/24/20 11:06 AM, Mark Gray wrote:
> As 'ovs-vswitchd' does not understand IPsec tunnel options, it
> gives a warning message. This can be safely suppressed.
>
> Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1906701
> Signed-off-by: Mark Gray
> Acked-by: Eelco Chaudron
> Acked-by:
On 12/23/20 5:01 PM, Mark Gray wrote:
> _nss_clear_database() runs `certutil` in order to get a list
> of certificates currently loaded in NSS. This fails with error:
>
> "ovs-monitor-ipsec | ERR | Failed to clear NSS database.
> startswith first arg must be bytes or a tuple of bytes, not str"
>
On 12/22/20 4:48 PM, Eelco Chaudron wrote:
>
>
> On 22 Dec 2020, at 16:16, Paolo Valerio wrote:
>
>> Eelco Chaudron writes:
>>
>>> When you would like to add, modify, or delete a lot of flows in the
>>> datapath, for example when you want to measure performance, adding
>>> one flow at the time
On 5/26/20 8:30 AM, Han Zhou wrote:
> On Mon, May 25, 2020 at 8:28 AM Daniel Alvarez wrote:
>>
>> ovs-ctl started to add the hostname as external-id [0] at some point.
>>
>> However, this can be problematic as if it's already set by an external
>> entity it will get overwritten. In RHEL systems, s
From: Vladimir Oltean
After commit 28172739f0a2 ("net: fix 64 bit counters on 32 bit arches"),
dev_get_stats got an additional argument for storage of statistics. At
this point, dev_get_stats could return either the passed "storage"
argument, or the output of .ndo_get_stats64.
Then commit caf586
From: Vladimir Oltean
Now that we have a good summary in Documentation/networking/netdevices.rst,
these comments serve no purpose and are actually distracting/confusing.
Signed-off-by: Vladimir Oltean
---
drivers/net/ethernet/cisco/enic/enic_main.c | 1 -
drivers/net/ethernet/nvidia/forcedeth.
From: Vladimir Oltean
The failover framework sets up a virtio_net interface [ when it has the
VIRTIO_NET_F_STANDBY feature ] and a VF interface, having the same MAC
address, in a standby/active relationship. When the active VF is
unplugged, the standby virtio_net temporarily kicks in.
The failov
From: Vladimir Oltean
Now that all callers have been converted to not use atomic context when
calling dev_get_stats, it is time to update the documentation and put a
notice in the function that it expects process context.
Signed-off-by: Vladimir Oltean
---
Documentation/networking/netdevices.r
From: Vladimir Oltean
There is an effort to convert .ndo_get_stats64 to sleepable context, and
for that to work, we need to prevent callers of dev_get_stats from using
atomic locking.
The bonding driver retrieves its statistics recursively from its lower
interfaces, with additional care to only
From: Vladimir Oltean
In the effort of making .ndo_get_stats64 be able to sleep, we need to
ensure the callers of dev_get_stats do not use atomic context.
The LED driver for HP-PARISC workstations uses a workqueue to
periodically check for updates in network interface statistics, and
flicker whe
From: Vladimir Oltean
The standard in the Linux kernel is to use one tab character per
indentation level.
Cc: "James E.J. Bottomley"
Cc: Helge Deller
Cc: linux-par...@vger.kernel.org
Signed-off-by: Vladimir Oltean
---
drivers/parisc/led.c | 23 +--
1 file changed, 13 inse
From: Vladimir Oltean
In the effort of making .ndo_get_stats64 be able to sleep, we need to
ensure the callers of dev_get_stats do not use atomic context.
I need to preface this by saying that I have no idea why netstat_show
takes the dev_base_lock rwlock. Two things can be observed:
(a) it does
From: Vladimir Oltean
In the effort of making .ndo_get_stats64 be able to sleep, we need to
ensure the callers of dev_get_stats do not use atomic context.
In the case of the appldata driver, an RCU read-side critical section is
used to ensure the integrity of the list of network interfaces, beca
From: Vladimir Oltean
In the effort of making .ndo_get_stats64 be able to sleep, we need to
ensure the callers of dev_get_stats do not use atomic context.
The /proc/net/dev file uses an RCU read-side critical section to ensure
the integrity of the list of network interfaces, because it iterates
From: Vladimir Oltean
Currently, any writer that wants to alter the lists of network
interfaces (either the plain list net->dev_base_head, or the hash tables
net->dev_index_head and net->dev_name_head) can keep other writers at
bay using the RTNL mutex.
However, the RTNL mutex has become a very
From: Vladimir Oltean
There is a movement to eliminate the usage of dev_base_lock, which
exists since as far as I could track the kernel history down (the
"7a2deb329241 Import changeset" commit from the bitkeeper branch).
The dev_base_lock approach has multiple issues:
- It is global and not per
From: Vladimir Oltean
Changes in v2:
- Addressed the recursion issues in .ndo_get_stats64 from bonding and
net_failover.
- Renamed netdev_lists_lock to netif_lists_lock
- Stopped taking netif_lists_lock from drivers as much as possible.
This series converts all callers of dev_get_stats() to be
The Linux Out of Tree kernel driver is deprecated. Emit a warning
when the '--with-linux' configure parameter is supplied to remind
the user.
Signed-off-by: Greg Rose
---
acinclude.m4 | 1 +
1 file changed, 1 insertion(+)
diff --git a/acinclude.m4 b/acinclude.m4
index 60871f67a..3432e1f9b 1006
It is decided (1) to deprecate the Linux Out of Tree (OOT) drivers.
Update the NEWS and FAQ to provide notice.
1. https://mail.openvswitch.org/pipermail/ovs-dev/2020-December/378831.html
Signed-off-by: Greg Rose
---
Documentation/faq/releases.rst | 7 ++-
NEWS | 3
As agreed in (1) deprecate the Linux OOT driver.
github Build and Test here:
https://github.com/gvrose8192/ovs-experimental/actions/runs/463987690
1. https://mail.openvswitch.org/pipermail/ovs-dev/2020-December/378831.html
Greg Rose (2):
doc: Deprecate the Linux Out of Tree drivers
acinclude
Introduce the bfd reference in logical_router_static_router table
in order to check if the next-hop is properly running using the BFD
protocol. The CMS is supposed to populate bfd column with the proper
reference otherwise the BFD status is set to admin_down.
Add BFD tests in system-ovn.at.
Signed
Introduce BFD state machine for BFD packet parsing
according to RFC880 https://tools.ietf.org/html/rfc5880.
Introduce BFD logical flows in ovn-northd.
Signed-off-by: Lorenzo Bianconi
---
NEWS| 2 +
controller/pinctrl.c| 341 ++--
nort
Introduce rx demand mode support according to RFC5880 [0].
Demand mode on tx side is not supported yet.
https://tools.ietf.org/html/rfc5880
Signed-off-by: Lorenzo Bianconi
---
controller/pinctrl.c | 105 ---
1 file changed, 68 insertions(+), 37 deletions(-
Introduce BFD protocol in ovn-controller according to RFC5880 [0]
We added BFD implementation in ovn since layered protocols usually request to
enable it on ovn entities (e.g. logical router ports) while ovs implementation
relies on physical entities (e.g. ovs interfaces).
Moreover we would establi
Add handle_bfd_msg() action to parse BFD packets received by the
controller. handle_bfd_msg() logic is currently empty and it will be
implemented adding BFD state machine in the following patches.
Signed-off-by: Lorenzo Bianconi
---
controller/pinctrl.c | 15 +++
include/ovn/actions
Introduce the capability to transmit BFD packets in ovn-controller.
Introduce BFD tables in nb/sb dbs in order to configure BFD parameters
(e.g. min_tx, min_rx, ..) for ovn-controller.
Signed-off-by: Lorenzo Bianconi
---
controller/ovn-controller.c | 1 +
controller/pinctrl.c| 299
From: Anton Ivanov
---
northd/ovn-northd.c | 499 ++--
1 file changed, 249 insertions(+), 250 deletions(-)
diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index cd18db9fd..73ea6e096 100644
--- a/northd/ovn-northd.c
+++ b/northd/ovn-northd.c
@@ -892
From: Anton Ivanov
Split build_lswitch_output_port_sec into a per port and per
datapath iterator. Migrate to the relevant per-port and
per-datapath loops.
Signed-off-by: Anton Ivanov
---
northd/ovn-northd.c | 82 -
1 file changed, 37 insertions(+), 4
From: Anton Ivanov
Signed-off-by: Anton Ivanov
---
northd/ovn-northd.c | 96 +++--
1 file changed, 50 insertions(+), 46 deletions(-)
diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index 8084d1bfe..cd18db9fd 100644
--- a/northd/ovn-northd.c
+++ b/
From: Anton Ivanov
1. Move igmp/mld destination handling into a function.
2. Move unicast destination handling into a function.
Signed-off-by: Anton Ivanov
---
northd/ovn-northd.c | 437 +++-
1 file changed, 227 insertions(+), 210 deletions(-)
diff --gi
From: Anton Ivanov
Signed-off-by: Anton Ivanov
---
northd/ovn-northd.c | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index f35d1b9db..22e6e801d 100644
--- a/northd/ovn-northd.c
+++ b/north
From: Anton Ivanov
Signed-off-by: Anton Ivanov
---
northd/ovn-northd.c | 33 ++---
1 file changed, 18 insertions(+), 15 deletions(-)
diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index 22e6e801d..daf1db908 100644
--- a/northd/ovn-northd.c
+++ b/northd/ovn-n
From: Anton Ivanov
Signed-off-by: Anton Ivanov
---
northd/ovn-northd.c | 169 +++-
1 file changed, 87 insertions(+), 82 deletions(-)
diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index daf1db908..201c4d252 100644
--- a/northd/ovn-northd.c
+++ b/
From: Anton Ivanov
Signed-off-by: Anton Ivanov
---
northd/ovn-northd.c | 100 ++--
1 file changed, 51 insertions(+), 49 deletions(-)
diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index f518af83b..6bdf5e893 100644
--- a/northd/ovn-northd.c
+++ b/
From: Anton Ivanov
Move arp/nd responder lflow processing to per-iterable functions.
Signed-off-by: Anton Ivanov
---
northd/ovn-northd.c | 496 +++-
1 file changed, 260 insertions(+), 236 deletions(-)
diff --git a/northd/ovn-northd.c b/northd/ovn-northd
From: Anton Ivanov
Signed-off-by: Anton Ivanov
---
northd/ovn-northd.c | 50 -
1 file changed, 27 insertions(+), 23 deletions(-)
diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index 6bdf5e893..f35d1b9db 100644
--- a/northd/ovn-northd.c
+++ b/
Fix the following ovn-trace warning triggered by controller_event:
1|ovntrace|WARN|trigger_event(event = "empty_lb_backends", meter = "",
vip = "192.168.0.100:80", protocol = "tcp",
load_balancer =
"2c5462a7-b6ca-4b02-86c9-b9
Fix ovn-trace core dump with unknown datapath
Fixes: aade361c7ebe ("ovn-trace: Make the "datapath" command-line argument
optional.")
Co-authored-by: Dumitru Ceara
Signed-off-by: Dumitru Ceara
Signed-off-by: Lorenzo Bianconi
---
Changes since v1:
- simplify patch logic
- add unitests
---
tests
On 21/12/2020 12:06, Numan Siddique wrote:
On Wed, Nov 25, 2020 at 4:32 PM wrote:
From: Anton Ivanov
1. Add support for parallel lflow build.
2. Move combined lflow generation to be build in parallel.
Signed-off-by: Anton Ivanov
Hi Anton,
Sorry for the delay in reviews. I think now tha
48 matches
Mail list logo
