Re: [ovs-dev] [PATCH net-next] net: openvswitch: add log message for error case

Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 13 Jan 2021 14:50:00 +0100 you wrote: > As requested by upstream OVS, added some error messages in the > validate_and_copy_dec_ttl function. > > Includes a small cleanup, which removes an unnecessary parameter > fr

[ovs-dev] [PATCH v2] netlink: ignore IFLA_WIRELESS events

From: Michal Kazior Some older wireless drivers - ones relying on the old and long deprecated wireless extension ioctl system - can generate quite a bit of IFLA_WIRELESS events depending on their configuration and runtime conditions. These are delivered as RTNLGRP_LINK via RTM_NEWLINK messages.

Re: [ovs-dev] [PATCH ovn] northd: Fix ACL fair log meters for Port_Group ACLs.

Acked-by: Flavio Fernandes mailto:fla...@flaviof.com>> > On Jan 15, 2021, at 8:41 AM, Dumitru Ceara wrote: > > Commit 880dca99eaf7 added support for fair meters but didn't cover the > case when an ACL is configured on a port group instead of a logical > switch. > > Iterate over PG ACLs too whe

Re: [ovs-dev] [PATCH V5 0/2] Deprecate Linux kernel module

On 1/15/2021 11:10 AM, Ilya Maximets wrote: On 1/12/21 8:15 PM, Greg Rose wrote: As agreed in (1) deprecate building the Linux kernel module from the Open vSwitch source tree. github Build and Test here: https://github.com/gvrose8192/ovs-experimental/actions/runs/480920378 1. https://mail.o

Re: [ovs-dev] [PATCH v1 ovn] OVN: Multiple distributed gateway port support

Hi Numan, Just submitted a V2. Please look. Appreciate your help. Regards, Ankur From: Numan Siddique Sent: Wednesday, January 13, 2021 2:48 AM To: svc.mail.git ; Ankur Sharma Cc: ovs dev Subject: Re: [ovs-dev] [PATCH v1 ovn] OVN: Multiple distributed gateway

[ovs-dev] [PATCH v2 ovn] OVN: Multiple distributed gateway port support

From: Ankur Sharma By default, OVN support only one distributed gateway port (we will call it l3dgw port for further reference) per logical router. While a single l3dgw port suffices for most of the North South connectivity, however there are requirements where a logical router could be connected

[ovs-dev] [PATCH v2 ovn] Multiple l3dgw port support

From: Ankur Sharma This patch adds multiple l3dgw port support in OVN. Code changes are high, however since data structure was enhanced and it had to be consumed in same patch, hence we think that from review perspective probably a single patch would suffice, rather than a series. Some request

Re: [ovs-dev] [PATCH 0/2] Patches to branch for 2.15.

On Fri, Jan 15, 2021 at 09:34:18PM +0100, Ilya Maximets wrote: > On 1/15/21 8:25 PM, Ilya Maximets wrote: > > Ilya Maximets (2): > > Prepare for 2.15.0. > > Prepare for post-2.15.0 (2.15.90). > > > > NEWS | 6 +- > > configure.ac | 2 +- > > debian/changelog | 10 +++

Re: [ovs-dev] [PATCH] odp-util: Fix abort while formatting nsh actions.

On 12/01/2021 23:55, Ilya Maximets wrote: > On 1/11/21 7:22 PM, Mark Gray wrote: >> On 18/12/2020 13:34, Ilya Maximets wrote: >>> OVS should not exit if it cannot format NSH actions for the user. >>> It should just report the error like the other formatting functions do. >>> >>> Credit to OSS-Fuzz.

Re: [ovs-dev] [PATCH 0/2] Patches to branch for 2.15.

On 1/15/21 8:25 PM, Ilya Maximets wrote: > Ilya Maximets (2): > Prepare for 2.15.0. > Prepare for post-2.15.0 (2.15.90). > > NEWS | 6 +- > configure.ac | 2 +- > debian/changelog | 10 -- > 3 files changed, 14 insertions(+), 4 deletions(-) > Thanks, Flavio and

Re: [ovs-dev] [PATCH ovn] ovn-architecture.xml: remove extra word

On 4/22/20 11:29 AM, wangpeihui...@126.com wrote: > From: Frank Wang > > Signed-off-by: Frank Wang > --- > ovn-architecture.7.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml > index 533ae716d..e63e0d96b 100644 > --- a

Re: [ovs-dev] [PATCH 0/2] Patches to branch for 2.15.

Ilya Maximets writes: > Ilya Maximets (2): > Prepare for 2.15.0. > Prepare for post-2.15.0 (2.15.90). > > NEWS | 6 +- > configure.ac | 2 +- > debian/changelog | 10 -- > 3 files changed, 14 insertions(+), 4 deletions(-) Acked-by: Aaron Conole __

Re: [ovs-dev] [PATCH 0/2] Patches to branch for 2.15.

On Fri, Jan 15, 2021 at 08:25:55PM +0100, Ilya Maximets wrote: > Ilya Maximets (2): > Prepare for 2.15.0. > Prepare for post-2.15.0 (2.15.90). > > NEWS | 6 +- > configure.ac | 2 +- > debian/changelog | 10 -- > 3 files changed, 14 insertions(+), 4 deletions(-)

[ovs-dev] [PATCH 2/2] Prepare for post-2.15.0 (2.15.90).

Signed-off-by: Ilya Maximets --- NEWS | 4 configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index a94af0279..066317e88 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +Post-v2.15.0 +-

[ovs-dev] [PATCH 0/2] Patches to branch for 2.15.

Ilya Maximets (2): Prepare for 2.15.0. Prepare for post-2.15.0 (2.15.90). NEWS | 6 +- configure.ac | 2 +- debian/changelog | 10 -- 3 files changed, 14 insertions(+), 4 deletions(-) -- 2.25.4 ___ dev mailing list d

[ovs-dev] [PATCH 1/2] Prepare for 2.15.0.

Signed-off-by: Ilya Maximets --- NEWS | 2 +- configure.ac | 2 +- debian/changelog | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index 1591087c4..a94af0279 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -Post-v2.14.0 +v2.15.0 - xx xxx --

Re: [ovs-dev] [PATCH V5 0/2] Deprecate Linux kernel module

On 1/12/21 8:15 PM, Greg Rose wrote: > As agreed in (1) deprecate building the Linux kernel module from > the Open vSwitch source tree. > > github Build and Test here: > https://github.com/gvrose8192/ovs-experimental/actions/runs/480920378 > > 1. https://mail.openvswitch.org/pipermail/ovs-dev/202

Re: [ovs-dev] [PATCH v2] ovsdb: Use column diffs for ovsdb and raft log entries.

On 1/15/21 6:05 PM, Dumitru Ceara wrote: > On 1/14/21 2:11 AM, Ilya Maximets wrote: >> Currently, ovsdb-server stores complete value for the column in a database >> file and in a raft log in case this column changed.  This means that >> transaction that adds, for example, one new acl to a port grou

Re: [ovs-dev] [PATCH v6 0/4] Add PMD auto load balance parameters.

On 15/01/2021 18:48, Ilya Maximets wrote: > On 12/21/20 2:10 PM, Kevin Traynor wrote: >> v6: >> - Split patches to add log to existing interval param as a seperate fix first >> - Fix reference in vswitchd.xml >> - Kept Acks as minor changes >> >> v5: >> - Make naming more consistent in vswitchd.xml

Re: [ovs-dev] [PATCH V3 0/4] netdev datapath flush offloaded flows

On 12/28/20 11:18 AM, Eli Britstein wrote: > Netdev datapath offloads are done in a separate thread, using messaging > between the threads. With port removal there is a race between the offload > thread removing the offloaded rules and the actual port removal, so some > rules will not be removed. I

Re: [ovs-dev] [PATCH v6 0/4] Add PMD auto load balance parameters.

On 12/21/20 2:10 PM, Kevin Traynor wrote: > v6: > - Split patches to add log to existing interval param as a seperate fix first > - Fix reference in vswitchd.xml > - Kept Acks as minor changes > > v5: > - Make naming more consistent in vswitchd.xml/NEWS/commit msgs > - Added Co-Authored-By > > v4

[ovs-dev] [PATCH ovn] Support configuring Load Balancer hairpin source IP.

In case traffic that gets load balanced is DNAT-ed to a backend IP that happens to be the source of the traffic then OVN performs an additional SNAT to ensure that return traffic is directed through OVN. Until now the load balancer VIP was chosen as SNAT IP. However, in specific scenarios, the CM

Re: [ovs-dev] [PATCH v1 branch-2.14 1/2] acinclude: Strip out -march provided by DPDK.

On 1/15/21 6:37 PM, Ian Stokes wrote: > DPDK flags may include -march. Forcing -march could be > considered too heavy a requirement when users compile OVS from > source and could override user provided options. > > Resolve this by stripping -march from provided DPDK flags. > > Signed-off-by: Ian

Re: [ovs-dev] [PATCH v1 branch-2.14 2/2] acinclude: Strip out -mno-avx512f provided by DPDK.

On 1/15/21 6:38 PM, Ian Stokes wrote: > DPDK forces '-mno-avx512f' flag for the application if the toolchain > used to build DPDK had broken AVX512 support. > > DPDK forces '-mno-avx512f' flag for the application if the toolchain > used to build DPDK had broken AVX512 support. But OVS could be bu

Re: [ovs-dev] [PATCH v1 branch-2.13 2/2] acinclude: Strip out -mno-avx512f provided by DPDK.

On 1/15/21 6:38 PM, Ian Stokes wrote: > DPDK forces '-mno-avx512f' flag for the application if the toolchain > used to build DPDK had broken AVX512 support. > > DPDK forces '-mno-avx512f' flag for the application if the toolchain > used to build DPDK had broken AVX512 support. But OVS could be bu

Re: [ovs-dev] [PATCH v6 2/4] dpif-netdev: Add parameters to configure PMD auto load balance.

> On 15/01/2021 17:22, Ilya Maximets wrote: > > On 12/21/20 2:10 PM, Kevin Traynor wrote: > >> From: Christophe Fontaine > >> > >> Two important parts of how PMD auto load balance operates are how > >> loaded a core needs to be and how much improvement is estimated > >> before a PMD auto load bala

[ovs-dev] [PATCH v1 branch-2.13 2/2] acinclude: Strip out -mno-avx512f provided by DPDK.

DPDK forces '-mno-avx512f' flag for the application if the toolchain used to build DPDK had broken AVX512 support. DPDK forces '-mno-avx512f' flag for the application if the toolchain used to build DPDK had broken AVX512 support. But OVS could be built with a completely different or fixed toolcha

[ovs-dev] [PATCH v1 branch-2.13 1/2] acinclude: Strip out -march provided by DPDK.

DPDK flags may include -march. Forcing -march could be considered too heavy a requirement when users compile OVS from source and could override user provided options. Resolve this by stripping -march from provided DPDK flags. Signed-off-by: Ian Stokes --- acinclude.m4 | 3 +++ 1 file changed, 3

[ovs-dev] [PATCH v1 branch-2.14 2/2] acinclude: Strip out -mno-avx512f provided by DPDK.

DPDK forces '-mno-avx512f' flag for the application if the toolchain used to build DPDK had broken AVX512 support. DPDK forces '-mno-avx512f' flag for the application if the toolchain used to build DPDK had broken AVX512 support. But OVS could be built with a completely different or fixed toolcha

[ovs-dev] [PATCH v1 branch-2.14 1/2] acinclude: Strip out -march provided by DPDK.

DPDK flags may include -march. Forcing -march could be considered too heavy a requirement when users compile OVS from source and could override user provided options. Resolve this by stripping -march from provided DPDK flags. Signed-off-by: Ian Stokes --- acinclude.m4 | 3 +++ 1 file changed, 3

Re: [ovs-dev] [PATCH v6 2/4] dpif-netdev: Add parameters to configure PMD auto load balance.

On 15/01/2021 17:22, Ilya Maximets wrote: > On 12/21/20 2:10 PM, Kevin Traynor wrote: >> From: Christophe Fontaine >> >> Two important parts of how PMD auto load balance operates are how >> loaded a core needs to be and how much improvement is estimated >> before a PMD auto load balance can trigge

Re: [ovs-dev] [PATCH v6 2/4] dpif-netdev: Add parameters to configure PMD auto load balance.

On 12/21/20 2:10 PM, Kevin Traynor wrote: > From: Christophe Fontaine > > Two important parts of how PMD auto load balance operates are how > loaded a core needs to be and how much improvement is estimated > before a PMD auto load balance can trigger. > > Previously they were hardcoded to 95% lo

Re: [ovs-dev] [PATCH v2] ovsdb: Use column diffs for ovsdb and raft log entries.

On 1/14/21 2:11 AM, Ilya Maximets wrote: Currently, ovsdb-server stores complete value for the column in a database file and in a raft log in case this column changed. This means that transaction that adds, for example, one new acl to a port group creates a log entry with all UUIDs of all existi

Re: [ovs-dev] [OVN Patch v12 3/4] ovn-northd: Introduce parallel lflow build

Bleep bloop. Greetings Anton Ivanov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #155 FILE: northd/ovn-northd.c:11

Re: [ovs-dev] [OVN Patch v12 1/4] ovn-libs: Add support for parallel processing

Bleep bloop. Greetings Anton Ivanov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 83 characters long (recommended limit is 79) #189 FILE: lib/fasthmap.c:148:

[ovs-dev] [OVN Patch v12 4/4] ovn-northd: Add configuration option for parallel lflow build

From: Anton Ivanov Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 2 ++ ovn-nb.xml | 13 + 2 files changed, 15 insertions(+) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 53e0cc50d..e7c6c97b5 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c

[ovs-dev] [OVN Patch v12 1/4] ovn-libs: Add support for parallel processing

From: Anton Ivanov This adds a set of functions and macros intended to process hashes in parallel. The principles of operation are documented in the fasthmap.h If these one day go into the OVS tree, the OVS tree versions would be used in preference. Signed-off-by: Anton Ivanov --- lib/automa

[ovs-dev] [OVN Patch v12 2/4] Fix BFD Calling conventions

From: Anton Ivanov The calling convention for the per-od/per-op routines is that any data is passed as a part of the lsi struct. This way the functions can be used in both sequential and parallel builds. Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 12 1 file changed, 8 i

[ovs-dev] [OVN Patch v12 3/4] ovn-northd: Introduce parallel lflow build

From: Anton Ivanov Datapaths, ports, igmp groups and load balancers can now be iterated over in parallel in order to speed up the lflow generation. This decreases the time needed to generate the logical flows by a factor of 4+ on a 6 core/12 thread CPU without datapath groups - from 0.8-1 microse

[ovs-dev] [PATCH] vswitchd.conf.db.5: Fix supported IPsec tunnels

'ovs-monitor-ipsec' does not support 'ip6gre' tunnels. Fixes: 22c5eafb6efa ("ipsec: reintroduce IPsec support for tunneling") Signed-off-by: Mark Gray --- vswitchd/vswitch.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml inde

[ovs-dev] [PATCH ovn] northd: Fix ACL fair log meters for Port_Group ACLs.

Commit 880dca99eaf7 added support for fair meters but didn't cover the case when an ACL is configured on a port group instead of a logical switch. Iterate over PG ACLs too when syncing fair meters to the Southbound database. Due to the fact that a meter might be used for ACLs that are applied on

Re: [ovs-dev] [PATCH] acinclude: Strip out -mno-avx512f provided by DPDK.

On 1/15/21 1:12 PM, Stokes, Ian wrote: >> Hi Folks, >> >> There are structs, defines and inlines in public headers that change depending on whether or not AVX* are used. I do not know if the resulting mix-and-match is safe to use, and most importantly if it is guaranteed t

Re: [ovs-dev] [PATCH] acinclude: Strip out -mno-avx512f provided by DPDK.

> Hi Folks, > > > > > > > > There are structs, defines and inlines in public headers that change > > > depending on whether or not AVX* are used. I do not know if the > > > resulting mix-and-match is safe to use, and most importantly if it is > > > guaranteed to be supported, and I think it shoul

Re: [ovs-dev] [PATCH] netdev-offload-dpdk: Reverting Temporary patch to fix broken hardware offload ethernet matching for XL710 NICs.

> Removing temporary patch - 023f257 (netdev-offload-dpdk: Fix for broken > ethernet matching HWOL for XL710NIC). > Ethernet pattern is now being set correctly withtin the i40e PMD. > Thanks for the patch Emma, pushed to master with slight modification to the title and some alignment changes in

Re: [ovs-dev] [PATCH v5] dpdk: Support running PMD threads on any core.

On 12/01/2021 16:24, Stokes, Ian wrote: > Hi David, > > Thanks for the patch, a few comments and queries inline. > >> DPDK 20.08 introduced a new API that associates a non-EAL thread to a free >> lcore. This new API does not change the thread characteristics (like CPU >> affinity). >> Using this

Re: [ovs-dev] [PATCH v6 2/4] dpif-netdev: Add parameters to configure PMD auto load balance.

> On 14/01/2021 19:49, Stokes, Ian wrote: > >> From: Christophe Fontaine > >> > >> Two important parts of how PMD auto load balance operates are how > >> loaded a core needs to be and how much improvement is estimated > >> before a PMD auto load balance can trigger. > >> > >> Previously they were

Re: [ovs-dev] [OVN Patch v11 1/4] ovn-libs: Add support for parallel processing

On 15/01/2021 09:55, Numan Siddique wrote: On Thu, Jan 14, 2021 at 10:12 PM > wrote: From: Anton Ivanov mailto:anton.iva...@cambridgegreys.com>> This adds a set of functions and macros intended to process hashes in parallel. The princi

Re: [ovs-dev] [PATCH v6 2/4] dpif-netdev: Add parameters to configure PMD auto load balance.

On 14/01/2021 19:49, Stokes, Ian wrote: >> From: Christophe Fontaine >> >> Two important parts of how PMD auto load balance operates are how >> loaded a core needs to be and how much improvement is estimated >> before a PMD auto load balance can trigger. >> >> Previously they were hardcoded to 95%

Re: [ovs-dev] [OVN Patch v11 3/4] ovn-northd: Introduce parallel lflow build

On Thu, Jan 14, 2021 at 10:12 PM wrote: > From: Anton Ivanov > > Datapaths, ports, igmp groups and load balancers can now > be iterated over in parallel in order to speed up the lflow > generation. This decreases the time needed to generate the > logical flows by a factor of 4+ on a 6 core/12 th

Re: [ovs-dev] [OVN Patch v11 1/4] ovn-libs: Add support for parallel processing

On Thu, Jan 14, 2021 at 10:12 PM wrote: > From: Anton Ivanov > > This adds a set of functions and macros intended to process > hashes in parallel. > > The principles of operation are documented in the fasthmap.h > > If these one day go into the OVS tree, the OVS tree versions > would be used in