Re: [ovs-dev] [ovs-dev v2] ofproto: add refcount to ofproto to fix crash at ofproto_destroy

Hi, Thanks William and Ilya for a detailed revisiting of the origin of the problem. I learned a lot. I now understand that the mix using of RCU and refcounts is not intended in the first place. But my point is that mix using RCU and refcounts now gives you more choices, and actually eases the cod

[ovs-dev] [PATCH v3] ofproto-dpif-xlate: fix zone set from non-frozen-metadata fields

CT zone could be set from a field that is not included in frozen metadata. Consider the example rules which are typically seen in OpenStack security group rules: priority=100,in_port=1,tcp,ct_state=-trk,action=ct(zone=5,table=0) priority=100,in_port=1,tcp,ct_state=+trk,action=ct(commit,zone=NXM_NX

Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: fix zone set from non-frozen-metadata fields

Hi, Sent a new version of the patch. 贺鹏 于2021年2月20日周六 上午10:21写道： > > Hi, Mark, > > thanks for the review! > > Mark Gray 于2021年2月19日周五 下午9:07写道： > > > > On 18/02/2021 09:43, Peng He wrote: > > > > One small comment below. By the way, good catch .. i found it difficult > > enough to review it, le

Re: [ovs-dev] [PATCH 1/4] conntrack: remove nat_conn

Hi, Thanks for the detailed reviews. These patches are like RFC to see if the work is interesting enough. Aaron Conole 于2021年2月25日周四 上午1:37写道： > > "hepeng.0320" writes: > > > From: hepeng > > > > Currently, when doing NAT, the userspace conntrack will use an extra > > conn for the two directio

Re: [ovs-dev] [PATCH v3] ofproto-dpif-xlate: fix zone set from non-frozen-metadata fields

Bleep bloop. Greetings 贺鹏, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Peng He needs to sign off. WARNING: Unexpected sign-offs from developers who are not author

Re: [ovs-dev] [PATCH v4 0/5] XDP offload using flow API provider

On 2021/02/26 10:13, William Tu wrote: On Thu, Feb 25, 2021 at 7:26 AM Toshiaki Makita wrote: On 2021/02/24 3:37, William Tu wrote: I don't know if this is too much to ask for. I wonder if you, or we can work together, to add at least a tunnel support, ex: vxlan? The current version is a good

Re: [ovs-dev] [ovs-dev v2] ofproto: add refcount to ofproto to fix crash at ofproto_destroy

Hi Hepeng, Thanks, now I understand. On Sat, Feb 27, 2021 at 12:54 AM 贺鹏 wrote: > > Hi, > > Thanks William and Ilya for a detailed revisiting of the origin of the > problem. I learned a lot. > > I now understand that the mix using of RCU and refcounts is not > intended in the first place. > But m