Re: [ovs-dev] [PATCH v2] ovs-ctl: Allow recording hostname separately

On Mon, Mar 1, 2021 at 9:26 PM Ilya Maximets wrote: > > On 2/25/21 4:28 PM, Frode Nordahl wrote: > > ovs-ctl determines the system FQDN or hostname and records it in > > the `external-ids:hostname` field of the `Open-vSwitch` table on > > system startup if it is not already set. > > > > This value

Re: [ovs-dev] [External] Re: [ovs-dev v2] ofproto: add refcount to ofproto to fix crash at ofproto_destroy

On Tue, Mar 2, 2021 at 4:15 AM Ilya Maximets wrote: > > On 2/27/21 9:53 AM, 贺鹏 wrote: > > Hi, > > > > Thanks William and Ilya for a detailed revisiting of the origin of the > > problem. I learned a lot. > > > > I now understand that the mix using of RCU and refcounts is not > > intended in the fir

Re: [ovs-dev] [PATCH] tunnel:fix vlan bug for tunnel forwarding

The VLAN id of the inner packet is 2, and the VLAN id of the tunnel port is 3. The result I expect should be that the packet can be forwarded from the VXLAN tunnel. And the VXLAN packet received by the destination should be in the following format, the outer VLAN id is 3, and the inner VLAN id is

Re: [ovs-dev] [PATCH ovn v7 0/5] Add DDlog implementation of ovn-northd

On Thu, Nov 19, 2020 at 12:53:45PM +0530, Numan Siddique wrote: > On Thu, Nov 19, 2020 at 10:43 AM Ben Pfaff wrote: > 1. In the last OVN weekly irc meeting, I had mentioned about > ovn-northd-ddlog taking a lot of time in the loop. I also shared the > scale test results with ddlog > (https://imgur

Re: [ovs-dev] [PATCH ovn v1] Static Routes: Add ability to specify "discard" nexthop

On Mon, Feb 22, 2021 at 07:40:15PM +, svc.eng.git-m...@nutanix.com wrote: > From: karthik-kc > > Physical switches have the ability to specify "discard" or sometimes > "NULL interface" as a nexthop for routes. This can be used to prevent > routing loops in the network. Add a similar configura

Re: [ovs-dev] [ovs-dev v2] ofproto: add refcount to ofproto to fix crash at ofproto_destroy

On Thu, Feb 25, 2021 at 10:31:35AM -0800, William Tu wrote: > I think refcount and RCU are mutually exclusive. They are two > different ways of doing synchronization and somehow we mix them > together by using RCU to optimize refcount. I think that you are correct in your description of the possib

Re: [ovs-dev] [PATCH 2/2] dpctl: dpif: allow viewing and configuring dp cache sizes

On Wed, Sep 02, 2020 at 12:12:44PM +0200, Eelco Chaudron wrote: > This patch adds a general way of viewing/configuring datapath > cache sizes. With an implementation for the netlink interface. I see you added support to multiple cache levels. Does that mean we can use to set sizes of EMC and SMC?

Re: [ovs-dev] [PATCH 1/2] dpctl: dpif: add kernel datapath cache hit output

Hi Eelco, Thanks for the patch. I added few comments in line below. On Wed, Sep 02, 2020 at 12:12:36PM +0200, Eelco Chaudron wrote: > This patch adds cache usage statistics to the output: > > $ ovs-dpctl show >

Re: [ovs-dev] [PATCH branch-2.7] ofproto-dpif-xlate: Fix leak in learn action

On 2/26/21 4:23 PM, Darragh O'Reilly via dev wrote: > On 2021-02-25 18:23:00, Gregory Rose via dev wrote: >>   >> This appears correct from my reading of the code.  LGTM. >> >> In reason why not to update to a more recent release?  2.7 is pretty >> old. >> >> Acked-by: Greg Rose >> > Thanks for th

Re: [ovs-dev] [PATCH v2] ovs-ctl: Allow recording hostname separately

On 2/25/21 4:28 PM, Frode Nordahl wrote: > ovs-ctl determines the system FQDN or hostname and records it in > the `external-ids:hostname` field of the `Open-vSwitch` table on > system startup if it is not already set. > > This value may be consumed by downstream software and having it > unset or s

Re: [ovs-dev] [PATCHv2] Documentation: Fix DPDK qos example.

On 2/18/21 5:52 PM, Eelco Chaudron wrote: > > > On 18 Feb 2021, at 16:24, William Tu wrote: > >> Fix the example use case based on the decription. >> EIR and CIR are measured in bytes/sec and considered 64-byte >> IP packets size withtout 14-byte Ethernet header. >> So fix the 1000pps example by

Re: [ovs-dev] [PATCH] raft: Add 'stop-raft-rpc' failure test command.

On 2/25/21 8:16 AM, Han Zhou wrote: > > > On Tue, Feb 23, 2021 at 5:18 AM Ilya Maximets > wrote: >> >> This command will stop sending and receiving any RAFT-related >> traffic or accepting new connections.  Useful to simulate >> network problems between cluster members

Re: [ovs-dev] [PATCH] raft: Report disconnected in cluster/status if candidate retries election.

On 2/25/21 8:14 AM, Han Zhou wrote: > > > On Tue, Feb 23, 2021 at 5:16 AM Ilya Maximets > wrote: >> >> If election times out for a server in 'candidate' role it sets >> 'candidate_retrying' flag that notifies that storage is disconnected >> and client should re-connect

Re: [ovs-dev] [PATCH] raft: Reintroduce jsonrpc inactivity probes.

On 2/25/21 8:06 AM, Han Zhou wrote: > > > On Tue, Feb 23, 2021 at 5:15 AM Ilya Maximets > wrote: >> >> It's not enough to just have heartbeats. >> >> RAFT heartbeats are unidirectional, i.e. leader sends them to followers >> but not the other way around.  Missing heart

Re: [ovs-dev] [PATCH v2] ovsdb-cs: Fix use-after-free for the request id.

On 3/1/21 5:18 PM, Dumitru Ceara wrote: > On 2/23/21 7:00 PM, Ilya Maximets wrote: >> ovsdb_cs_send_transaction() returns the pointer to the same >> 'request_id' object that is used internally.  This leads to >> situation where transaction in idl and CS module has the >> same 'request_id' object. 

Re: [ovs-dev] [ovs-dev v2] ofproto: add refcount to ofproto to fix crash at ofproto_destroy

On 2/27/21 9:53 AM, 贺鹏 wrote: > Hi, > > Thanks William and Ilya for a detailed revisiting of the origin of the > problem. I learned a lot. > > I now understand that the mix using of RCU and refcounts is not > intended in the first place. > But my point is that mix using RCU and refcounts now give

Re: [ovs-dev] [PATCH v2] netlink: ignore IFLA_WIRELESS events

On 1/14/21 10:09 AM, Michal Kazior wrote: > From: Michal Kazior > > Some older wireless drivers - ones relying on the > old and long deprecated wireless extension ioctl > system - can generate quite a bit of IFLA_WIRELESS > events depending on their configuration and > runtime conditions. These a

Re: [ovs-dev] [PATCH] tunnel:fix vlan bug for tunnel forwarding

On Mon, Mar 1, 2021 at 3:47 AM Ilya Maximets wrote: > > On 1/10/21 3:16 AM, Hongzhi Guo wrote: > > From: hongzhi guo > > > > I found the basic vxlan topology cannot work when upgrade ovs 2.12 version. > > Through debugging, I found that when the native tunnel forward, > > the inner vlan was used

Re: [ovs-dev] [PATCH ovn v3] ovn-controller: Split logical flow and phsyical flow processing.

an On Thu, Feb 25, 2021 at 3:42 PM Mark Gray wrote: > > On 18/02/2021 15:54, num...@ovn.org wrote: > > From: Numan Siddique > > Hi Numans, I can't comment on the design change but I have a few > comments/questions. Hi Mark, Thanks for the review. > > It needs to be rebased again. Just to hel

Re: [ovs-dev] [PATCH v2] ovsdb-cs: Fix use-after-free for the request id.

On 2/23/21 7:00 PM, Ilya Maximets wrote: ovsdb_cs_send_transaction() returns the pointer to the same 'request_id' object that is used internally. This leads to situation where transaction in idl and CS module has the same 'request_id' object. However, CS module is able to destroy this transacti

Re: [ovs-dev] [OVN Patch v15 1/3] ovn-libs: Add support for parallel processing

Bleep bloop. Greetings Anton Ivanov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has trailing whitespace #466 FILE: lib/ovn-parallel-hmap.c:425: } ERROR: Im

Re: [ovs-dev] [PATCH ovn] northd: Remove the usage of 'ct.inv' in logical flows.

On Fri, Feb 26, 2021 at 1:15 AM Han Zhou wrote: > > On Thu, Feb 25, 2021 at 1:25 AM Numan Siddique wrote: > > > > On Thu, Feb 25, 2021 at 1:12 PM Han Zhou wrote: > > > > > > On Wed, Feb 24, 2021 at 5:27 AM wrote: > > > > > > > > From: Numan Siddique > > > > > > > > Presently we add 65535 prior

Re: [ovs-dev] [PATCH ovn] ovn-northd: Warn for >1 IPv4 in build_lrouter_force_snat_flows_op().

On Thu, Feb 25, 2021 at 11:43 PM Ben Pfaff wrote: > > On Thu, Feb 25, 2021 at 11:21:26PM +0530, Numan Siddique wrote: > > On Thu, Feb 25, 2021 at 4:57 AM Ben Pfaff wrote: > > > > > > The comments here point out that more than one IPv4 address is a > > > problem (versus more than 2 IPv6 addresses)

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

On 3/1/2021 8:48 PM, Ilya Maximets wrote: On 3/1/21 9:30 AM, Chris Mi wrote: Hi Simon, Ilya, Could I know what should we do to make progress for this patch set? It has been posted in the community for a long time 😁 In general, the way to get your patches reviewed is to review other patches. I

Re: [ovs-dev] updating ovn's submodule for ovs

On Fri, Feb 26, 2021 at 8:27 AM Ben Pfaff wrote: > > Leonid pointed out that OVN's submodule for OVS is wrong now because it > doesn't include what ovn-northd-ddlog needs to build. Do we have a > policy or a practice on which commit to update it to? It's tempting to > just pick "current tip of O

[ovs-dev] [PATCH ovn] ovn-nbctl: update BFD rows in nbctl_lr_route_del routine

Remove BFD entry if its the last reference in static_routes table has been removed. Signed-off-by: Lorenzo Bianconi --- tests/ovn-nbctl.at| 11 --- utilities/ovn-nbctl.c | 17 + 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/tests/ovn-nbctl.at b/tests

[ovs-dev] [OVN Patch v15 1/3] ovn-libs: Add support for parallel processing

From: Anton Ivanov This adds a set of functions and macros intended to process hashes in parallel. The principles of operation are documented in the ovn-parallel-hmap.h If these one day go into the OVS tree, the OVS tree versions would be used in preference. Signed-off-by: Anton Ivanov --- l

[ovs-dev] [OVN Patch v15 2/3] ovn-northd: Introduce parallel lflow build

From: Anton Ivanov Datapaths, ports, igmp groups and load balancers can now be iterated over in parallel in order to speed up the lflow generation. This decreases the time needed to generate the logical flows by a factor of 4+ on a 6 core/12 thread CPU without datapath groups - from 0.8-1 microse

[ovs-dev] [OVN Patch v15 3/3] ovn-northd: Add configuration option for parallel lflow build

From: Anton Ivanov Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 3 +++ ovn-nb.xml | 13 + 2 files changed, 16 insertions(+) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 4b2591385..5fbd6a819 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

On 3/1/21 9:30 AM, Chris Mi wrote: > Hi Simon, Ilya, > > Could I know what should we do to make progress for this patch set? > It has been posted in the community for a long time 😁 In general, the way to get your patches reviewed is to review other patches. It's simply because we still have a hu

Re: [ovs-dev] [PATCH V2 10/14] netdev-offload-dpdk: Support tunnel pop action

On 3/1/2021 1:30 PM, Sriharsha Basavapatna wrote: The details of this array is under the PMD's responsibility. So this means the PMD has to pick a range of private action values that are not defined in rte_flow.h, but what if later a new action type with the same value is added to rte_flow.h

Re: [ovs-dev] [PATCH V2 13/14] netdev-offload-dpdk: Support vports flows offload

On 3/1/2021 1:30 PM, Sriharsha Basavapatna wrote: On Thu, Feb 25, 2021 at 7:51 PM Eli Britstein wrote: On 2/25/2021 9:35 AM, Sriharsha Basavapatna wrote: On Wed, Feb 24, 2021 at 4:50 PM Eli Britstein wrote: On 2/24/2021 12:37 PM, Sriharsha Basavapatna wrote: On Wed, Feb 10, 2021 at 8:57

Re: [ovs-dev] [PATCH] tunnel:fix vlan bug for tunnel forwarding

On 1/10/21 3:16 AM, Hongzhi Guo wrote: > From: hongzhi guo > > I found the basic vxlan topology cannot work when upgrade ovs 2.12 version. > Through debugging, I found that when the native tunnel forward, > the inner vlan was used for forwarding mistakely. > Which resulted in packet loss on the t

Re: [ovs-dev] [PATCH V2 13/14] netdev-offload-dpdk: Support vports flows offload

On Thu, Feb 25, 2021 at 7:51 PM Eli Britstein wrote: > > > On 2/25/2021 9:35 AM, Sriharsha Basavapatna wrote: > > On Wed, Feb 24, 2021 at 4:50 PM Eli Britstein wrote: > >> > >> On 2/24/2021 12:37 PM, Sriharsha Basavapatna wrote: > >>> On Wed, Feb 10, 2021 at 8:57 PM Eli Britstein wrote: > V

Re: [ovs-dev] [PATCH V2 10/14] netdev-offload-dpdk: Support tunnel pop action

On Thu, Feb 25, 2021 at 7:50 PM Eli Britstein wrote: > > > On 2/25/2021 9:35 AM, Sriharsha Basavapatna wrote: > > On Wed, Feb 24, 2021 at 1:50 PM Eli Britstein wrote: > >> > >> On 2/24/2021 9:52 AM, Sriharsha Basavapatna wrote: > >>> On Wed, Feb 10, 2021 at 8:57 PM Eli Britstein wrote: > Su

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

Hi Simon, Ilya, Could I know what should we do to make progress for this patch set? It has been posted in the community for a long time 😁 Thanks, Chris On 2/23/2021 5:08 PM, Roi Dayan wrote: On 2021-01-27 8:23 AM, Chris Mi wrote: This patch set adds offload support for sFlow. Psample is a