Re: [ovs-dev] [PATCH ovn] northd: Remove the usage of 'ct.inv' in logical flows.

2021-03-04 Thread Han Zhou
On Thu, Mar 4, 2021 at 5:25 PM Numan Siddique wrote: > > On Fri, Mar 5, 2021 at 4:22 AM Han Zhou wrote: > > > > On Mon, Mar 1, 2021 at 5:40 AM Numan Siddique wrote: > > > > > > On Fri, Feb 26, 2021 at 1:15 AM Han Zhou wrote: > > > > > > > > On Thu, Feb 25, 2021 at 1:25 AM Numan Siddique

Re: [ovs-dev] [PATCH ovn 2/2] northd: Fix the missing force_snat_for_lb flows when router_ip is configured.

2021-03-04 Thread Numan Siddique
On Fri, Mar 5, 2021 at 7:10 AM Ben Pfaff wrote: > > On Fri, Mar 05, 2021 at 06:46:55AM +0530, Numan Siddique wrote: > > On Fri, Mar 5, 2021 at 2:30 AM Ben Pfaff wrote: > > > > > > On Wed, Mar 03, 2021 at 11:32:39PM +0530, num...@ovn.org wrote: > > > > From: Numan Siddique > > > > > > > > The

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-03-04 Thread Chris Mi
Hi Ilya, I think about your suggestion recently. But I'm still not very clear about the design. Please see my reply below: On 3/1/2021 8:48 PM, Ilya Maximets wrote: On 3/1/21 9:30 AM, Chris Mi wrote: Hi Simon, Ilya, Could I know what should we do to make progress for this patch set? It has

Re: [ovs-dev] [PATCH ovn 2/2] northd: Fix the missing force_snat_for_lb flows when router_ip is configured.

2021-03-04 Thread Ben Pfaff
On Fri, Mar 05, 2021 at 06:46:55AM +0530, Numan Siddique wrote: > On Fri, Mar 5, 2021 at 2:30 AM Ben Pfaff wrote: > > > > On Wed, Mar 03, 2021 at 11:32:39PM +0530, num...@ovn.org wrote: > > > From: Numan Siddique > > > > > > The commit c6e21a23bd8 which supported the option > > >

Re: [ovs-dev] [PATCH ovn] northd: Remove the usage of 'ct.inv' in logical flows.

2021-03-04 Thread Numan Siddique
On Fri, Mar 5, 2021 at 4:22 AM Han Zhou wrote: > > On Mon, Mar 1, 2021 at 5:40 AM Numan Siddique wrote: > > > > On Fri, Feb 26, 2021 at 1:15 AM Han Zhou wrote: > > > > > > On Thu, Feb 25, 2021 at 1:25 AM Numan Siddique wrote: > > > > > > > > On Thu, Feb 25, 2021 at 1:12 PM Han Zhou wrote: > >

Re: [ovs-dev] [PATCH ovn 2/2] northd: Fix the missing force_snat_for_lb flows when router_ip is configured.

2021-03-04 Thread Numan Siddique
On Fri, Mar 5, 2021 at 2:30 AM Ben Pfaff wrote: > > On Wed, Mar 03, 2021 at 11:32:39PM +0530, num...@ovn.org wrote: > > From: Numan Siddique > > > > The commit c6e21a23bd8 which supported the option > > 'lb_force_snat_ip=router_ip' > > on a gateway router, missed out on > > - updating the

Re: [ovs-dev] [PATCH ovn] northd: Remove the usage of 'ct.inv' in logical flows.

2021-03-04 Thread Han Zhou
On Mon, Mar 1, 2021 at 5:40 AM Numan Siddique wrote: > > On Fri, Feb 26, 2021 at 1:15 AM Han Zhou wrote: > > > > On Thu, Feb 25, 2021 at 1:25 AM Numan Siddique wrote: > > > > > > On Thu, Feb 25, 2021 at 1:12 PM Han Zhou wrote: > > > > > > > > On Wed, Feb 24, 2021 at 5:27 AM wrote: > > > > > >

Re: [ovs-dev] [PATCH ovn 2/2] northd: Fix the missing force_snat_for_lb flows when router_ip is configured.

2021-03-04 Thread Ben Pfaff
On Wed, Mar 03, 2021 at 11:32:39PM +0530, num...@ovn.org wrote: > From: Numan Siddique > > The commit c6e21a23bd8 which supported the option 'lb_force_snat_ip=router_ip' > on a gateway router, missed out on > - updating the flows in 'lr_in_dnat' to set 'flags.force_snat_for_lb = 1'. > -

Re: [ovs-dev] [PATCH ovn 1/2] northd-ddlog: Fix lb_force_snat_ip router option.

2021-03-04 Thread Ben Pfaff
On Wed, Mar 03, 2021 at 11:32:22PM +0530, num...@ovn.org wrote: > From: Numan Siddique > > There were few typos because of which lflows related to > router option lb_force_snat_ip were not generated correctly. > > This patch fixes it. > > Fixes: 0e77b3bcbfe("ovn-northd-ddlog: New

Re: [ovs-dev] [PATCH v5] python: Send notifications after the transaction ends

2021-03-04 Thread Brian Haley
Acked-by: Brian Haley Thanks for fixing this Terry. -Brian On 3/4/21 11:18 AM, Terry Wilson wrote: The Python IDL notification mechanism was sending a notification for each processed update in a transaction as it was processed. This causes issues with multi-row changes that contain

Re: [ovs-dev] [PATCH v4 1/1] python: Send notifications after the transaction ends

2021-03-04 Thread 0-day Robot
Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Terry Wilson needs to sign off. Lines checked: 220, Warnings: 0, Errors: 1

[ovs-dev] [PATCH] RFC: netdev-afxdp: Support for XDP metadata HW hints.

2021-03-04 Thread William Tu
One big problem of netdev-afxdp is that there is no metadata support from the hardware at all. For example, OVS netdev-afxdp has to do rxhash, or TCP checksum in software, resulting in high performance overhead. A generic meta data type for XDP frame using BTF is proposed[1] and there is sample

Re: [ovs-dev] [PATCH ovn 00/11] ovn-northd-ddlog improvements

2021-03-04 Thread Ben Pfaff
On Thu, Mar 04, 2021 at 06:07:42PM +0530, Numan Siddique wrote: > On Thu, Mar 4, 2021 at 9:40 AM Ben Pfaff wrote: > Thanks for this series. > > Acked-by: Numan Siddique > > Please note that I'm still learning ddlog and haven't understood much > of the northd ddlog code. > > I ran the patches

Re: [ovs-dev] [PATCH v5] python: Send notifications after the transaction ends

2021-03-04 Thread Flavio Fernandes
Acked-by: Flavio Fernandes mailto:fla...@flaviof.com>> > On Mar 4, 2021, at 11:18 AM, Terry Wilson wrote: > > The Python IDL notification mechanism was sending a notification > for each processed update in a transaction as it was processed. > This causes issues with multi-row changes that

Re: [ovs-dev] [PATCH v3] netlink: ignore IFLA_WIRELESS events

2021-03-04 Thread 0-day Robot
Bleep bloop. Greetings Michal Kazior, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #158 FILE: lib/rtnetlink.h:49:

[ovs-dev] [PATCH v4] netlink: ignore IFLA_WIRELESS events

2021-03-04 Thread Michal Kazior
From: Michal Kazior Some older wireless drivers - ones relying on the old and long deprecated wireless extension ioctl system - can generate quite a bit of IFLA_WIRELESS events depending on their configuration and runtime conditions. These are delivered as RTNLGRP_LINK via RTM_NEWLINK messages.

[ovs-dev] [PATCH v5] python: Send notifications after the transaction ends

2021-03-04 Thread Terry Wilson
The Python IDL notification mechanism was sending a notification for each processed update in a transaction as it was processed. This causes issues with multi-row changes that contain references to each other. For example, if a Logical_Router_Port is created along with a Gateway_Chassis, and the

[ovs-dev] [PATCH v4 1/1] python: Send notifications after the transaction ends

2021-03-04 Thread Terry Wilson
The Python IDL notification mechanism was sending a notification for each processed update in a transaction as it was processed. This causes issues with multi-row changes that contain references to each other. For example, if a Logical_Router_Port is created along with a Gateway_Chassis, and the

[ovs-dev] [PATCH v4 0/1] Send notifications after the transaction ends

2021-03-04 Thread Terry Wilson
Ok, I think this is likely to be the final iteration of the patch as we are down to the typos. In Neutron, we process these notifications in a separate thread. So what that means is that we were experiencing race conditions where sometimes the notification's row would have a value set, and other

[ovs-dev] [PATCH v3] netlink: ignore IFLA_WIRELESS events

2021-03-04 Thread Michal Kazior
From: Michal Kazior Some older wireless drivers - ones relying on the old and long deprecated wireless extension ioctl system - can generate quite a bit of IFLA_WIRELESS events depending on their configuration and runtime conditions. These are delivered as RTNLGRP_LINK via RTM_NEWLINK messages.

[ovs-dev] [PATCH v2 3/3] netdev-offload-tc: Add support for ct_state flags inv and rpl

2021-03-04 Thread Paul Blakey
Signed-off-by: Paul Blakey Acked-by: Roi Dayan --- lib/netdev-offload-tc.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c index 0775883..8553cb2 100644 --- a/lib/netdev-offload-tc.c +++

[ovs-dev] [PATCH v2 2/3] netdev-offload-tc: Probe for support for any of the ct_state flags

2021-03-04 Thread Paul Blakey
Upstream kernel now rejects unsupported ct_state flags. Earlier kernels, ignored it but still echoed back the requested ct_state, if ct_state was supported. ct_state initial support had trk, new, est, and rel flags. If kernel echos back ct_state, assume support for trk, new, est, and rel. If

[ovs-dev] [PATCH v2 0/3] Add offload support for ct_state rpl and inv flags

2021-03-04 Thread Paul Blakey
Add offload support for ct_state rpl and inv flags. For example: ovs-ofctl del-flows br-ovs ovs-ofctl add-flow br-ovs arp,actions=normal ovs-ofctl add-flow br-ovs "table=0, ip,ct_state=-trk actions=ct(table=1,zone=5)" ovs-ofctl add-flow br-ovs "table=1, ip,ct_state=+trk+new actions=ct(zone=5,

[ovs-dev] [PATCH v2 1/3] compat: Add ct_state flags definitions

2021-03-04 Thread Paul Blakey
Add TCA_FLOWER_KEY_CT_FLAGS_REPLY, and TCA_FLOWER_KEY_CT_FLAGS_INVALID. Signed-off-by: Paul Blakey Acked-by: Roi Dayan --- acinclude.m4| 6 +++--- include/linux/pkt_cls.h | 5 - 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index

Re: [ovs-dev] [PATCH ovn 00/11] ovn-northd-ddlog improvements

2021-03-04 Thread Numan Siddique
On Thu, Mar 4, 2021 at 9:40 AM Ben Pfaff wrote: > > The first commit here is an improvement to the tests. It is not > ddlog specific: > tests: Improve synchronization and debuggability. > > The next commit is an improvement to ovs-sandbox for > ovn-northd-ddlog: > ovs-sandbox: Make it

Re: [ovs-dev] [PATCH 2/3] netdev-offload-tc: Probe for support for any of the ct_state flags

2021-03-04 Thread Paul Blakey
On Wed, 3 Mar 2021, Marcelo Ricardo Leitner wrote: > Hi, > > On Wed, Mar 03, 2021 at 02:15:35PM +0200, Paul Blakey wrote: > > Upstream kernel now rejects unsupported ct_state flags. > > Earlier kernels, ignored it but still echoed back the requested ct_state, > > if ct_state was supported.

Re: [ovs-dev] [PATCH v3 2/2] dpctl: dpif: allow viewing and configuring dp cache sizes

2021-03-04 Thread Eelco Chaudron
On 3 Mar 2021, at 21:44, Flavio Leitner wrote: > On Wed, Mar 03, 2021 at 02:53:22PM +0100, Eelco Chaudron wrote: >> This patch adds a general way of viewing/configuring datapath >> cache sizes. With an implementation for the netlink interface. >> >> The ovs-dpctl/ovs-appctl show commands will

Re: [ovs-dev] [PATCH v3 1/2] dpctl: dpif: add kernel datapath cache hit output

2021-03-04 Thread Eelco Chaudron
On 3 Mar 2021, at 21:44, Flavio Leitner wrote: On Wed, Mar 03, 2021 at 02:52:33PM +0100, Eelco Chaudron wrote: This patch adds cache usage statistics to the output: $ ovs-dpctl show system@ovs-system: lookups: hit:24 missed:71 lost:0 flows: 0 masks: hit:334 total:0