Hi,
On 3/8/21 6:21 PM, Gaëtan Rivet wrote:
> On Mon, Mar 8, 2021, at 16:04, Maxime Coquelin wrote:
>> Hi Gaetan,
>>
>> On 2/10/21 4:33 PM, Gaetan Rivet wrote:
>>> Expose functions reporting user configuration of offloading threads, as
>>> well as utility functions for multithreading.
>>>
>>> This
Is this a version that mixes using refcount and RCU?
do we have reached an agreement?
BTW, please use my company email address: hepeng.0...@bytedance.com
thanks.
Hongzhi Guo 于2021年3月8日周一 上午11:34写道：
>
> ASAN report use-after-free of ofproto when destroy ofproto_rule.
> The rule uses both RCU and
On Sun, Mar 07, 2021 at 04:22:02PM +0200, Paul Blakey wrote:
> Upstream kernel now rejects unsupported ct_state flags.
> Earlier kernels, ignored it but still echoed back the requested ct_state,
> if ct_state was supported. ct_state initial support had trk, new, est,
> and rel flags.
>
> If kernel
The Python IDL notification mechanism was sending a notification
for each processed update in a transaction as it was processed.
This causes issues with multi-row changes that contain references
to each other.
For example, if a Logical_Router_Port is created along with a
Gateway_Chassis, and the L
On 3/3/21 3:39 PM, Dumitru Ceara wrote:
> IDL tests need predictable output from test-ovsdb.
>
> This used to be done by first sorting the output of test-ovsdb and then
> applying uuidfilt to predictably translate UUIDs. This was not
> reliable enough in case test-ovsdb processes two or more inse
On 3/3/21 3:40 PM, Dumitru Ceara wrote:
> Considering two DB rows, 'a' from table A and 'b' from table B (with
> column 'ref_a' a reference to table A):
> a = {A._uuid=}
> b = {B._uuid=, B.ref_a=}
>
> Assuming both records are present in the IDL client's in-memory view of
> the database, depending
On Thu, Feb 18, 2021 at 11:48 AM Kevin Traynor wrote:
>
> These tests focus on enabling/disabling and user parameters.
>
> Signed-off-by: Kevin Traynor
The patch looks good to me and I tested it with no issue.
Just two small comments, see below.
> ---
> tests/alb.at | 256 +
On 3/9/21 3:36 PM, Ilya Maximets wrote:
On 3/3/21 3:39 PM, Dumitru Ceara wrote:
IDL tests need predictable output from test-ovsdb.
This used to be done by first sorting the output of test-ovsdb and then
applying uuidfilt to predictably translate UUIDs. This was not
reliable enough in case test
On 3/9/21 4:07 PM, Ilya Maximets wrote:
On 3/3/21 3:40 PM, Dumitru Ceara wrote:
Considering two DB rows, 'a' from table A and 'b' from table B (with
column 'ref_a' a reference to table A):
a = {A._uuid=}
b = {B._uuid=, B.ref_a=}
Assuming both records are present in the IDL client's in-memory vi
Paolo Valerio writes:
> since a27d70a89 ("conntrack: add generic IP protocol support") all
> the unrecognized IP protocols gets handled using ct_proto_other ops
> and are managed as L3 using 3 tuples.
>
> This patch stores L4 informations for SCTP in the conn_key so that
> multiple conn instances
Acked-by: Brian Haley
-Brian
On 3/9/21 9:34 AM, Terry Wilson wrote:
The Python IDL notification mechanism was sending a notification
for each processed update in a transaction as it was processed.
This causes issues with multi-row changes that contain references
to each other.
For example, if
On 3/9/21 5:26 PM, Dumitru Ceara wrote:
> On 3/9/21 4:07 PM, Ilya Maximets wrote:
>> On 3/3/21 3:40 PM, Dumitru Ceara wrote:
>>> Considering two DB rows, 'a' from table A and 'b' from table B (with
>>> column 'ref_a' a reference to table A):
>>> a = {A._uuid=}
>>> b = {B._uuid=, B.ref_a=}
>>>
>>> A
On 3/9/21 5:54 PM, Ilya Maximets wrote:
> On 3/9/21 5:26 PM, Dumitru Ceara wrote:
>> On 3/9/21 4:07 PM, Ilya Maximets wrote:
>>> On 3/3/21 3:40 PM, Dumitru Ceara wrote:
Considering two DB rows, 'a' from table A and 'b' from table B (with
column 'ref_a' a reference to table A):
a = {A
On 3/9/21 5:56 PM, Ilya Maximets wrote:
On 3/9/21 5:54 PM, Ilya Maximets wrote:
On 3/9/21 5:26 PM, Dumitru Ceara wrote:
On 3/9/21 4:07 PM, Ilya Maximets wrote:
On 3/3/21 3:40 PM, Dumitru Ceara wrote:
Considering two DB rows, 'a' from table A and 'b' from table B (with
column 'ref_a' a referen
Hi Aaron,
thanks for the feedback
Aaron Conole writes:
> Paolo Valerio writes:
>
>> since a27d70a89 ("conntrack: add generic IP protocol support") all
>> the unrecognized IP protocols gets handled using ct_proto_other ops
>> and are managed as L3 using 3 tuples.
>>
>> This patch stores L4 info
On Mon, Mar 08, 2021 at 02:43:20PM -0800, Han Zhou wrote:
> On Fri, Mar 5, 2021 at 1:10 PM Ben Pfaff wrote:
> >
> > 'test "$a"' is always true if $abc is nonempty.
>
> I guess you meant: 'test "$abc"' is ... :)
Yes, thanks, I fixed the commit message here and applied this to master.
> Acked-by:
On Mon, Mar 08, 2021 at 02:44:16PM -0800, Han Zhou wrote:
> On Fri, Mar 5, 2021 at 1:10 PM Ben Pfaff wrote:
> >
> > Signed-off-by: Ben Pfaff
> > ---
> > tests/ovn.at | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/ovn.at b/tests/ovn.at
> > index 87579e59d7a
On Thu, Mar 04, 2021 at 10:15:47AM -0800, Ben Pfaff wrote:
> On Thu, Mar 04, 2021 at 06:07:42PM +0530, Numan Siddique wrote:
> > On Thu, Mar 4, 2021 at 9:40 AM Ben Pfaff wrote:
> > Thanks for this series.
> >
> > Acked-by: Numan Siddique
> >
> > Please note that I'm still learning ddlog and hav
Otherwise we will see these deltas every time we go through the main
loop, which is harmless but unnecessary.
Signed-off-by: Ben Pfaff
---
northd/ovn-northd-ddlog.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/northd/ovn-northd-ddlog.c b/northd/ovn-northd-ddlog.c
index
ddlog_delta_get_table() returns data that must be freed, but the code
in northd_update_probe_interval() did not do that. This fixes it.
In addition, the accumulated deltas weren't freed when the daemon exits.
This doesn't really matter but it's cleaner to do so, so this commit
also does that.
Si
Seems overall like a cleanup.
Signed-off-by: Ben Pfaff
---
northd/ovn-northd-ddlog.c | 58 ++-
1 file changed, 33 insertions(+), 25 deletions(-)
diff --git a/northd/ovn-northd-ddlog.c b/northd/ovn-northd-ddlog.c
index 80d3aa8d8aeb..4efdfa38749a 100644
--- a/n
This string is allocated in northd_ctx_create() but until now it was
not freed.
Signed-off-by: Ben Pfaff
Reported-by: Numan Siddique
---
northd/ovn-northd-ddlog.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/northd/ovn-northd-ddlog.c b/northd/ovn-northd-ddlog.c
index 4efdfa38749a..c98bde
On Thu, Mar 04, 2021 at 06:07:42PM +0530, Numan Siddique wrote:
> On Thu, Mar 4, 2021 at 9:40 AM Ben Pfaff wrote:
> Another issue I want to report (which I see happening with the present
> master).
> When the sources are configured with "CFLAGS=-g -fsanitize=address",
> many tests fail with addre
new_delta has the error status but this function was checking a
different variable instead.
Found by inspection.;
Signed-off-by: Ben Pfaff
---
northd/ovn-northd-ddlog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/northd/ovn-northd-ddlog.c b/northd/ovn-northd-ddlog.c
inde
On Fri, Mar 5, 2021 at 2:54 PM Ben Pfaff wrote:
>
> The Logical_Flow table can have rows that differ only in actions. Such
> rows would have identical matches and priorities and be in the same
> datapath. At first glance, any these rows would be a bug, since they'd
> match the same packets and t
Hi all
We've recently encountered an interesting situation with OVS conntrack
when offloading to the TC datapath, and would like some feedback. Sorry
about the longish wall of text, but I'm trying to explain the problem
as clearly as possible. The very short summary is that there is a mismatch
in
26 matches
Mail list logo
