On Tue, Apr 20, 2021 at 1:55 PM Mark Michelson wrote:
>
> Looks good and passes for me regularly. I'm curious if this issue with
> the pcap file is common across other failing tests.
It could be. That's why I thought adding the reset pcap file function
as a common
function. We should change the
From: Alexey Roytman
When ovn-sbctl lflow-list gets lflow argument with 0x prefix, e.g. 0x8131c8a8,
it prints correct output, but fails with coredump.
For example:
ovn-sbctl --uuid lflow-list sw1 0x8131c8a8
Bleep bloop. Greetings Alexey Roytman, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line has trailing whitespace
#32 FILE: utilities/ovn-sbctl.c:769:
{
WARNING: Lin
Bleep bloop. Greetings Alexey Roytman, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line has trailing whitespace
#32 FILE: utilities/ovn-sbctl.c:769:
{
WARNING: Lin
From: Alexey Roytman
When ovn-sbctl lflow-list gets lflow argument with 0x prefix, e.g. 0x8131c8a8,
it prints correct output, but fails with coredump.
For example:
ovn-sbctl --uuid lflow-list sw1 0x8131c8a8
From: Alexey Roytman
When ovn-sbctl lflow-list gets lflow argument with 0x prefix, e.g. 0x8131c8a8,
it prints correct output, but fails with coredump.
For example:
ovn-sbctl --uuid lflow-list sw1 0x8131c8a8
Hi,
Thanks for the quick reaction!
I've tested your patch against 20.06.3 and it works well for me.
May I ask you to backport your patch down to supported branches?
Tested-by: Vladislav Odintsov
On 20.04.2021, 20:58, "dev on behalf of Mark Michelson"
wrote:
Acked-by: Mark Michelson
On Tue, Apr 20, 2021 at 12:43 AM Dumitru Ceara wrote:
>
> On 4/19/21 7:24 PM, Han Zhou wrote:
> > On Mon, Apr 19, 2021 at 12:27 AM Dumitru Ceara
wrote:
> >>
> >> On 4/16/21 7:16 PM, Mark Michelson wrote:
> >>> Thanks for the explanation Dumitru. It made good sense out of what had
> >>> to be a di
Acked-by: Mark Michelson
On 4/14/21 6:09 AM, Dumitru Ceara wrote:
This doubles the size of the test matrix but should help protecting
against regressions.
This change is inspired from Ilya's work below but instead of selectively
running tests with Datapath Groups if an external variable is set
Commit 35b00c7e79 ('northd: Add ECMP support to router policies.')
introduced 'nexthops' column in the Logical_Router_Policy table to
support ECMP for router policies however print_routing_policy() still
dumps legacy 'nexthop' column as policy next hop.
Fix the issue dumping 'nexthops' columns.
Fi
Acked-by: Mark Michelson
On 4/20/21 6:32 AM, Dumitru Ceara wrote:
Without this ovn-controller-vtep fails to register new chassis when RBAC
is enabled.
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-dev/2021-April/382207.html
Reported-by: Odintsov Vladislav
Fixes: d06760b64276 ("ovn:
Looks good and passes for me regularly. I'm curious if this issue with
the pcap file is common across other failing tests.
Acked-by: Mark Michelson
On 4/17/21 4:39 PM, num...@ovn.org wrote:
From: Numan Siddique
This test is failing quite often due to timing issues. The failures are
mainly
> Acked-by: Mark Michelson
>
> See below for one tiny nit that doesn't affect the ACK-edness of the patch.
ack, I will fix it in v2.
Regards,
Lorenzo
>
> On 4/12/21 5:12 PM, Lorenzo Bianconi wrote:
> > Commit 35b00c7e79 ('northd: Add ECMP support to router policies.')
> > introduced 'nexthops
Acked-by: Mark Michelson
See below for one tiny nit that doesn't affect the ACK-edness of the patch.
On 4/12/21 5:12 PM, Lorenzo Bianconi wrote:
Commit 35b00c7e79 ('northd: Add ECMP support to router policies.')
introduced 'nexthops' column in the Logical_Router_Policy table to
support ECMP fo
Hi Dan,
Acked-by: Mark Michelson
for both patches in the series.
On 4/12/21 10:58 AM, Dan Williams wrote:
Wait for the databases to actually exit before returning to
the caller of ovn-ctl.
v1 -> v2
-
* No code changes
* Fixed stop_ovn_daemon() name in patch headers
* Added "ovn"
Previous behavior of ovn-controller was to only create MAC bindings for
the same addresses for which we would send gARPs. That is:
* A logical switch has its "nat_addresses" configured.
* That logical switch has a localnet port.
This makes sense for gARPs: we only want to send gARPs for addresses
northd currently stores logical switch port's configured "nat-addresses"
in the southbound Port_Binding "nat_addresses" column. This allows for
explicit configuration of which NAT addresses should be broadcast in
gARP messages by OVN.
This adds a similar column, "router_addresses" to the Port_Bind
Previously, ARP TPAs were filtered down only to "reachable" addresses.
Reachable addresses are all router interface addresses, as well as NAT
external addresses and load balancer VIPs that are within the subnet
handled by a router's port.
However, it is possible that in some configurations, CMSes
Signed-off-by: Mark Michelson
---
ovn-sb.xml | 10 --
1 file changed, 10 deletions(-)
diff --git a/ovn-sb.xml b/ovn-sb.xml
index 258a12b4e..b853a5031 100644
--- a/ovn-sb.xml
+++ b/ovn-sb.xml
@@ -3015,16 +3015,6 @@ tcp.flags = RST;
The chassis in which the port resides.
When a hairpin scenario is detected (i.e. egressing on gateway router
port to a NAT external address), we loop back to the ingress router
pipeline and swap the inport and outport. This is intended to allow for
the traffic to get DNATted. In practice, though, the ethernet
destination has not been up
This patch series aims to fix issues seen in OpenStack deployments when
floating IPs were assigned to routers, and those floating IPs were not
part of any subnet configured on that router.
Originally, this was a two patch series but it has bloomed into a 5
patch series.
Patch 1 fixes the scenario
On 19/04/2021 21:58, num...@ovn.org wrote:
> @@ -4099,6 +4099,9 @@ do_ovn_lflow_add(struct hmap *lflow_map, bool shared,
> hmap_insert_fast(lflow_map, &lflow->hmap_node, hash);
> }
>
> +/* If this option is 'true' northd will make use of ct.inv match fields.
> + * Otherwise, it will avoid u
On 4/19/21 7:36 PM, Odintsov Vladislav wrote:
> Hi Dumitru,
>
Hi Vladislav,
> I've seen your patches have been backported to 20.06 branch and tried it with
> RBAC-enabled installation. It seems working for ovn-controller, but for
> ovn-controller-vtep I still see similar errors.
> Should this
Without this ovn-controller-vtep fails to register new chassis when RBAC
is enabled.
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-dev/2021-April/382207.html
Reported-by: Odintsov Vladislav
Fixes: d06760b64276 ("ovn: Restrict encap modification to its creating chassis")
Signed-off-by:
On 4/9/21 1:28 PM, Simon Horman wrote:
> On Thu, Apr 08, 2021 at 09:33:12PM +0800, wangyunjian wrote:
>> From: Yunjian Wang
>>
>> Before info.tc_modify_flow_deleted is assigned a value, error
>> processing of other statements goes to the out label. In the
>> out label, the uninitialized variant is
On 3/31/21 10:45 PM, Marcelo Ricardo Leitner wrote:
> On Tue, Mar 30, 2021 at 01:00:15PM +0300, Ariel Levkovich wrote:
>
> TCA_FLOWER_KEY_CT_FLAGS_RELATED is already defined in ovs' copy at
> include/linux/pkt_cls.h, so no change there is needed.
> To and from flower parsing is handled below.
> Ma
On 4/13/21 2:17 PM, Michal Kazior wrote:
> From: Michal Kazior
>
> Some older wireless drivers - ones relying on the
> old and long deprecated wireless extension ioctl
> system - can generate quite a bit of IFLA_WIRELESS
> events depending on their configuration and
> runtime conditions. These ar
On 4/13/21 9:28 PM, Flavio Leitner wrote:
> On Tue, Apr 13, 2021 at 01:06:40PM -0400, Mark Gray wrote:
>> This patch fixes an issue where, depending on timing fluctuations,
>> each node has not fully loaded all connections before the other
>> node begins to establish a connection. In this failure c
On 4/5/21 4:42 AM, Tonghao Zhang wrote:
> On Mon, Apr 5, 2021 at 1:32 AM Ilya Maximets wrote:
>>
>> 'dpif_execute_helper_cb' doesn't initilalize the 'hash' field that
>> may be passed down to datapath and might cause execution of a different
>> set of actions, e.g. on recirculation.
>>
>> Thread
On 4/5/21 4:31 PM, William Tu wrote:
> On Sun, Apr 4, 2021 at 10:31 AM Ilya Maximets wrote:
>>
>> 'struct erspan_metadata' contains union with fields of different
>> sizes, hence not all the memory initiliazed. This memory goes
>> to syscalls and also used to compare ukeys with memcmp which may
>
On 4/19/21 3:13 PM, Marcelo Leitner wrote:
> On Mon, Apr 19, 2021 at 08:25:01AM -0400, Aaron Conole wrote:
>> Backport the recent fixes related to ct-offload state flags being ignored
>> to fix HWOL.
>>
>> This pulls in the skip_hw flag refactor (note it already existed, so the
>> refactor exposes
On 4/15/21 10:29 PM, Marcelo Leitner wrote:
> On Fri, Apr 09, 2021 at 09:35:32AM -0400, Aaron Conole wrote:
>> Backport the recent fixes related to ct-offload state flags being ignored
>> to fix HWOL.
>>
>> This pulls in the skip_hw flag refactor (note it already existed, so the
>> refactor exposes
On 4/15/21 10:25 PM, Marcelo Leitner wrote:
> On Fri, Apr 09, 2021 at 09:31:50AM -0400, Aaron Conole wrote:
>> Backport the recent fixes related to ct-offload state flags being ignored
>> to fix HWOL.
>>
>> Paul Blakey (2):
>> compat: Add ct_state flags definitions
>> netdev-offload-tc: Probe f
> -Original Message-
> From: dev On Behalf Of Sriharsha
> Basavapatna via dev
> Sent: Thursday 8 April 2021 18:04
> To: Eli Britstein
> Cc: ovs dev ; ivan.ma...@oktetlabs.ru; Ilya
> Maximets ; Ameer Mahagneh
> ; Majd Dibbiny
> Subject: Re: [ovs-dev] [PATCH V6 00/13] Netdev vxlan-decap
On 4/12/21 5:19 PM, Gaetan Rivet wrote:
> Add a new operation for flow API providers to
> uninitialize when the API is disassociated from a netdev.
>
> Signed-off-by: Gaetan Rivet
> Reviewed-by: Eli Britstein
> ---
> lib/netdev-offload-provider.h | 3 +++
> lib/netdev-offload.c | 4
Sometimes a port might be configured with a single flow that just
forwards packets to another port. This would be useful in configs
where the bridge is just fowarding packets between two ports (for
example, between a vhost-user port and a physical port). A flow
that matches only on the in_port and
On 4/19/21 7:24 PM, Han Zhou wrote:
> On Mon, Apr 19, 2021 at 12:27 AM Dumitru Ceara wrote:
>>
>> On 4/16/21 7:16 PM, Mark Michelson wrote:
>>> Thanks for the explanation Dumitru. It made good sense out of what had
>>> to be a difficult thing to debug. I'm assuming you went with
>>> unconditional
On 4/19/21 6:34 PM, Numan Siddique wrote:
> On Mon, Apr 19, 2021 at 3:27 AM Dumitru Ceara wrote:
>>
>> On 4/16/21 7:16 PM, Mark Michelson wrote:
>>> Thanks for the explanation Dumitru. It made good sense out of what had
>>> to be a difficult thing to debug. I'm assuming you went with
>>> unconditi
On 4/20/21 3:57 AM, gmingchen(陈供明) wrote:
>
>
> On 2021/4/12, 4:48 PM, "Dumitru Ceara" wrote:
>
> On 4/8/21 1:24 PM, gmingchen(陈供明) wrote:
> >
> >
> > On 2021/4/7, 12:01 AM, "Dumitru Ceara" wrote:
> >
> > On 4/6/21 12:11 PM, Mark Gray wrote:
> > > I had
On 19/04/2021 21:51, Numan Siddique wrote:
> On Fri, Apr 16, 2021 at 4:52 AM Mark Gray wrote:
>>
>> I noticed some tests failing but I think the ddlog tests look flakey as
>> I saw other failures without these patches.
>>
>> I did my best to review the ddlog part but I am not familiar with ddlog
>
40 matches
Mail list logo
