Ok. Thanks Ben. Will take care of this.
-Vasu
*Vasu Dasari*
On Mon, May 10, 2021 at 7:57 PM Ben Pfaff wrote:
> On Mon, May 10, 2021 at 07:38:08PM -0400, Vasu Dasari wrote:
> > 1. Adding Nicira extensions for Flow Monitoring was pretty
> straightforward
> > with the existing code base. As you
Yes. You are right, Ben. I can have mac_entry_age() return 0, in case of
static entry. Actually, this following code is preventing age from getting
overwritten.
void@@ -336,6 +353,7 @@ mac_learning_insert(struct mac_learning *ml,
e->vlan = vlan;
e->grat_arp_lock = TIME_MIN;
On Mon, May 10, 2021 at 07:38:08PM -0400, Vasu Dasari wrote:
> 1. Adding Nicira extensions for Flow Monitoring was pretty straightforward
> with the existing code base. As you might have seen, I just had to tweak
> some functions to get this to work. I do not have any hard opinions against
> your p
I do not see how that helps. mac_entry_age() returns -1 if the entry is
static, and its caller uses mac_entry_age() like this:
if (!mac || mac_entry_age(ml, mac)) {
return true;
}
which means that -1 will cause learning to happen.
On Mon, May 10, 2021 at 07:43:46PM -0400, Vasu D
1. Sure. Will add more documentation to the code.
2. In mac_entry_age(), added new code to protect the age of the static
entry being overwritten by a received packet.
int
mac_entry_age(const struct mac_learning *ml, const struct mac_entry *e)
{-time_t remaining = e->expires - time_now();-
Thanks Ben for your comments.
1. Adding Nicira extensions for Flow Monitoring was pretty straightforward
with the existing code base. As you might have seen, I just had to tweak
some functions to get this to work. I do not have any hard opinions against
your point that we should not duplicate func
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Co-author Dumitru Ceara needs to sign off.
Lines checked: 87, Warnings: 0, Errors: 1
Pleas
On Mon, May 10, 2021 at 10:51 AM Ihar Hrachyshka
wrote:
>
> For allow-stateless ACLs, bypass connection tracking by avoiding
> setting ct hints for matching traffic. Avoid sending all traffic to ct
> when a stateful ACL is present.
>
> ===
>
> Reusing an existing 'allow' verb for stateless matchin
On Mon, May 10, 2021 at 12:42 AM Dumitru Ceara wrote:
>
> On 5/8/21 5:08 PM, Han Zhou wrote:
> > In commit b468c2c1 it avoided using DPG for multicast related lflows,
but
> > commit dd94f126 update the MC_UNKNOWN related lflows with DPG used again
> > by mistake. This patch fixes it to avoid probl
In commit b468c2c1 it avoided using DPG for multicast related lflows, but
commit dd94f126 update the MC_UNKNOWN related lflows with DPG used again
by mistake. This patch fixes it to avoid problems when a lflow using
MC_UNKNOWN is monitored by a ovn-controller before the related mc-group
is monitore
Thanks Lorenzo, it looks good to me.
Acked-by: Mark Michelson
On 4/24/21 8:46 AM, Lorenzo Bianconi wrote:
Add new debug logs in pinctrl_handle_bfd_msg flow path useful for
debugging
Signed-off-by: Lorenzo Bianconi
---
controller/pinctrl.c | 28 +---
1 file changed,
I pushed this to master, branch-21.03 and branch-20.12.
On 4/27/21 2:46 PM, Mark Michelson wrote:
Excellent! Looks good to me!
Acked-by: Mark Michelson
On 4/21/21 12:17 PM, Alexey Roytman wrote:
From: Alexey Roytman
When ovn-sbctl lflow-list gets lflow argument with 0x prefix, e.g.
0x8131
Hi Alexey,
In general, the C side of things looks good. I recommend that you run
./utilities/checkpatch.py against the resulting patch, though.
checkpatch.py recently had a bug fixed in it so that it correctly
catches lines that are in excess of 80 characters now. You'll find that
there are s
On Sat, May 08, 2021 at 07:12:27AM -0400, Vasu Dasari wrote:
> Currently OVS supports flow-monitoring for OpenFlow 1.0 and Nicira
> Extenstions.
> Any other OpenFlow versioned messages are not accepted. This checkin will
> allow
> OpenFlow1.0+ Flow Monitoring wth Nicira extensions be accepted. Al
On 5/10/21 12:13 PM, Dumitru Ceara wrote:
>> +/* Creates a new pstream named 'name' that will accept new replay
>> connections
>> + * reading them from the replay file and stores a pointer to the stream in
>> + * '*pstreamp'.
>> + *
>> + * Takes ownership of 'name'.
>> + *
>> + * Returns 0 if succ
On Sat, May 08, 2021 at 06:18:41PM -0400, Vasu Dasari wrote:
> Currently there is an option to add/flush/show ARP/ND neighbor. This covers L3
> side. For L2 side, there is only fdb show command. This patch gives an option
> to add/del an fdb entry via CLI.
>
> CLI command looks like:
>
> To add:
On Mon, May 10, 2021 at 05:57:45PM +0200, Ilya Maximets wrote:
> File layout for man pages in sphinx 4 by default changed [1] from:
>
> Documentation/_ref/man/page.section
>
> to:
>
> Documentation/_ref/man/section/page.section
>
> Ajusting our build scripts so they will be able to locate
Hello Karthik,
This all looks good to me. Thanks!
Acked-by: Mark Michelson
On 4/2/21 5:08 PM, svc.eng.git-m...@nutanix.com wrote:
From: Karthik Chandrashekar
Physical switches have the ability to specify "discard" or sometimes
"NULL interface" as a nexthop for routes. This can be used to pr
On Mon, May 10, 2021 at 09:36:24AM +0200, Simon Horman wrote:
> Hi Marcello, Hi Ilya, Hi all,
Hi Simon,
>
> On Fri, Apr 16, 2021 at 03:58:47PM +0200, Simon Horman wrote:
> > Hi,
> >
> > this short test adds support for add port-based ingress policing based
> > packet-per-second rate-limiting. Thi
On 4/28/21 11:19 AM, Kumar Amber wrote:
v2 updates:
- reabse on to latest DPIF v11
This patchset introduces miniflow extract Infrastructure changes
which allows user to choose different type of ISA based optimized
miniflow extract variants which can be user choosen or set based on
packets studie
On 5/10/21 5:57 PM, Ilya Maximets wrote:
> File layout for man pages in sphinx 4 by default changed [1] from:
>
> Documentation/_ref/man/page.section
>
> to:
>
> Documentation/_ref/man/section/page.section
>
> Ajusting our build scripts so they will be able to locate files
> in new places.
For allow-stateless ACLs, bypass connection tracking by avoiding
setting ct hints for matching traffic. Avoid sending all traffic to ct
when a stateful ACL is present.
===
Reusing an existing 'allow' verb for stateless matching would have its
drawbacks, specifically, when it comes to backwards in
On 4/27/21 6:29 PM, Numan Siddique wrote:
On Tue, Apr 27, 2021 at 1:20 PM Mark Michelson wrote:
The ACL Conjunction test would occasionally fail during automated test
runs. During the test, we send a packet on a netdev-dummy interface and
check the associated pcap file to ensure the packet is
Bleep bloop. Greetings Timothy Miskell, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#1224 FILE: lib/netdev.c:2331:
netdev_mirror_
From: Liang-min Wang
The following parameters are added:
- mirror-offload: to turn on/off mirror offloading.
- output-port-name: specify a port, using name string, that is on a different
bridge
- output-src-vlan: output port vlan for each select-src-port.
- output-dst-vlan: output port vla
From: Emma Finn
The existing port mirroring uses packet copy to replicate the traffic
from the mirror target site. This patch replaces the packet copy with
hardware (NIC) device mirroring which is available in many NICs.
Our benchmark shows (detail test setup can be found in ovs/ovn
conference
On 5/10/21 4:40 PM, Ilya Maximets wrote:
> On 5/10/21 3:08 PM, Ilya Maximets wrote:
>> sphinx 4.0 seems to change paths for generated files and this
>> breaks the distcheck, e.g.:
>>
>> /usr/bin/install: cannot stat './Documentation/_build/man/ovs-l3ping.8':
>> No such file or directory
>
File layout for man pages in sphinx 4 by default changed [1] from:
Documentation/_ref/man/page.section
to:
Documentation/_ref/man/section/page.section
Ajusting our build scripts so they will be able to locate files
in new places. This fixes our CI build.
[1] https://github.com/sphinx-doc
On 5/10/21 5:39 PM, Dumitru Ceara wrote:
> On 5/7/21 4:42 PM, num...@ovn.org wrote:
>> From: Numan Siddique
>>
>> Some smart NICs can't offload datapath flows matching on conntrack
>> fields. If a deployment desires to make use of such smart NICs
>> then it cannot configure ACLs on the logical sw
On 5/7/21 4:42 PM, num...@ovn.org wrote:
> From: Numan Siddique
>
> Some smart NICs can't offload datapath flows matching on conntrack
> fields. If a deployment desires to make use of such smart NICs
> then it cannot configure ACLs on the logical switches. If suppose
> a logical switch S1 has n
On 06/05/2021 16:25, David Marchand wrote:
> Add Travis jobs to check compilation with DPDK experimental API enabled.
> This will help us catch issues for the day we need one of them.
>
> Note: this should not be merged to master, intended for dpdk-latest
> branch only.
>
> Signed-off-by: David M
On 06/05/2021 16:25, David Marchand wrote:
> Make this branch point to current main master branch so that we can
> track API breakage.
>
s/master//
> Note: this should not be merged to master, intended for dpdk-latest
> branch only.
>
It's probably better to give full project/branch names when
On 06/05/2021 16:25, David Marchand wrote:
> Hello Ian,
>
> DPDK v21.05-rc2 has been tagged last night, so I spent some time today
> rebasing the dpdk-latest OVS branch against OVS master branch (commit
> a019868a6268 ("ofproto/ofproto-dpif-sflow: Check sflow ..."), then
> fixing build against DPD
On 5/10/21 4:44 PM, Numan Siddique wrote:
> On Mon, May 10, 2021 at 9:29 AM Dumitru Ceara wrote:
>>
>> On 5/10/21 11:58 AM, Numan Siddique wrote:
>>> On Fri, May 7, 2021 at 11:26 AM Dumitru Ceara wrote:
On 5/7/21 4:35 PM, Numan Siddique wrote:
> On Fri, May 7, 2021 at 5:50 AM Dumitr
On Mon, May 10, 2021 at 9:29 AM Dumitru Ceara wrote:
>
> On 5/10/21 11:58 AM, Numan Siddique wrote:
> > On Fri, May 7, 2021 at 11:26 AM Dumitru Ceara wrote:
> >>
> >> On 5/7/21 4:35 PM, Numan Siddique wrote:
> >>> On Fri, May 7, 2021 at 5:50 AM Dumitru Ceara wrote:
>
> On 5/6/21 3:52 P
On 5/10/21 3:08 PM, Ilya Maximets wrote:
> sphinx 4.0 seems to change paths for generated files and this
> breaks the distcheck, e.g.:
>
> /usr/bin/install: cannot stat './Documentation/_build/man/ovs-l3ping.8':
> No such file or directory
>
> Restricting the version to <4.0 until we fi
On 5/10/21 11:58 AM, Numan Siddique wrote:
> On Fri, May 7, 2021 at 11:26 AM Dumitru Ceara wrote:
>>
>> On 5/7/21 4:35 PM, Numan Siddique wrote:
>>> On Fri, May 7, 2021 at 5:50 AM Dumitru Ceara wrote:
On 5/6/21 3:52 PM, num...@ovn.org wrote:
> From: Numan Siddique
>
> Some
On 5/6/21 2:47 PM, Ilya Maximets wrote:
[...]
Oops, I meant to send this along with the acked-by:
>
> diff --git a/ovsdb/raft.c b/ovsdb/raft.c
> index d2ff643b2..658a016b2 100644
> --- a/ovsdb/raft.c
> +++ b/ovsdb/raft.c
> @@ -4160,9 +4160,24 @@ raft_may_snapshot(const struct raft *raft)
>
On 5/6/21 2:47 PM, Ilya Maximets wrote:
> With a big database writing snapshot could take a lot of time, for
> example, on one of the systems compaction of 300MB database takes
> about 10 seconds to complete. For the clustered database, 40% of this
> time takes conversion of the database to the fi
sphinx 4.0 seems to change paths for generated files and this
breaks the distcheck, e.g.:
/usr/bin/install: cannot stat './Documentation/_build/man/ovs-l3ping.8':
No such file or directory
Restricting the version to <4.0 until we figure out how to support new
version correctly.
pip is
On 5/1/21 2:55 AM, Ilya Maximets wrote:
> Replication can be used to scale out read-only access to the database.
> But there are clients that are not read-only, but read-mostly.
> One of the main examples is ovn-controller that mostly monitors
> updates from the Southbound DB, but needs to claim po
On 5/1/21 2:55 AM, Ilya Maximets wrote:
> As described in commit [1], it's possible that remote IP is backed by
> a load-balancer and re-connection to this same IP will lead to
> connection to a different server. This case is supported for C version
> of IDL and should be supported in a same way f
On 5/1/21 2:55 AM, Ilya Maximets wrote:
> Clients may want to know if current replica actually has an active
> connection with the replication source. For example, if one of the
> replicas lost connection, clients may want to re-connect to another
> replica in order to receive all the up-to-date d
On 5/1/21 2:55 AM, Ilya Maximets wrote:
> The same change as for ovsdb-cs module.
>
> Monitoring data from '_synced_Database' table to check the state of
> clustered databases from which this replica receives updates.
>
> Not allowing 'leader-only' connection to the replication server as
> this t
On 5/1/21 2:55 AM, Ilya Maximets wrote:
> Monitoring data from '_synced_Database' table to check the state of
> clustered databases from which this replica receives updates.
>
> Not allowing 'leader-only' connection to the replication server as
> this type of connections typically used for databas
On 5/1/21 2:55 AM, Ilya Maximets wrote:
> If replication server is connected to a cluster member, clients
> would like to know the state of the cluster from that server.
> This will allow them to make a decision about re-connection.
>
> Marking 'Database' table with a 'copyForReplication' flag to
On 5/1/21 2:55 AM, Ilya Maximets wrote:
> New flag for ovsdb table schema 'copyForReplication'. It's needed to
> enable replication of a _Server database in later commits.
>
> With this option ovsdb-server will create a new _synced_
> table where it will store data received from the replication s
On 5/1/21 2:55 AM, Ilya Maximets wrote:
> Current version of ovsdb replication allows to scale out read-only
> access to the primary database. However, many clients are not
> read-only but read-mostly. For example, ovn-controller.
>
> In order to scale out database access for this case ovsdb-ser
On 4/13/21 12:00 AM, Ilya Maximets wrote:
> Also added a NEWS entry.
>
> Signed-off-by: Ilya Maximets
> ---
A typo below, otherwise:
Acked-by: Dumitru Ceara
Regards,
Dumitru
> Documentation/automake.mk | 1 +
> Documentation/topics/index.rst | 1 +
> Documentation/t
On 4/13/21 12:00 AM, Ilya Maximets wrote:
> This is primarily to be able to test recording of client connections.
> Unit test added accordingly.
>
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Dumitru Ceara
Regards,
Dumitru
___
dev mailing list
d..
On 4/13/21 12:00 AM, Ilya Maximets wrote:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Dumitru Ceara
Regards,
Dumitru
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 4/13/21 12:00 AM, Ilya Maximets wrote:
> Current version of replay engine doesn't handle time-based internal
> events that results in stream send/receive. Disabling jsonrpc inactivity
> probes for now to not block process waiting for probe being sent.
>
> The proper solution would be to implem
On 4/13/21 12:00 AM, Ilya Maximets wrote:
> Current version or replay engine doesn't handle correctly internal
> time-based events that ends up in stream events. For example,
> updates of a database status that happens each 2.5 seconds results
> in updates on client monitors. Disable updates for
On 4/13/21 12:00 AM, Ilya Maximets wrote:
> This change adds support of stream record/replay functionality to
> ovsdb-server.
>
> Since current replay engine doesn't work well with time-based
> events generated locally, it will work only with standalone databases
> for now (raft heavily depends on
On 4/13/21 12:00 AM, Ilya Maximets wrote:
> This is required for the stream record/replay functionality of
> ovsdb-server. With record/replay of UUIDs we could record all
> incoming transactions and replay them later while being sure
> that ovsdb-server will generate exactly same UUIDs for all the
On 4/13/21 12:00 AM, Ilya Maximets wrote:
> For debugging purposes it is useful to be able to record all the
> incoming transactions and commands and replay them locally under
> debugger or with additional logging enabled. This patch introduces
> ability to record all the incoming stream data and
On 4/13/21 12:00 AM, Ilya Maximets wrote:
> This library provides interfaces to open replay files and
> read/write records. Will be used later for stream record/replay
> functionality, i.e. to record all the incoming connections and
> data and replay it later for debugging and performance analysis
On Fri, May 7, 2021 at 11:26 AM Dumitru Ceara wrote:
>
> On 5/7/21 4:35 PM, Numan Siddique wrote:
> > On Fri, May 7, 2021 at 5:50 AM Dumitru Ceara wrote:
> >>
> >> On 5/6/21 3:52 PM, num...@ovn.org wrote:
> >>> From: Numan Siddique
> >>>
> >>> Some smart NICs can't offload datapath flows matchin
On Thu, May 6, 2021 at 2:27 PM Ilya Maximets wrote:
>
> FreeBSD sometimes changes the base version of python3 that is
> used for packages. This affects package names. For example,
> currently CI is broken, because there is no more py37- versions
> of sphinx and openssl available, only py38- ones
On 5/8/21 5:08 PM, Han Zhou wrote:
> In commit b468c2c1 it avoided using DPG for multicast related lflows, but
> commit dd94f126 update the MC_UNKNOWN related lflows with DPG used again
> by mistake. This patch fixes it to avoid problems when a lflow using
> MC_UNKNOWN is monitored by a ovn-control
Hi Marcello, Hi Ilya, Hi all,
On Fri, Apr 16, 2021 at 03:58:47PM +0200, Simon Horman wrote:
> Hi,
>
> this short test adds support for add port-based ingress policing based
> packet-per-second rate-limiting. This builds on existing support for
> byte-per-second rate limiting.
I'm wondering if it
61 matches
Mail list logo
