On Fri, Apr 30, 2021 at 11:31:27AM -0400, Mark Gray wrote:
> 'n_handlers' and 'n_revalidators' are declared as type 'size_t'.
> However, dpif_handlers_set() requires parameter 'n_handlers' as
> type 'uint32_t'. This patch fixes this type mismatch.
The change looks good, but I didn't understand the
On Fri, Apr 30, 2021 at 11:31:28AM -0400, Mark Gray wrote:
> Signed-off-by: Mark Gray
This looks like a bug fix for this commit:
1579cf677fcb dpif-linux: Implement the API functions to allow multiple ...
If you agree, please add the Fixes: tag.
fbl
> ---
> lib/dpif-netlink.c | 4 ++--
> 1 fil
Hi Mark,
I think this patch is going in the right direction but there
are some points that I think we should address. See below.
On Fri, Apr 30, 2021 at 11:33:25AM -0400, Mark Gray wrote:
> The Open vSwitch kernel module uses the upcall mechanism to send
> packets from kernel space to user spac
If a lflow has an lport name in the match, but when the lflow is
processed the port-binding is not seen by ovn-controller, the
corresponding openflow will not be created. Later if the port-binding is
created/monitored by ovn-controller, the lflow is not reprocessed
because the lflow didn't change a
This patch removes the workaround when adding multicast group related
lflows, because the multicast group dependency problem is fixed in
ovn-controller in the previous commit.
This patch also removes the UniqueFlow/AnnotatedFlow usage in northd
DDlog implementation for the same reason.
Signed-off
Always monitor all logical datapath groups. Otherwise, DPG updates may
be received *after* the lflows using it are seen by ovn-controller.
Since the number of DPGs are relatively small, we monitor all DPGs to
avoid the unnecessarily extra control plane round trip for the lflows to
be processed.
Si
Multicast group changes are handled for physical flows in I-P, but not
handled for logical flows. Although logical flow doesn't care about the
content of a multicast group, the existance of it matters for logical
flow processing. If the multicast group is not found when the logical
flow is processe
The series fixes incremental processing for missing dependency handling for
multicast group and logical port binding changes when computing logical flows.
It also removes the workaround in northd that was required due to the missing
dependency handling. In addition, the fix also allows us to monito
Dumitru Ceara writes:
> Spotted during code inspection.
>
> Fixes: 993cae678bca ("ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy
> tables")
> Signed-off-by: Dumitru Ceara
> ---
Acked-by: Paolo Valerio
___
dev mailing list
d...@openvswitch.org
Dumitru Ceara writes:
> Reproducer:
> ovs-vsctl \
> -- add-br br \
> -- set bridge br datapath-type=foo \
> -- --id=@m create Datapath datapath_version=0 'capabilities={}' \
> -- set Open_vSwitch . datapaths:"foo"=@m
>
> Fixes: 27501802d09f ("ofproto-dpif: Expose datapath capabi
DHCP Option Hostname is a per-Logical_Switch_Port property, configured in
Logical_Switch_Port's options:hostname field. It is used if DHCPv4 is
enabled for this LSP.
Signed-off-by: Vladislav Odintsov
---
The implementation for ovn-northd-ddlog is absent, it needs help from
somebody, who's familia
I've posted a new version of this patch with requested changes:
https://patchwork.ozlabs.org/project/ovn/patch/20210528082105.70086-1-odiv...@gmail.com/
Regards,
Vladislav Odintsov
On 27.05.2021, 23:00, "dev on behalf of 0-day Robot"
wrote:
Bleep bloop. Greetings Vladislav Odintsov, I
Before this patch ovn-controller-vtep created Mcast_Macs_Remote
record for each Port Binding in the ovn Logical Switch, to which
vtep Logical Switch was attached.
With this patch there is only one Mcast_Macs_Remote record per datapath.
Physical Locator set is created every time when physical locato
13 matches
Mail list logo
