Re: [ovs-dev] [PATCH v2] ofproto-dpif-upcall: Fix race condition while purging

2021-05-31 Thread Jianbo Liu
The 05/31/2021 19:58, Ilya Maximets wrote: > On 5/28/21 5:16 AM, Jianbo Liu wrote: > > The 05/27/2021 12:43, Ilya Maximets wrote: > >> On 5/27/21 12:29 PM, Jianbo Liu wrote: > >>> There is a race condidtion between purger and handler in dpif-netlink. > >>> Handler may create new ukey and install it

Re: [ovs-dev] [PATCH v2] ofproto-dpif-upcall: Fix race condition while purging

2021-05-31 Thread Ilya Maximets
On 5/28/21 5:16 AM, Jianbo Liu wrote: > The 05/27/2021 12:43, Ilya Maximets wrote: >> On 5/27/21 12:29 PM, Jianbo Liu wrote: >>> There is a race condidtion between purger and handler in dpif-netlink. >>> Handler may create new ukey and install it while executing 'ovs-appctl >>> revalidator/purge' c

Re: [ovs-dev] [PATCH] fix coding style in bridge_configure_rstp() function.

2021-05-31 Thread Kevin Traynor
On 31/05/2021 13:20, miter wrote: > This patch fix the style of bridge_configure_rstp() function. > > Signed-off-by: linhuang > --- >  vswitchd/bridge.c | 6 ++ >  1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c > index 5ed7e8234..4ada5

Re: [ovs-dev] [PATCH] fix coding style in bridge_configure_rstp() function.

2021-05-31 Thread 0-day Robot
Bleep bloop. Greetings miter, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: patch failed: vswitchd/bridge.c:1883 error: vswitchd/bridge.c: patch does not apply error: Did you h

[ovs-dev] [PATCH] fix coding style in bridge_configure_rstp() function.

2021-05-31 Thread miter
This patch fix the style of bridge_configure_rstp() function. Signed-off-by: linhuang ---  vswitchd/bridge.c | 6 ++  1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 5ed7e8234..4ada54475 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/br

Re: [ovs-dev] [PATCH v3] conntrack: document all-zero IP SNAT behavior and add a test case

2021-05-31 Thread Eelco Chaudron
Hi Alin (or any other OVS windows expert), Do you know if the described all-zero IP address SNAT feature is supported by the windows datapath? If you don't but have a windows setup available, can you run the below self-test to find out? Thanks, Eelco On 26 Apr 2021, at 14:19, Eelco Chaudron

Re: [ovs-dev] [PATCH 2/6] netdev-offload-dpdk: Introduce a dump_port_id helper function

2021-05-31 Thread 0-day Robot
Bleep bloop. Greetings Noa Levy, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (lib/netdev-offload-dpdk.c). error: could not build fake a

[ovs-dev] Integrating p4rt-ovs to ovs-afxdp

2021-05-31 Thread Mah-Rukh Fida
Hi, I am a postdoctoral fellow at Simula, Oslo. For one of my project I have to run a p4 program on openvswitch, I am using ovs-afxdp and p4rt-ovs following the links below https://github.com/Orange-OpenSource/p4rt-ovs https://github.com/Orange-OpenSource/p4rt-ovs/blob/master/Documentation/intro/

[ovs-dev] [PATCH 4/6] netdev-offload-dpdk: Support multiple local destinations

2021-05-31 Thread Noa Levy
Add support for offloading multiple local destinations using rte_flow_action_sample with ratio 1. Co-authored-by: Salem Sol Signed-off-by: Noa Levy Signed-off-by: Salem Sol --- NEWS | 2 +- lib/netdev-offload-dpdk.c | 77 ++- 2 files ch

[ovs-dev] [PATCH 6/6] netdev-offload-dpdk: Support multiple remote destinations

2021-05-31 Thread Noa Levy
Add support for offloading multiple remote destinations by parsing the actions and adding remote destinations actions. Update dump_flow_action in order to support tunnel actions. Co-authored-by: Salem Sol Signed-off-by: Noa Levy Signed-off-by: Salem Sol --- NEWS | 3 +- l

[ovs-dev] [PATCH 3/6] netdev-offload-dpdk: Introduce a dump_raw_encap helper function

2021-05-31 Thread Noa Levy
Introduce a helper function as a pre-step towards supporting offload multiple remote destinations. Co-authored-by: Salem Sol Signed-off-by: Noa Levy Signed-off-by: Salem Sol --- lib/netdev-offload-dpdk.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff

[ovs-dev] [PATCH 0/6] Multiple destinations

2021-05-31 Thread Noa Levy
Adding support for multiple local and remote destinations. Each non-last destination is embedded in a sample action with ratio=1. for example: set sample_actions 1 port_id original 0 id 2 / end; set sample_actions 2 Raw-encap size=50 set raw_encap 0 raw pattern is / end_set; raw_encap index 0 / p

[ovs-dev] [PATCH 5/6] netdev-offload-dpdk: Extract raw_encap and output netdev by parse_clone_actions

2021-05-31 Thread Noa Levy
Extract the raw_encap and the output netdev of cloned actions as a pre-step towards using them embedded in a sample action. Co-authored-by: Salem Sol Signed-off-by: Noa Levy Signed-off-by: Salem Sol --- lib/netdev-offload-dpdk.c | 39 +++ 1 file changed, 27

[ovs-dev] [PATCH 2/6] netdev-offload-dpdk: Introduce a dump_port_id helper function

2021-05-31 Thread Noa Levy
Introduce a helper function as a pre-step towards supporting offload multiple desinations. Signed-off-by: Noa Levy --- lib/netdev-offload-dpdk.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c inde

[ovs-dev] [PATCH 1/6] netdev-offload-dpdk: Introduce a get_netdev_by_port helper function

2021-05-31 Thread Noa Levy
Introduce a helper function to get the struct netdev * handle for the target output odp_port, given in the netlink actions, as a pre-step towards using it embedded in a sampled action. Co-authored-by: Salem Sol Signed-off-by: Noa Levy Signed-off-by: Salem Sol --- lib/netdev-offload-dpdk.c | 54

[ovs-dev] [PATCH ovn] ovn-northd.c: Add proxy ARP support to OVN

2021-05-31 Thread Brendan Doyle
From a9d3140845175edb7644b2d0d82a95bd6cf94662 Mon Sep 17 00:00:00 2001 From: Brendan Doyle Date: Fri, 28 May 2021 10:01:17 -0700 Subject: [PATCH ovn] ovn-northd.c: Add proxy ARP support to OVN This patch provides the ability to configure proxy ARP IPs on a Logical Switch Router port. The IPs are