Re: [ovs-dev] [PATCH ovn] Document priority behavior for allow-stateless ACLs

2021-06-08 Thread Han Zhou
On Tue, Jun 8, 2021 at 1:33 PM Ihar Hrachyshka wrote: > > It's complex and probably impossible to split returning traffic for > allow-related ACLs from stateless traffic, we don't fully implement > ACL priority for allow-stateless rules. Meaning, allow-stateless rules > always take precedence

[ovs-dev] [PATCH] lib/ipf: fix only nat the first fragment in the reass process

2021-06-08 Thread wenxu
From: wenxu The ipf collect original fragment packets and reass a new pkt to do the conntrack logic. After finsh the conntrack things copy the ct meta info to each orignal packet and modify the l4 header in the first fragment. It should modify the ip src/ dst info for all the fragments.

[ovs-dev] [PATCH ovn] Document priority behavior for allow-stateless ACLs

2021-06-08 Thread Ihar Hrachyshka
It's complex and probably impossible to split returning traffic for allow-related ACLs from stateless traffic, we don't fully implement ACL priority for allow-stateless rules. Meaning, allow-stateless rules always take precedence over stateful rules regardless of their relative priority order.

Re: [ovs-dev] [PATCH] ovsdb-idl: Fix the database update signaling if it has never been connected.

2021-06-08 Thread Bailey, Josh
I confirm this fixes the problem. Thanks for the help! On Wed, Jun 9, 2021 at 1:17 AM Ilya Maximets wrote: > The symptom of this issue is that OVS bridge looses its IP address on > restart. > > Simple reproducer: > 0. start ovsdb-server and ovs-vswitchd > 1. ovs-vsctl add-br br0 > 2.

Re: [ovs-dev] [RFC 3/3] dpif-netlink: Introduce per-cpu upcall dispatch

2021-06-08 Thread Flavio Leitner
Hi Mark, This looks good to me. Since the new scheme doesn't allow users to change the number of handlers, we must update ovs-vswitchd.conf.db(5) as well. Some comments below. On Fri, Apr 30, 2021 at 11:31:29AM -0400, Mark Gray wrote: > The Open vSwitch kernel module uses the upcall

[ovs-dev] [PATCH ovn] if-status: Fix logging of interface creation.

2021-06-08 Thread Ilya Maximets
'iface->id' is NULL at this point, so the message is always the same: "Interface (null) create." Fixes: 5c3371922994 ("if-status: Add OVS interface status management module.") Signed-off-by: Ilya Maximets --- controller/if-status.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [ovs-dev] [PATCH] Remove Python 2 leftovers.

2021-06-08 Thread Ilya Maximets
On 6/8/21 12:31 AM, Rosemarie O'Riorden wrote: > Fixes: 1ca0323e7c29 ("Require Python 3 and remove support for Python 2.") > Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1949875 > Signed-off-by: Rosemarie O'Riorden > --- Hi, Rosemarie. Thanks for working on improving OVS! See some

Re: [ovs-dev] [PATCH v2 ovn 3/3] northd: add check_pkt_larger lflows for ingress traffic

2021-06-08 Thread Lorenzo Bianconi
> DDLog equivalent is missing from this patch. > > See below for more comments in-line. > > On 5/27/21 6:26 PM, Lorenzo Bianconi wrote: > > Introduce check_pkt_larger action for ingress traffic > > entering the cluster from a distributed gw router port > > or from a gw router. This patch enables

Re: [ovs-dev] [PATCH v2 ovn 2/3] northd: enable check_pkt_larger for gw router

2021-06-08 Thread Lorenzo Bianconi
> Equivalent DDLog code is missing from this patch. > > The new test is pretty much exactly the same as "ovn -- router - check > packet length - icmp defrag". I think there are about 3-4 changed lines, > including the title and keywords. I think you could add the gateway router > testing to the

Re: [ovs-dev] [PATCH v2 ovn 3/3] northd: add check_pkt_larger lflows for ingress traffic

2021-06-08 Thread Mark Michelson
DDLog equivalent is missing from this patch. See below for more comments in-line. On 5/27/21 6:26 PM, Lorenzo Bianconi wrote: Introduce check_pkt_larger action for ingress traffic entering the cluster from a distributed gw router port or from a gw router. This patch enables pMTU discovery for

Re: [ovs-dev] [PATCH v2 ovn 2/3] northd: enable check_pkt_larger for gw router

2021-06-08 Thread Mark Michelson
Equivalent DDLog code is missing from this patch. The new test is pretty much exactly the same as "ovn -- router - check packet length - icmp defrag". I think there are about 3-4 changed lines, including the title and keywords. I think you could add the gateway router testing to the existing

Re: [ovs-dev] [PATCH v2 ovn 1/3] northd: introduce build_check_pkt_len_flows_for_lrp routine

2021-06-08 Thread Mark Michelson
Acked-by: Mark Michelson On 5/27/21 6:26 PM, Lorenzo Bianconi wrote: Introduce build_check_pkt_len_flows_for_lrp routine to configure check_pkt_larger logical flow for a given logical port. This is a preliminary patch to enable check_pkt_larger support for gw router use case. Signed-off-by:

Re: [ovs-dev] OvS port on QNX issue

2021-06-08 Thread Ilya Maximets
On 6/8/21 2:20 PM, Miladin Jovanović wrote: > Hello, > We managed to compile OpenVSwitch to a Blackberry QNX. Idea is to use > complete user-space switching in OvS (like it is done for NetBSD, QNX > netstack is based on it ). In order for compilation to pass, compile flag > __NetBSD__ was

[ovs-dev] OvS port on QNX issue

2021-06-08 Thread Miladin Jovanović
Hello, We managed to compile OpenVSwitch to a Blackberry QNX. Idea is to use complete user-space switching in OvS (like it is done for NetBSD, QNX netstack is based on it ). In order for compilation to pass, compile flag __NetBSD__ was needed to be added and some small changes in code : -

Re: [ovs-dev] [PATCH] ofproto/trace: Support for DP-HASH recirculation

2021-06-08 Thread Rudra Surya Bhaskara Rao via dev
Hi Team, Please consider this as gentle reminder. Could you please review below changes. Thanks & Regards, Surya. -Original Message- From: Surya Rudra Sent: 23 July 2020 03:15 PM To: ovs-dev@openvswitch.org Cc: Surya Rudra Subject: [PATCH] ofproto/trace: Support for DP-HASH

Re: [ovs-dev] openvswitch 2.15 [re]start losing bridge IP

2021-06-08 Thread Ilya Maximets
On 6/2/21 8:12 PM, Ben Pfaff wrote: > On Wed, Jun 02, 2021 at 12:01:24AM +, venugopal iyer via dev wrote: >> Hi, Ben et. al.: >> When we moved from 2.14.0 to 2.15.0 we noticed a change in behavior. A >> 2.14.0 openvswitch restart (even explicit stop followed by start) didn't >> lose the

[ovs-dev] [PATCH] ovsdb-idl: Fix the database update signaling if it has never been connected.

2021-06-08 Thread Ilya Maximets
The symptom of this issue is that OVS bridge looses its IP address on restart. Simple reproducer: 0. start ovsdb-server and ovs-vswitchd 1. ovs-vsctl add-br br0 2. ifconfig br0 10.0.0.1 up 3. ovs-appctl -t ovs-vswitchd exit 4. start ovs-vswitchd back. After step #3 ovs-vswitchd is down, but

Re: [ovs-dev] [PATCH v2] tests: Add PMD auto load balance unit tests.

2021-06-08 Thread Kevin Traynor
Not sure why some names seemed dropped out of CC. Re-adding. On 08/06/2021 13:47, Kevin Traynor wrote: > Ping > > On 05/05/2021 14:34, Kevin Traynor wrote: >> Ping. Any objection to adding these unit tests? >> >> On 16/03/2021 15:45, Kevin Traynor wrote: >>> These tests focus on

Re: [ovs-dev] [PATCH v2] tests: Add PMD auto load balance unit tests.

2021-06-08 Thread Kevin Traynor
Ping On 05/05/2021 14:34, Kevin Traynor wrote: > Ping. Any objection to adding these unit tests? > > On 16/03/2021 15:45, Kevin Traynor wrote: >> These tests focus on enabling/disabling and user parameters. >> >> Co-Authored-by: David Marchand >> Signed-off-by: David Marchand >> Signed-off-by:

[ovs-dev] [PATCH] ovsdb: provide raft and command interfaces with priority

2021-06-08 Thread anton . ivanov
From: Anton Ivanov Set a soft time limit of "raft election timer"/2 on ovsdb processing. This improves behaviour in large heavily loaded clusters. While it cannot fully eliminate spurious raft elections under heavy load, it significantly decreases their number. TODO: randomize session

[ovs-dev] (no subject)

2021-06-08 Thread Simon Horman
___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-06-08 Thread Chris Mi
On 5/25/2021 7:19 PM, Eli Britstein wrote: On 5/19/2021 12:47 PM, Simon Horman wrote: External email: Use caution opening links or attachments On Tue, May 18, 2021 at 02:22:26PM +0200, Ilya Maximets wrote: On 4/27/21 3:23 AM, Chris Mi wrote: ... Hi Ilya, The code according to your