[ovs-dev] [PATCH ovn v3 0/3] tests: Add check-perf target

This is a proposal to add some micro-benchmarks to aid developers in benchmarking optimizations to OVN. It starts by adding simple metrics for northd but could be expanded in future patches. Mark Gray (3): ovn-macros.at: fix typo ovn-northd: Add useful stopwatches tests: Add check-perf targe

[ovs-dev] [PATCH ovn v3 1/3] ovn-macros.at: fix typo

Signed-off-by: Mark Gray --- tests/ovn-macros.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at index cd02b6986cc2..c92c07720112 100644 --- a/tests/ovn-macros.at +++ b/tests/ovn-macros.at @@ -184,7 +184,7 @@ ovn_start_northd() { # ov

[ovs-dev] [PATCH ovn v3 2/3] ovn-northd: Add useful stopwatches

For performance measurement, it is useful to understand the length of time required to complete a number of key code paths in ovn-northd.c. Add stopwatches to measure these timings. Signed-off-by: Mark Gray --- northd/ovn-northd-ddlog.c | 15 +++ northd/ovn-northd.c | 20 ++

[ovs-dev] [PATCH ovn v3 3/3] tests: Add check-perf target

Add a suite of micro-benchmarks to aid a developer in understanding the performance impact of any changes that they are making. They can be used to help to understand the relative performance between two test runs on the same test machine, but are not intended to give the absolute performance of OV

Re: [ovs-dev] [PATCH ovn v3 3/3] tests: Add check-perf target

Bleep bloop. Greetings Mark Gray, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #44 FILE: Documentation/topics/testin

Re: [ovs-dev] [PATCH v4 ovn 1/4] ovn-controller: Add support for Logical_Flow control meters

On 16/06/2021 11:30, Lorenzo Bianconi wrote: > Add a new 'ofctrl_add_flow_metred' function to create a new 'ovn_flow' > with an attached controller meter. typo: it should be "metered". This is also a typo in the code (i.e. its not just the commit message) You can add my ack. Acked-by: Mark D. Gr

Re: [ovs-dev] [PATCH v4 ovn 3/4] ovn-northd: Add CoPP policies for flows that punt packets to ovn-controller.

On 16/06/2021 11:30, Lorenzo Bianconi wrote: > - "udp.dst == 53", > - REGBIT_DNS_LOOKUP_RESULT" = dns_lookup(); next;"); > +ovn_lflow_add_ctrl(lflows, od, S_SWITCH_IN_DNS_LOOKUP, 100, > + "udp.dst == 53", This is a bit of

Re: [ovs-dev] [PATCH v4 ovn 4/4] NEWS: Add CoPP support.

On 16/06/2021 11:30, Lorenzo Bianconi wrote: > From: Dumitru Ceara > > Signed-off-by: Dumitru Ceara > Signed-off-by: Lorenzo Bianconi > --- > NEWS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/NEWS b/NEWS > index 0da7d8f97..72585e56b 100644 > --- a/NEWS > +++ b/NEWS > @@ -25,6 +25,

Re: [ovs-dev] [PATCH v4 ovn 2/4] ovn-northd: Add support for CoPP.

On 16/06/2021 11:30, Lorenzo Bianconi wrote: > From: Dumitru Ceara > > Add new 'Copp' (Control plane protection) table to OVN Northbound DB: > - this stores mappings between control plane protocol names and meters > that should be used to rate limit controller-destined traffic for > those pro

Re: [ovs-dev] [PATCH v4 ovn 2/4] ovn-northd: Add support for CoPP.

On 16/06/2021 11:30, Lorenzo Bianconi wrote: > +dnl This test is not suported by ovn-northd-ddlog yet. > +AT_SKIP_IF([test NORTHD_TYPE = ovn-northd-ddlog && test "$RUN_ANYWAY" != > yes]) One more thing .. I am unsure what the policy is with regards to pushing this without ddlog support. Perhaps

Re: [ovs-dev] [PATCH V3 1/1] dpdk: Add debug appctl to get malloc statistics.

On 5/19/21 10:00 AM, Eli Britstein wrote: > New appctl 'dpdk/get-malloc-stats' implemented to get result of > 'rte_malloc_dump_stats()' function. > > Could be used for debugging. > > Signed-off-by: Eli Britstein > Reviewed-by: Salem Sol > --- > > v2: > - Following Eelco Chaudron's comments, ab

[ovs-dev] [ovn] howto? L3 support in HW VTEP

Hi all, I’m trying to implement support for L3 routing between OVN and HW VTEP devices. In my setup I use Cumulus Linux-managed Mellanox SN2000 switches. Current L2 functionality in this setup works well: ovn-controller-vtep and a small python service on the switch (which installs necessary mcast_

Re: [ovs-dev] [PATCH v4 ovn 2/4] ovn-northd: Add support for CoPP.

> On 16/06/2021 11:30, Lorenzo Bianconi wrote: > > +dnl This test is not suported by ovn-northd-ddlog yet. > > +AT_SKIP_IF([test NORTHD_TYPE = ovn-northd-ddlog && test "$RUN_ANYWAY" != > > yes]) > > One more thing .. > > I am unsure what the policy is with regards to pushing this without > ddlog

Re: [ovs-dev] [v13 01/12] dpif-netdev: Refactor to multiple header files.

Hello, Some comments below. On Thu, Jun 17, 2021 at 05:18:14PM +0100, Cian Ferriter wrote: > From: Harry van Haaren > > Split the very large file dpif-netdev.c and the datastructures > it contains into multiple header files. Each header file is > responsible for the datastructures of that com

Re: [ovs-dev] [v13 02/12] dpif-netdev: Split HWOL out to own header file.

Hello, I have some comments inline. On Thu, Jun 17, 2021 at 05:18:15PM +0100, Cian Ferriter wrote: > From: Harry van Haaren > > This commit moves the datapath lookup functions required for > hardware offload to a seperate file. This allows other DPIF Spelling

Re: [ovs-dev] [v13 03/12] dpif-netdev: Add function pointer for netdev input.

Hello, On Thu, Jun 17, 2021 at 05:18:16PM +0100, Cian Ferriter wrote: > From: Harry van Haaren > > This commit adds a function pointer to the pmd thread data structure, > giving the pmd thread flexibility in its dpif-input function choice. > This allows choosing of the implementation based on

[ovs-dev] [PATCH v2 ovn 1/9] northd: move snat_type out of vip loop

Move snat_type out of vip loop in build_lrouter_lb_flows() since there is not vip dependency Signed-off-by: Lorenzo Bianconi --- northd/ovn-northd.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index aae7314c8..83ac7

[ovs-dev] [PATCH v2 ovn 3/9] northd: move build_empty_lb_event_flow in build_lrouter_flows_for_lb

Introduce build_lrouter_flows_for_lb routine in order to visit first each load_balancer and then related datapath during lb flow installation. This patch allows to reduce memory footprint and cpu utilization in ovn-northd. Signed-off-by: Lorenzo Bianconi --- northd/ovn-northd.c | 109 +++

[ovs-dev] [PATCH v2 ovn 2/9] lib: link logical routers assigned for the same lb

add logical routers datapath references in ovn_northd_lb data structure. This is a preliminary patch to invert the logic used during the lb flow creation in order to visit lb first and then related datapath. Signed-off-by: Lorenzo Bianconi --- lib/lb.c| 11 +++ lib/lb.h

[ovs-dev] [PATCH v2 ovn 6/9] northd: remove dead code in build_lrouter_nat_defrag_and_lb

Remove if condition that is never executed in build_lrouter_nat_defrag_and_lb routine Signed-off-by: Lorenzo Bianconi --- northd/ovn-northd.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 0fff0c2e0..ed864e038 100644 --- a/northd/ovn-nor

[ovs-dev] [PATCH v2 ovn 0/9] northd: rework ovn-northd lb flow installation

Rework lb flow logic in order to visit first each load_balancer and then related datapath during lb flow installation. This patch allows to reduce memory footprint and cpu utilization in ovn-northd. Testing environment: ovn-nbctl lr-list |wc -l 308 ovn-nbctl ls-list |wc -l 615 ovn-nbctl lb-list |w

[ovs-dev] [PATCH v2 ovn 4/9] northd: move lb_{skip, force}_snat code in build_lrouter_snat_flows_for_lb

Introduce build_lrouter_snat_flows_for_lb routine to configuring lb_{skip,force}_snat flows for each configured load_balancer Signed-off-by: Lorenzo Bianconi --- northd/ovn-northd.c | 205 1 file changed, 152 insertions(+), 53 deletions(-) diff --git

[ovs-dev] [PATCH v2 ovn 5/9] northd: get rid of add_router_lb_flow

Remove add_router_lb_flow routine and move leftover lb flow installation code in build_lrouter_snat_flows_for_lb routine Signed-off-by: Lorenzo Bianconi --- northd/ovn-northd.c | 257 1 file changed, 118 insertions(+), 139 deletions(-) diff --git a/n

[ovs-dev] [PATCH v2 ovn 7/9] lb: link logical switches assigned for the same lb

As it has been already done for logical routers, add logical switches datapath references in ovn_northd_lb data structure. This is a preliminary patch to invert the logic used during the lb flow creation in order to visit lb first and then related datapath. Signed-off-by: Lorenzo Bianconi --- li

[ovs-dev] [PATCH v2 ovn 8/9] northd: move build_empty_lb_event_flow in build_lswitch_flows_for_lb

Introduce build_lswitch_flows_for_lb routine in order to visit first each load_balancer and then related datapath (logical switches) during lb flow installation. This patch allows to reduce memory footprint and cpu utilization in ovn-northd. Signed-off-by: Lorenzo Bianconi --- northd/ovn-northd.

[ovs-dev] [PATCH v2 ovn 9/9] northd: move build_lb_rules in build_lswitch_flows_for_lb

Move stateful lb rules for logical switches in build_lswitch_flows_for_lb routine in order to reduce cpu utilization Signed-off-by: Lorenzo Bianconi --- northd/ovn-northd.c | 42 ++ 1 file changed, 18 insertions(+), 24 deletions(-) diff --git a/northd/ovn

[ovs-dev] [PATCH ovn v3] ovn-northd.c: Add proxy ARP support to OVN

From 634fd88b726700b30cb76203ca45f1e9c041368a Mon Sep 17 00:00:00 2001 From: Brendan Doyle Date: Fri, 28 May 2021 10:01:17 -0700 Subject: [PATCH ovn] ovn-northd.c: Add proxy ARP support to OVN This patch provides the ability to configure proxy ARP IPs on a Logical Switch Router port. The IPs are

Re: [ovs-dev] [PATCH] dpif-netdev: Fix crash when PACKET_OUT is metered

On 6/17/21 11:59 PM, Ben Pfaff wrote: > All these flags for stealing, allowing stealing, blah blah, are just > ways to do some kind of dumb reference counting without actually have a > reference count. When it gets super complex like this, maybe > introducing a reference count is the way to go. I

Re: [ovs-dev] [PATCH] dpif-netdev: Fix crash when PACKET_OUT is metered

Ilya Maximets writes: > On 6/17/21 11:59 PM, Ben Pfaff wrote: >> All these flags for stealing, allowing stealing, blah blah, are just >> ways to do some kind of dumb reference counting without actually have a >> reference count. When it gets super complex like this, maybe >> introducing a refere

Re: [ovs-dev] [PATCH ovn v2 1/5] ovn-util.h: Call ds_clear() in get_sb_port_group_name().

On 6/11/21 9:35 PM, Han Zhou wrote: > This moves the burden from caller to the helper function. > > Signed-off-by: Han Zhou > --- Acked-by: Dumitru Ceara Thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo

Re: [ovs-dev] [PATCH ovn v2 2/5] ovn-controller: Fix incremental processing for multicast group dependency.

On 6/11/21 9:35 PM, Han Zhou wrote: > Multicast group changes are handled for physical flows in I-P, but not > handled for logical flows. Although logical flow doesn't care about the > content of a multicast group, the existance of it matters for logical > flow processing. If the multicast group is

Re: [ovs-dev] [PATCH ovn v2 3/5] ovn-northd: Remove lflow_add_unique.

On 6/11/21 9:35 PM, Han Zhou wrote: > This patch removes the workaround when adding multicast group related > lflows, because the multicast group dependency problem is fixed in > ovn-controller in the previous commit. > > This patch also removes the UniqueFlow/AnnotatedFlow usage in northd > DDlog

Re: [ovs-dev] [PATCH ovn v2 4/5] ovn-controller: Always monitor all logical datapath groups.

On 6/11/21 9:35 PM, Han Zhou wrote: > Always monitor all logical datapath groups. Otherwise, DPG updates may > be received *after* the lflows using it are seen by ovn-controller. > Since the number of DPGs are relatively small, we monitor all DPGs to > avoid the unnecessarily extra control plane ro

Re: [ovs-dev] [PATCH ovn v2 5/5] ovn-controller: Fix incremental processing for logical port references.

On 6/11/21 9:35 PM, Han Zhou wrote: > If a lflow has an lport name in the match, but when the lflow is > processed the port-binding is not seen by ovn-controller, the > corresponding openflow will not be created. Later if the port-binding is > created/monitored by ovn-controller, the lflow is not r

[ovs-dev] [PATCH ovn branch-21.06 0/2] Release patches for v21.06.0.

Mark Michelson (2): Set release date for 21.06.0. Prepare for 21.06.1. NEWS | 3 +++ debian/changelog | 8 +++- 2 files changed, 10 insertions(+), 1 deletion(-) -- 2.31.1 ___ dev mailing list d...@openvswitch.org https://mail.op

[ovs-dev] [PATCH ovn branch-21.06 1/2] Set release date for 21.06.0.

Signed-off-by: Mark Michelson --- debian/changelog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/changelog b/debian/changelog index 35dbd04c2..b1e6650c6 100644 --- a/debian/changelog +++ b/debian/changelog @@ -2,7 +2,7 @@ ovn (21.06.90-1) unstable; urgency=low *

[ovs-dev] [PATCH ovn branch-21.06 2/2] Prepare for 21.06.1.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ debian/changelog | 6 ++ 2 files changed, 9 insertions(+) diff --git a/NEWS b/NEWS index c62377919..c52db0386 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v21.06.1 - xx xxx +-- + Post-v21.06.0 ---

Re: [ovs-dev] [PATCH ovn branch-21.06 1/2] Set release date for 21.06.0.

On 6/18/21 6:34 PM, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- > debian/changelog | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/debian/changelog b/debian/changelog > index 35dbd04c2..b1e6650c6 100644 > --- a/debian/changelog > +++ b/debian/changelog >

Re: [ovs-dev] [PATCH ovn branch-21.06 2/2] Prepare for 21.06.1.

On 6/18/21 6:34 PM, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- > NEWS | 3 +++ > debian/changelog | 6 ++ > 2 files changed, 9 insertions(+) > > diff --git a/NEWS b/NEWS > index c62377919..c52db0386 100644 > --- a/NEWS > +++ b/NEWS > @@ -1,3 +1,6 @@ > +OVN v21.06

[ovs-dev] [PATCH ovn branch-21.06 v2 1/2] Set release date for 21.06.0.

Signed-off-by: Mark Michelson --- NEWS | 5 + configure.ac | 2 +- debian/changelog | 2 +- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/NEWS b/NEWS index c62377919..839ab2cfe 100644 --- a/NEWS +++ b/NEWS @@ -1,7 +1,4 @@ -Post-v21.06.0 ---

[ovs-dev] [PATCH ovn branch-21.06 v2 0/2] Release patches for v21.06.0.

Mark Michelson (2): Set release date for 21.06.0. Prepare for 21.06.1. NEWS | 6 +++--- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 11 insertions(+), 5 deletions(-) -- 2.31.1 ___ dev mailing list d...@op

[ovs-dev] [PATCH ovn branch-21.06 v2 2/2] Prepare for 21.06.1.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 839ab2cfe..38ea66e77 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v21.06.1 - xx xxx +---

Re: [ovs-dev] [PATCH ovn branch-21.06 v2 2/2] Prepare for 21.06.1.

On 6/18/21 6:58 PM, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index 839ab2cfe..38ea66e77 100644 > --- a/NEWS >

Re: [ovs-dev] [PATCH ovn branch-21.06 v2 1/2] Set release date for 21.06.0.

On 6/18/21 6:58 PM, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- > NEWS | 5 + > configure.ac | 2 +- > debian/changelog | 2 +- > 3 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/NEWS b/NEWS > index c62377919..839ab2cfe 100644 > --- a/NEWS > +

[ovs-dev] [PATCH ovn branch-21.06 v3 0/2] Release patches for v21.06.0.

Mark Michelson (2): Set release date for 21.06.0. Prepare for 21.06.1. NEWS | 4 ++-- configure.ac | 2 +- debian/changelog | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) -- 2.31.1 ___ dev mailing list d...@openvsw

[ovs-dev] [PATCH ovn branch-21.06 v3 2/2] Prepare for 21.06.1.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 0da7d8f97..c99cb7a0b 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v21.06.1 - xx xxx +---

[ovs-dev] [PATCH ovn branch-21.06 v3 2/2] Set release date for 21.06.0.

Signed-off-by: Mark Michelson --- configure.ac | 2 +- debian/changelog | 8 +--- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index df0b98295..53034388a 100644 --- a/configure.ac +++ b/configure.ac @@ -13,7 +13,7 @@ # limitations under the L

[ovs-dev] [PATCH ovn branch-21.06 v3 1/2] github: Use nmap-ncat instead of netcat-openbsd.

From: Dumitru Ceara There are some bugs in the netcat-openbsd version shipped with Ubuntu 20.04. Switch to nmap-ncat to avoid system tests that will be added by upcoming commits fail in CI. One example: 1. Start a TCP connection from IP1:port-x to IP2:port-y. 2. Start a TCP connection from IP1

[ovs-dev] [PATCH ovn branch-21.06 v3 1/2] Set release date for 21.06.0.

Signed-off-by: Mark Michelson --- NEWS | 3 --- configure.ac | 2 +- debian/changelog | 8 +--- 3 files changed, 2 insertions(+), 11 deletions(-) diff --git a/NEWS b/NEWS index c62377919..0da7d8f97 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,3 @@ -Post-v21.06.0 --

[ovs-dev] [PATCH ovn branch-21.06 v4 1/2] Set release date for 21.06.0.

Signed-off-by: Mark Michelson --- NEWS | 3 --- configure.ac | 2 +- debian/changelog | 8 +--- 3 files changed, 2 insertions(+), 11 deletions(-) diff --git a/NEWS b/NEWS index c62377919..0da7d8f97 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,3 @@ -Post-v21.06.0 --

[ovs-dev] [PATCH ovn branch-21.06 v4 2/2] Prepare for 21.06.1.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 0da7d8f97..c99cb7a0b 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v21.06.1 - xx xxx +---

[ovs-dev] [PATCH ovn branch-21.06 v4 0/2] Release patches for v21.06.0.

Mark Michelson (2): Set release date for 21.06.0. Prepare for 21.06.1. NEWS | 4 ++-- configure.ac | 2 +- debian/changelog | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) -- 2.31.1 ___ dev mailing list d...@openvsw

[ovs-dev] [PATCH ovn branch-21.06 v5 0/2] Release patches for v21.06.0.

Mark Michelson (2): Set release date for 21.06.0. Prepare for 21.06.1. NEWS | 4 ++-- configure.ac | 2 +- debian/changelog | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) -- 2.31.1 ___ dev mailing list d...@openvsw

[ovs-dev] [PATCH ovn branch-21.06 v5 2/2] Prepare for 21.06.1.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 0da7d8f97..c99cb7a0b 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v21.06.1 - xx xxx +---

[ovs-dev] [PATCH ovn branch-21.06 v5 1/2] Set release date for 21.06.0.

Signed-off-by: Mark Michelson --- NEWS | 3 --- configure.ac | 2 +- debian/changelog | 8 +--- 3 files changed, 2 insertions(+), 11 deletions(-) diff --git a/NEWS b/NEWS index c62377919..0da7d8f97 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,3 @@ -Post-v21.06.0 --

[ovs-dev] [PATCH ovn branch-21.06 v6 0/2] Release patches for v21.06.0.

Mark Michelson (2): Set release date for 21.06.0. Prepare for 21.06.1. NEWS | 6 +++--- configure.ac | 2 +- debian/changelog | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) -- 2.31.1 ___ dev mailing list d...@openv

[ovs-dev] [PATCH ovn branch-21.06 v6 2/2] Prepare for 21.06.1.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 839ab2cfe..38ea66e77 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v21.06.1 - xx xxx +---

[ovs-dev] [PATCH ovn branch-21.06 v6 1/2] Set release date for 21.06.0.

Signed-off-by: Mark Michelson --- NEWS | 5 + configure.ac | 2 +- debian/changelog | 8 +--- 3 files changed, 3 insertions(+), 12 deletions(-) diff --git a/NEWS b/NEWS index c62377919..839ab2cfe 100644 --- a/NEWS +++ b/NEWS @@ -1,7 +1,4 @@ -Post-v21.06.0

Re: [ovs-dev] [PATCH ovn branch-21.06 v6 0/2] Release patches for v21.06.0.

On 6/18/21 7:35 PM, Mark Michelson wrote: > > Mark Michelson (2): > Set release date for 21.06.0. > Prepare for 21.06.1. > > NEWS | 6 +++--- > configure.ac | 2 +- > debian/changelog | 6 +++--- > 3 files changed, 7 insertions(+), 7 deletions(-) > This one looks correct to

Re: [ovs-dev] [DISCUSS] CI discussion: travis-ci.org / travis-ci.com

On 6/18/21 1:49 AM, Ben Pfaff wrote: > On Wed, Jun 16, 2021 at 12:25:34PM -0400, Aaron Conole wrote: >> Recently, Travis-CI has retired the travis-ci.org service. At the >> moment, it is read-only. In the future, it may disappear completely. >> >> Currently, Open vSwitch has public facing badges,

Re: [ovs-dev] [PATCH ovn branch-21.06 v3 2/2] Prepare for 21.06.1.

Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (debian/changelog). error: could not build fake anc

Re: [ovs-dev] [PATCH ovn branch-21.06 v5 1/2] Set release date for 21.06.0.

Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: patch failed: NEWS:1 error: NEWS: patch does not apply error: Did you hand edit your patch

Re: [ovs-dev] [ovn] howto? L3 support in HW VTEP

On Fri, Jun 18, 2021 at 7:42 AM Vladislav Odintsov wrote: > > Hi all, > > I’m trying to implement support for L3 routing between OVN and HW VTEP > devices. > In my setup I use Cumulus Linux-managed Mellanox SN2000 switches. > Current L2 functionality in this setup works well: ovn-controller-vtep

Re: [ovs-dev] [PATCH ovn v2 3/5] ovn-northd: Remove lflow_add_unique.

On 6/18/21 5:51 PM, Dumitru Ceara wrote: > On 6/11/21 9:35 PM, Han Zhou wrote: >> This patch removes the workaround when adding multicast group related >> lflows, because the multicast group dependency problem is fixed in >> ovn-controller in the previous commit. >> >> This patch also removes the U

Re: [ovs-dev] [PATCH ovn branch-21.06 v6 0/2] Release patches for v21.06.0.

On Fri, Jun 18, 2021 at 1:40 PM Ilya Maximets wrote: > > On 6/18/21 7:35 PM, Mark Michelson wrote: > > > > Mark Michelson (2): > > Set release date for 21.06.0. > > Prepare for 21.06.1. > > > > NEWS | 6 +++--- > > configure.ac | 2 +- > > debian/changelog | 6 +++--- > > 3 fi

Re: [ovs-dev] [PATCH ovn v2 3/5] ovn-northd: Remove lflow_add_unique.

On Fri, Jun 18, 2021 at 11:57 AM Dumitru Ceara wrote: > > On 6/18/21 5:51 PM, Dumitru Ceara wrote: > > On 6/11/21 9:35 PM, Han Zhou wrote: > >> This patch removes the workaround when adding multicast group related > >> lflows, because the multicast group dependency problem is fixed in > >> ovn-con

Re: [ovs-dev] [PATCH ovn v2 2/2] lflow-cache: Auto trim when cache size is reduced significantly.

Hi Dumitru, I only had one finding down below. On 6/15/21 9:06 AM, Dumitru Ceara wrote: Due to a bug in glibc [0], M_TRIM_THRESHOLD (default 128KB) is not honored. The lflow cache is one of the largest memory consumers in ovn-controller and it used to trim memory whenever the cache was flushed

Re: [ovs-dev] [PATCH ovn v2 3/5] ovn-northd: Remove lflow_add_unique.

On 6/18/21 9:10 PM, Han Zhou wrote: > On Fri, Jun 18, 2021 at 11:57 AM Dumitru Ceara wrote: >> >> On 6/18/21 5:51 PM, Dumitru Ceara wrote: >>> On 6/11/21 9:35 PM, Han Zhou wrote: This patch removes the workaround when adding multicast group related lflows, because the multicast group dep

Re: [ovs-dev] [PATCH ovn v2 2/2] lflow-cache: Auto trim when cache size is reduced significantly.

On 6/18/21 9:11 PM, Mark Michelson wrote: > Hi Dumitru, > > I only had one finding down below. > > On 6/15/21 9:06 AM, Dumitru Ceara wrote: >> Due to a bug in glibc [0], M_TRIM_THRESHOLD (default 128KB) is not >> honored.  The lflow cache is one of the largest memory consumers in >> ovn-controlle

Re: [ovs-dev] [PATCH ovn] northd: avoid memory reallocation while building ACL and QoS rules

On 6/4/21 10:00 PM, Dan Williams wrote: > Inspried by: > > 3b6362d64e86b northd: Avoid memory reallocation while building lb rules. > > Signed-off-by: Dan Williams > --- > NOTE: this is driven by visual inspection not perf data. But it > shouldn't be worse than current code and should be better

[ovs-dev] [PATCH ovn v3 0/2] ovn-controller: Auto trim memory when chache size is reduced significantly.

Changes in v3: - Addressed Mark Michelson's comment on patch 2/2, to properly set need_trim. - Fixed the unit test that was supposed to check trimming. Changes in v2: - Addressed Mark Gray's comments: - Made trim flow limit configurable. - Made trim high watermark percentage configurable. -

[ovs-dev] [PATCH ovn v3 1/2] chassis: Refactor chassis other_config propagation.

Signed-off-by: Dumitru Ceara --- controller/chassis.c | 87 -- 1 file changed, 28 insertions(+), 59 deletions(-) diff --git a/controller/chassis.c b/controller/chassis.c index 9b0a36cf0..80d516f49 100644 --- a/controller/chassis.c +++ b/controlle

[ovs-dev] [PATCH ovn v3 2/2] lflow-cache: Auto trim when cache size is reduced significantly.

Due to a bug in glibc [0], M_TRIM_THRESHOLD (default 128KB) is not honored. The lflow cache is one of the largest memory consumers in ovn-controller and it used to trim memory whenever the cache was flushed. However, that required periodic intervention from the CMS side. Instead, we now automati

Re: [ovs-dev] [PATCH ovn v2 2/2] lflow-cache: Auto trim when cache size is reduced significantly.

On 6/18/21 9:14 PM, Dumitru Ceara wrote: >> Should this be "need_trim = true;"? Currently, it's impossible for >> need_trim to ever be true in this function. >> > Ugh, you're right, sorry about that. I'll also add a test to exercise > this. Thanks for the review! Turns out I had a test already b

Re: [ovs-dev] [ovn] howto? L3 support in HW VTEP

Sorry, there was a typo. Sure, VM has IP 192.168.1.2/24 and host 192.168.2.2/24. [root@ovn-1 ~]# ovn-nbctl show switch 8e1e2828-67b2-432b-8b2e-088f312dab5d (switch1) port switch1-uplink type: router router-port: switch1-gw port switch1-vm addresses: ["00:00:00:00:00

Re: [ovs-dev] [PATCH v3 ovn 0/5] Handle DNAT/no-NAT conntrack tuple collisions if possible.

On Tue, Jun 15, 2021 at 4:52 PM Numan Siddique wrote: > > On Fri, Jun 11, 2021 at 6:11 AM Dumitru Ceara wrote: > > > > This depends on the following OVS patch to be accepted: > > > > https://patchwork.ozlabs.org/project/openvswitch/patch/162264080113.315078.1220132318734842720.stgit@ebuild/ > > >

Re: [ovs-dev] [PATCH] dpif-netdev: Fix crash when PACKET_OUT is metered

Hi all I am in favour of a better fix, bandaids tend to come back and bite you in the end anyway. So, will be happy to help with this effort, though I am probably going to have to defer to the rest of you when it comes to actually knowing what to do in this area. Cheers Tony __

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

On Thu, Apr 08, 2021 at 03:31:24PM +0200, Eelco Chaudron wrote: > > > On 8 Apr 2021, at 14:05, Martin Varghese wrote: > > > On Wed, Apr 07, 2021 at 03:49:07PM +, Jan Scheurich wrote: > > > Hi Martin, > > > > > > I guess you are aware of the original design document we wrote for > > > generi