Re: [ovs-dev] [PATCH ovn v2 5/5] ovn-controller: Fix incremental processing for logical port references.

2021-06-20 Thread Han Zhou
On Fri, Jun 18, 2021 at 8:52 AM Dumitru Ceara wrote: > > On 6/11/21 9:35 PM, Han Zhou wrote: > > If a lflow has an lport name in the match, but when the lflow is > > processed the port-binding is not seen by ovn-controller, the > > corresponding openflow will not be created. Later if the port-bind

Re: [ovs-dev] [PATCH ovn v2 3/5] ovn-northd: Remove lflow_add_unique.

2021-06-20 Thread Han Zhou
On Fri, Jun 18, 2021 at 12:12 PM Dumitru Ceara wrote: > > On 6/18/21 9:10 PM, Han Zhou wrote: > > On Fri, Jun 18, 2021 at 11:57 AM Dumitru Ceara wrote: > >> > >> On 6/18/21 5:51 PM, Dumitru Ceara wrote: > >>> On 6/11/21 9:35 PM, Han Zhou wrote: > This patch removes the workaround when adding

[ovs-dev] [PATCH ovn v3 1/3] ovn-northd: Remove lflow_add_unique.

2021-06-20 Thread Han Zhou
This patch removes the workaround when adding multicast group related lflows, because the multicast group dependency problem is fixed in ovn-controller in the previous commit. This patch also removes the UniqueFlow/AnnotatedFlow usage in northd DDlog implementation for the same reason. Signed-off

[ovs-dev] [PATCH ovn v3 3/3] ovn-controller: Fix incremental processing for logical port references.

2021-06-20 Thread Han Zhou
If a lflow has an lport name in the match, but when the lflow is processed the port-binding is not seen by ovn-controller, the corresponding openflow will not be created. Later if the port-binding is created/monitored by ovn-controller, the lflow is not reprocessed because the lflow didn't change a

[ovs-dev] [PATCH ovn v3 0/3] Fix ovn-controller I-P for multicast groups and lport changes

2021-06-20 Thread Han Zhou
The series fixes incremental processing for missing dependency handling for multicast group and logical port binding changes when computing logical flows. It also removes the workaround in northd that was required due to the missing dependency handling. In addition, the fix also allows us to monito

[ovs-dev] [PATCH ovn v3 2/3] ovn-controller: Always monitor all logical datapath groups.

2021-06-20 Thread Han Zhou
Always monitor all logical datapath groups. Otherwise, DPG updates may be received *after* the lflows using it are seen by ovn-controller. Since the number of DPGs are relatively small, we monitor all DPGs to avoid the unnecessarily extra control plane round trip for the lflows to be processed. Ac

[ovs-dev] [PATCH] conntrack: fix inverse check nat_action_info in check_orig_tuple

2021-06-20 Thread wenxu
From: wenxu When the conntrack is not be found, CT will check whether the pkt has be NATed, get the orignal tuple and search the conntrack from orignal tuple. If there is nat_action_info in the rule, the pkt maybe NATed. So it should find the original tuple to find the conntrack. Signed-off-by:

Re: [ovs-dev] [v13 04/12] dpif-avx512: Add ISA implementation of dpif.

2021-06-20 Thread Flavio Leitner
Hi, I am still reviewing the patch, but I thought worth to discuss few items below. On Thu, Jun 17, 2021 at 05:18:17PM +0100, Cian Ferriter wrote: > From: Harry van Haaren > > This commit adds the AVX512 implementation of DPIF functionality, > specifically the dp_netdev_input_outer_avx512 fun

Re: [ovs-dev] [PATCH ovn v3 2/2] lflow-cache: Auto trim when cache size is reduced significantly.

2021-06-20 Thread Mark Gray
On 18/06/2021 20:58, Dumitru Ceara wrote: > Due to a bug in glibc [0], M_TRIM_THRESHOLD (default 128KB) is not > honored. The lflow cache is one of the largest memory consumers in > ovn-controller and it used to trim memory whenever the cache was > flushed. However, that required periodic interve

Re: [ovs-dev] [PATCH ovn v3 1/2] chassis: Refactor chassis other_config propagation.

2021-06-20 Thread Mark Gray
On 18/06/2021 20:58, Dumitru Ceara wrote: > Signed-off-by: Dumitru Ceara > --- > controller/chassis.c | 87 > -- > 1 file changed, 28 insertions(+), 59 deletions(-) Acked-by: Mark D. Gray ___ dev mai