On 19 Jun 2021, at 8:06, Martin Varghese wrote:
> On Thu, Apr 08, 2021 at 03:31:24PM +0200, Eelco Chaudron wrote:
>>
>>
>> On 8 Apr 2021, at 14:05, Martin Varghese wrote:
>>
>>> On Wed, Apr 07, 2021 at 03:49:07PM +, Jan Scheurich wrote:
Hi Martin,
I guess you are aware of the
In a new OVS use case with a 3rd party SDN controller,
we observe two new typical patterns that are handled
sub-optimally:
1. Degenerate select groups with a single bucket.
For such select groups the overhead of computing a dp_hash
and recirculating the packet in the datapath to look up the
bucket
For patch ports, the is_last_action value is not propagated and is
always set to true. This causes non-reversible actions to modify the
packet, and the original content is not preserved when processing
the remaining actions.
This patch propagates the is_last_action flag for patch port related
acti
On 6/20/21 9:49 AM, Mark Gray wrote:
>> Instead, we now automatically trim memory every time the lflow cache
>> utilization decreases by 50%, with a threshold of at least
>> lflow-cache-trim-limit (1) elements in the cache.
>>
>> The percentage of the high watermark under which memory is trimme
On 6/21/21 8:53 AM, Han Zhou wrote:
> is_cr_cond_present only checks if is_chassis_resident() exists (which would
> reference a logical port). lflow_ref_lookup() checks for all the logical
> port references (not just by is_chassis_resident()).
> For lflows that reference logical ports, we can cache
Two more patches has been introduced.
1/4 is a prereq for the series because it fixes an issue that prevents
OVN to use all-zero snat due to the way it builds the pipeline.
The patch 2/4 has been introduced in v6 as a prereq of 3/4.
All the versions up to v6 were about patch 3/4.
{2,3}/4 are unto
when a packet gets dnatted and then recirculated, it could be possible
that it matches another rule that performs another nat action.
The kernel datapath handles this situation turning to a no-op the
second nat action, so natting only once the packet. In the userspace
datapath instead, when the ct
this macro is handy when it comes paste two tokens when one or both
are macros.
Rename CURSOR_JOIN() to OVS_JOIN() and move it to util.h so that it can
be reused.
Signed-off-by: Paolo Valerio
Acked-by: Gaetan Rivet
Acked-by: Aaron Conole
---
lib/cmap.h |5 +
lib/util.h |7 +++
this patch introduces for the userspace datapath the handling
of rules like the following:
ct(commit,nat(src=0.0.0.0),...)
Kernel datapath already handle this case that is particularly
handy in scenarios like the following:
Given A: 10.1.1.1, B: 192.168.2.100, C: 10.1.1.2
A opens a connection t
Signed-off-by: Paolo Valerio
---
lib/dpif-netdev.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 05de57ed5..3f04bf6ec 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -8250,6 +8250,16 @@ dpif_netdev_ct_del_l
Hi Numan,
I know things are busy but did you get a chance to look at this. I made
the change to use
extract_ip_addresses() as requested.
Brendan
On 18/06/2021 14:53, Brendan Doyle wrote:
From 634fd88b726700b30cb76203ca45f1e9c041368a Mon Sep 17 00:00:00 2001
From: Brendan Doyle
Date: Fri, 28
Bleep bloop. Greetings Paolo Valerio, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch' to see the failed p
On 5/27/21 9:15 PM, Aaron Conole wrote:
> This makes openvswitch module use the event tracing framework
> to log the upcall interface and action execution pipeline. When
> using openvswitch as the packet forwarding engine, some types of
> debugging are made possible simply by using the ovs-vswitch
Dumitru Ceara writes:
> On 5/27/21 9:15 PM, Aaron Conole wrote:
>> This makes openvswitch module use the event tracing framework
>> to log the upcall interface and action execution pipeline. When
>> using openvswitch as the packet forwarding engine, some types of
>> debugging are made possible s
Paolo Valerio writes:
> Signed-off-by: Paolo Valerio
> ---
Acked-by: Aaron Conole
> lib/dpif-netdev.c | 12 +++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> index 05de57ed5..3f04bf6ec 100644
> --- a/lib/dpif-netdev.c
>
Hi Flavio,
Thanks for the review. My responses are inline.
Thanks,
Cian
> -Original Message-
> From: Flavio Leitner
> Sent: Friday 18 June 2021 13:12
> To: Ferriter, Cian
> Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [v13 01/12] dpif-netdev: Refactor to mul
Hi Flavio,
Thanks for the review. My comments are inline,
Cian
> -Original Message-
> From: Flavio Leitner
> Sent: Friday 18 June 2021 13:12
> To: Ferriter, Cian
> Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [v13 02/12] dpif-netdev: Split HWOL out to own he
Hi Flavio,
Thanks for the review. My responses are inline.
Cian
> -Original Message-
> From: Flavio Leitner
> Sent: Friday 18 June 2021 13:53
> To: Ferriter, Cian
> Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [v13 03/12] dpif-netdev: Add function pointer fo
Hi Flavio,
Thanks for the review. My responses are inline.
Cian
> -Original Message-
> From: Flavio Leitner
> Sent: Sunday 20 June 2021 21:09
> To: Ferriter, Cian
> Cc: ovs-dev@openvswitch.org; Amber, Kumar ;
> i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [v13 04/12] dpif-avx512: Add I
On 18/06/2021 00:43, David Wilder wrote:
> This change removes the assumption that numa nodes and cores are numbered
> contiguously in linux. This change is required to support some Power
> systems.
>
> A check has been added to verify that cores are online,
> offline cores result in non-contiguo
On Mon, Jun 21, 2021 at 04:13:12PM +, Ferriter, Cian wrote:
> Hi Flavio,
>
> Thanks for the review. My responses are inline.
>
> Cian
>
> > -Original Message-
> > From: Flavio Leitner
> > Sent: Sunday 20 June 2021 21:09
> > To: Ferriter, Cian
> > Cc: ovs-dev@openvswitch.org; Amber,
On Fri, Jun 4, 2021 at 12:55 PM Lorenzo Bianconi
wrote:
>
> Add a rule to drop traffic from a distributed NAT if the virtual
> port has not claimed yet becaused otherwise the traffic will be
> centralized misconfiguring the TOR switch.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1952961
> Sign
Hi,
This commit could be submitted outside of this patch-set as fix
for commit 9ff7cabfd7 ("dpif-netdev: add subtable-lookup-prio-get
command") and commit 3d018c3ea79d ("dpif-netdev: add subtable lookup
prio set command.").
This helps to get it merged sooner and reduce this patch-set size.
Tha
On 6/11/21 5:42 PM, anton.iva...@cambridgegreys.com wrote:
> From: Anton Ivanov
>
> Set a soft time limit of "raft election timer"/2 on ovsdb
> processing.
>
> This improves behaviour in large heavily loaded clusters.
> While it cannot fully eliminate spurious raft elections
> under heavy load,
On 6/19/21 4:11 AM, Tony van der Peet wrote:
> Hi all
>
> I am in favour of a better fix, bandaids tend to come back and bite you in
> the end anyway. So, will be happy to help with this effort, though I am
> probably going to have to defer to the rest of you when it comes to actually
> knowing
On Fri, Jun 11, 2021 at 10:32 AM Lorenzo Bianconi
wrote:
>
> As it is already done for distributed gw router scenario, introduce
> check_pkt_larger logical flows for gw router use case.
>
> Signed-off-by: Lorenzo Bianconi
Hi Lorenzo,
Thanks for the patches. You forgot to put the "ovn" tag in t
On Fri, Jun 11, 2021 at 10:32 AM Lorenzo Bianconi
wrote:
>
> Introduce check_pkt_larger action for ingress traffic
> entering the cluster from a distributed gw router port
> or from a gw router. This patch enables pMTU discovery
> for ingress traffic.
>
> Signed-off-by: Lorenzo Bianconi
Hi Lore
The test case fails quite often for northd-ddlog because of the tunnel
keys mismatch when comparing OpenFlow rules. Keys can change in
different runs. This patch fixes it by extracting the expected keys from
SB DB before comparison instead of hardcoding.
There are some other potential timing issue
On Mon, Jun 21, 2021 at 6:37 PM Han Zhou wrote:
>
> The test case fails quite often for northd-ddlog because of the tunnel
> keys mismatch when comparing OpenFlow rules. Keys can change in
> different runs. This patch fixes it by extracting the expected keys from
> SB DB before comparison instead
The test case fails quite often for northd-ddlog because of the tunnel
keys mismatch when comparing OpenFlow rules. Keys can change in
different runs. This patch fixes it by extracting the expected keys from
SB DB before comparison instead of hardcoding.
There are some other potential timing issue
On Thu, Jun 17, 2021 at 12:59 PM Mark Michelson wrote:
>
> On 6/14/21 2:44 PM, Ben Pfaff wrote:
> > On Fri, Jun 11, 2021 at 03:48:52PM -0700, Han Zhou wrote:
> >> The test case fails quite often for northd-ddlog because of the tunnel
> >> keys mismatch when comparing OpenFlow rules. Keys can chang
Acked-by: Han Zhou
On Sat, Jun 19, 2021 at 2:51 AM Mark Gray wrote:
> Signed-off-by: Mark Gray
> ---
> tests/system-ovn.at | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/system-ovn.at b/tests/system-ovn.at
> index 1b8bb3803def..552fdae52665 100644
> --- a/tests
On Sat, Jun 19, 2021 at 2:51 AM Mark Gray wrote:
>
> If a new table is added to a logical flow pipeline, the mapping between
> 'external_ids:stage-name' from the 'Logical_Flow' table in the
> 'OVN_Southbound' database and the 'stage' number may change for some
tables.
>
> If 'ovn-northd' is starte
33 matches
Mail list logo
