[ovs-dev] [PATCH ovn] Set release date for 21.06.0.

From: Numan Siddique And also prepare for 21.6.90. This was missed out when v21.06.0 was released. Signed-off-by: Numan Siddique --- NEWS | 6 +- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS

[ovs-dev] [PATCH RFC ovn 0/1] RFC: Logical flow generation in ovn-controller

From: Numan Siddique This is a an RFC patch to move the logical flow generation from ovn-northd to ovn-controller. The same patch can be found here : https://github.com/numansiddique/ovn/tree/lflows_in_controller_internal_rfc_v1 This patch doesn't move all the generation to ovn-controller. ovn

Re: [ovs-dev] [PATCH] datapath-windows: Specify external include paths

Alin, Does it make sense to apply this patch to stable branches too. I see that 2.15 fails with a similar error. Thanks, Guru On Thu, 17 Jun 2021 at 02:31, Alin-Gabriel Serdean wrote: > On Wed, 2021-06-16 at 18:06 +0300, Alin-Gabriel Serdean wrote: > > On Tue, 2021-06-15 at 18:06 +0200, Ilya M

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix port group I-P when they contain non-vif ports.

On Fri, Jun 25, 2021 at 2:53 PM Han Zhou wrote: > > On Fri, Jun 25, 2021 at 4:50 AM Dumitru Ceara wrote: > > > > It's valid that port_groups contain non-vif ports, they can actually > > contain any type of logical_switch_port. > > > > Also, there's no need to allocate a new sset containing the lo

Re: [ovs-dev] [External] : [PATCH ovn v3] ovn-northd.c: Add proxy ARP support to OVN

On Thu, Jun 24, 2021 at 5:14 AM Brendan Doyle wrote: > > Hi, > > Just wondering how to move this along. It's been in the queue a while now. > I've made the requested changes, this is v3 of the patch. > > The product I'm working on requires this feature and If I can't get it > upstream > I'll need

Re: [ovs-dev] [PATCH v9] ofproto-dpif: APIs and CLI option to add/delete static fdb entry

Hi Eelco. Thanks for the review. Will update with your suggestions. I am out of town. Will do this next week. Thanks Vasu > On Jun 25, 2021, at 8:55 AM, Eelco Chaudron wrote: > >  > This one looks good, however, I would make some small changes. > If you do, you can add my acked by to the

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix port group I-P when they contain non-vif ports.

On Fri, Jun 25, 2021 at 4:50 AM Dumitru Ceara wrote: > > It's valid that port_groups contain non-vif ports, they can actually > contain any type of logical_switch_port. > > Also, there's no need to allocate a new sset containing the local ports' > names every time the I-P engine processes a change

Re: [ovs-dev] [PATCH ovn v2 2/2] ovn-macros.at: Enable northd parallelization

On Tue, Jun 22, 2021 at 7:09 PM Fabrizio D'Angelo wrote: > > - Add NORTHD_USE_PARALLELIZATION variable to enable it in ovn_start. > > - Add NORTHD_DUMMY_NUMA variable for passing --dummy-numa flag when > tests are run in a low CPU system. > > Signed-off-by: Fabrizio D'Angelo > Acked-by: Mark Mi

Re: [ovs-dev] Openvswitch patch doubts:conntrack: Fix missed 'conn' lookup checks.

On Fri, Jun 25, 2021 at 11:36:12AM +0800, user wrote: > Hi Darrell, > I'm currently doing some tests on OVS-DPDK and trying to optimize it, > in the process I found your patch(28274f7 conntrack: Fix missed 'conn' lookup > checks.) made OVS check for the presence of the 'conn' entry before i

Re: [ovs-dev] [PATCH V7 00/13] Netdev vxlan-decap offload

> -Original Message- > From: dev On Behalf Of Ilya Maximets > Sent: Friday, June 25, 2021 4:26 PM > To: Sriharsha Basavapatna ; Ilya Maximets > > Cc: Eli Britstein ; ovs dev ; Ivan > Malov > ; Majd Dibbiny > Subject: Re: [ovs-dev] [PATCH V7 00/13] Netdev vxlan-decap offload > >> That

[ovs-dev] [PATCH v2] checkpatch: Ignore macro definitions of FOR_EACH

When defining a FOR_EACH macro, checkpatch freaks out and generates a control block whitespace error. Create an exception so that it doesn't generate errors for this case. Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2020-August/373509.html Reported-by: Toshiaki Makita Signed-off

Re: [ovs-dev] [PATCH v4] ovs-lib: pass optional --election-timer arg to ovsdb-tool

On Fri, Jun 25, 2021 at 11:23:16AM -0500, Dan Williams wrote: > Signed-off-by: Dan Williams Thanks, applied to master. I added this note to the commit message: This doesn't have any current users within the OVS repository. OVN will use it. __

[ovs-dev] [PATCH v4] ovs-lib: pass optional --election-timer arg to ovsdb-tool

Signed-off-by: Dan Williams --- v4: fix quoting of election_timer_arg v3: fix line wrapping v2: put --election-timer arg before create-cluster utilities/ovs-lib.in | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in index ab3

Re: [ovs-dev] [PATCH v3] ovs-lib: pass optional --election-timer arg to ovsdb-tool

On Thu, 2021-06-24 at 14:58 -0700, Ben Pfaff wrote: > On Wed, Jun 09, 2021 at 02:11:42PM -0500, Dan Williams wrote: > > Signed-off-by: Dan Williams > > --- > > v3: fix line wrapping > > v2: put --election-timer arg before create-cluster per Ilya > > > >  utilities/ovs-lib.in | 10 -- > >  

Re: [ovs-dev] is vxlan well supported by ovn ?

On Fri, Jun 25, 2021 at 5:43 AM Krzysztof Klimonda wrote: > > Hi, > > Is this a limitation for a number of logical switches and logical ports that > are part of networks that use vxlan (for example, by utilizing vtep > interfaces) or for a total number of LSs and LSPs in a deployment? It's glob

[ovs-dev] Openvswitch patch doubts:conntrack: Fix missed 'conn' lookup checks.

Hi Darrell, I'm currently doing some tests on OVS-DPDK and trying to optimize it, in the process I found your patch(28274f7 conntrack: Fix missed 'conn' lookup checks.) made OVS check for the presence of the 'conn' entry before inserting it: @@ -1158,8 +1165,11 @@ process_one(struct connt

Re: [ovs-dev] Path MTU discovery on GRE interfaces

On 24/06/2021 05:51, Jesse Gross wrote: > On Wed, Jun 23, 2021 at 10:06 AM Ben Pfaff > wrote: > > [updating Jesse's email address] > > On Wed, Jun 23, 2021 at 04:48:29PM +0200, Matthias May via dev wrote: > > I'm currently fighting with issues where TCP/UDP frame

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix port group I-P when they contain non-vif ports.

On 6/25/21 4:36 PM, Numan Siddique wrote: > On Fri, Jun 25, 2021 at 7:51 AM Dumitru Ceara wrote: >> >> It's valid that port_groups contain non-vif ports, they can actually >> contain any type of logical_switch_port. >> >> Also, there's no need to allocate a new sset containing the local ports' >>

Re: [ovs-dev] [PATCH V7 00/13] Netdev vxlan-decap offload

On 6/24/21 8:18 AM, Sriharsha Basavapatna wrote: > On Thu, Jun 24, 2021 at 12:23 AM Ilya Maximets wrote: >> >> On 6/23/21 5:52 PM, Eli Britstein wrote: >>> VXLAN decap in OVS-DPDK configuration consists of two flows: >>> F1: in_port(ens1f0),eth(),ipv4(),udp(), actions:tnl_pop(vxlan_sys_4789) >>> F

Re: [ovs-dev] [PATCH V7 06/13] dpif-netdev: Add HW miss packet state recover logic.

On 6/25/21 3:56 PM, Eli Britstein wrote: > > On 6/25/2021 3:09 PM, Balazs Nemeth wrote: >> *External email: Use caution opening links or attachments* >> >> >> Ilya, >> >> Sure, I'll rebase my patch and also ensure netdev_is_flow_api_enabled() >> is called once per batch. I don't expect any issue w

Re: [ovs-dev] Path MTU discovery on GRE interfaces

On 23/06/2021 19:06, Ben Pfaff wrote: > [updating Jesse's email address] > > On Wed, Jun 23, 2021 at 04:48:29PM +0200, Matthias May via dev wrote: >> I'm currently fighting with issues where TCP/UDP frames that are larger than >> the MTU of a GRE tunnel are dropped. >> I'm aware of the whys and h

Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif implementation.

On 24 Jun 2021, at 13:53, Ferriter, Cian wrote: > Hi Flavio, > > Thanks for the review. My responses are inline. > > Cian > >>> >>> +static void >>> +dpif_netdev_impl_set(struct unixctl_conn *conn, int argc, >>> + const char *argv[], void *aux OVS_UNUSED) >>> +{ >>> +

[ovs-dev] [RFC] Documentation: minimize travis as our testing infrastructure

Recently, Travis-CI has retired the travis-ci.org service. At the moment, it is read-only. In the future, it may disappear completely. Travis-CI might still be useful for individual developers testing small patches, but can no longer fulfill the role of project-wide continuous integration servic

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix port group I-P when they contain non-vif ports.

On Fri, Jun 25, 2021 at 7:51 AM Dumitru Ceara wrote: > > It's valid that port_groups contain non-vif ports, they can actually > contain any type of logical_switch_port. > > Also, there's no need to allocate a new sset containing the local ports' > names every time the I-P engine processes a change

Re: [ovs-dev] [PATCH v7 1/4] conntrack: handle already natted packets

Dumitru Ceara writes: > On 6/25/21 2:01 PM, Paolo Valerio wrote: >> Dumitru Ceara writes: >> >>> On 6/21/21 12:06 PM, Paolo Valerio wrote: when a packet gets dnatted and then recirculated, it could be possible that it matches another rule that performs another nat action. The ker

Re: [ovs-dev] [PATCH V7 06/13] dpif-netdev: Add HW miss packet state recover logic.

On 6/25/2021 3:09 PM, Balazs Nemeth wrote: *External email: Use caution opening links or attachments* Ilya, Sure, I'll rebase my patch and also ensure netdev_is_flow_api_enabled() is called once per batch. I don't expect any issue with that. Thanks Balazs. Regards, Balazs On Fri, Jun 25

Re: [ovs-dev] [PATCH v2 9/9] docs: Add documentation for ovsdb relay mode.

On 6/12/21 4:00 AM, Ilya Maximets wrote: > Main documentation for the service model and tutorial with the use case > and configuration examples. > > Signed-off-by: Ilya Maximets > --- I left a few minor comments below. With them addressed: Acked-by: Dumitru Ceara Thanks! > Documentation/au

Re: [ovs-dev] [PATCH v2 7/9] ovsdb: relay: Reflect connection status in _Server database.

On 6/12/21 4:00 AM, Ilya Maximets wrote: > It might be important for clients to know that relay lost connection > with the relay remote, so they could re-connect to other relay. > > Signed-off-by: Ilya Maximets > --- [...] > > +#define RELAY_MAX_RECONNECTION_MS 3 30 seconds of relay "inc

Re: [ovs-dev] [PATCH v2 8/9] ovsdb: Make clients aware of relay service model.

On 6/12/21 4:00 AM, Ilya Maximets wrote: > Clients needs to re-connect from the relay that has no connection > with the database source. Also, relay acts similarly to the follower > from a clustered model from the consistency point of view, so it's not > suitable for leader-only connections. > >

Re: [ovs-dev] [PATCH v2 6/9] ovsdb: relay: Add support for transaction forwarding.

On 6/12/21 4:00 AM, Ilya Maximets wrote: > Current version of ovsdb relay allows to scale out read-only > access to the primary database. However, many clients are not > read-only but read-mostly. For example, ovn-controller. > > In order to scale out database access for this case ovsdb-server >

Re: [ovs-dev] [PATCH v2 5/9] ovsdb: New ovsdb 'relay' service model.

On 6/12/21 4:00 AM, Ilya Maximets wrote: > New database service model 'relay' that is needed to scale out > read-mostly database access, e.g. ovn-controller connections to > OVN_Southbound. > > In this service model ovsdb-server connects to existing OVSDB > server and maintains in-memory copy of t

Re: [ovs-dev] [PATCH v2 4/9] ovsdb: row: Add support for xor-based row updates.

On 6/12/21 4:00 AM, Ilya Maximets wrote: > This will be used to apply update3 type updates to ovsdb tables > while processing updates for future ovsdb 'relay' service model. > > 'ovsdb_datum_apply_diff' is allowed to fail, so adding support > to return this error. > > Signed-off-by: Ilya Maximets

Re: [ovs-dev] [PATCH v2 2/9] ovsdb: storage: Allow setting the name for the unbacked storage.

On 6/12/21 4:00 AM, Ilya Maximets wrote: > ovsdb_create() requires schema or storage to be nonnull, but in > practice it requires to have schema name or a storage name to > use it as a database name. Only clustered storage has a name. > This means that only clustered database can be created withou

Re: [ovs-dev] [PATCH v2 3/9] ovsdb: table: Expose functions to execute operations on ovsdb tables.

On 6/12/21 4:00 AM, Ilya Maximets wrote: > These functions will be used later for ovsdb 'relay' service model, so > moving them to a common code. > > Warnings translated to ovsdb errors, caller in replication.c only > printed inconsistency warnings, but mostly ignored them. Implementing > the sam

Re: [ovs-dev] [PATCH v2 1/9] jsonrpc-server: Wake up jsonrpc session if there are completed triggers.

On 6/12/21 4:00 AM, Ilya Maximets wrote: > If there are completed triggers, jsonrpc server should wake up and > update clients with the new data, but there is no such condition > in ovsdb_jsonrpc_session_wait(). For some reason this doesn't result > in any processing delays in current code, probab

Re: [ovs-dev] [PATCH v2 0/9] OVSDB Relay Service Model. (Was: OVSDB 2-Tier deployment)

On 6/12/21 3:59 AM, Ilya Maximets wrote: > Replication can be used to scale out read-only access to the database. > But there are clients that are not read-only, but read-mostly. > One of the main examples is ovn-controller that mostly monitors > updates from the Southbound DB, but needs to claim p

Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function for miniflow extract

Hi Kumar, I plan to review this patch set, but I need to go over the dpif AVX512 set first to get a better understanding. However, I did run some performance tests on old hardware (as I do not have an AVX512 system) and notice some degradation (and improvements). This was a single run for bo

Re: [ovs-dev] [PATCH v9] ofproto-dpif: APIs and CLI option to add/delete static fdb entry

This one looks good, however, I would make some small changes. If you do, you can add my acked by to the new revision. //Eelco On 24 Jun 2021, at 17:57, Vasu Dasari wrote: Currently there is an option to add/flush/show ARP/ND neighbor. This covers L3 side. For L2 side, there is only fdb show

Re: [ovs-dev] [PATCH V7 06/13] dpif-netdev: Add HW miss packet state recover logic.

Ilya, Sure, I'll rebase my patch and also ensure netdev_is_flow_api_enabled() is called once per batch. I don't expect any issue with that. Regards, Balazs On Fri, Jun 25, 2021 at 2:00 PM Ilya Maximets wrote: > On 6/25/21 1:04 PM, Ferriter, Cian wrote: > > Hi Eli, > > > > I have some concerns

Re: [ovs-dev] [PATCH v7 1/4] conntrack: handle already natted packets

On 6/25/21 2:01 PM, Paolo Valerio wrote: > Dumitru Ceara writes: > >> On 6/21/21 12:06 PM, Paolo Valerio wrote: >>> when a packet gets dnatted and then recirculated, it could be possible >>> that it matches another rule that performs another nat action. >>> The kernel datapath handles this situat

Re: [ovs-dev] [PATCH v7 1/4] conntrack: handle already natted packets

Dumitru Ceara writes: > On 6/21/21 12:06 PM, Paolo Valerio wrote: >> when a packet gets dnatted and then recirculated, it could be possible >> that it matches another rule that performs another nat action. >> The kernel datapath handles this situation turning to a no-op the >> second nat action,

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix port group I-P when they contain non-vif ports.

On 6/25/21 1:50 PM, Dumitru Ceara wrote: > It's valid that port_groups contain non-vif ports, they can actually > contain any type of logical_switch_port. > > Also, there's no need to allocate a new sset containing the local ports' > names every time the I-P engine processes a change, we can maint

[ovs-dev] [PATCH ovn] ovn-controller: Fix port group I-P when they contain non-vif ports.

It's valid that port_groups contain non-vif ports, they can actually contain any type of logical_switch_port. Also, there's no need to allocate a new sset containing the local ports' names every time the I-P engine processes a change, we can maintain a sset and incrementally update it when port bi

Re: [ovs-dev] [PATCH V7 06/13] dpif-netdev: Add HW miss packet state recover logic.

On 6/25/21 1:04 PM, Ferriter, Cian wrote: > Hi Eli, > > I have some concerns about how we plug the packet state recover logic into > dfc_processing() here. My concerns are inline below. > > I'm concerned that we are hurting performance in the partial HWOL case, as > this patchset is introducing

Re: [ovs-dev] [PATCH V7 06/13] dpif-netdev: Add HW miss packet state recover logic.

Hi Eli, I have some concerns about how we plug the packet state recover logic into dfc_processing() here. My concerns are inline below. I'm concerned that we are hurting performance in the partial HWOL case, as this patchset is introducing new direct (non-inline) function calls per packet to t

Re: [ovs-dev] [PATCH v7 1/1] ovs-numa: Support non-contiguous numa nodes and offline CPU cores

On 22/06/2021 19:53, David Wilder wrote: > This change removes the assumption that numa nodes and cores are numbered > contiguously in linux. This change is required to support some Power > systems. > > A check has been added to verify that cores are online, > offline cores result in non-contiguo

Re: [ovs-dev] is vxlan well supported by ovn ?

Hi, Is this a limitation for a number of logical switches and logical ports that are part of networks that use vxlan (for example, by utilizing vtep interfaces) or for a total number of LSs and LSPs in a deployment? Best Regards Krzysztof On Thu, Jun 24, 2021, at 18:32, Ihar Hrachyshka wrote:

Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif implementation.

Hi Flavio, Just one correction I noticed while implementing your feedback. I've replied inline. Thanks, Cian > -Original Message- > From: Ferriter, Cian > Sent: Thursday 24 June 2021 12:54 > To: Flavio Leitner > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: RE: [ovs-dev] [

Re: [ovs-dev] [ovn] howto? L3 support in HW VTEP

Hi Numan, did you have a chance to look at db dump? Regards, Vladislav Odintsov > On 18 Jun 2021, at 23:34, Vladislav Odintsov wrote: > > Sorry, there was a typo. > Sure, VM has IP 192.168.1.2/24 and host 192.168.2.2/24. > > [root@ovn-1 ~]# ovn-nbctl show > switch 8e1e2828-67b2-432b-8b2e-088f