[ovs-dev] Openvswitch patch doubts:conntrack: Fix missed 'conn' lookup checks.

Hi Ben, I think this situation may not happen, because if there are two pkts are going to create the same conntrack, their headers will be roughly the same, the rss of the hardware will assign the packets to the same cpu, so there is no chance for two threads to try to insert the same

Re: [ovs-dev] [v4 09/12] dpdk: add additional CPU ISA detection strings

On Thu, Jun 17, 2021 at 09:57:51PM +0530, Kumar Amber wrote: > From: Harry van Haaren > > This commit enables OVS to at runtime check for more detailed > AVX512 capabilities, specifically Byte and Word (BW) extensions, > and Vector Bit Manipulation Instructions (VBMI). > > These instructions

Re: [ovs-dev] [v4 08/12] dpif/stats: add miniflow extract opt hits counter

On Thu, Jun 17, 2021 at 09:57:50PM +0530, Kumar Amber wrote: > From: Harry van Haaren > > This commit adds a new counter to be displayed to the user when > requesting datapath packet statistics. It counts the number of > packets that are parsed and a miniflow built up from it by the > optimized

Re: [ovs-dev] [v4 07/12] test/sytem-dpdk: Add unit test for mfex autovalidator

Hi, On Thu, Jun 17, 2021 at 09:57:49PM +0530, Kumar Amber wrote: > Tests: > 6: OVS-DPDK - MFEX Autovalidator > 7: OVS-DPDK - MFEX Autovalidator Fuzzy > > Added a new directory to store the PCAP file used > in the tests and a script to generate the fuzzy traffic > type pcap to be used in

Re: [ovs-dev] [v4 06/12] dpif-netdev: Add additional packet count parameter for study function

Hi, On Thu, Jun 17, 2021 at 09:57:48PM +0530, Kumar Amber wrote: > This commit introduces additonal command line paramter Typos. > for mfex study function. If user provides additional packet out > it is used in study to compare minimum

Re: [ovs-dev] [v4 05/12] dpif-netdev: Add configure to enable autovalidator at build time.

Hi, I think Ian covered all issues and I suspect this patch might change a bit due to comments on previous patches. fbl On Thu, Jun 17, 2021 at 09:57:47PM +0530, Kumar Amber wrote: > This commit adds a new command to allow the user to enable > autovalidatior by default at build time thus

Re: [ovs-dev] [v4 04/12] docs/dpdk/bridge: add miniflow extract section.

On Thu, Jun 17, 2021 at 09:57:46PM +0530, Kumar Amber wrote: > This commit adds a section to the dpdk/bridge.rst netdev documentation, > detailing the added miniflow functionality. The newly added commands are > documented, and sample output is provided. > > The use of auto-validator and special

Re: [ovs-dev] [v4 03/12] dpif-netdev: Add study function to select the best mfex function

Hi, On Thu, Jun 17, 2021 at 09:57:45PM +0530, Kumar Amber wrote: > The study function runs all the available implementations > of miniflow_extract and makes a choice whose hitmask has > maximum hits and sets the mfex to that function. > > Study can be run at runtime using the following

Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function for miniflow extract

Hi, I haven't tested the patch set yet. I left some comments in line. On Thu, Jun 17, 2021 at 09:57:44PM +0530, Kumar Amber wrote: > This patch introduced the auto-validation function which > allows users to compare the batch of packets obtained from > different miniflow implementations

Re: [ovs-dev] [v4 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

Hi, I am reviewing this patch ignoring the things that were already pointed out in other reviews in the ML. On Thu, Jun 17, 2021 at 09:57:43PM +0530, Kumar Amber wrote: > This patch introduces the mfex function pointers which allows > the user to switch between different miniflow extract

Re: [ovs-dev] [PATCH ovs v1] tunnel: Remove the padding from packet when encapsulating.

On Thu, Apr 1, 2021 at 9:34 PM Tonghao Zhang wrote: > > On Mon, Dec 14, 2020 at 11:11 AM wrote: > > > > From: Tonghao Zhang > > > > The root cause is that the old version of openvswitch doesn't > > remove the padding from packet before L3+ conntrack processing > > and then packets is dropped in

Re: [ovs-dev] [External] : [PATCH ovn v3] ovn-northd.c: Add proxy ARP support to OVN

On 27/06/2021 18:19, Numan Siddique wrote: On Sun, Jun 27, 2021 at 8:46 AM Brendan Doyle wrote: Hi Numan, I did a fresh clone and recreated/resubmitted the patch [PATCH ovn v4] ovn-northd.c: Add proxy ARP support to OVN. v4 still doesn't apply. Maybe you can share your github private

Re: [ovs-dev] [External] : [PATCH ovn v3] ovn-northd.c: Add proxy ARP support to OVN

On Sun, Jun 27, 2021 at 8:46 AM Brendan Doyle wrote: > > Hi Numan, > > I did a fresh clone and recreated/resubmitted the patch [PATCH ovn v4] > ovn-northd.c: Add proxy ARP support to OVN. v4 still doesn't apply. Maybe you can share your github private branch with the patch ? Thanks Numan > >

Re: [ovs-dev] [External] : [PATCH ovn v3] ovn-northd.c: Add proxy ARP support to OVN

Hi Numan, I did a fresh clone and recreated/resubmitted the patch  [PATCH ovn v4] ovn-northd.c: Add proxy ARP support to OVN. I tried to create a PR, but I got an error when trying to create a remote branch from which to generate the PR: git push --set-upstream origin proxy_arp:proxy_arp

[ovs-dev] [PATCH ovn v4] ovn-northd.c: Add proxy ARP support to OVN

From 7a38fff6ce6ee17767b426c7cf84e1b07eda5552 Mon Sep 17 00:00:00 2001 From: Brendan Doyle Date: Sun, 27 Jun 2021 05:36:40 -0700 Subject: [PATCH ovn] ovn-northd.c: Add proxy ARP support to OVN This patch provides the ability to configure proxy ARP IPs on a Logical Switch Router port. The IPs