[ovs-dev] Fwd: Openvswitch patch doubts:conntrack: Fix missed 'conn' lookup checks.

2021-06-28 Thread user
Hi Gaetan, Thanks for your resolve. It is indeed possible for tunneled packets to be allocated to different CPUs by RSS, in which case a check before adding connTrack is necessary. And I didn't made it clear that the two packets belong to the same conntrack. What I mean is that the two pa

Re: [ovs-dev] [PATCH v3] flow: Read recirc depth and flow api enabled once per batch in miniflow_extract

2021-06-28 Thread Eli Britstein
On 6/28/2021 6:19 PM, Balazs Nemeth wrote: External email: Use caution opening links or attachments The call to recirc_depth_get involves accessing a TLS value. So read that once, and store it on the stack for re-use while processing the batch. The same goes for reading netdev_is_flow_api_ena

Re: [ovs-dev] [v4 07/12] test/sytem-dpdk: Add unit test for mfex autovalidator

2021-06-28 Thread Amber, Kumar
Hi Flavio, Thanks again for excellent reviews and my replies are inline. > -Original Message- > From: Flavio Leitner > Sent: Monday, June 28, 2021 8:28 AM > To: Amber, Kumar > Cc: d...@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v4 07/12] test/sytem-dpdk: Add unit test

Re: [ovs-dev] [v4 08/12] dpif/stats: add miniflow extract opt hits counter

2021-06-28 Thread Amber, Kumar
Hi Flavio, Thanks Again, replies inline. > -Original Message- > From: Flavio Leitner > Sent: Monday, June 28, 2021 8:29 AM > To: Amber, Kumar > Cc: d...@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v4 08/12] dpif/stats: add miniflow extract opt hits > counter > > On Th

Re: [ovs-dev] [v4 09/12] dpdk: add additional CPU ISA detection strings

2021-06-28 Thread Amber, Kumar
Thanks Flavio. > -Original Message- > From: Flavio Leitner > Sent: Monday, June 28, 2021 8:29 AM > To: Amber, Kumar > Cc: d...@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v4 09/12] dpdk: add additional CPU ISA detection > strings > > On Thu, Jun 17, 2021 at 09:57:51PM

Re: [ovs-dev] [v4 06/12] dpif-netdev: Add additional packet count parameter for study function

2021-06-28 Thread Amber, Kumar
Hi Flavio, Thanks Again, replies are inline. > -Original Message- > From: Flavio Leitner > Sent: Monday, June 28, 2021 8:26 AM > To: Amber, Kumar > Cc: d...@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v4 06/12] dpif-netdev: Add additional packet count > parameter for s

Re: [ovs-dev] [v4 05/12] dpif-netdev: Add configure to enable autovalidator at build time.

2021-06-28 Thread Amber, Kumar
Hi Flavio, All the refactored changes are now in v5 done accordingly to previous patches changes. > -Original Message- > From: Flavio Leitner > Sent: Monday, June 28, 2021 8:24 AM > To: Amber, Kumar > Cc: d...@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v4 05/12] dpif

Re: [ovs-dev] [v4 04/12] docs/dpdk/bridge: add miniflow extract section.

2021-06-28 Thread Amber, Kumar
Hi Flavio , Thanks Again replies inline. > -Original Message- > From: Flavio Leitner > Sent: Monday, June 28, 2021 8:23 AM > To: Amber, Kumar > Cc: d...@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v4 04/12] docs/dpdk/bridge: add miniflow extract > section. > > On Thu,

Re: [ovs-dev] [v4 03/12] dpif-netdev: Add study function to select the best mfex function

2021-06-28 Thread Amber, Kumar
Hi Flavio, Thanks again and my replies are inline. > -Original Message- > From: Flavio Leitner > Sent: Monday, June 28, 2021 8:22 AM > To: Amber, Kumar > Cc: d...@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v4 03/12] dpif-netdev: Add study function to select > the best

Re: [ovs-dev] [ovn] howto? L3 support in HW VTEP

2021-06-28 Thread Numan Siddique
On Fri, Jun 25, 2021 at 4:13 AM Vladislav Odintsov wrote: > > Hi Numan, > > did you have a chance to look at db dump? Sorry. I didn't get a chance. Will this patch help your use case ? - https://patchwork.ozlabs.org/project/ovn/patch/9d24b588-9527-f7bc-7e39-b9f9d3195...@oracle.com/ Thanks Num

Re: [ovs-dev] [PATCH ovn] ovn-northd-ddlog: Fix build errror due to wrong ovs-numa.h path.

2021-06-28 Thread Numan Siddique
On Mon, Jun 28, 2021 at 11:25 AM Dumitru Ceara wrote: > > Fixes: 37ad427cfb78 ("northd: Port dummy-numa cli option from OVS") > Signed-off-by: Dumitru Ceara Oops. Thanks for fixing it. I applied. Thanks Numan > --- > northd/ovn-northd-ddlog.c | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [ovs-dev] [PATCH] Testing: Introduce "bring your own lab" as an additional test option

2021-06-28 Thread 0-day Robot
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #162 FILE: Documentation/topics/t

Re: [ovs-dev] [RFC] Documentation: minimize travis as our testing infrastructure

2021-06-28 Thread Aaron Conole
Aaron Conole writes: > Recently, Travis-CI has retired the travis-ci.org service. At the > moment, it is read-only. In the future, it may disappear completely. > > Travis-CI might still be useful for individual developers testing small > patches, but can no longer fulfill the role of project-wi

[ovs-dev] [PATCH] Testing: Introduce "bring your own lab" as an additional test option

2021-06-28 Thread Aaron Conole
Two big changes are announced here, and the first pertains to allowing other developers and labs to report patch status in the ozlabs patchwork UI to assist maintainers making decisions on patch inclusion. To make this as easy as possible, the robot will take a known form of email sent to the ovs-

Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif implementation.

2021-06-28 Thread Ferriter, Cian
Hi Eelco, Thanks for the comments. My responses are inline. Cian > -Original Message- > From: Eelco Chaudron > Sent: Monday 28 June 2021 15:35 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org; Flavio Leitner > ; Van Haaren, Harry > > Subject: Re: [ovs-dev] [v13

Re: [ovs-dev] ovn-northd-ddlog scale issues

2021-06-28 Thread Dumitru Ceara
On 5/20/21 5:50 PM, Ben Pfaff wrote: > On Thu, May 20, 2021 at 05:06:26PM +0200, Dumitru Ceara wrote: >> On 4/7/21 6:49 PM, Ben Pfaff wrote: >> >> [...] >> Thanks! I can download them now. It's back on my to-do list. >>> >>> I can reproduce the problem now. I haven't fixed it yet, but

[ovs-dev] [PATCH ovn] ovn-northd-ddlog: Fix build errror due to wrong ovs-numa.h path.

2021-06-28 Thread Dumitru Ceara
Fixes: 37ad427cfb78 ("northd: Port dummy-numa cli option from OVS") Signed-off-by: Dumitru Ceara --- northd/ovn-northd-ddlog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/northd/ovn-northd-ddlog.c b/northd/ovn-northd-ddlog.c index d81414ce7..bc2c75f51 100644 --- a/northd/o

[ovs-dev] [PATCH v3] flow: Read recirc depth and flow api enabled once per batch in miniflow_extract

2021-06-28 Thread Balazs Nemeth
The call to recirc_depth_get involves accessing a TLS value. So read that once, and store it on the stack for re-use while processing the batch. The same goes for reading netdev_is_flow_api_enabled(), a non-inlined function. Signed-off-by: Balazs Nemeth Acked-by: Gaetan Rivet Acked-by: Paolo Val

Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function for miniflow extract

2021-06-28 Thread Amber, Kumar
Hi Flavio, Thanks Again replies are inlined. > > /* Implementations of available extract options. */ static struct > > dpif_miniflow_extract_impl mfex_impls[] = { > > + { > > +.probe = NULL, > > +.extract_func = dpif_miniflow_extract_autovalidator, > > +.name = "autova

Re: [ovs-dev] [v4 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

2021-06-28 Thread Amber, Kumar
Hi Flavio, Thanks a lot for the review my replies are inline. > > +uint32_t mfex_hit = (mf_mask & (1 << i)); > > This is actually a bool. > Fixed in upcoming v5. > > > > /* Check for partial hardware offload mark. */ > > uint32_t mark; > > I find 'ovs-appctl dpif-n

Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif implementation.

2021-06-28 Thread Eelco Chaudron
On 17 Jun 2021, at 18:18, Cian Ferriter wrote: > From: Harry van Haaren > > This commit adds a new command to allow the user to switch > the active DPIF implementation at runtime. A probe function > is executed before switching the DPIF implementation, to ensure > the CPU is capable of running

Re: [ovs-dev] [PATCH V7 00/13] Netdev vxlan-decap offload

2021-06-28 Thread Ilya Maximets
On 6/25/21 7:28 PM, Van Haaren, Harry wrote: >> -Original Message- >> From: dev On Behalf Of Ilya Maximets >> Sent: Friday, June 25, 2021 4:26 PM >> To: Sriharsha Basavapatna ; Ilya Maximets >> >> Cc: Eli Britstein ; ovs dev ; Ivan >> Malov >> ; Majd Dibbiny >> Subject: Re: [ovs-dev] [P

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Using output netdev's ip as tunnel arp/nd request ip

2021-06-28 Thread 0-day Robot
Bleep bloop. Greetings mit...@outlook.com, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author mit...@outlook.com needs to sign off. WARNING: Unexpected sign-offs from d

[ovs-dev] [PATCH] ofproto-dpif-xlate: Using output netdev's ip as tunnel arp/nd request ip

2021-06-28 Thread mit...@outlook.com
If VXLAN tunnel's source ip and the output_bridge netdev's ip are not on the same subnet, tnl_send_arp_request() will use tunnel's source ip as arp/nd sender not the output netdev's ip. This lead to address resolution (i.e., IPv4 ARP and IPv6 ND) scaling issues. OVS unable to get gateway address in

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Using output netdev's ip as tunnel arp/nd request ip

2021-06-28 Thread 0-day Robot
Bleep bloop. Greetings mit...@outlook.com, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: patch fragment without header at line 11: @@ -3656,10 +3665,22 @@ native_tunnel_outpu

[ovs-dev] [PATCH] ofproto-dpif-xlate: Using output netdev's ip as tunnel arp/nd request ip

2021-06-28 Thread mit...@outlook.com
If VXLAN tunnel's source ip and the output_bridge netdev's ip are not on the same subnet, tnl_send_arp_request() will use tunnel's source ip as arp/nd sender not the output netdev's ip. This lead to address resolution (i.e., IPv4 ARP and IPv6 ND) scaling issues. OVS unable to get gateway address in

Re: [ovs-dev] [External] : [PATCH ovn v3] ovn-northd.c: Add proxy ARP support to OVN

2021-06-28 Thread Brendan Doyle
Hi Numan, So just did a v5 this time using git mail, please see if you can apply that one. Thanks On 27/06/2021 18:19, Numan Siddique wrote: On Sun, Jun 27, 2021 at 8:46 AM Brendan Doyle wrote: Hi Numan, I did a fresh clone and recreated/resubmitted the patch [PATCH ovn v4] ovn-northd.c: