[ovs-dev] [PATCH v2 ovn 0/2] incrementally process ras-ipv6 pd router ports

2021-07-10 Thread Lorenzo Bianconi
https://bugzilla.redhat.com/show_bug.cgi?id=1944220 Changes since v1: - use shash instead of hamp - always remove the entry from shash if the user removed the ipv6_pd/ras info in port_binding option column Lorenzo Bianconi (2): controller: incrementally create ipv6 prefix delegation port_bind

[ovs-dev] [PATCH v2 ovn 1/2] controller: incrementally create ipv6 prefix delegation port_binding list

2021-07-10 Thread Lorenzo Bianconi
Incrementally manage local_active_ports_ipv6_pd map for interfaces where IPv6 prefix-delegation has been enabled. This patch allows to avoid looping over all local interfaces to check if prefix-delegation is running on the current port binding. Signed-off-by: Lorenzo Bianconi --- controller/bind

[ovs-dev] [PATCH v2 ovn 2/2] controller: incrementally create ras port_binding list

2021-07-10 Thread Lorenzo Bianconi
Incrementally manage local_active_ports_ras map for interfaces where periodic router advertisement has been enabled. This patch allows to avoid looping over all local interfaces to check if periodic RA is running on the current port binding. Signed-off-by: Lorenzo Bianconi --- controller/binding

Re: [ovs-dev] [PATCH v2] netdev-linux: Ignore TSO packets when TSO is not enabled for userspace

2021-07-10 Thread Flavio Leitner
On Fri, Jul 09, 2021 at 10:08:39PM +0200, Ilya Maximets wrote: > On 7/8/21 2:16 PM, Flavio Leitner wrote: > > On Mon, Jul 05, 2021 at 07:57:41AM -0400, Eelco Chaudron wrote: > >> When TSO is disabled from a userspace forwarding datapath perspective, > >> but TSO has been wrongly enabled on the kern

Re: [ovs-dev] [PATCH v6 ovn 0/4] respin CoPP series

2021-07-10 Thread Lorenzo Bianconi
> On Fri, Jul 09, 2021 at 11:11:48AM +0200, Lorenzo Bianconi wrote: > > On Jul 08, Ben Pfaff wrote: > > > On Thu, Jul 08, 2021 at 06:40:01PM +0200, Lorenzo Bianconi wrote: > > > > This series respin CoPP support introduced here [0] by Dumitru rebasing > > > > on top > > > > of ovn master branch an

Re: [ovs-dev] [PATCH v3 7/8] conntrack: Inverse conn and ct lock precedence

2021-07-10 Thread wenxu
Hi Gaetan, First, Thanks for your patch. This is very useful for us. But maybe there are some question need to be checked. > > ovs_mutex_unlock(&ct->ct_lock); >@@ -1034,7 +1057,6 @@ conn_not_found(struct conntrack *ct, struct dp_packet >*pkt, >const struct nat_action_info

Re: [ovs-dev] [v8 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-10 Thread Flavio Leitner
Hi On Fri, Jul 09, 2021 at 05:35:51PM +0530, kumar Amber wrote: > From: Kumar Amber > > This patch introduces the mfex function pointers which allows Let's use capital MFEX. > the user to switch between different miniflow extract implementations > which are provided by the OVS based on opti

Re: [ovs-dev] [v8 02/12] dpif-netdev: Add auto validation function for miniflow extract

2021-07-10 Thread Flavio Leitner
On Fri, Jul 09, 2021 at 05:35:52PM +0530, kumar Amber wrote: > From: Kumar Amber > > This patch introduced the auto-validation function which > allows users to compare the batch of packets obtained from > different miniflow implementations against the linear > miniflow extract and return a hitmas

Re: [ovs-dev] [v8 03/12] dpif-netdev: Add study function to select the best mfex function

2021-07-10 Thread Flavio Leitner
Hi, On Fri, Jul 09, 2021 at 05:35:53PM +0530, kumar Amber wrote: > From: Kumar Amber > > The study function runs all the available implementations > of miniflow_extract and makes a choice whose hitmask has > maximum hits and sets the mfex to that function. > > Study can be run at runtime usin

Re: [ovs-dev] [v8 04/12] docs/dpdk/bridge: add miniflow extract section.

2021-07-10 Thread Flavio Leitner
On Fri, Jul 09, 2021 at 05:35:54PM +0530, kumar Amber wrote: > From: Kumar Amber > > This commit adds a section to the dpdk/bridge.rst netdev documentation, > detailing the added miniflow functionality. The newly added commands are > documented, and sample output is provided. > > The use of auto

Re: [ovs-dev] [v8 05/12] dpif-netdev: Add configure to enable autovalidator at build time.

2021-07-10 Thread Flavio Leitner
On Fri, Jul 09, 2021 at 05:35:55PM +0530, kumar Amber wrote: > From: Kumar Amber > > This commit adds a new command to allow the user to enable > autovalidatior by default at build time thus allowing for > runnig unit test by default. > > $ ./configure --enable-mfex-default-autovalidator > > S

Re: [ovs-dev] [v8 06/12] dpif-netdev: Add packet count and core id paramters for study

2021-07-10 Thread Flavio Leitner
Hi, On Fri, Jul 09, 2021 at 05:35:56PM +0530, kumar Amber wrote: > From: Kumar Amber > > This commit introduces additional command line paramter Parameter. > for mfex study function. If user provides additional packet out > it is used in study to compare minimum packets which must be process

Re: [ovs-dev] [v8 07/12] test/sytem-dpdk: Add unit test for mfex autovalidator

2021-07-10 Thread Flavio Leitner
On Fri, Jul 09, 2021 at 05:35:57PM +0530, kumar Amber wrote: > From: Kumar Amber > > Tests: > 6: OVS-DPDK - MFEX Autovalidator > 7: OVS-DPDK - MFEX Autovalidator Fuzzy > > Added a new directory to store the PCAP file used > in the tests and a script to generate the fuzzy traffic > type pcap

Re: [ovs-dev] [v8 08/12] dpif/stats: add miniflow extract opt hits counter

2021-07-10 Thread Flavio Leitner
On Fri, Jul 09, 2021 at 05:35:58PM +0530, kumar Amber wrote: > From: Harry van Haaren > > This commit adds a new counter to be displayed to the user when > requesting datapath packet statistics. It counts the number of > packets that are parsed and a miniflow built up from it by the > optimized m

Re: [ovs-dev] [v8 10/12] dpif-netdev/mfex: Add AVX512 based optimized miniflow extract

2021-07-10 Thread Flavio Leitner
Hi, On Fri, Jul 09, 2021 at 05:36:00PM +0530, kumar Amber wrote: > From: Harry van Haaren > > This commit adds AVX512 implementations of miniflow extract. > By using the 64 bytes available in an AVX512 register, it is > possible to convert a packet to a miniflow data-structure in > a small qu

Re: [ovs-dev] [v8 11/12] dpif-netdev/mfex: add more AVX512 traffic profiles

2021-07-10 Thread Flavio Leitner
On Fri, Jul 09, 2021 at 05:36:01PM +0530, kumar Amber wrote: > From: Harry van Haaren > > This commit adds 3 new traffic profile implementations to the > existing avx512 miniflow extract infrastructure. The profiles added are: > - Ether()/IP()/TCP() > - Ether()/Dot1Q()/IP()/UDP() > - Ether()/Dot1

Re: [ovs-dev] [v8 12/12] dpif-netdev: add mfex options to scalar dpif

2021-07-10 Thread Flavio Leitner
On Fri, Jul 09, 2021 at 05:36:02PM +0530, kumar Amber wrote: > This commits add the mfex optimized options to be > executed as part of scalar DPIF. > > Signed-off-by: kumar Amber > --- Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.or

[ovs-dev] [PATCH 2/2] netdev-offload-dpdk: Fix vxlan vni cast-align warnings

2021-07-10 Thread Eli Britstein
Compiling with -Werror and -Wcast-align has errors like: lib/netdev-offload-dpdk.c: In function 'dump_flow_pattern': lib/netdev-offload-dpdk.c:385:38: error: cast increases required alignment of target type [-Werror=cast-align] 385 |ntohl(*(ovs_be32 *) vxlan_spec->vni) >> 8, |

[ovs-dev] [PATCH 1/2] netdev-offload-dpdk: Fix IPv6 rewrite cast-align warning

2021-07-10 Thread Eli Britstein
Compile with -Werror and -Wcast-align: lib/netdev-offload-dpdk.c:578:30: error: cast increases required alignment of target type [-Werror=cast-align] 578 |ipv6_format_addr((struct in6_addr *) &set_ipv6->ipv6_addr, s); | ^ Fix it. Fixes: b6207b1d2711 ("netdev-o