On Wed, Jun 30, 2021 at 2:53 AM Mark Gray wrote:
>
> The Open vSwitch kernel module uses the upcall mechanism to send
> packets from kernel space to user space when it misses in the kernel
> space flow table. The upcall sends packets via a Netlink socket.
> Currently, a Netlink socket is created
Bleep bloop. Greetings Chris Mi, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#56 FILE:
Implement dpif-offload API for netlink datapath.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
lib/automake.mk | 1 +
lib/dpif-netlink.c | 2 +-
lib/dpif-offload-netlink.c | 210
lib/dpif-offload-provider.h | 12 +++
4
Create a unique group ID to map the sFlow info when offloading sFlow
action to TC. When showing the offloaded datapath flows, translate the
group ID from TC sample action to sFlow info using the mapping.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
NEWS| 1 +
Some offload actions require functionality that is not netdev
based, but dpif. For example, sFlow action requires to create
a psample netlink socket to receive the sampled packets from
TC or kernel driver.
Create dpif-offload-provider layer to support such actions.
Signed-off-by: Chris Mi
Process sFlow offload packet in handler thread if handler id is 0.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
ofproto/ofproto-dpif-upcall.c | 57 +++
1 file changed, 57 insertions(+)
diff --git a/ofproto/ofproto-dpif-upcall.c
When offloading sample action to TC, userspace creates a unique ID
to map sFlow action and tunnel info and passes this ID to kernel instead
of the sFlow info. psample will send this ID and sampled packet to
userspace. Using the ID, userspace can recover the sFlow info and send
sampled packet to
Update kernel UAPI to support psample and the tc sample action.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
include/linux/automake.mk| 4 ++-
include/linux/psample.h | 62
include/linux/tc_act/tc_sample.h |
This patch set adds offload support for sFlow.
Psample is a genetlink channel for packet sampling. TC action act_sample
uses psample to send sampled packets to userspace.
When offloading sample action to TC, userspace creates a unique ID to
map sFlow action and tunnel info and passes this ID to
Load kernel module psample to receive sampled packets from TC.
Before removing kernel module psample, remove act_sample first.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
utilities/ovs-kmod-ctl.in | 14 ++
1 file changed, 14 insertions(+)
diff
Hi Eelco,
Yeah I missed one Comments below but all have been fixed waiting for more
reviews on this patch before sending new one.
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, July 14, 2021 8:43 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org;
Bleep bloop. Greetings Ihar Hrachyshka, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
Hi Eelco,
From: Eelco Chaudron
Sent: Wednesday, July 14, 2021 8:26 PM
To: Amber, Kumar
Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van Haaren,
Harry ; Ferriter, Cian ;
Stokes, Ian
Subject: Re: [v12 07/11] test/sytem-dpdk: Add unit test for mfex autovalidator
On
On Wed, Jul 14, 2021 at 8:07 PM Numan Siddique wrote:
>
> On Wed, Jul 14, 2021 at 4:59 PM Ihar Hrachyshka wrote:
> >
> > Recently, we stopped leaking localport traffic through localnet ports
> > into fabric to avoid unnecessary flipping between chassis hosting the
> > same localport.
> >
> >
Recently, we stopped leaking localport traffic through localnet ports
into fabric to avoid unnecessary flipping between chassis hosting the
same localport.
Despite the type name, in some scenarios localports are supposed to
talk outside the hosting chassis. Specifically, in OpenStack [1]
metadata
On Wed, Jul 14, 2021 at 8:07 PM Numan Siddique wrote:
>
> On Wed, Jul 14, 2021 at 4:59 PM Ihar Hrachyshka wrote:
> >
> > Recently, we stopped leaking localport traffic through localnet ports
> > into fabric to avoid unnecessary flipping between chassis hosting the
> > same localport.
> >
> >
On Wed, Jul 14, 2021 at 7:47 PM Ben Pfaff wrote:
>
> On Wed, Jul 14, 2021 at 06:23:15PM -0400, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > Fixes: 895e02ec0be6("ovn-sbctl.c Add logical flows count numbers")
> > Signed-off-by: Numan Siddique
>
> Acked-by: Ben Pfaff
Thanks for the
On Wed, Jul 14, 2021 at 4:59 PM Ihar Hrachyshka wrote:
>
> Recently, we stopped leaking localport traffic through localnet ports
> into fabric to avoid unnecessary flipping between chassis hosting the
> same localport.
>
> Despite the type name, in some scenarios localports are supposed to
> talk
On Wed, Jul 14, 2021 at 4:59 PM Ihar Hrachyshka wrote:
>
> On Wed, Jul 14, 2021 at 11:21 AM Numan Siddique wrote:
> >
> > On Tue, Jul 13, 2021 at 8:40 PM Ihar Hrachyshka wrote:
> > >
> > > Recently, we stopped leaking localport traffic through localnet ports
> > > into fabric to avoid
On Wed, Jul 14, 2021 at 06:23:15PM -0400, num...@ovn.org wrote:
> From: Numan Siddique
>
> Fixes: 895e02ec0be6("ovn-sbctl.c Add logical flows count numbers")
> Signed-off-by: Numan Siddique
Acked-by: Ben Pfaff
___
dev mailing list
On Wed, Jul 14, 2021 at 09:12:10PM +0100, Anton Ivanov wrote:
> On 14/07/2021 19:33, Ben Pfaff wrote:
> > On Wed, Jul 14, 2021 at 05:36:36PM +0100, anton.iva...@cambridgegreys.com
> > wrote:
> > > From: Anton Ivanov
> > >
> > > There is no point to add 512 bytes on the stack
> > > every time
Hi,
I have reviewed more patches, but there are some that Eelco
requested to follow up with fixes, so I am going to wait as well.
Thanks,
fbl
On Wed, Jul 14, 2021 at 07:44:33PM +0530, kumar Amber wrote:
> v12:
> - re-work the set command to sweep method
> - changes skip for unit-test to true
From: Numan Siddique
Fixes: 895e02ec0be6("ovn-sbctl.c Add logical flows count numbers")
Signed-off-by: Numan Siddique
---
utilities/ovn-sbctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovn-sbctl.c b/utilities/ovn-sbctl.c
index 1ab148a67b..4d7e7d6702 100644
On Wed, Jul 7, 2021 at 3:15 AM Fabrizio D'Angelo wrote:
>
> Uses northd database to specify number of threads that should be used
> when lflow parallel computation is enabled.
>
> Example:
> ovn-nbctl set NB_Global . options:num_parallel_threads=16
>
> Reported at:
>
On Wed, Jul 14, 2021 at 8:23 AM Mark Michelson wrote:
>
> Looks good to me Alexey, thanks!
>
> Acked-by: Mark Michelson
Thanks Alexey and Mark for the reviews.
I applied this patch to the main branch.
Numan
>
> On 6/19/21 3:38 PM, Alexey Roytman wrote:
> > From: Alexey Roytman
> >
> > For
On Wed, Jul 14, 2021 at 11:21 AM Numan Siddique wrote:
>
> On Tue, Jul 13, 2021 at 8:40 PM Ihar Hrachyshka wrote:
> >
> > Recently, we stopped leaking localport traffic through localnet ports
> > into fabric to avoid unnecessary flipping between chassis hosting the
> > same localport.
> >
> >
Recently, we stopped leaking localport traffic through localnet ports
into fabric to avoid unnecessary flipping between chassis hosting the
same localport.
Despite the type name, in some scenarios localports are supposed to
talk outside the hosting chassis. Specifically, in OpenStack [1]
metadata
On Wed, Jul 14, 2021 at 07:44:38PM +0530, kumar Amber wrote:
> From: Kumar Amber
>
> This commit adds a new command to allow the user to enable
> autovalidatior by default at build time thus allowing for
> runnig unit test by default.
>
> $ ./configure --enable-mfex-default-autovalidator
>
>
On Wed, Jul 14, 2021 at 07:44:36PM +0530, kumar Amber wrote:
> From: Kumar Amber
>
> The study function runs all the available implementations
> of miniflow_extract and makes a choice whose hitmask has
> maximum hits and sets the mfex to that function.
>
> Study can be run at runtime using the
On Wed, Jul 14, 2021 at 11:21 AM Numan Siddique wrote:
>
> On Tue, Jul 13, 2021 at 8:40 PM Ihar Hrachyshka wrote:
> >
> > Recently, we stopped leaking localport traffic through localnet ports
> > into fabric to avoid unnecessary flipping between chassis hosting the
> > same localport.
> >
> >
On 14/07/2021 19:33, Ben Pfaff wrote:
On Wed, Jul 14, 2021 at 05:36:36PM +0100, anton.iva...@cambridgegreys.com wrote:
From: Anton Ivanov
There is no point to add 512 bytes on the stack
every time latch is polled. Alignment, cache line thrashing,
etc - you name it.
Do you have evidence this
On Wed, Jul 14, 2021 at 07:44:35PM +0530, kumar Amber wrote:
> From: Kumar Amber
>
> This patch introduced the auto-validation function which
> allows users to compare the batch of packets obtained from
> different miniflow implementations against the linear
> miniflow extract and return a
On Wed, Jul 14, 2021 at 07:44:34PM +0530, kumar Amber wrote:
> From: Kumar Amber
>
> This patch introduces the MFEX function pointers which allows
> the user to switch between different miniflow extract implementations
> which are provided by the OVS based on optimized ISA CPU.
>
> The user can
On Wed, Jul 14, 2021 at 05:36:36PM +0100, anton.iva...@cambridgegreys.com wrote:
> From: Anton Ivanov
>
> There is no point to add 512 bytes on the stack
> every time latch is polled. Alignment, cache line thrashing,
> etc - you name it.
Do you have evidence this is a real problem?
> The
On 7/14/21 3:50 PM, Ilya Maximets wrote:
> Replication can be used to scale out read-only access to the database.
> But there are clients that are not read-only, but read-mostly.
> One of the main examples is ovn-controller that mostly monitors
> updates from the Southbound DB, but needs to claim
Add some tests to ensure that if there are numa local
PMDs they are used for polling an rxq.
Also check that if there are only numa non-local PMDs they
will be used ito poll the rxq and but the user will be warned.
Signed-off-by: Kevin Traynor
Acked-by: Sunil Pai G
Acked-by: David Marchand
Pinning an rxq to a PMD with pmd-rxq-affinity may be done for
various reasons such as reserving a full PMD for an rxq, or to
ensure that multiple rxqs from a port are handled on different PMDs.
Previously pmd-rxq-affinity always isolated the PMD so no other rxqs
could be assigned to it by OVS.
This reworks the current rxq scheduling code to break it into more
generic and reusable pieces.
The behaviour does not change from a user perspective, except the logs
are updated to be more consistent.
>From an implementation view, there are some changes with mind to
extending functionality.
Add an rxq scheduling option that allows rxqs to be grouped
on a pmd based purely on their load.
The current default 'cycles' assignment sorts rxqs by measured
processing load and then assigns them to a list of round robin PMDs.
This helps to keep the rxqs that require most processing on
Previously, if pmd-rxq-affinity was used to pin an rxq to
a core that was not in pmd-cpu-mask the rxq was not polled
for and the user received a warning. This meant that no traffic
would be received from that rxq.
Now that pinned and non-pinned rxqs are assigned to PMDs in
a common call to rxq
The list of PMDs is round robined through for the selection
when assigning an rxq to a PMD. The list is based on a
hash map, so there is no defined order.
It means the same set of PMDs may get assigned different rxqs
on different runs for no reason other than how the PMDs are stored
in the hash
PMD auto load balance had its own separate implementation of the
rxq scheduling that it used for dry runs. This was done because
previously the rxq scheduling was not made reusable for a dry run.
Apart from the code duplication (which is a good enough reason
to replace it alone) this meant that
The first two patches do not provide new functionality for the user
(except the logs are reworked). They are reworking to make the
rxq scheduling and PMD auto load balance code more modular for cleanup
and to be used by subsequent patches. They are also removing the code
duplication between them
From: Anton Ivanov
There is no point to add 512 bytes on the stack
every time latch is polled. Alignment, cache line thrashing,
etc - you name it.
The result of the read is discarded anyway so the buffer
can be shared by all latches.
Signed-off-by: Anton Ivanov
---
lib/latch-unix.c | 7
On 14/07/2021 10:05, Jan Scheurich wrote:
>>> In our patch series we decided to skip the check on cross-numa polling
>>> during
>> auto-load balancing. The rationale is as follows:
>>>
>>> If the estimated PMD-rxq distribution includes cross-NUMA rxq assignments,
>> the same must apply for the
On Tue, Jul 13, 2021 at 8:40 PM Ihar Hrachyshka wrote:
>
> Recently, we stopped leaking localport traffic through localnet ports
> into fabric to avoid unnecessary flipping between chassis hosting the
> same localport.
>
> Despite the type name, in some scenarios localports are supposed to
> talk
On 7/14/2021 5:58 PM, Ferriter, Cian wrote:
External email: Use caution opening links or attachments
-Original Message-
From: Ilya Maximets
Sent: Friday 9 July 2021 21:53
To: Ferriter, Cian ; Gaëtan Rivet ;
Eli Britstein
; d...@openvswitch.org; Van Haaren, Harry
Cc: Majd Dibbiny
On 14 Jul 2021, at 16:14, kumar Amber wrote:
> From: Kumar Amber
>
> This commit introduces additional command line paramter
> for mfex study function. If user provides additional packet out
> it is used in study to compare minimum packets which must be processed
> else a default value is
Bleep bloop. Greetings Eelco Chaudron, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error,
On 14 Jul 2021, at 16:14, kumar Amber wrote:
> From: Harry van Haaren
>
> This commit adds AVX512 implementations of miniflow extract.
> By using the 64 bytes available in an AVX512 register, it is
> possible to convert a packet to a miniflow data-structure in
> a small quantity instructions.
> -Original Message-
> From: Ilya Maximets
> Sent: Friday 9 July 2021 21:53
> To: Ferriter, Cian ; Gaëtan Rivet ;
> Eli Britstein
> ; d...@openvswitch.org; Van Haaren, Harry
>
> Cc: Majd Dibbiny ; Ilya Maximets ;
> Stokes, Ian
> ; Flavio Leitner
> Subject: Re: [ovs-dev] [PATCH 2/2]
On 14 Jul 2021, at 16:14, kumar Amber wrote:
From: Kumar Amber
Tests:
6: OVS-DPDK - MFEX Autovalidator
7: OVS-DPDK - MFEX Autovalidator Fuzzy
Added a new directory to store the PCAP file used
in the tests and a script to generate the fuzzy traffic
type pcap to be used in fuzzy unit
On 9 Jul 2021, at 16:07, Ilya Maximets wrote:
> On 7/9/21 10:29 AM, Eelco Chaudron wrote:
>>
>>
>> On 8 Jul 2021, at 21:23, Ilya Maximets wrote:
>>
>>> On 6/10/21 11:24 AM, Eelco Chaudron wrote:
Currently, conntrack in the kernel has an undocumented feature referred
to as all-zero IP
Currently, conntrack in the kernel has an undocumented feature referred
to as all-zero IP address SNAT. Basically, when a source port
collision is detected during the commit, the source port will be
translated to an ephemeral port. If there is no collision, no SNAT is
performed.
This patchset
Hi Eelco,
The requested changes for the rework of MFEX-set commands are now available in
v12
Br Amber
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, July 14, 2021 4:04 PM
> To: Van Haaren, Harry
> Cc: Amber, Kumar ; ovs-dev@openvswitch.org;
> f...@sysclose.org;
From: Harry van Haaren
This commit adds 3 new traffic profile implementations to the
existing avx512 miniflow extract infrastructure. The profiles added are:
- Ether()/IP()/TCP()
- Ether()/Dot1Q()/IP()/UDP()
- Ether()/Dot1Q()/IP()/TCP()
The design of the avx512 code here is for scalability to
From: Harry van Haaren
This commit enables OVS to at runtime check for more detailed
AVX512 capabilities, specifically Byte and Word (BW) extensions,
and Vector Bit Manipulation Instructions (VBMI).
These instructions will be used in the CPU ISA optimized
implementations of traffic profile
From: Harry van Haaren
This commit adds AVX512 implementations of miniflow extract.
By using the 64 bytes available in an AVX512 register, it is
possible to convert a packet to a miniflow data-structure in
a small quantity instructions.
The implementation here probes for Ether()/IP()/UDP()
From: Harry van Haaren
This commit adds a new counter to be displayed to the user when
requesting datapath packet statistics. It counts the number of
packets that are parsed and a miniflow built up from it by the
optimized miniflow extract parsers.
The ovs-appctl command
From: Kumar Amber
Tests:
6: OVS-DPDK - MFEX Autovalidator
7: OVS-DPDK - MFEX Autovalidator Fuzzy
Added a new directory to store the PCAP file used
in the tests and a script to generate the fuzzy traffic
type pcap to be used in fuzzy unit test.
Signed-off-by: Kumar Amber
Acked-by: Flavio
From: Kumar Amber
This commit introduces additional command line paramter
for mfex study function. If user provides additional packet out
it is used in study to compare minimum packets which must be processed
else a default value is choosen.
Also introduces a third paramter for choosing a
From: Kumar Amber
This commit adds a new command to allow the user to enable
autovalidatior by default at build time thus allowing for
runnig unit test by default.
$ ./configure --enable-mfex-default-autovalidator
Signed-off-by: Kumar Amber
Co-authored-by: Harry van Haaren
Signed-off-by:
From: Kumar Amber
This commit adds a section to the dpdk/bridge.rst netdev documentation,
detailing the added miniflow functionality. The newly added commands are
documented, and sample output is provided.
The use of auto-validator and special study function is also described
in detail as well
From: Kumar Amber
The study function runs all the available implementations
of miniflow_extract and makes a choice whose hitmask has
maximum hits and sets the mfex to that function.
Study can be run at runtime using the following command:
$ ovs-appctl dpif-netdev/miniflow-parser-set study
From: Kumar Amber
This patch introduces the MFEX function pointers which allows
the user to switch between different miniflow extract implementations
which are provided by the OVS based on optimized ISA CPU.
The user can query for the available minflow extract variants available
for that CPU by
From: Kumar Amber
This patch introduced the auto-validation function which
allows users to compare the batch of packets obtained from
different miniflow implementations against the linear
miniflow extract and return a hitmask.
The autovaidator function can be triggered at runtime using the
v12:
- re-work the set command to sweep method
- changes skip for unit-test to true from not-available
- added acks from Eelco
- minor doc fixed and typos
v11:
- reworked set command in alingment with Eelco and Harry
- added Acks from Eelco.
- added skip to unit test if other implementations not
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Comment with 'xxx' marker
#525 FILE: ovsdb/relay.c:158:
/* XXX: ovsdb-cs module
Main documentation for the service model and tutorial with the use case
and configuration examples.
Acked-by: Dumitru Ceara
Signed-off-by: Ilya Maximets
---
Documentation/automake.mk| 1 +
Documentation/ref/ovsdb.7.rst| 62 --
Documentation/topics/index.rst
Clients needs to re-connect from the relay that has no connection
with the database source. Also, relay acts similarly to the follower
from a clustered model from the consistency point of view, so it's not
suitable for leader-only connections.
Acked-by: Mark D. Gray
Acked-by: Dumitru Ceara
Current version of ovsdb relay allows to scale out read-only
access to the primary database. However, many clients are not
read-only but read-mostly. For example, ovn-controller.
In order to scale out database access for this case ovsdb-server
need to process transactions that are not
It might be important for clients to know that relay lost connection
with the relay remote, so they could re-connect to other relay.
Signed-off-by: Ilya Maximets
---
ovsdb/_server.xml| 17 +
ovsdb/ovsdb-server.c | 3 ++-
ovsdb/relay.c| 34
New database service model 'relay' that is needed to scale out
read-mostly database access, e.g. ovn-controller connections to
OVN_Southbound.
In this service model ovsdb-server connects to existing OVSDB
server and maintains in-memory copy of the database. It serves
read-only transactions and
This will be used to apply update3 type updates to ovsdb tables
while processing updates for future ovsdb 'relay' service model.
'ovsdb_datum_apply_diff' is allowed to fail, so adding support
to return this error.
Acked-by: Dumitru Ceara
Signed-off-by: Ilya Maximets
---
ovsdb/execution.c |
These functions will be used later for ovsdb 'relay' service model, so
moving them to a common code.
Warnings translated to ovsdb errors, caller in replication.c only
printed inconsistency warnings, but mostly ignored them. Implementing
the same logic by checking the error tag.
Also
ovsdb_create() requires schema or storage to be nonnull, but in
practice it requires to have schema name or a storage name to
use it as a database name. Only clustered storage has a name.
This means that only clustered database can be created without
schema, Changing that by allowing unbacked
If there are completed triggers, jsonrpc server should wake up and
update clients with the new data, but there is no such condition
in ovsdb_jsonrpc_session_wait(). For some reason this doesn't result
in any processing delays in current code, probably because there are
always some other types of
Replication can be used to scale out read-only access to the database.
But there are clients that are not read-only, but read-mostly.
One of the main examples is ovn-controller that mostly monitors
updates from the Southbound DB, but needs to claim ports by sending
transactions that changes some
On 6/30/21 3:15 PM, Mark Gray wrote:
> Add a suite of micro-benchmarks to aid a developer in understanding the
> performance impact of any changes that they are making. They can be used to
> help to understand the relative performance between two test runs on the same
> test machine, but are not
On 14 Jul 2021, at 14:25, Van Haaren, Harry wrote:
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Wednesday, July 14, 2021 12:57 PM
>> To: Amber, Kumar
>> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
>> Haaren,
>> Harry ; Ferriter, Cian ;
>>
On 6/30/21 3:15 PM, Mark Gray wrote:
> For performance measurement, it is useful to understand the
> length of time required to complete a number of key code paths
> in ovn-northd.c. Add stopwatches to measure these timings.
>
> Signed-off-by: Mark Gray
> Acked-by: Dumitru Ceara
> ---
>
>
Port numbers are usually small. Maintain an array of netdev handles indexed
by port numbers. It accelerates looking up for them for
netdev_hw_miss_packet_recover().
Reported-by: Cian Ferriter
Signed-off-by: Eli Britstein
Reviewed-by: Gaetan Rivet
---
lib/dpif-netdev-private-thread.h | 4 +++
rte_flow_get_restore_info() API is under experimental attribute. Using it
has a performance impact that can be avoided for non-experimental compilation.
Do not call it without experimental support.
Reported-by: Cian Ferriter
Signed-off-by: Eli Britstein
Reviewed-by: Gaetan Rivet
---
"Van Haaren, Harry" writes:
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Wednesday, July 14, 2021 10:12 AM
>> To: Amber, Kumar ; Aaron Conole
>>
>> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
>> Haaren,
>> Harry ; Ferriter, Cian ;
>> Stokes, Ian
On 8 Jul 2021, at 21:21, Ilya Maximets wrote:
> On 5/24/21 2:39 PM, Timothy Redaelli wrote:
>> On Tue, 18 May 2021 06:17:48 -0400
>> Eelco Chaudron wrote:
>>
>>> Due to flow lookup optimizations, especially in the resubmit/clone cases,
>>> we might end up with multiple ct_clear actions, which
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, July 14, 2021 12:57 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren,
> Harry ; Ferriter, Cian ;
> Stokes, Ian
> Subject: Re: [v11 06/11] dpif-netdev: Add packet count
Looks good to me Alexey, thanks!
Acked-by: Mark Michelson
On 6/19/21 3:38 PM, Alexey Roytman wrote:
From: Alexey Roytman
For big scale deployments, when number of logical flows can be 2M+,
sometimes users just need to know the total number of logical flows
and numbers of logical flows per
On 14 Jul 2021, at 13:33, Amber, Kumar wrote:
> Hi Eelco,
>
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Wednesday, July 14, 2021 4:21 PM
>> To: Amber, Kumar
>> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
>> Haaren, Harry ; Ferriter, Cian
>> ;
Hi Eelco,
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, July 14, 2021 4:21 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren, Harry ; Ferriter, Cian
> ; Stokes, Ian
> Subject: Re: [v11 06/11] dpif-netdev: Add
On 12 Jul 2021, at 14:54, Marcelo Ricardo Leitner wrote:
> On Mon, Jul 12, 2021 at 10:28:15AM +0200, Eelco Chaudron wrote:
>>
>>
>> On 9 Jul 2021, at 20:23, Ilya Maximets wrote:
>>
>>> On 7/9/21 10:35 AM, Eelco Chaudron wrote:
On 8 Jul 2021, at 22:18, Ilya Maximets wrote:
On 14 Jul 2021, at 13:02, Amber, Kumar wrote:
> Hi Eelco,
>
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Wednesday, July 14, 2021 4:08 PM
>> To: Amber, Kumar
>> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
>> Haaren, Harry ; Ferriter, Cian
>> ;
Hi Eelco,
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, July 14, 2021 4:08 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren, Harry ; Ferriter, Cian
> ; Stokes, Ian
> Subject: Re: [v11 07/11] test/sytem-dpdk: Add
On 14 Jul 2021, at 12:30, Eelco Chaudron wrote:
> On 14 Jul 2021, at 4:02, kumar Amber wrote:
>
>> From: Kumar Amber
>>
>> This commit introduces additional command line paramter
>> for mfex study function. If user provides additional packet out
>> it is used in study to compare minimum
On 14 Jul 2021, at 12:27, Amber, Kumar wrote:
> Hi Eelco,
>
>
>>> +
>>> +AT_SKIP_IF([! ovs-appctl dpif-netdev/miniflow-parser-get | sed 1,4d |
>>> +grep -v "not available"], [], [dnl
>>> +])
>>
>> Please, if you make changes, test them, as this has never worked, as you
>> changed this to
On 13 Jul 2021, at 18:11, Van Haaren, Harry wrote:
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Tuesday, July 13, 2021 3:26 PM
>> To: Van Haaren, Harry
>> Cc: Amber, Kumar ; ovs-dev@openvswitch.org;
>> f...@sysclose.org; i.maxim...@ovn.org; Ferriter, Cian
>> ;
>> Stokes,
On 14 Jul 2021, at 4:02, kumar Amber wrote:
From: Kumar Amber
This commit introduces additional command line paramter
for mfex study function. If user provides additional packet out
it is used in study to compare minimum packets which must be processed
else a default value is choosen.
Also
Hi Eelco,
> > +
> > +AT_SKIP_IF([! ovs-appctl dpif-netdev/miniflow-parser-get | sed 1,4d |
> > +grep -v "not available"], [], [dnl
> > +])
>
> Please, if you make changes, test them, as this has never worked, as you
> changed this to True/False.
> Here is a working example:
>
> AT_SKIP_IF([!
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, July 14, 2021 10:12 AM
> To: Amber, Kumar ; Aaron Conole
>
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren,
> Harry ; Ferriter, Cian ;
> Stokes, Ian
> Subject: Re: [v11 10/11]
On 14 Jul 2021, at 4:02, kumar Amber wrote:
> From: Harry van Haaren
>
> This commit adds a new counter to be displayed to the user when
> requesting datapath packet statistics. It counts the number of
> packets that are parsed and a miniflow built up from it by the
> optimized miniflow
On 14 Jul 2021, at 4:02, kumar Amber wrote:
> From: Kumar Amber
>
> Tests:
> 6: OVS-DPDK - MFEX Autovalidator
> 7: OVS-DPDK - MFEX Autovalidator Fuzzy
>
> Added a new directory to store the PCAP file used
> in the tests and a script to generate the fuzzy traffic
> type pcap to be used in
1 - 100 of 117 matches
Mail list logo
