Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Introduce netdev array cache

2021-07-16 Thread Ferriter, Cian
> -Original Message- > From: Eli Britstein > Sent: Thursday 15 July 2021 15:10 > To: Ferriter, Cian ; Ilya Maximets > ; Gaëtan Rivet > ; d...@openvswitch.org; Van Haaren, Harry > > Cc: Majd Dibbiny ; Stokes, Ian ; > Flavio Leitner > > Subject: Re: [ovs-dev] [PATCH 2/2] dpif-netdev:

Re: [ovs-dev] [PATCH v14 10/11] dpif-netdev/mfex: Add AVX512 based optimized miniflow extract

2021-07-16 Thread Eelco Chaudron
On 16 Jul 2021, at 10:49, Stokes, Ian wrote: >> On Thu, Jul 15, 2021 at 09:36:16PM +0530, kumar Amber wrote: >>> From: Harry van Haaren >>> >>> This commit adds AVX512 implementations of miniflow extract. >>> By using the 64 bytes available in an AVX512 register, it is >>> possible to convert

Re: [ovs-dev] [PATCH v14 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-16 Thread Stokes, Ian
> Some small things you forgot (also added the one Ian found) guess he can fix > them all up on commit. Also, a lot of indentation issues, guess no one noticed > them earlier :( > > Ian if you are going to fix all of this including indentation issues, you can > add my > ack when committing. If

Re: [ovs-dev] [PATCH v14 07/11] test/sytem-dpdk: Add unit test for mfex autovalidator

2021-07-16 Thread Eelco Chaudron
On 15 Jul 2021, at 18:30, Stokes, Ian wrote: >> From: Kumar Amber >> >> Tests: >> 6: OVS-DPDK - MFEX Autovalidator >> 7: OVS-DPDK - MFEX Autovalidator Fuzzy >> 8: OVS-DPDK - MFEX Configuration >> >> Added a new directory to store the PCAP file used >> in the tests and a script to

Re: [ovs-dev] [PATCH v14 03/11] dpif-netdev: Add study function to select the best mfex function

2021-07-16 Thread Eelco Chaudron
This one also has some indentation issue. Maybe Ian can fix on commit. On 15 Jul 2021, at 18:06, kumar Amber wrote: > From: Kumar Amber > > The study function runs all the available implementations > of miniflow_extract and makes a choice whose hitmask has > maximum hits and sets the mfex to

Re: [ovs-dev] [PATCH v14 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-16 Thread Eelco Chaudron
Some small things you forgot (also added the one Ian found) guess he can fix them all up on commit. Also, a lot of indentation issues, guess no one noticed them earlier :( Ian if you are going to fix all of this including indentation issues, you can add my ack when committing. If it’s too much

Re: [ovs-dev] [PATCH v14 09/11] dpdk: Add additional CPU ISA detection strings

2021-07-16 Thread Stokes, Ian
> From: Harry van Haaren > > This commit enables OVS to at runtime check for more detailed > AVX512 capabilities, specifically Byte and Word (BW) extensions, > and Vector Bit Manipulation Instructions (VBMI). > > These instructions will be used in the CPU ISA optimized > implementations of

Re: [ovs-dev] [PATCH v14 10/11] dpif-netdev/mfex: Add AVX512 based optimized miniflow extract

2021-07-16 Thread Stokes, Ian
> On Thu, Jul 15, 2021 at 09:36:16PM +0530, kumar Amber wrote: > > From: Harry van Haaren > > > > This commit adds AVX512 implementations of miniflow extract. > > By using the 64 bytes available in an AVX512 register, it is > > possible to convert a packet to a miniflow data-structure in > > a

Re: [ovs-dev] [PATCH] ovsdb-server: Fix memleak when failing to rea storage.

2021-07-16 Thread Dumitru Ceara
On 7/15/21 8:54 PM, Ben Pfaff wrote: > On Wed, Jul 14, 2021 at 09:21:19AM +0200, Dumitru Ceara wrote: >> Fixes: 1b1d2e6daa56 ("ovsdb: Introduce experimental support for clustered >> databases.") >> Signed-off-by: Dumitru Ceara > > Thanks! I pushed this. I noticed that the declaration could be

Re: [ovs-dev] ovn-northd-ddlog - high mem and cpu usage when started with an existing DB

2021-07-16 Thread Dumitru Ceara
On 7/16/21 1:54 AM, Ben Pfaff wrote: > On Mon, Jul 12, 2021 at 04:42:27PM -0700, Ben Pfaff wrote: >> On Thu, Jul 08, 2021 at 08:59:24PM +0200, Dumitru Ceara wrote: >>> Hi Ben, >>> >>> As discussed earlier, during the OVN meeting, I've noticed a new >>> performance issue with ovn-northd-ddlog when

Re: [ovs-dev] [PATCH ovn v2] controller: Avoid unnecessary load balancer flow processing.

2021-07-16 Thread Dumitru Ceara
On 7/16/21 3:05 AM, Han Zhou wrote: > On Thu, Jul 15, 2021 at 5:03 PM Ben Pfaff wrote: > >> On Mon, Jul 12, 2021 at 10:08:10AM +0200, Dumitru Ceara wrote: >>> Whenever a Load_Balancer is updated, e.g., a VIP is added, the following >>> sequence of events happens: >>> >>> 1. The Southbound

Re: [ovs-dev] [PATCH net-next v2] openvswitch: Introduce per-cpu upcall dispatch

2021-07-16 Thread Mark Gray
On 15/07/2021 23:57, Pravin Shelar wrote: > On Thu, Jul 15, 2021 at 5:28 AM Mark Gray wrote: >> >> The Open vSwitch kernel module uses the upcall mechanism to send >> packets from kernel space to user space when it misses in the kernel >> space flow table. The upcall sends packets via a Netlink

<    1   2