Re: [ovs-dev] [PATCH v2 ovn] controller: instrument ovn-controller loop with stopwatch

2021-07-21 Thread Mark Michelson
I pushed the change to master. Thanks! On 7/19/21 9:30 AM, Lorenzo Bianconi wrote: Introduce stopwatch instrumentation to the following ovn-controller routines: - commit_ct_zones - bfd_run - patch_run - pinctrl_run - if_status_mgr_update - if_status_mgr_run - ofctrl_seqno_run Acked-by: Dumitru

Re: [ovs-dev] [PATCH v4] ovsdb: provide raft and command interfaces with priority

2021-07-21 Thread Dumitru Ceara
On 7/9/21 7:27 PM, anton.iva...@cambridgegreys.com wrote: > From: Anton Ivanov > > Set a soft time limit of "raft election timer"/2 on ovsdb > processing. > > This improves behaviour in large heavily loaded clusters. > While it cannot fully eliminate spurious raft elections > under heavy load, i

Re: [ovs-dev] ideas for improving the OVS review process

2021-07-21 Thread Ben Pfaff
On Wed, Jul 21, 2021 at 10:37:18AM +0200, Eelco Chaudron wrote: > > > On 20 Jul 2021, at 20:41, Ben Pfaff wrote: > > > The OVS review process has greatly slowed over the last few years. This > > is partly because I haven't been able to spend as much time on review, > > since I was once the most

[ovs-dev] [PATCH v3 1/2] ovs-save: Save igmp flows in ofp_parse syntax

2021-07-21 Thread Salvatore Daniele
match.c generates the keyword "igmp", which is not supported in ofp-parse. This means that flow dumps containing 'igmp' can not be restored. Removing the 'igmp' keyword entirely could break existing scripts in stable branches, so this patch creates a workaround within ovs-save by converting any in

[ovs-dev] [PATCH v3 2/2] Match: Do not print "igmp" match keyword

2021-07-21 Thread Salvatore Daniele
From: Adrian Moreno The match keyword "igmp" is not supported in ofp-parse, which means that flow dumps cannot be restored. Previously a workaround was added to ovs-save to avoid changing output in stable branches. This patch removes that work around, and instead prints the igmp match in the acc

[ovs-dev] [PATCH v3 0/2] flow dumps containing igmp match cannot be restored

2021-07-21 Thread Salvatore Daniele
match_format() prints the keyword "igmp" for flows with the field "ip,nw_proto=2". ofp_parse_protocol does not accept this value. This results in flow dump restoration failing when the ovs-save script is used by "ovs-ctl restart" on a dump of flows containing this match. However, removing the "igm

Re: [ovs-dev] [PATCH ovn 0/4] Avoid parsing non-local lflows with the help of tags in SB.

2021-07-21 Thread Han Zhou
On Wed, Jul 21, 2021 at 7:58 AM Mark Michelson wrote: > > Hi Han, > > For the series, > Acked-by: Mark Michelson Thanks Mark! I applied the series. > > I think this series is good to go in as-is. I'm curious if a future > enhancement might be to add an in_out_port tag to flows that use > is_cha

Re: [ovs-dev] [PATCH ovn 0/4] Avoid parsing non-local lflows with the help of tags in SB.

2021-07-21 Thread Mark Michelson
Hi Han, For the series, Acked-by: Mark Michelson I think this series is good to go in as-is. I'm curious if a future enhancement might be to add an in_out_port tag to flows that use is_chassis_resident(). It might even make sense to eventually deprecate is_chassis_resident() in favor of in_o

Re: [ovs-dev] [PATCH v2 0/2] flow dumps containing igmp match cannot be restored

2021-07-21 Thread Salvatore Daniele
Will do, thanks Ilya On Wed, Jul 21, 2021 at 6:32 AM Ilya Maximets wrote: > On 7/20/21 9:50 PM, Salvatore Daniele wrote: > > match_format() prints the keyword "igmp" for flows with the field > > "ip,nw_proto=2". ofp_parse_protocol does not accept this value. > > > > This results in flow dump res

Re: [ovs-dev] [PATCH ovn] ovn.at: Fix "Symmetric IPv6 ECMP reply flows" test.

2021-07-21 Thread Numan Siddique
On Mon, Jul 19, 2021 at 11:30 AM Mark Gray wrote: > > On 19/07/2021 14:51, Dumitru Ceara wrote: > > When running tests against OVS master branch, the "Symmetric IPv6 ECMP > > reply flows" test was failing because it wasn't taking into account the > > possibility that null-SNAT might be supported b

Re: [ovs-dev] [PATCH ovn v3] northd: Process load balancer defrag flows once for all routers.

2021-07-21 Thread Numan Siddique
On Fri, Jul 16, 2021 at 12:25 PM Dumitru Ceara wrote: > > This allows creating the match strings for each LB VIP exactly once, > instead of once per datapath as it was before this change, reducing CPU > usage in the ovn-northd event processing loop. > > On a scaled ovn-kubernetes-like deployment f

Re: [ovs-dev] [PATCH v2] jsonrpc: Add a new API to allow clients to reset reconnect backoff.

2021-07-21 Thread Dumitru Ceara
On 7/21/21 2:07 PM, Ilya Maximets wrote: > On 7/21/21 12:56 PM, Dumitru Ceara wrote: >> Add jsonrpc_session_reset_backoff() which resets the number of >> backoff-free tries to the number of remotes + 1. This is used by >> upper layers (e.g., ovsdb-cs) before forcefully triggering a >> reconnection

[ovs-dev] [PATCH v3] ovsdb-cs: Perform forced reconnects without a backoff.

2021-07-21 Thread Dumitru Ceara
The ovsdb-cs layer triggers a forced reconnect in various cases: - when an inconsistency is detected in the data received from the remote server. - when the remote server is running in clustered mode and transitioned to "follower", if the client is configured in "leader-only" mode. - when expli

Re: [ovs-dev] [PATCH v2] jsonrpc: Add a new API to allow clients to reset reconnect backoff.

2021-07-21 Thread Ilya Maximets
On 7/21/21 12:56 PM, Dumitru Ceara wrote: > Add jsonrpc_session_reset_backoff() which resets the number of > backoff-free tries to the number of remotes + 1. This is used by > upper layers (e.g., ovsdb-cs) before forcefully triggering a > reconnection. Like this the reconnection will happen as so

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix continuations with OF instructions in OF1.1+.

2021-07-21 Thread Ilya Maximets
On 7/21/21 12:52 AM, Ben Pfaff wrote: > On Tue, Jul 20, 2021 at 08:29:14PM +0200, Ilya Maximets wrote: >> On 7/7/21 8:51 PM, Ben Pfaff wrote: >>> +/* From an OpenFlow point of view, goto_table and write_metadata >>> are >>> + * instructions, not actions. This means that to use the

Re: [ovs-dev] [PATCH] reconnect: Add graceful reconnect.

2021-07-21 Thread Dumitru Ceara
On 7/20/21 4:32 PM, Dumitru Ceara wrote: > On 7/20/21 4:29 PM, Ilya Maximets wrote: >> On 7/20/21 4:25 PM, Ilya Maximets wrote: >>> On 7/20/21 3:39 PM, Dumitru Ceara wrote: On 7/20/21 3:18 PM, Ilya Maximets wrote: > On 7/13/21 5:03 PM, Dumitru Ceara wrote: >> On 7/12/21 10:36 PM, Ilya

[ovs-dev] [PATCH v2] jsonrpc: Add a new API to allow clients to reset reconnect backoff.

2021-07-21 Thread Dumitru Ceara
Add jsonrpc_session_reset_backoff() which resets the number of backoff-free tries to the number of remotes + 1. This is used by upper layers (e.g., ovsdb-cs) before forcefully triggering a reconnection. Like this the reconnection will happen as soon as possible. The backoff mechanism should be u

Re: [ovs-dev] [PATCH v2 0/2] flow dumps containing igmp match cannot be restored

2021-07-21 Thread Ilya Maximets
On 7/20/21 9:50 PM, Salvatore Daniele wrote: > match_format() prints the keyword "igmp" for flows with the field > "ip,nw_proto=2". ofp_parse_protocol does not accept this value. > > This results in flow dump restoration failing when the ovs-save script > is used by "ovs-ctl restart" on a dump of

Re: [ovs-dev] ideas for improving the OVS review process

2021-07-21 Thread Eelco Chaudron
On 20 Jul 2021, at 20:41, Ben Pfaff wrote: > The OVS review process has greatly slowed over the last few years. This > is partly because I haven't been able to spend as much time on review, > since I was once the most productive reviewer. Ilya has been able to > step up the amount of review h