On Fri, Jul 23, 2021 at 11:54 AM Priyankar Jain
wrote:
>
> Sure. Thanks Numan.
Hi Priyankar,
Please see below for a few comments. This is not a full review. But
over all the patch LGTM.
>
> Best Regards,
> Priyankar Jain
>
> On 23/07/21 7:57 pm, Numan Siddique wrote:
> > On Tue, Jul 20, 2021
On Fri, Jul 23, 2021 at 08:26:51PM +0800, Tonghao Zhang wrote:
> On Wed, Jul 21, 2021 at 2:41 AM Ben Pfaff wrote:
> >
> > The OVS review process has greatly slowed over the last few years. This
> > is partly because I haven't been able to spend as much time on review,
> > since I was once the mos
On Fri, Jul 23, 2021 at 4:05 PM Dumitru Ceara wrote:
>
> The ovn-kubernetes CI job builds OVS RPMs from the submodule sources but
> only installs the x86 ones. The noarch dependencies are pulled from
> other sources and may not exist yet (e.g., OVS submodule points to a
> commit on the OVS maste
On Fri, Jul 23, 2021 at 2:42 PM Mark Michelson wrote:
>
> Hi Dumitru,
>
> From a functionality standpoint,
>
> Acked-by: Mark Michelson
>
> I have a question and suggestion below.
>
Hi Dumitru,
Thanks for addressing this issue.
I have a few comments. Please see below.
> On 7/23/21 12:27 PM
Atomic variables must be read atomically. And since we already have
'smc_enable_db' in the PMD context, we need to use it from there to
avoid reading atomically twice.
Also, 'smc_enable_db' is a global configuration, there is no need
to read it per-port or per-rxq.
CC: Harry van Haaren
Fixes: 9
On Wed, Jul 14, 2021 at 9:08 AM Dumitru Ceara wrote:
>
> On 6/30/21 3:15 PM, Mark Gray wrote:
> > Add a suite of micro-benchmarks to aid a developer in understanding the
> > performance impact of any changes that they are making. They can be used to
> > help to understand the relative performance
The ovn-kubernetes CI job builds OVS RPMs from the submodule sources but
only installs the x86 ones. The noarch dependencies are pulled from
other sources and may not exist yet (e.g., OVS submodule points to a
commit on the OVS master branch with no official release).
Fixes: b35a6f0faded ("add o
On Fri, Jul 23, 2021 at 2:55 PM Mark Michelson wrote:
>
> I merged the change with your recommended edit to the commit message.
Does this patch need a backport to branch-21.06 ?
Thanks
Numan
>
> On 7/23/21 2:14 PM, Dumitru Ceara wrote:
> > On 7/23/21 8:03 PM, Dumitru Ceara wrote:
> >> Specifica
I merged the change with your recommended edit to the commit message.
On 7/23/21 2:14 PM, Dumitru Ceara wrote:
On 7/23/21 8:03 PM, Dumitru Ceara wrote:
Specifically, include daf627f459ff ("ovsdb-cs: Perform forced reconnects
without a backoff."), without which all reconnects from clients
requir
Hi Dumitru,
From a functionality standpoint,
Acked-by: Mark Michelson
I have a question and suggestion below.
On 7/23/21 12:27 PM, Dumitru Ceara wrote:
Commit 6aab704fb67d ("controller: Avoid unnecessary load balancer flow
processing.") handled the case when load balancers are updated but
ad
On 7/23/21 8:03 PM, Dumitru Ceara wrote:
> Specifically, include daf627f459ff ("ovsdb-cs: Perform forced reconnects
> without a backoff."), without which all reconnects from clients
> requiring leader-only connections to clustered DBs (e.g., ovn-northd,
> ovn-nbctl daemon) happen with the maximum b
Specifically, include daf627f459ff ("ovsdb-cs: Perform forced reconnects
without a backoff."), without which all reconnects from clients
requiring leader-only connections to clustered DBs (e.g., ovn-northd,
ovn-nbctl daemon) happen with the maximum backoff of 8 seconds.
Reported-at: https://bugzil
On 7/23/21 6:05 PM, Numan Siddique wrote:
> On Fri, Jul 23, 2021, 11:47 AM Dumitru Ceara wrote:
>
>> On 7/23/21 5:06 PM, Mark Gray wrote:
>>> On 23/07/2021 12:21, Dumitru Ceara wrote:
With the ovn-kubernetes version currently tagged for use within OVN CI
there were often failures that w
On 7/12/21 5:07 PM, Eli Britstein wrote:
> Before flushing offloads of a removed port was supported by [1], it was
> necessary to flush the 'marks'. In doing so, all offloads of the PMD are
> removed, include the ones that are not related to the removed port and
> that are not modified following th
On 7/23/21 6:39 PM, Ilya Maximets wrote:
> On 7/21/21 2:51 PM, Dumitru Ceara wrote:
>> The ovsdb-cs layer triggers a forced reconnect in various cases:
>> - when an inconsistency is detected in the data received from the
>> remote server.
>> - when the remote server is running in clustered mode a
On 7/21/21 2:51 PM, Dumitru Ceara wrote:
> The ovsdb-cs layer triggers a forced reconnect in various cases:
> - when an inconsistency is detected in the data received from the
> remote server.
> - when the remote server is running in clustered mode and transitioned
> to "follower", if the clien
On 7/19/21 3:40 PM, kumar Amber wrote:
> This fixes the flake8 error on pyhton version older than 3.6
> as ModuleNotFoundError in not available before 3.6 and that is now
> replaced to ImportError which is present in earlier versions.
>
> ../../tests/mfex_fuzzy.py:5:8: F821 undefined name 'ModuleN
On 7/16/21 5:42 PM, Ben Pfaff wrote:
> On Fri, Jul 16, 2021 at 09:43:17AM +0200, Dumitru Ceara wrote:
>> On 7/16/21 3:05 AM, Han Zhou wrote:
>>> On Thu, Jul 15, 2021 at 5:03 PM Ben Pfaff wrote:
>>>
On Mon, Jul 12, 2021 at 10:08:10AM +0200, Dumitru Ceara wrote:
> Whenever a Load_Balancer i
Hi Lorenzo, thanks for your your persistence on this. I pushed the
series to master.
On 7/23/21 11:10 AM, Lorenzo Bianconi wrote:
This series respin CoPP support introduced here [0] by Dumitru rebasing on top
of ovn master branch and adding some missing meters (e.g. bfd or acl reject).
The main
Commit 6aab704fb67d ("controller: Avoid unnecessary load balancer flow
processing.") handled the case when load balancers are updated but
addition/removal of load balancers will trigger almost all logical
flows to be reprocessed by ovn-controller.
The references are just used for optimizing lookup
On Fri, Jul 23, 2021, 11:47 AM Dumitru Ceara wrote:
> On 7/23/21 5:06 PM, Mark Gray wrote:
> > On 23/07/2021 12:21, Dumitru Ceara wrote:
> >> With the ovn-kubernetes version currently tagged for use within OVN CI
> >> there were often failures that were unrelated to OVN itself.
> >>
> >> Update t
Sure. Thanks Numan.
Best Regards,
Priyankar Jain
On 23/07/21 7:57 pm, Numan Siddique wrote:
On Tue, Jul 20, 2021 at 12:17 PM Priyankar Jain
wrote:
ping for review.
Hi Priyankar,
I'll take a look at the patch and come back to you with comments.
Thanks
Numan
On 12/07/21 1:04 pm, Priyank
On 7/23/21 5:06 PM, Mark Gray wrote:
> On 23/07/2021 12:21, Dumitru Ceara wrote:
>> With the ovn-kubernetes version currently tagged for use within OVN CI
>> there were often failures that were unrelated to OVN itself.
>>
>> Update to the current ovn-kubernetes master branch version for improved
>>
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#873 FILE: utilities/ovn-nbctl.c:432:
ls-c
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or committ
On Mon, Jul 19, 2021 at 1:14 PM Ihar Hrachyshka wrote:
>
> This allows L3+ ACLs to match against double tagged vlan traffic on
> vlan-passthru switches.
>
> The default in OVS is vlan-limit=1 for backwards compatibility. This
> means packets are not "parsed" deeper than one tag level.
>
> This pat
From: Dumitru Ceara
Change the ovn-northd implementation to set the new 'controller_meter'
field for flows that need to punt packets to ovn-controller.
Protocol packets for which CoPP is enforced when sending packets to
ovn-controller (if configured):
- ARP
- ND_NS
- ND_NA
- ND_RA
- DNS
- IGMP
-
From: Dumitru Ceara
Acked-by: Mark D. Gray
Co-authored-by: Lorenzo Bianconi
Signed-off-by: Lorenzo Bianconi
Signed-off-by: Dumitru Ceara
---
NEWS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index a4643510e..eefdae9bc 100644
--- a/NEWS
+++ b/NEWS
@@ -1,6 +1
From: Dumitru Ceara
Add new 'Copp' (Control plane protection) table to OVN Northbound DB:
- this stores mappings between control plane protocol names and meters
that should be used to rate limit controller-destined traffic for
those protocols.
Add new 'copp' columns to the following OVN Nort
From: Dumitru Ceara
Add a new 'controller_meter' column to OVN Southbound Logical_Flow
table. This stores an optional string which should correspond to
the Meter that must be used for rate limiting controller actions
generated by packets hitting the flow.
Add a new 'ofctrl_add_flow_metered' func
From: Ben Pfaff
This should avoid some work by doing the cheapest check (the one on
UseLogicalDatapathGroups) before any joins. DDlog is probably
factoring out the reference to the Flow relation, which is identical
in both, but this ought to avoid the group_by aggregation (which is
relatively ex
This series respin CoPP support introduced here [0] by Dumitru rebasing on top
of ovn master branch and adding some missing meters (e.g. bfd or acl reject).
The main goal of this series is to continue the discussion about the proposed
approach and to align on CMS APIs.
For the moment DDLog is not s
On 23/07/2021 12:21, Dumitru Ceara wrote:
> With the ovn-kubernetes version currently tagged for use within OVN CI
> there were often failures that were unrelated to OVN itself.
>
> Update to the current ovn-kubernetes master branch version for improved
> reliability of the test runs.
>
> Changes
From: Adrian Moreno
The match keyword "igmp" is not supported in ofp-parse, which means
that flow dumps cannot be restored. Previously a workaround was
added to ovs-save to avoid changing output in stable branches.
This patch changes the output to print igmp match in the accepted
ofp-parse forma
match.c generates the keyword "igmp", which is not supported in ofp-parse.
This means that flow dumps containing 'igmp' can not be restored.
Removing the 'igmp' keyword entirely could break existing scripts in stable
branches, so this patch creates a workaround within ovs-save by converting any
in
match_format() prints the keyword "igmp" for flows with the field
"ip,nw_proto=2". ofp_parse_protocol does not accept this value.
This results in flow dump restoration failing when the ovs-save script
is used by "ovs-ctl restart" on a dump of flows containing this match.
However, removing the "igm
On Thu, Jul 22, 2021 at 4:54 PM Mark Michelson wrote:
>
> Hi Lorenzo,
>
> In the commit message:
>
> s/centralized/centralize/
>
> There's no reason for you to upload a new version of the patch with this
> change. Whoever merges this can edit the commit message.
>
> Acked-by: Mark Michelson
Than
On Tue, Jul 20, 2021 at 12:17 PM Priyankar Jain
wrote:
>
> ping for review.
Hi Priyankar,
I'll take a look at the patch and come back to you with comments.
Thanks
Numan
>
> On 12/07/21 1:04 pm, Priyankar Jain wrote:
> > Allow adding label to an ACL to identify which ACL allowed a particular
>
fix incorrect type in argument 1 (different address spaces)
../net/openvswitch/datapath.c:169:17: warning: incorrect type in argument 1
(different address spaces)
../net/openvswitch/datapath.c:169:17:expected void const *
../net/openvswitch/datapath.c:169:17:got struct dp_nlsk_pids [noder
Signed-off-by: Mark Gray
---
include/uapi/linux/openvswitch.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/openvswitch.h
index 6571b57b2268..0e436a3755f1 100644
--- a/include/uapi/linux/openvswitch.h
+++ b/include/uapi/l
Signed-off-by: Mark Gray
---
include/uapi/linux/openvswitch.h | 4 ++--
net/openvswitch/actions.c| 6 --
net/openvswitch/datapath.c | 16 ++--
3 files changed, 16 insertions(+), 10 deletions(-)
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/ope
Some issues were raised by patchwork at:
https://patchwork.kernel.org/project/netdevbpf/patch/20210630095350.817785-1-mark.d.g...@redhat.com/#24285159
Mark Gray (3):
openvswitch: update kdoc OVS_DP_ATTR_PER_CPU_PIDS
openvswitch: fix alignment issues
openvswitch: fix sparse warning incorrect
Thank you for the feedback Aaron, I hadn't considered that. I will send a
v4 without reverting the workaround.
On Thu, Jul 22, 2021 at 1:25 PM Aaron Conole wrote:
> Ilya Maximets writes:
>
> > On 7/22/21 4:15 PM, Aaron Conole wrote:
> >> Salvatore Daniele writes:
> >>
> >>> From: Adrian Moreno
On 7/22/21 8:52 PM, Ben Pfaff wrote:
> On Thu, Jul 22, 2021 at 01:33:37PM +0200, Ilya Maximets wrote:
>> GCC 11 on Feodra 34 emits a false-positive warning like this:
>>
>> lib/netdev-dummy.c: In function ‘dummy_packet_stream_run’:
>> lib/netdev-dummy.c:284:16: error: ‘n’ may be used uninitialize
19 bytes in 1 blocks are definitely lost in loss record 24 of 121
at 0x4839748: malloc (vg_replace_malloc.c:306)
by 0x483BD63: realloc (vg_replace_malloc.c:834)
by 0x521C26: xrealloc (util.c:149)
by 0x478F91: ds_reserve (dynamic-string.c:63)
by 0x47928B: ds_put_format_valist (d
On Wed, Jul 21, 2021 at 2:41 AM Ben Pfaff wrote:
>
> The OVS review process has greatly slowed over the last few years. This
> is partly because I haven't been able to spend as much time on review,
> since I was once the most productive reviewer. Ilya has been able to
Thanks for your work!
> ste
With the ovn-kubernetes version currently tagged for use within OVN CI
there were often failures that were unrelated to OVN itself.
Update to the current ovn-kubernetes master branch version for improved
reliability of the test runs.
Changes in ovn-kubernetes between the two versions:
https://git
On 7/22/21 7:16 PM, anton.iva...@cambridgegreys.com wrote:
> From: Anton Ivanov
>
> Set a soft time limit of "raft election timer"/2 on ovsdb
> processing.
>
> This improves behaviour in large heavily loaded clusters.
> While it cannot fully eliminate spurious raft elections
> under heavy load,
48 matches
Mail list logo
