Re: [ovs-dev] [PATCH V3 0/4] dpif-netdev offload transitions

2021-08-03 Thread Eli Britstein via dev
On 8/2/2021 10:58 PM, Ilya Maximets wrote: External email: Use caution opening links or attachments On 7/26/21 10:14 AM, Eli Britstein wrote: This patch-set improves/fixes offloads transitions behavior. Patch #1 avoids flushing PMD offloads unnecessarily. Patch #2 fixes a flow modifications

Re: [ovs-dev] [PATCH v4 2/2] Minimize the number of time calls in time_poll()

2021-08-03 Thread Anton Ivanov
On 02/08/2021 23:53, Gaëtan Rivet wrote: On Tue, Jul 20, 2021, at 17:06, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov time_poll() makes an excessive number of time_msec() calls which incur a performance penalty. 1. Avoid time_msec() call for timeout calculation when time_poll()

Re: [ovs-dev] [PATCH v4 1/2] Optimize the poll loop for poll_immediate_wake()

2021-08-03 Thread Anton Ivanov
On 03/08/2021 00:29, Gaëtan Rivet wrote: On Tue, Jul 20, 2021, at 17:06, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov If we are not obtaining any useful information out of the poll(), such as is a fd busy or not, we do not need to do a poll() if an immediate_wake() has been reque

Re: [ovs-dev] [PATCH V3 0/4] dpif-netdev offload transitions

2021-08-03 Thread Ilya Maximets
On 8/3/21 9:24 AM, Eli Britstein wrote: > > On 8/2/2021 10:58 PM, Ilya Maximets wrote: >> External email: Use caution opening links or attachments >> >> >> On 7/26/21 10:14 AM, Eli Britstein wrote: >>> This patch-set improves/fixes offloads transitions behavior. >>> >>> Patch #1 avoids flushing PM

[ovs-dev] [PATCH ovn] system-ovn.at: Fix flaky "load-balancing" test.

2021-08-03 Thread xsimonar
When running load-balancing test, tcpdump is executed in background. When the backround process stops, it outputs a message which might be catched by the following command (wget) causing the test to fail. wget being executed with -q we can safely ignore its output. Fixes: ebbcd8e8cc ("northd: add

Re: [ovs-dev] [PATCH ovn] system-ovn.at: Fix flaky "load-balancing" test.

2021-08-03 Thread 0-day Robot
Bleep bloop. Greetings Xavier Simonart, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author xsimo...@redhat.com needs to sign off. WARNING: Unexpected sign-offs from dev

[ovs-dev] [PATCH 2/4] ovsdb: Parallel snapshot generation

2021-08-03 Thread anton . ivanov
From: Anton Ivanov Generate structures of the type {"table":{"row uuid":"row"}} in parallel. This is one of the slowest operations in ovsdb as it involves walks as well as convertion to jason. Both are parellelized and the results from worker threads working on "slices" of the hash are merged. Us

[ovs-dev] [PATCH 1/4] Migrate parallelisation routines from the OVN tree

2021-08-03 Thread anton . ivanov
From: Anton Ivanov Migrate the routines used in parallel processing of hash data from the OVN tree. Signed-off-by: Anton Ivanov --- include/openvswitch/hmap.h | 2 + lib/automake.mk| 2 + lib/parallel-hmap.c| 456 + lib/parallel-hmap.

[ovs-dev] [PATCH 3/4] ovsdb: Parallel processing for monitor compose update

2021-08-03 Thread anton . ivanov
From: Anton Ivanov Enable parallel processing of monitor compose update reusing the json merge routines for parallel snapshotting. Signed-off-by: Anton Ivanov --- ovsdb/monitor.c | 154 ++-- 1 file changed, 135 insertions(+), 19 deletions(-) diff --

[ovs-dev] [PATCH 4/4] ovsdb: Parallel processing for monitor compose cond changes

2021-08-03 Thread anton . ivanov
From: Anton Ivanov Processing monitor cond changes in parallel where applicable. The cut-off at 32 entries is set based on experimentation on a 6/12 Ryzen. It is reasonably conservative and should be OK for other CPUs with higher cost of thread IPC. Signed-off-by: Anton Ivanov --- ovsdb/monit

Re: [ovs-dev] [PATCH ovn] ovn-northd: Multiple distributed gateway port support.

2021-08-03 Thread Numan Siddique
On Thu, Jul 29, 2021 at 4:03 AM Han Zhou wrote: > > From: Ankur Sharma > > By default, OVN support only one DGP (distributed gateway port) per > logical router. While a single DGP port suffices for most of the North > South connectivity, there are requirements where a logical router could > be co

Re: [ovs-dev] [PATCH 1/4] Migrate parallelisation routines from the OVN tree

2021-08-03 Thread 0-day Robot
Bleep bloop. Greetings Anton Ivanov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 87 characters long (recommended limit is 79) #191 FILE: lib/parallel-hmap.c:14

Re: [ovs-dev] [PATCH 2/4] ovsdb: Parallel snapshot generation

2021-08-03 Thread 0-day Robot
Bleep bloop. Greetings Anton Ivanov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 84 characters long (recommended limit is 79) #89 FILE: ovsdb/file.c:407:

Re: [ovs-dev] [PATCH 3/4] ovsdb: Parallel processing for monitor compose update

2021-08-03 Thread 0-day Robot
Bleep bloop. Greetings Anton Ivanov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #149 FILE: ovsdb/monitor.c:1218:

Re: [ovs-dev] [PATCH 4/4] ovsdb: Parallel processing for monitor compose cond changes

2021-08-03 Thread 0-day Robot
Bleep bloop. Greetings Anton Ivanov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #77 FILE: ovsdb/monitor.c:1309:

[ovs-dev] [PATCH] acinclude: Don't set AVX512-related configuration via CFLAGS.

2021-08-03 Thread Ilya Maximets
The correct way to pass configuration options is to define them inside the config.h. Additionally, few long lines wrapped and fixed the unnecessary double check for -mavx512f. Fixes: abb807e27dd4 ("dpif-netdev: Add command to switch dpif implementation.") Fixes: 5324b54e606a ("dpif-netdev: Add co

Re: [ovs-dev] [PATCH ovn] ovn-northd: Multiple distributed gateway port support.

2021-08-03 Thread Han Zhou
On Tue, Aug 3, 2021 at 10:14 AM Numan Siddique wrote: > > On Thu, Jul 29, 2021 at 4:03 AM Han Zhou wrote: > > > > From: Ankur Sharma > > > > By default, OVN support only one DGP (distributed gateway port) per > > logical router. While a single DGP port suffices for most of the North > > South co

Re: [ovs-dev] [PATCH] Fix compilation error on Fedora 34 with GCC 11

2021-08-03 Thread Numan Siddique
On Thu, Jul 29, 2021 at 2:01 AM Guzowski Adrian via dev wrote: > > > > W dniu śro, 28.07.2021 o godzinie 11∶52 -0400, użytkownik Numan Siddique > napisał: > > > > On Wed, Jul 28, 2021 at 8:19 AM Guzowski Adrian via dev > > wrote: > > > > > > With newest version of GCC, OVS fails to compile due t

Re: [ovs-dev] [PATCH ovn] ovn-northd: Multiple distributed gateway port support.

2021-08-03 Thread Numan Siddique
On Tue, Aug 3, 2021 at 1:55 PM Han Zhou wrote: > > On Tue, Aug 3, 2021 at 10:14 AM Numan Siddique wrote: > > > > On Thu, Jul 29, 2021 at 4:03 AM Han Zhou wrote: > > > > > > From: Ankur Sharma > > > > > > By default, OVN support only one DGP (distributed gateway port) per > > > logical router. W

Re: [ovs-dev] [RFC PATCH ovn 0/4] Use Distributed Gateway Port for ovn-controller scalability.

2021-08-03 Thread Numan Siddique
On Fri, Jul 30, 2021 at 3:22 AM Han Zhou wrote: > > Note: This patch series is on top of a pending patch that is still under > review: > http://patchwork.ozlabs.org/project/ovn/patch/20210729080218.1235041-1-hz...@ovn.org/ > > It is RFC because: a) it is based on the unmerged patch. b) DDlog > ch

Re: [ovs-dev] [RFC PATCH ovn 0/4] Use Distributed Gateway Port for ovn-controller scalability.

2021-08-03 Thread Han Zhou
On Tue, Aug 3, 2021 at 11:09 AM Numan Siddique wrote: > > On Fri, Jul 30, 2021 at 3:22 AM Han Zhou wrote: > > > > Note: This patch series is on top of a pending patch that is still under > > review: http://patchwork.ozlabs.org/project/ovn/patch/20210729080218.1235041-1-hz...@ovn.org/ > > > > It i

Re: [ovs-dev] [RFC PATCH ovn 0/4] Use Distributed Gateway Port for ovn-controller scalability.

2021-08-03 Thread Numan Siddique
On Tue, Aug 3, 2021 at 2:34 PM Han Zhou wrote: > > On Tue, Aug 3, 2021 at 11:09 AM Numan Siddique wrote: > > > > On Fri, Jul 30, 2021 at 3:22 AM Han Zhou wrote: > > > > > > Note: This patch series is on top of a pending patch that is still under > > > review: > http://patchwork.ozlabs.org/projec

Re: [ovs-dev] [RFC PATCH ovn 0/4] Use Distributed Gateway Port for ovn-controller scalability.

2021-08-03 Thread Han Zhou
On Tue, Aug 3, 2021 at 11:57 AM Numan Siddique wrote: > > On Tue, Aug 3, 2021 at 2:34 PM Han Zhou wrote: > > > > On Tue, Aug 3, 2021 at 11:09 AM Numan Siddique wrote: > > > > > > On Fri, Jul 30, 2021 at 3:22 AM Han Zhou wrote: > > > > > > > > Note: This patch series is on top of a pending patch

Re: [ovs-dev] [PATCH v7 ovn 3/3] northd: add check_pkt_larger lflows for ingress traffic

2021-08-03 Thread Han Zhou
On Tue, Jul 27, 2021 at 10:06 AM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > > Introduce check_pkt_larger action for ingress traffic > entering the cluster from a distributed gw router port > or from a gw router. This patch enables pMTU discovery > for ingress traffic. > > Signed-off-b

Re: [ovs-dev] [PATCH v7 ovn 3/3] northd: add check_pkt_larger lflows for ingress traffic

2021-08-03 Thread Numan Siddique
On Tue, Aug 3, 2021 at 3:29 PM Han Zhou wrote: > > On Tue, Jul 27, 2021 at 10:06 AM Lorenzo Bianconi < > lorenzo.bianc...@redhat.com> wrote: > > > > Introduce check_pkt_larger action for ingress traffic > > entering the cluster from a distributed gw router port > > or from a gw router. This patch

Re: [ovs-dev] [PATCH v7 ovn 3/3] northd: add check_pkt_larger lflows for ingress traffic

2021-08-03 Thread Numan Siddique
On Tue, Aug 3, 2021 at 4:08 PM Numan Siddique wrote: > > On Tue, Aug 3, 2021 at 3:29 PM Han Zhou wrote: > > > > On Tue, Jul 27, 2021 at 10:06 AM Lorenzo Bianconi < > > lorenzo.bianc...@redhat.com> wrote: > > > > > > Introduce check_pkt_larger action for ingress traffic > > > entering the cluster

Re: [ovs-dev] [PATCH v7 ovn 3/3] northd: add check_pkt_larger lflows for ingress traffic

2021-08-03 Thread Han Zhou
On Tue, Aug 3, 2021 at 1:42 PM Numan Siddique wrote: > > On Tue, Aug 3, 2021 at 4:08 PM Numan Siddique wrote: > > > > On Tue, Aug 3, 2021 at 3:29 PM Han Zhou wrote: > > > > > > On Tue, Jul 27, 2021 at 10:06 AM Lorenzo Bianconi < > > > lorenzo.bianc...@redhat.com> wrote: > > > > > > > > Introduce

Re: [ovs-dev] [PATCH v7 ovn 3/3] northd: add check_pkt_larger lflows for ingress traffic

2021-08-03 Thread Han Zhou
On Tue, Aug 3, 2021 at 2:49 PM Han Zhou wrote: > > > > On Tue, Aug 3, 2021 at 1:42 PM Numan Siddique wrote: > > > > On Tue, Aug 3, 2021 at 4:08 PM Numan Siddique wrote: > > > > > > On Tue, Aug 3, 2021 at 3:29 PM Han Zhou wrote: > > > > > > > > On Tue, Jul 27, 2021 at 10:06 AM Lorenzo Bianconi <

Re: [ovs-dev] [PATCH] conntrack: extract l4 information for SCTP

2021-08-03 Thread Gaëtan Rivet
On Tue, Jul 13, 2021, at 22:59, Paolo Valerio wrote: > since a27d70a89 ("conntrack: add generic IP protocol support") all > the unrecognized IP protocols get handled using ct_proto_other ops > and are managed as L3 using 3 tuples. > > This patch stores L4 information for SCTP in the conn_key so th

Re: [ovs-dev] [PATCH v7 ovn 3/3] northd: add check_pkt_larger lflows for ingress traffic

2021-08-03 Thread Numan Siddique
On Tue, Aug 3, 2021 at 6:58 PM Han Zhou wrote: > > On Tue, Aug 3, 2021 at 2:49 PM Han Zhou wrote: > > > > > > > > On Tue, Aug 3, 2021 at 1:42 PM Numan Siddique wrote: > > > > > > On Tue, Aug 3, 2021 at 4:08 PM Numan Siddique wrote: > > > > > > > > On Tue, Aug 3, 2021 at 3:29 PM Han Zhou wrote:

[ovs-dev] [PATCH ovn v2 1/2] system-ovn.at: Fix flaky "load-balancing" test.

2021-08-03 Thread Xavier Simonart
When running load-balancing test, tcpdump is executed in background. When the backround tcpdump stops, it sends to stderr a message (such as number of packets captured) which might be catched by the following command (wget) causing the test to fail. Fixes: ebbcd8e8cc ("northd: add reject action fo

[ovs-dev] [PATCH ovn v2 2/2] system-ovn.at: Fix flaky "load-balancing" test (all servers targetted).

2021-08-03 Thread Xavier Simonart
This test sends requests to LB and checks that each server receives at least one request. However, even if 20 requests are sent to 3 servers, there was a possibility that one server did not get any request (0.3%). Signed-off-by: Xavier Simonart --- tests/system-ovn.at | 115 +

Re: [ovs-dev] [PATCH ovn v2 2/2] system-ovn.at: Fix flaky "load-balancing" test (all servers targetted).

2021-08-03 Thread 0-day Robot
Bleep bloop. Greetings Xavier Simonart, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has trailing whitespace #38 FILE: tests/system-ovn.at:1458: for i in `seq