Re: [ovs-dev] [PATCH] netdev-offload-dpdk: fix a crash in dump_flow_attr()

2021-08-10 Thread Sriharsha Basavapatna via dev
On Wed, Aug 11, 2021 at 6:21 AM Gaëtan Rivet wrote: > > On Wed, Aug 4, 2021, at 14:37, Sriharsha Basavapatna via dev wrote: > > In netdev_offload_dpdk_flow_create() when an offload request fails, > > dump_flow() is called to log a warning message. The 's_tnl' string > > in flow_patterns gets

[ovs-dev] [PATCH v2] conntrack: remove the nat_action_info from the conn

2021-08-10 Thread wenxu
From: wenxu Only 'nat_action_info->nat_action' is used for packet forwarding. Other items such as min/max_ip/port are used only when creating new connections. No need to store the whole nat_action_info in conn. Signed-off-by: wenxu Acked-by: Gaetan Rivet Acked-By Michael Santana --- v2:

Re: [ovs-dev] Execute the DPIF_OP_FLOW_PUT action after the slowpath packet is sent

2021-08-10 Thread 0-day Robot
Bleep bloop. Greetings liyang_12921, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (ofproto/ofproto-dpif-upcall.c). error: could not

[ovs-dev] Execute the DPIF_OP_FLOW_PUT action after the slowpath packet is sent

2021-08-10 Thread liyang_12921
We encountered a problem when using ovs to provide forwarding for vm. A process in the vm frequently uploads files to the NOS server, and the tcp sessons of uploading is often reset by NOS server. Through packet capture, we found that when the session is reset, the packets sent by the vm are

Re: [ovs-dev] [PATCH] netdev-offload-dpdk: fix a crash in dump_flow_attr()

2021-08-10 Thread Gaëtan Rivet
On Wed, Aug 4, 2021, at 14:37, Sriharsha Basavapatna via dev wrote: > In netdev_offload_dpdk_flow_create() when an offload request fails, > dump_flow() is called to log a warning message. The 's_tnl' string > in flow_patterns gets initialized in vport_to_rte_tunnel() conditionally > via

Re: [ovs-dev] [PATCH] conntrack: remove the nat_action_info from the conn

2021-08-10 Thread Gaëtan Rivet
On Thu, Aug 5, 2021, at 05:11, we...@ucloud.cn wrote: > From: wenxu Hi Wenxu, A few nits in the commit log, otherwise the change looks good to me. > > Only the nat_action in the nat_action_info is used for conn > packet forward and other item such as min/max_ip/port only > used for the new

[ovs-dev] [PATCH 1/1] include/openvswitch/compiler.h: check existence of __builtin_prefetch using __has_builtin

2021-08-10 Thread Sergey Madaminov
Checking if '__has_builtin' is defined and then defining OVS_PREFETCH to be '__builtin_prefetch' if it is available. To preserve backwards compatibility, the previous way to define OVS_PREFETCH macro is also there. Signed-off-by: Sergey Madaminov --- include/openvswitch/compiler.h | 25

[ovs-dev] [PATCH 0/1] include/openvswitch/compiler.h: check existence of __builtin_prefetch using __has_builtin

2021-08-10 Thread Sergey Madaminov
Currently, '__builtin_prefetch' is defined for OVS_PREFETCH macro only if '__GNUC__' is defined. However, it would make sense to use a '__has_builtin' preprocessor operator to check if '__builtin_prefetch' is available and then define the OVS_PREFETCH macro. Doing so will allow to use prefetching

Re: [ovs-dev] [PATCH v7] ovsdb: provide raft and command interfaces with priority

2021-08-10 Thread Ilya Maximets
On 7/27/21 10:21 AM, anton.iva...@cambridgegreys.com wrote: > From: Anton Ivanov > > Set a soft time limit of "raft election timer"/2 on ovsdb > processing. > > This improves behaviour in large heavily loaded clusters. > While it cannot fully eliminate spurious raft elections > under heavy

Re: [ovs-dev] [PATCH RFC 0/1] use meson and ninja as a build system for ovs

2021-08-10 Thread Ilya Maximets
On 8/10/21 4:43 PM, Van Haaren, Harry wrote: >> -Original Message- >> From: dev On Behalf Of William Tu >> Sent: Tuesday, August 10, 2021 1:00 AM >> To: Ilya Maximets >> Cc: ; Sergey Madaminov >> >> Subject: Re: [ovs-dev] [PATCH RFC 0/1] use meson and ninja as a build system >> for

[ovs-dev] [PATCH] checkpatch: check if some tags are wrongly written

2021-08-10 Thread Timothy Redaelli
Currently, there are some patches with the tags wrongly written (with space instead of dash ) and this may prevent some automatic system or CI to detect them correctly. This commit adds a check in checkpatch to be sure the tag is written correctly with dash and not with space. The tags supported

Re: [ovs-dev] [RFC PATCH ovn 0/4] Use Distributed Gateway Port for ovn-controller scalability.

2021-08-10 Thread Mark Gray
On 03/08/2021 19:33, Han Zhou wrote: > On Tue, Aug 3, 2021 at 11:09 AM Numan Siddique wrote: >> >> On Fri, Jul 30, 2021 at 3:22 AM Han Zhou wrote: >>> >>> Note: This patch series is on top of a pending patch that is still under >>> review: >

Re: [ovs-dev] [ovn] Need advice for multiple routing tables support in LR

2021-08-10 Thread Numan Siddique
On Tue, Aug 10, 2021 at 12:22 PM Vladislav Odintsov wrote: > > Thanks Numan for your help! > > I’ve sent patch, which fixes documentation: > https://patchwork.ozlabs.org/project/ovn/patch/20210810161537.71692-1-odiv...@gmail.com/ > > Since lr_in_defrag stage first writes xxreg0 register only in

Re: [ovs-dev] [ovn] Need advice for multiple routing tables support in LR

2021-08-10 Thread Vladislav Odintsov
Thanks Numan for your help! I’ve sent patch, which fixes documentation: https://patchwork.ozlabs.org/project/ovn/patch/20210810161537.71692-1-odiv...@gmail.com/ Since lr_in_defrag stage first writes xxreg0 register only in master branch after

[ovs-dev] [PATCH ovn] northd: fix xxreg{0, 1} registers usage description in router pipeline

2021-08-10 Thread Vladislav Odintsov
XXREG0 and XXREG1 (128-bit registers), are currently used in router pipeline to store NEXT_HOP_IPV6 and SRC_IPV6 respectively. First time XXREG0 register is written - in stage lr_in_defrag. XXREG1 register is written first in lr_in_ip_routing. This patch updates documentation, where it was

Re: [ovs-dev] [ovn] Need advice for multiple routing tables support in LR

2021-08-10 Thread Numan Siddique
On Tue, Aug 10, 2021 at 8:00 AM Vladislav Odintsov wrote: > > Hi Numan, > > thanks for the answer. > > You said that it’s possible to use reg2-reg7 for ipv4. > I’ve checked usage of xxreg0 and xxreg1 to find out where they’re used in > router pipeline. > > In ovn-northd.c it’s written that those

Re: [ovs-dev] [PATCH RFC 0/1] use meson and ninja as a build system for ovs

2021-08-10 Thread Van Haaren, Harry
> -Original Message- > From: dev On Behalf Of William Tu > Sent: Tuesday, August 10, 2021 1:00 AM > To: Ilya Maximets > Cc: ; Sergey Madaminov > > Subject: Re: [ovs-dev] [PATCH RFC 0/1] use meson and ninja as a build system > for ovs > > Hi Ilya, > > Thanks for your feedback! > > >

Re: [ovs-dev] [PATCH] conntrack: remove the nat_action_info from the conn

2021-08-10 Thread Michael Santana
On Mon, Aug 9, 2021 at 11:41 PM wenxu wrote: > > > > > > > > > From: Michael Santana > Date: 2021-08-09 23:17:06 > To: we...@ucloud.cn > Cc: b...@ovn.org,Ilya Maximets > ,dlu...@gmail.com,d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] conntrack: remove the nat_action_info from the >

Re: [ovs-dev] [PATCH] netlink-socket: Log extack error messages in netlink transactions.

2021-08-10 Thread Paolo Valerio
Hi Marcelo, thanks for your feedback. Marcelo Ricardo Leitner writes: > Hi, > > On Thu, Aug 05, 2021 at 11:55:51PM +0200, Paolo Valerio wrote: > > Now that you put these two together: > >> As an example, with this patch applied, the following generic message: >> >>

[ovs-dev] [PATCH v2] Documentation: Cleanup PMD information.

2021-08-10 Thread Kevin Traynor
The 'Port/Rx Queue Assigment to PMD Threads' section has expanded over time and now includes info about stats/commands, manual pinning and different options for OVS assigning Rxqs to PMDs. Split them into different sections with sub-headings and move the two similar paragraphs about stats

Re: [ovs-dev] [PATCH] Documentation: Cleanup PMD information.

2021-08-10 Thread Kevin Traynor
On 05/08/2021 09:32, Adrian Moreno wrote: > > On 7/22/21 3:25 PM, Kevin Traynor wrote: >> The 'Port/Rx Queue Assigment to PMD Threads' section has >> expanded over time and now includes info about stats/commands, >> manual pinning and different options for OVS assigning Rxqs to >> PMDs. >> >>

Re: [ovs-dev] [ovn] Need advice for multiple routing tables support in LR

2021-08-10 Thread Vladislav Odintsov
Hi Numan, thanks for the answer. You said that it’s possible to use reg2-reg7 for ipv4. I’ve checked usage of xxreg0 and xxreg1 to find out where they’re used in router pipeline. In ovn-northd.c it’s written that those ipv6-related registers are used in >= IP_INPUT. Am I right, its about

Re: [ovs-dev] [PATCH] dpcls: fix build on compilers without AVX512-VPOPCNT

2021-08-10 Thread Stokes, Ian
> > This commit adds extra checks around the AVX-512 vpopcnt instruction > > enabling, ensuring that in the function where the ISA is enabled the > > compiler has also indicated its support for the ISA. This is achieved > > by checking the __AVX512VPOPCNTDQ__ define, which the compiler sets if > >

Re: [ovs-dev] [PATCH] dpcls: fix build on compilers without AVX512-VPOPCNT

2021-08-10 Thread Stokes, Ian
> On 8/10/21 12:11 PM, Stokes, Ian wrote: > >>> -Original Message- > >>> From: Van Haaren, Harry > >>> Sent: Thursday, July 29, 2021 5:55 PM > >>> To: ovs-dev@openvswitch.org > >>> Cc: Stokes, Ian ; Van Haaren, Harry > >>> > >>> Subject: [PATCH] dpcls: fix build on compilers without

Re: [ovs-dev] [PATCH] dpcls: fix build on compilers without AVX512-VPOPCNT

2021-08-10 Thread Ilya Maximets
On 8/10/21 12:11 PM, Stokes, Ian wrote: >>> -Original Message- >>> From: Van Haaren, Harry >>> Sent: Thursday, July 29, 2021 5:55 PM >>> To: ovs-dev@openvswitch.org >>> Cc: Stokes, Ian ; Van Haaren, Harry >>> >>> Subject: [PATCH] dpcls: fix build on compilers without AVX512-VPOPCNT >>>

Re: [ovs-dev] [PATCH] dpcls: fix build on compilers without AVX512-VPOPCNT

2021-08-10 Thread Stokes, Ian
> > -Original Message- > > From: Van Haaren, Harry > > Sent: Thursday, July 29, 2021 5:55 PM > > To: ovs-dev@openvswitch.org > > Cc: Stokes, Ian ; Van Haaren, Harry > > > > Subject: [PATCH] dpcls: fix build on compilers without AVX512-VPOPCNT > > > > This commit adds extra checks around

Re: [ovs-dev] [PATCH] dpcls: fix build on compilers without AVX512-VPOPCNT

2021-08-10 Thread Van Haaren, Harry
> -Original Message- > From: Van Haaren, Harry > Sent: Thursday, July 29, 2021 5:55 PM > To: ovs-dev@openvswitch.org > Cc: Stokes, Ian ; Van Haaren, Harry > > Subject: [PATCH] dpcls: fix build on compilers without AVX512-VPOPCNT > > This commit adds extra checks around the AVX-512