Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix extremely inefficient usage of lflow hash map.

2021-08-23 Thread Anton Ivanov
On 23/08/2021 22:36, Ilya Maximets wrote: On 8/23/21 10:37 PM, Anton Ivanov wrote: On 23/08/2021 21:26, Ilya Maximets wrote: On 8/23/21 10:20 PM, Anton Ivanov wrote: Should not be the case. The map is pre-sized for the size from the previous iterations. Line 12861 in my tree which is

Re: [ovs-dev] [PATCH ovn] controller: Don't allocate zone ids for non-VIF port bindings.

2021-08-23 Thread Numan Siddique
On Mon, Aug 23, 2021 at 11:26 AM Vladislav Odintsov wrote: > > Hi Numan, > thanks for the quick fix. This worked for me. > > Regards, > Vladislav Odintsov > > > On 23 Aug 2021, at 18:24, Vladislav Odintsov wrote: > > > > Tested-by: Vladislav Odintsov mailto:odiv...@gmail.com>> Thanks for

[ovs-dev] [PATCH v3 2/2] ovsdb-idl: Exclude missing tables and columns in the transaction.

2021-08-23 Thread numans
From: Numan Siddique In the cases where the C idl client is compiled with a newer schema and the ovsdb-server is running with older schema, the IDL clients can included tables or columns in the transaction which are missing in the server schema. ovsdb-server will reject the transaction, but the

[ovs-dev] [PATCH v3 1/2] ovsdb-idl : Add APIs to query if a table and a column is present or not.

2021-08-23 Thread numans
From: Numan Siddique This patch adds 2 new APIs in the ovsdb-idl client library - ovsdb_idl_has_table() and ovsdb_idl_has_column_in_table() to query if a table and a column is present in the IDL or not. This is required for scenarios where the server schema is old and missing a table or column

[ovs-dev] [PATCH v3 0/2] ovsdb-idl: Address missing table and column

2021-08-23 Thread numans
From: Numan Siddique This patch series addresses the transaction issues seen when the C IDL client is running compiled with newer schema and ovsdb-server is still running with older schema. Patch 1: Adds the API to query for table and column names. Patch 2: Addresses the transaction issues. v2

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix extremely inefficient usage of lflow hash map.

2021-08-23 Thread Ilya Maximets
On 8/23/21 10:37 PM, Anton Ivanov wrote: > On 23/08/2021 21:26, Ilya Maximets wrote: >> On 8/23/21 10:20 PM, Anton Ivanov wrote: >>> Should not be the case. >>> >>> The map is pre-sized for the size from the previous iterations. >>> >>> Line 12861 in my tree which is probably a few commits out of

[ovs-dev] [PATCH ovn v2] northd: Add VIP port to established flows in DNAT table for Load Balancers

2021-08-23 Thread Mark Gray
When adding a load balancer to a logical router, two flows are added to the ingress DNAT table. One flow is for established connections and one is for new connections. They have the following form: ct.est && ip4 && reg0 == 10.0.0.10 && ct_label.natted == 1 && tcp As the established flow does not

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix extremely inefficient usage of lflow hash map.

2021-08-23 Thread Anton Ivanov
On 23/08/2021 21:26, Ilya Maximets wrote: On 8/23/21 10:20 PM, Anton Ivanov wrote: Should not be the case. The map is pre-sized for the size from the previous iterations. Line 12861 in my tree which is probably a few commits out of date:     fast_hmap_size_for(, max_seen_lflow_size); And

Re: [ovs-dev] [PATCH ovn v4 5/5] controller: Improve ct zone handling.

2021-08-23 Thread Odintsov Vladislav
Numan, I think I found one more problem with incremental processing, but I’m not sure in which commit the problem was introduced. I met this problem between LR and Transi Switch using ovn-ic, but I’ve managed to emulate behaviour without need to setup ovn-ic infrastructure. Problem comes when

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix extremely inefficient usage of lflow hash map.

2021-08-23 Thread Ilya Maximets
On 8/23/21 10:20 PM, Anton Ivanov wrote: > Should not be the case. > > The map is pre-sized for the size from the previous iterations. > > Line 12861 in my tree which is probably a few commits out of date: > >     fast_hmap_size_for(, max_seen_lflow_size); > > And immediately after building

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix extremely inefficient usage of lflow hash map.

2021-08-23 Thread Anton Ivanov
Should not be the case. The map is pre-sized for the size from the previous iterations. Line 12861 in my tree which is probably a few commits out of date:     fast_hmap_size_for(, max_seen_lflow_size); And immediately after building the lflows:     if (hmap_count() > max_seen_lflow_size) {   

[ovs-dev] [PATCH ovn] ovn-northd: Fix extremely inefficient usage of lflow hash map.

2021-08-23 Thread Ilya Maximets
'lflow_map' is never expanded because northd always uses fast insertion. This leads to the case where we have a hash map with only 128 initial buckets and every ovn_lflow_find() ends up iterating over n_lflows / 128 entries. It's thousands of logical flows or even more. For example, it takes

Re: [ovs-dev] [PATCH ovn 0/3] Add multiple routing tables support to Logical Routers

2021-08-23 Thread Odintsov Vladislav
Hi, I’m wonder if this patch series is interesting for the project. Should I wait for review or what is the process to add new functionality? Thanks. Regards, Vladislav Odintsov On 17 Aug 2021, at 00:15, Vladislav Odintsov mailto:odiv...@gmail.com>> wrote: This patch series extends Logical

[ovs-dev] [PATCH] rhel: Fix dual kernel rpm install for RHEL 8.4

2021-08-23 Thread Greg Rose
RHEL 8.4 is the first of the RHEL 8.x kernels that has broken ABI so it requires the same sort of fix as we did for several RHEL 7.x kernel that needed two kernel rpms to work for all minor revisions of the baseline kernel module. Signed-off-by: Greg Rose ---

Re: [ovs-dev] [PATCH] ovsdb-idl : Add APIs to query if a table and a column is present or not.

2021-08-23 Thread Numan Siddique
On Fri, Aug 20, 2021 at 1:49 PM Numan Siddique wrote: > > On Fri, Aug 20, 2021 at 12:43 PM Ben Pfaff wrote: > > > > On Wed, Aug 18, 2021 at 08:42:47PM -0400, num...@ovn.org wrote: > > > From: Numan Siddique > > > > > > This patch adds 2 new APIs in the ovsdb-idl client library > > > -

[ovs-dev] [PATCH v2 4/6] netdev-offload-dpdk: Support multiple local destinations

2021-08-23 Thread Salem Sol via dev
From: Noa Levy Add support for offloading multiple local destinations using rte_flow_action_sample with ratio 1. Co-authored-by: Salem Sol Signed-off-by: Noa Levy Signed-off-by: Salem Sol --- NEWS | 1 + lib/netdev-offload-dpdk.c | 77

[ovs-dev] [PATCH v2 5/6] netdev-offload-dpdk: Extract raw_encap and output netdev by parse_clone_actions

2021-08-23 Thread Salem Sol via dev
From: Noa Levy Extract the raw_encap and the output netdev of cloned actions as a pre-step towards using them embedded in a sample action. Co-authored-by: Salem Sol Signed-off-by: Noa Levy Signed-off-by: Salem Sol --- lib/netdev-offload-dpdk.c | 39 +++ 1

[ovs-dev] [PATCH v2 6/6] netdev-offload-dpdk: Support multiple remote destinations

2021-08-23 Thread Salem Sol via dev
From: Noa Levy Add support for offloading multiple remote destinations by parsing the actions and adding remote destinations actions. Update dump_flow_action in order to support tunnel actions. Co-authored-by: Salem Sol Signed-off-by: Noa Levy Signed-off-by: Salem Sol --- NEWS

[ovs-dev] [PATCH v2 3/6] netdev-offload-dpdk: Introduce a dump_raw_encap helper function

2021-08-23 Thread Salem Sol via dev
From: Noa Levy Introduce a helper function as a pre-step towards supporting offload multiple remote destinations. Co-authored-by: Salem Sol Signed-off-by: Noa Levy Signed-off-by: Salem Sol --- lib/netdev-offload-dpdk.c | 28 +++- 1 file changed, 19 insertions(+), 9

[ovs-dev] [PATCH v2 1/6] netdev-offload-dpdk: Introduce a get_netdev_by_port helper function

2021-08-23 Thread Salem Sol via dev
From: Noa Levy Introduce a helper function to get the struct netdev * handle for the target output odp_port, given in the netlink actions, as a pre-step towards using it embedded in a sampled action. Co-authored-by: Salem Sol Signed-off-by: Noa Levy Signed-off-by: Salem Sol ---

[ovs-dev] [PATCH v2 2/6] netdev-offload-dpdk: Introduce a dump_port_id helper function

2021-08-23 Thread Salem Sol via dev
From: Noa Levy Introduce a helper function as a pre-step towards supporting offload multiple desinations. Signed-off-by: Noa Levy --- lib/netdev-offload-dpdk.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/lib/netdev-offload-dpdk.c

[ovs-dev] [PATCH v2 0/6] Adding support for multiple destinations

2021-08-23 Thread Salem Sol via dev
This series adds support offloading multiple "output"/"clone" actions within one datapath flow. Some cases which require sending a packet to multiple destinations is not currently offloaded, HWOL can be done by translating the fate actions "output" and "clone" into rte_flow_action_sample

Re: [ovs-dev] [PATCH ovn] controller: Don't allocate zone ids for non-VIF port bindings.

2021-08-23 Thread Vladislav Odintsov
Hi Numan, thanks for the quick fix. This worked for me. Regards, Vladislav Odintsov > On 23 Aug 2021, at 18:24, Vladislav Odintsov wrote: > > Tested-by: Vladislav Odintsov mailto:odiv...@gmail.com>> > > Regards, > Vladislav Odintsov > >> On 21 Aug 2021, at 07:58, num...@ovn.org

Re: [ovs-dev] [PATCH ovn] controller: Don't allocate zone ids for non-VIF port bindings.

2021-08-23 Thread Vladislav Odintsov
Tested-by: Vladislav Odintsov Regards, Vladislav Odintsov > On 21 Aug 2021, at 07:58, num...@ovn.org wrote: > > From: Numan Siddique > > The commit 6fb87aad8c3("controller: Improve ct zone handling.") > caused a regression. After this commit ovn-controller is allocating > zone id for non

Re: [ovs-dev] [PATCH v2] ipf: fix only nat the first fragment in the reass process

2021-08-23 Thread Aaron Conole
Ilya Maximets writes: > On 8/12/21 6:17 PM, Aaron Conole wrote: >> we...@ucloud.cn writes: >> >>> From: wenxu >>> >>> The ipf collect original fragment packets and reass a new pkt >>> to do the conntrack logic. After finsh the conntrack things >>> copy the ct meta info to each orignal packet

Re: [ovs-dev] [PATCH ovn v4 5/5] controller: Improve ct zone handling.

2021-08-23 Thread Numan Siddique
On Sat, Aug 21, 2021 at 4:11 AM Odintsov Vladislav wrote: > > Thanks Numan for the quick fix. > > Though you’ve already sent a patch, just in case info: > I was using a normal distributed router, LRP with no gateway chassis. > Codebase - master branch. Thanks. It would be great if you can test

Re: [ovs-dev] [PATCH ovn] northd: Add VIP port to established flows in DNAT table for Load Balancers

2021-08-23 Thread Mark Gray
On 20/08/2021 20:48, Mark Michelson wrote: > Hi Mark, > > One thing that is not addressed in the commit message is the change from > using reg0 to reg1 in some of the flows. For logical routers, > reg0/xxreg0 is the next hop address, and reg1/xxreg1 is the source IP. Thanks for the review.

Re: [ovs-dev] [PATCH v5 2/2] dpctl: dpif: allow viewing and configuring dp cache sizes

2021-08-23 Thread Eelco Chaudron
On 5 Aug 2021, at 21:47, Paolo Valerio wrote: > Eelco Chaudron writes: > >> This patch adds a general way of viewing/configuring datapath >> cache sizes. With an implementation for the netlink interface. >> >> The ovs-dpctl/ovs-appctl show commands will display the >> current cache sizes

[ovs-dev] [PATCH v1] system-dpdk: Add test-cases for set and get commands for DPCLS and DPIF

2021-08-23 Thread Kumar Amber
Added 2 separate test-cases for DPCLS and DPIF commands: OVS-DPDK unit-tests: 9: OVS-DPDK - DPIF Configuration 10: OVS-DPDK - DPCLS Configuration Also updated the validation docs for the same. Signed-off-by: Kumar Amber --- Documentation/topics/dpdk/bridge.rst | 14

Re: [ovs-dev] [PATCH] AUTHORS: Update Simon Horman

2021-08-23 Thread 0-day Robot
References: <20210823084053.13873-1-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected

[ovs-dev] [PATCH] AUTHORS: Update Simon Horman

2021-08-23 Thread Simon Horman
Some of Netronome's activities and people have moved over to Corigine, including OVS development and myself. Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- .mailmap| 3 ++- AUTHORS.rst | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.mailmap b/.mailmap