On 8/28/21 2:44 AM, Numan Siddique wrote:
> On Fri, Aug 27, 2021 at 8:06 PM Mark Michelson wrote:
>>
>> Thank you both for the quick reviews. I pushed the change to master.
Thanks Mark, Numan, and Flavio for fixing this and sorry for introducing
the issues in the first place.
>
> Would this req
On 27/08/2021 19:03, Ilya Maximets wrote:
> On 8/27/21 7:05 PM, Mark Gray wrote:
>> On 27/08/2021 16:24, Ilya Maximets wrote:
>>> It's common for CMS (e.g., ovn-kubernetes) to create 3 identical load
>>> balancers, one per protocol (tcp, udp, sctp). However, if VIPs of
>>> these load balancers has
Replace strcmp() with strncmp(), because the strcmp() function requires that
the two strings are exactly the same.
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 45a96b9be..4cf372b7a 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -963,7 +963,8 @@ dpdk_eth_dev_port_config(str
Bleep bloop. Greetings liyang_12921, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: patch failed: lib/netdev-dpdk.c:963
error: lib/netdev-dpdk.c: patch does not apply
error: Di
From a3a7693c02d383ce9cab3c1a54ade6274bbb6dec Mon Sep 17 00:00:00 2001
From: liyang_12921
Date: Mon, 30 Aug 2021 17:41:56 +0800
Subject: [PATCH] netdev-dpdk: Fix comparing virtio driver name
---
lib/netdev-dpdk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-
In the future, virtio may support RSS.
In any case, it is safer to rely on exposed capabilities rather than
matching on driver names.
Signed-off-by: David Marchand
---
lib/netdev-dpdk.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netd
On 27/08/2021 18:56, Mark Michelson wrote:
> Hi Mark,
>
> I had a look at this series, but I'm not 100% sure what the intent is.
> In patch 2, you mentioned modularity and the ability to include northd
> as a library. But I'm not sure where that allows us to go. Can you
> elaborate a bit?
Than
On Mon, Aug 30, 2021 at 11:23 AM liyang_12921 wrote:
>
> Replace strcmp() with strncmp(), because the strcmp() function requires that
> the two strings are exactly the same.
What was exactly the issue, is this because you were trying to use
net_virtio_user ports?
If so, could you have a try wit
On 8/24/21 9:00 PM, Ilya Maximets wrote:
> Introducing a new json type JSON_SERIALIZED_OBJECT. It's not an
> actual type that can be seen in a json message on a wire, but
> internal type that is intended to hold a serialized version of
> some other json object. For this reason it's defined after
On 8/24/21 9:00 PM, Ilya Maximets wrote:
> Raft log entries (and raft database snapshot) contains json objects
> of the data. Follower receives append requests with data that gets
> parsed and added to the raft log. Leader receives execution requests,
> parses data out of them and adds to the log
On 8/24/21 9:00 PM, Ilya Maximets wrote:
> Same json from a json cache is typically sent to all the clients,
> e.g., in case of OVN deployment with ovn-monitor-all=true.
>
> There could be hundreds or thousands connected clients and ovsdb
> will serialize the same json object for each of them befo
On 8/24/21 9:00 PM, Ilya Maximets wrote:
> In short, database snapshot stored inside the raft module is
> a huge json object. E.g. in ovn-heater scale tests with 270 MB
> on-disk Southbound DB, json object of a snapshot takes 1.6 GB of
> RAM out of total 3.8 GB of the RSS of an ovsdb-server proces
On 8/30/21 12:54 PM, Dumitru Ceara wrote:
> On 8/24/21 9:00 PM, Ilya Maximets wrote:
>> Same json from a json cache is typically sent to all the clients,
>> e.g., in case of OVN deployment with ovn-monitor-all=true.
>>
>> There could be hundreds or thousands connected clients and ovsdb
>> will seri
On 8/26/21 7:31 AM, Anton Ivanov wrote:
> On 25/08/2021 22:12, Ilya Maximets wrote:
>> On 8/25/21 5:17 PM, anton.iva...@cambridgegreys.com wrote:
>>> From: Anton Ivanov
>>>
>>> A JSON object sort order is by definition arbitrary. OVS
>>> parser(s) do not care about object order - the result is
>>>
On 8/30/21 1:23 PM, Ilya Maximets wrote:
> On 8/30/21 12:54 PM, Dumitru Ceara wrote:
>> On 8/24/21 9:00 PM, Ilya Maximets wrote:
>>> Same json from a json cache is typically sent to all the clients,
>>> e.g., in case of OVN deployment with ovn-monitor-all=true.
>>>
>>> There could be hundreds or th
On 8/26/21 4:31 AM, Numan Siddique wrote:
> On Tue, Aug 24, 2021 at 5:07 PM Ilya Maximets wrote:
>>
>> Current string serialization code puts all characters one by one.
>> This is slow because dynamic string needs to perform length checks
>> on every ds_put_char() and it's also doesn't allow compi
Yes, my net_virtio_user port cannot be created with error message is
"dpdk|ERR|virtio_dev_configure(): Unsupported Rx multi queue mode 1".
I verified your patch a moment ago and it works great.Obviously, your method is
more reliable than comparing virtio driver name.
Thanks.
| |
liyang_1292
From: Martin Varghese
The encap & decap actions are extended to support MPLS packet type.
Encap & decap actions adds and removes MPLS header at start of the
packet.
The existing PUSH MPLS & POP MPLS actions inserts & removes MPLS
header between ethernet header and the IP header. Though this beha
On Fri, Aug 27, 2021 at 9:30 PM Ilya Maximets wrote:
>
> On 8/27/21 12:56 AM, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > This patch adds 2 new APIs in the ovsdb-idl client library
> > - ovsdb_idl_server_has_table() and ovsdb_idl_server_has_column() to
> > query if a table and a colum
There are options for that.
Debug mode should never be a default.
On 30 August 2021 12:29:16 BST, Ilya Maximets wrote:
>On 8/26/21 7:31 AM, Anton Ivanov wrote:
>> On 25/08/2021 22:12, Ilya Maximets wrote:
>>> On 8/25/21 5:17 PM, anton.iva...@cambridgegreys.com wrote:
From: Anton Ivanov
>>
On Fri, Aug 27, 2021 at 12:10 PM Mark Michelson wrote:
>
> Hi Mark, looks good to me.
>
> Acked-by: Mark Michelson
Thanks. I applied this patch to the main branch.
Numan
>
> On 8/20/21 4:14 AM, Mark Gray wrote:
> > In order to debug northd, add the following stopwatches to help
> > determine
On Mon, Aug 16, 2021 at 5:15 PM Vladislav Odintsov wrote:
>
> Some tests which check logical flows were checking exact match for
> output. E.g.:
> table=12(lr_in_ip_routing ) ...
>
> This makes harder to add new tables in LR pipeline since in this
> case one have to update test, which are not re
Small optimization in routes advertizement code.
Instead of iterating over all routes and checking for
needed transit_switch and availability_zone, use
ovsdb_index built with appropriate fields.
Signed-off-by: Vladislav Odintsov
---
ic/ovn-ic.c | 22 ++
1 file changed, 14 ins
On 8/30/21 6:14 AM, Mark Gray wrote:
On 27/08/2021 18:56, Mark Michelson wrote:
Hi Mark,
I had a look at this series, but I'm not 100% sure what the intent is.
In patch 2, you mentioned modularity and the ability to include northd
as a library. But I'm not sure where that allows us to go. Can y
On 30/08/2021 20:27, Mark Michelson wrote:
> On 8/30/21 6:14 AM, Mark Gray wrote:
>> On 27/08/2021 18:56, Mark Michelson wrote:
>>> Hi Mark,
>>>
>>> I had a look at this series, but I'm not 100% sure what the intent is.
>>> In patch 2, you mentioned modularity and the ability to include northd
>>>
Prior to this commit ovn_db_run() function in ovn-ic
was called right after daemon's lock was acquired in SB DB.
Inside ovn_db_run() there is a search for availability zone
in NB DB. If AZ was not found, ovn_db_run returned. So, it was
an implicit requirement for connected NB DB.
But in case, whe
On Tue, Aug 24, 2021 at 11:07:22PM +0200, Ilya Maximets wrote:
> +count = 0;
> +start = string;
> while ((c = *string++) != '\0') {
> -escape = chars_escaping[c];
> -while ((c2 = *escape++) != '\0') {
> -ds_put_char(ds, c2);
> +if (c >= ' ' && c != '
On Mon, Aug 16, 2021 at 5:15 PM Vladislav Odintsov wrote:
>
> This patch extends Logical Router's routing functionality.
> Now user may create multiple routing tables within a Logical Router
> and assign them to Logical Router Ports.
>
> Traffic coming from Logical Router Port with assigned route_
Hi Numan,
thanks for review.
While my answers are inline, I’ve got a counterquestion:
After I’ve submitted this patch series, I’ve added support for route tables in
OVN IC daemon.
Is it okay if I submit a new version with requested changes and support for
interconnection as well?
I know it’s up
On Mon, Aug 30, 2021 at 5:25 PM Vladislav Odintsov wrote:
>
> Hi Numan,
>
> thanks for review.
> While my answers are inline, I’ve got a counterquestion:
>
> After I’ve submitted this patch series, I’ve added support for route tables
> in OVN IC daemon.
> Is it okay if I submit a new version with
On Sun, Aug 29, 2021 at 10:56 PM Michael Santana wrote:
>
> On Fri, Aug 27, 2021 at 12:18 PM Mark Michelson wrote:
> >
> > Hi Frode,
> >
> > This looks good to me, so
> >
> > Acked-by: Mark Michelson
> Acked-by: Michael Santana
> >
> > I have one small nit below, but I don't think you need to s
On Fri, Aug 27, 2021 at 5:01 PM Numan Siddique wrote:
>
> On Fri, Aug 27, 2021 at 4:55 PM Mark Michelson wrote:
> >
> > Hi all,
> >
> > As a previous email of mine stated, we pushed the OVN 21.09 soft freeze
> > to 3 September. That is one week away. If you have patches you are
> > working on for
On Mon, Aug 30, 2021 at 5:48 PM Numan Siddique wrote:
>
> On Mon, Aug 30, 2021 at 5:25 PM Vladislav Odintsov wrote:
> >
> > Hi Numan,
> >
> > thanks for review.
> > While my answers are inline, I’ve got a counterquestion:
> >
> > After I’ve submitted this patch series, I’ve added support for rout
On Tue, Aug 24, 2021 at 12:00 PM Ilya Maximets wrote:
>
> Raft log entries (and raft database snapshot) contains json objects
> of the data. Follower receives append requests with data that gets
> parsed and added to the raft log. Leader receives execution requests,
> parses data out of them and
On Tue, Aug 24, 2021 at 12:00 PM Ilya Maximets wrote:
>
> Introducing a new json type JSON_SERIALIZED_OBJECT. It's not an
> actual type that can be seen in a json message on a wire, but
> internal type that is intended to hold a serialized version of
> some other json object. For this reason it'
On Tue, Aug 24, 2021 at 12:00 PM Ilya Maximets wrote:
>
> Same json from a json cache is typically sent to all the clients,
> e.g., in case of OVN deployment with ovn-monitor-all=true.
>
> There could be hundreds or thousands connected clients and ovsdb
> will serialize the same json object for ea
On Mon, Aug 30, 2021 at 3:55 PM Numan Siddique wrote:
>
> On Mon, Aug 30, 2021 at 5:48 PM Numan Siddique wrote:
> >
> > On Mon, Aug 30, 2021 at 5:25 PM Vladislav Odintsov
wrote:
> > >
> > > Hi Numan,
> > >
> > > thanks for review.
> > > While my answers are inline, I’ve got a counterquestion:
>
On Mon, Aug 30, 2021 at 12:01 PM Vladislav Odintsov
wrote:
>
> Small optimization in routes advertizement code.
> Instead of iterating over all routes and checking for
> needed transit_switch and availability_zone, use
> ovsdb_index built with appropriate fields.
>
> Signed-off-by: Vladislav Odint
Hi Han,
Using Router Policies for the purpose of routing makes impossible to use
filtering on the LR level (using Router Policies, not ACLs), because in that
case routing flows and filter flows would be in the same lr stage.
We offer to our customers ability to configure multiple routing tables,
39 matches
Mail list logo
