Re: [ovs-dev] [PATCH ovn v4 6/9] lib: Add infrastructure for plugging providers.

On Tue, Sep 14, 2021 at 10:49 PM Numan Siddique wrote: > > On Tue, Sep 14, 2021 at 4:48 PM Numan Siddique wrote: > > > > On Fri, Sep 3, 2021 at 3:29 PM Frode Nordahl > > wrote: > > > > > > New module contains the infrastructure for registering plugging > > > classes which may be hosted inside

Re: [ovs-dev] [PATCH v4 0/2] Encap & Decap actions for MPLS packet type

HI Eelco, I have sent the v5 couple of weeks back. In case if you have not noticed. Regards, Martin -Original Message- From: Martin Varghese Sent: Tuesday, June 15, 2021 9:32 AM To: Eelco Chaudron Cc: d...@openvswitch.org; pshe...@ovn.org; Varghese, Martin (Nokia - IN/Bangalore)

Re: [ovs-dev] [PATCH ovn v4 6/9] lib: Add infrastructure for plugging providers.

On Tue, Sep 14, 2021 at 4:48 PM Numan Siddique wrote: > > On Fri, Sep 3, 2021 at 3:29 PM Frode Nordahl > wrote: > > > > New module contains the infrastructure for registering plugging > > classes which may be hosted inside or outside the core OVN > > repository. The data structures and

Re: [ovs-dev] [PATCH ovn v4 6/9] lib: Add infrastructure for plugging providers.

On Fri, Sep 3, 2021 at 3:29 PM Frode Nordahl wrote: > > New module contains the infrastructure for registering plugging > classes which may be hosted inside or outside the core OVN > repository. The data structures and functions for interacting > with these plugging classes also live there. > >

Re: [ovs-dev] [PATCH] sflow functions: fix unused parameter warnings for sflow functions

Bleep bloop. Greetings Sergey Madaminov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Improper whitespace around control block #28 FILE: lib/sflow_agent.c:132: for(;

Re: [ovs-dev] [PATCH ovn] ci: ovn-kubernetes: Log ovn-kubernetes commit SHA.

On Thu, Sep 9, 2021 at 11:32 AM Dumitru Ceara wrote: > > This makes it easier to debug test failures. > > Signed-off-by: Dumitru Ceara Thanks. I applied this patch to the main branch. Numan > --- > .ci/ovn-kubernetes/Dockerfile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [ovs-dev] [PATCH v3 ovn] northd: reduce number of nd_na lb logical flows

On Tue, Sep 14, 2021 at 9:32 AM Mark Michelson wrote: > > It looks good to me, thanks Lorenzo. > > Acked-by: Mark Michelson Thanks Lorenzo and Mark for the reviews. I applied this patch to the main branch. Numan > > On 9/9/21 8:50 AM, Lorenzo Bianconi wrote: > > As it has been already done

[ovs-dev] [PATCH] sflow functions: fix unused parameter warnings for sflow functions

From: Sergey Madaminov Several 'sflow' functions (sfl_poller_tick, sfl_sampler_tick, and sfl_receiver_tick) have unused parameter 'now' in their signatures. This patch removes that parameter from their signatures to fix compilation warnings. Signed-off-by: Sergey Madaminov ---

Re: [ovs-dev] [PATCH ovn v2 1/6] ic: remove port_binding on ts deletion

Hi Numan, yes, you’re correct. Regards, Vladislav Odintsov > On 14 Sep 2021, at 21:41, Numan Siddique wrote: > > On Fri, Sep 3, 2021 at 6:35 AM Vladislav Odintsov > wrote: >> >> When IC port_binding exists and transit switch is deleted, >> the orphan port_binding

Re: [ovs-dev] [PATCH ovn v2 6/6] Update Authors list

On Fri, Sep 3, 2021 at 6:36 AM Vladislav Odintsov wrote: > > Signed-off-by: Vladislav Odintsov > --- Thanks. I applied this patch (6) to the main branch. Numan > AUTHORS.rst | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/AUTHORS.rst b/AUTHORS.rst > index 3f93874a3..e03c6b407

Re: [ovs-dev] [PATCH ovn v2 3/6] tests: remove strict check for table=N for N > 9

On Fri, Sep 3, 2021 at 6:35 AM Vladislav Odintsov wrote: > > Previously patch [1] with same summary was submitted, > but it was applied lated then a new feature in commit > [2] was accepted. > There was added a new test, which also checks exact > logical flow table number. > > This commit

Re: [ovs-dev] [PATCH ovn v2 1/6] ic: remove port_binding on ts deletion

On Fri, Sep 3, 2021 at 6:35 AM Vladislav Odintsov wrote: > > When IC port_binding exists and transit switch is deleted, > the orphan port_binding if left in the IC_SB_DB. > > This patch fixes such situation and adds test for this case. > > Signed-off-by: Vladislav Odintsov This patch is already

Re: [ovs-dev] [PATCH ovn v4 5/7] northd: Add n_nat_entries field to 'struct ovn_datapath'

On 13/09/2021 21:41, Mark Michelson wrote: > Hi Mark, > > Of all the patches in this series, this is the one I am least sure about. Thanks for looking over these. > > It seems simple enough, but it's not clear to me > > 1) Why would the number of nat entries on an ovn_datapath differ from >

Re: [ovs-dev] [PATCH ovn v2 4/6] northd, utils: support for RouteTables in LRs

On Fri, Sep 3, 2021 at 6:35 AM Vladislav Odintsov wrote: > > Signed-off-by: Vladislav Odintsov Hi Vladislav, Please see below for few comments. Otherwise the patch LGTM. Thanks Numan > --- > northd/ovn-northd.8.xml | 63 -- > northd/ovn-northd.c | 198 +++--- >

Re: [ovs-dev] [PATCH v3 ovn] northd: reduce number of nd_na lb logical flows

It looks good to me, thanks Lorenzo. Acked-by: Mark Michelson On 9/9/21 8:50 AM, Lorenzo Bianconi wrote: As it has been already done for IPv4, collapse IPv6 Neighbour Advertisment flows for load balancer using address list and reduce the number of logical flows from N*M to N where N is the

Re: [ovs-dev] [PATCH] ovsdb-idl: Send "set_db_change_aware" before "monitor_cond_since".

Hi Ilya, Thanks for your patch! When I merge it into my project, it works to clear the error message. Looking forward for your final version in the community. Best Regards! Gang Chen > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@ovn.org] > Sent: Wednesday, September 8,

[ovs-dev] [PATCH 0/4] netdev datapath hardware offload support for GRE flows

Add hardware offload support for GRE flows (experimental). Available only if DPDK experimantal APIs enabled during the build. CI result : https://github.com/nanteby/ovs/actions/runs/1229743991 Nir Anteby (4): netdev-offload-dpdk: Refactor get_vport_netdev() netdev-dpdk: Add flow_api support

Re: [ovs-dev] [PATCH 0/4] netdev datapath hardware offload support for GRE flows

CI result : https://github.com/nanteby/ovs/actions/runs/1229743991 -Original Message- From: Nir Anteby Sent: Tuesday, September 14, 2021 11:05 AM To: d...@openvswitch.org Cc: Eli Britstein ; Majd Dibbiny ; Gaetan Rivet ; Nir Anteby Subject: [PATCH 0/4] netdev datapath hardware

[ovs-dev] [PATCH 1/4] netdev-offload-dpdk: Refactor get_vport_netdev()

Refactor the function as a pre-step towards supporting more tunnel types. Signed-off-by: Nir Anteby --- lib/netdev-offload-dpdk.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index

[ovs-dev] [PATCH 4/4] netdev-offload-dpdk: Add support for matching on gre fields

Add parsing gre match fields. Signed-off-by: Nir Anteby --- NEWS | 2 + lib/netdev-offload-dpdk.c | 96 +++ 2 files changed, 98 insertions(+) diff --git a/NEWS b/NEWS index 1f2adf7..35b71f8 100644 --- a/NEWS +++ b/NEWS @@ -8,6

[ovs-dev] [PATCH 3/4] netdev-offload-dpdk: Support tnl_pop for gre tunnel

Add support for tnl_pop action for gre vport. Signed-off-by: Nir Anteby --- lib/netdev-offload-dpdk.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index c831471..d15302a 100644 --- a/lib/netdev-offload-dpdk.c +++

[ovs-dev] [PATCH 2/4] netdev-dpdk: Add flow_api support for netdev gre vports

Add the acceptance of GRE devices to netdev_dpdk_flow_api_supported() API, to allow offloading of DPDK GRE devices. Signed-off-by: Nir Anteby --- lib/netdev-dpdk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 45a96b9..80cba39

[ovs-dev] [PATCH 0/4] netdev datapath hardware offload support for GRE flows

Add hardware offload support for GRE flows (experimental). Available only if DPDK experimantal APIs enabled during the build. Nir Anteby (4): netdev-offload-dpdk: Refactor get_vport_netdev() netdev-dpdk: Add flow_api support for netdev gre vports netdev-offload-dpdk: Support tnl_pop for gre