Re: [ovs-dev] [PATCH 0/4] dpif-netdev: rxq auto-lb improvements

2021-09-16 Thread Anurag Agarwal via dev
Thanks Ilya for your email. Except for one patch, all the others are superseded by the patchset posted by Kevin. Outstanding patch that should be applicable is the following one: [ovs-dev] [PATCH 4/4] dpif-netdev: Allow cross-NUMA polling on selected ports https://mail.openvswitch.org/pipermai

Re: [ovs-dev] [PATCH ovn 2/2] Update the probe interval in main loop.

2021-09-16 Thread 0-day Robot
Bleep bloop. Greetings Zhen Wang, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 85 characters long (recommended limit is 79) #107 FILE: northd/ovn-northd.c:932:

[ovs-dev] [PATCH ovn 2/2] Update the probe interval in main loop.

2021-09-16 Thread Zhen Wang via dev
From: zhen wang When ovn-northd work in HA mode, ovn-northd will not update the probe interval in standby mode. This patch address the problem by updating the value in main loop. Signed-off-by: zhen wang --- northd/northd.c | 25 - northd/ovn-northd.c | 29 +

[ovs-dev] [PATCH ovn 1/2] Revert "northd: Don't poll ovsdb before the connection is fully established"

2021-09-16 Thread Zhen Wang via dev
From: zhen wang This reverts commit 1e59feea933610b28fd4442243162ce35595cfee. Above commit introduced a bug when muptiple ovn-northd instances work in HA mode. If SB leader and active ovn-northd instance got killed by system power outage, standby ovn-northd instance would never detect the failure

Re: [ovs-dev] [PATCH ovn v4 8/9] binding: Consider plugging of ports on CMS request.

2021-09-16 Thread Numan Siddique
On Fri, Sep 3, 2021 at 3:28 PM Frode Nordahl wrote: > > When OVN is linked with an appropriate plugging implementation, > CMS can request OVN to plug individual lports into the local > Open vSwitch instance. > > The port and instance record will be maintained during the lifetime > of the lport and

[ovs-dev] [PATCH v4 ovn] controller: add datapath meter capability check

2021-09-16 Thread Lorenzo Bianconi
Dump datapath meter capabilities before configuring meters in ovn-controller Signed-off-by: Lorenzo Bianconi --- Changes since v3: - add missing rconn_run_wait() and rconn_recv_wait() at the end of swconn for loop - cosmetics Changes since v2: - move meter capability logic in lib/features.c Cha

Re: [ovs-dev] [PATCH ovn v5 0/2] northd: Split northd

2021-09-16 Thread Numan Siddique
On Thu, Sep 16, 2021 at 3:06 PM Han Zhou wrote: > > Acked-by: Han Zhou Thanks Mark G (and Mark M and Han). I applied both the patches to the main branch. Numan > > On Thu, Sep 16, 2021 at 8:49 AM Mark Gray wrote: > > > These commits reorganise the northd code base in preparation for potentia

Re: [ovs-dev] [PATCH] ovsdb: transaction: Use diffs for strong reference counting.

2021-09-16 Thread Ilya Maximets
On 9/16/21 22:38, 0-day Robot wrote: > Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Inappropriate bracing around sta

Re: [ovs-dev] [PATCH] ovsdb: transaction: Use diffs for strong reference counting.

2021-09-16 Thread 0-day Robot
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #65 FILE: lib/ovsdb-data.c:2093: for (oi = n

[ovs-dev] [PATCH] ovsdb-data: Optimize union of sets.

2021-09-16 Thread Ilya Maximets
Current algorithm of ovsdb_datum_union looks like this: for-each atom in b: if not bin_search(a, atom): a[n++] = clone(atom) quicksort(a) So, the complexity looks like this: Nb * log2(Na) +Nb + (Na + Nb) * log2(Na + Nb) Comparisonsclones Compar

Re: [ovs-dev] [PATCH ovn v2 00/10] 3x performance improvement for ddlog with load balancer benchmark

2021-09-16 Thread Ben Pfaff
Thanks. I rebased and applied this series to master. On Mon, Sep 13, 2021 at 02:13:28PM -0400, Mark Michelson wrote: > Hi Ben, for the series: > > Acked-by: Mark Michelson > > I had a question on patch 1, but it's minor and otherwise shouldn't block an > ACK. > > On 9/7/21 6:45 PM, Ben Pfaff

[ovs-dev] [PATCH] ovsdb: transaction: Use diffs for strong reference counting.

2021-09-16 Thread Ilya Maximets
Currently, even if one reference added to the set of strong references or removed from it, ovsdb-server will walk through the whole set and re-count references to other rows. These referenced rows will also be added to the transaction in order to re-count their references. For example, every time

Re: [ovs-dev] [PATCH] igmp: always check and mask igmp packets.

2021-09-16 Thread Aaron Conole
Ilya Maximets writes: > On 9/15/21 21:04, Aaron Conole wrote: >> When OVS starts with default settings, it will have no existing datapath >> flows configured, and it will not explicitly handle IGMP packets. This >> means that all traffic will hit the datapath, and then follow the >> xlate_normal

Re: [ovs-dev] [PATCH v2] acinclude: Use standardized DPDK component defines.

2021-09-16 Thread David Marchand
On Thu, Sep 16, 2021 at 8:11 AM Sunil Pai G wrote: > > The DPDK component defines have been renamed from > RTE_LIBRTE_* to macro's of the form: > "RTE_" + + "_" + drivername > as documented in the commit [1]. Nit: for clarity, "in the DPDK commit [1]." > This commit replaces the old macro's wit

Re: [ovs-dev] [PATCH ovn v5 0/2] northd: Split northd

2021-09-16 Thread Han Zhou
Acked-by: Han Zhou On Thu, Sep 16, 2021 at 8:49 AM Mark Gray wrote: > These commits reorganise the northd code base in preparation for potential > inclusion > of I-P for northd. > > Please note that this mainly involves moving code around with minimal > code changes. However, due to tight coupl

Re: [ovs-dev] [PATCH ovn v4 3/9] controller: Make use of Port_Binding:requested_chassis

2021-09-16 Thread Frode Nordahl
On Thu, Sep 16, 2021 at 7:50 PM Numan Siddique wrote: > > On Thu, Sep 16, 2021 at 1:33 PM Frode Nordahl > wrote: > > > > On Thu, Sep 16, 2021 at 6:12 PM Numan Siddique wrote: > > > > > > On Fri, Sep 3, 2021 at 3:28 PM Frode Nordahl > > > wrote: > > > > > > > > Improve the efficiency of the requ

Re: [ovs-dev] [PATCH ovn v4 3/9] controller: Make use of Port_Binding:requested_chassis

2021-09-16 Thread Numan Siddique
On Thu, Sep 16, 2021 at 1:33 PM Frode Nordahl wrote: > > On Thu, Sep 16, 2021 at 6:12 PM Numan Siddique wrote: > > > > On Fri, Sep 3, 2021 at 3:28 PM Frode Nordahl > > wrote: > > > > > > Improve the efficiency of the requested-chassis feature by using > > > the new Southbound Port_Binding:reques

Re: [ovs-dev] [PATCH ovn v4 3/9] controller: Make use of Port_Binding:requested_chassis

2021-09-16 Thread Frode Nordahl
On Thu, Sep 16, 2021 at 6:12 PM Numan Siddique wrote: > > On Fri, Sep 3, 2021 at 3:28 PM Frode Nordahl > wrote: > > > > Improve the efficiency of the requested-chassis feature by using > > the new Southbound Port_Binding:requested_chassis column instead > > of each chassis performing option proce

[ovs-dev] [PATCH ovn] controller: configure only matching encaps between chassis

2021-09-16 Thread Vladislav Odintsov
Previously tunnels encap on a chassis was based on the remote chassis "best" encap type. Suppose we have 2 chassis: one with STT, another with GENEVE. In this case on chassis 1 there was configured STT tunnel, and GENEVE on another one. No traffic could be sent between these chassis. With this app

Re: [ovs-dev] [PATCH ovn v5 0/2] northd: Split northd

2021-09-16 Thread Mark Michelson
Acked-by: Mark Michelson I'm fine with getting this change in for 21.09 with the intent of expanding on I-P for upcoming releases. On 9/16/21 11:49 AM, Mark Gray wrote: These commits reorganise the northd code base in preparation for potential inclusion of I-P for northd. Please note that

Re: [ovs-dev] [PATCH ovn v4 3/9] controller: Make use of Port_Binding:requested_chassis

2021-09-16 Thread Numan Siddique
On Fri, Sep 3, 2021 at 3:28 PM Frode Nordahl wrote: > > Improve the efficiency of the requested-chassis feature by using > the new Southbound Port_Binding:requested_chassis column instead > of each chassis performing option processing and string comparison. > > Signed-off-by: Frode Nordahl I've

Re: [ovs-dev] [ovn] problem: long tcp session instantiation with stateful ACLs

2021-09-16 Thread Dumitru Ceara
On 9/16/21 4:18 PM, Vladislav Odintsov wrote: > Sorry, by OOT I meant non-inbox kmod. > I’ve tried to use inbox kernel module (from kernel package) and problem > resolved. > > Regards, > Vladislav Odintsov > >> On 16 Sep 2021, at 17:17, Vladislav Odintsov wrote: >> >> Hi Dumitru, >> >> I’ve tri

Re: [ovs-dev] [PATCH ovn v5 2/2] northd: Split northd.c

2021-09-16 Thread 0-day Robot
Bleep bloop. Greetings Mark Gray, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Improper whitespace around control block #1697 FILE: northd/ovn-northd.c:378: SBREC_DHCP

Re: [ovs-dev] [PATCH ovn v5 1/2] ovn-northd: Rename ovn-northd.c to northd.c

2021-09-16 Thread 0-day Robot
Bleep bloop. Greetings Mark Gray, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 117 characters long (recommended limit is 79) #31 FILE: Documentation/tutorials/ov

[ovs-dev] [PATCH ovn v5 2/2] northd: Split northd.c

2021-09-16 Thread Mark Gray
This commit splits northd into two parts. One part, ovn-northd.c, is responsible for the `ovn-northd` application, and the other is responsible for northd processing. This takes one step towards a more modular northd code base. Signed-off-by: Mark Gray --- northd/automake.mk |2 + northd/n

[ovs-dev] [PATCH ovn v5 1/2] ovn-northd: Rename ovn-northd.c to northd.c

2021-09-16 Thread Mark Gray
In order to seperate the northd processing logic from the ovn-northd application logic, rename ovn-northd. In this way, we can recreate ovn-northd.c with only the application logic. Signed-off-by: Mark Gray --- Documentation/tutorials/ovn-openstack.rst | 154 +++--- northd/automa

[ovs-dev] [PATCH ovn v5 0/2] northd: Split northd

2021-09-16 Thread Mark Gray
These commits reorganise the northd code base in preparation for potential inclusion of I-P for northd. Please note that this mainly involves moving code around with minimal code changes. However, due to tight coupling between ovn-northd.c and northd.c, some minor changes were needed. For referen

Re: [ovs-dev] [PATCH RFC dpdk-latest V2 0/1] Enable vhost async API's in OvS.

2021-09-16 Thread Hu, Jiayu
Hi Ilya, > -Original Message- > From: Ilya Maximets > Sent: Thursday, September 16, 2021 1:27 AM > To: Pai G, Sunil ; d...@openvswitch.org > Cc: Richardson, Bruce ; Mcnamara, John > ; maxime.coque...@redhat.com; Hu, Jiayu > ; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [PATCH RFC dpdk-lat

[ovs-dev] [PATCH] openvswitch: Fix condition check by using nla_ok()

2021-09-16 Thread Jiasheng Jiang
Just using 'rem > 0' might be unsafe, so it's better to use the nla_ok() instead. Because we can see from the nla_next() that '*remaining' might be smaller than 'totlen'. And nla_ok() will avoid it happening. Signed-off-by: Jiasheng Jiang --- net/openvswitch/actions.c | 2 +- 1 file changed, 1 i

[ovs-dev] [PATCH] openvswitch: Fix condition check by using nla_ok()

2021-09-16 Thread Jiasheng Jiang
Just using 'rem > 0' might be unsafe, so it's better to use the nla_ok() instead. Because we can see from the nla_next() that '*remaining' might be smaller than 'totlen'. And nla_ok() will avoid it happening. Signed-off-by: Jiasheng Jiang --- net/openvswitch/actions.c | 2 +- 1 file changed, 1 i

Re: [ovs-dev] [PATCH ovn v4 1/9] ovn-sb: Add requested_chassis column to Port_Binding.

2021-09-16 Thread Numan Siddique
On Fri, Sep 3, 2021 at 3:28 PM Frode Nordahl wrote: > > To allow for ovn-controller to efficiently process unbound ports > that may be destined to it, for example for use in the optional > plugging support, we add a new requested_chassis column with > weakRef to the Chassis table. The ovn-control

[ovs-dev] [PATCH v2] ovsdb-server: Log database transactions for user requested tables.

2021-09-16 Thread Dumitru Ceara
Add a new command, 'ovsdb-server/log-db-ops DB TABLE on|off', which allows the user to enable/disable transaction logging for specific databases and tables. By default, logging is disabled. Once enabled, logs are generated with level INFO and are also rate limited. If used with care, this comman

Re: [ovs-dev] [PATCH] ovsdb-server: Log database transactions for user requested tables.

2021-09-16 Thread 0-day Robot
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch' to see the failed p

[ovs-dev] [PATCH] ovsdb-server: Log database transactions for user requested tables.

2021-09-16 Thread Dumitru Ceara
Add a new command, 'ovsdb-server/log-db-ops DB TABLE on|off', which allows the user to enable/disable transaction logging for specific databases and tables. By default, logging is disabled. Once enabled, logs are generated with level INFO and are also rate limited. If used with care, this comman

Re: [ovs-dev] [PATCH] openvswitch: Fix condition check by using nla_ok()

2021-09-16 Thread Jakub Kicinski
On Thu, 16 Sep 2021 07:36:40 -0700 Jakub Kicinski wrote: > On Thu, 16 Sep 2021 01:43:23 + Jiasheng Jiang wrote: > > Just using 'rem > 0' might be unsafe, so it's better > > to use the nla_ok() instead. > > Because we can see from the nla_next() that > > '*remaining' might be smaller than 'totle

Re: [ovs-dev] [PATCH ovn v4 2/7] northd: Split northd.c

2021-09-16 Thread Numan Siddique
On Fri, Sep 3, 2021 at 8:24 AM Mark Gray wrote: > > This commit splits northd into two parts. One part, ovn-northd.c, > is responsible for the `ovn-northd` application, and the other is > responsible for northd processing. > > This takes one step towards a more modular northd code base. > > Signed

Re: [ovs-dev] [PATCH] openvswitch: Fix condition check by using nla_ok()

2021-09-16 Thread Jakub Kicinski
On Thu, 16 Sep 2021 01:43:23 + Jiasheng Jiang wrote: > Just using 'rem > 0' might be unsafe, so it's better > to use the nla_ok() instead. > Because we can see from the nla_next() that > '*remaining' might be smaller than 'totlen'. And nla_ok() > will avoid it happening. > > Signed-off-by: Jia

Re: [ovs-dev] [PATCH ovn v4 1/7] ovn-northd: Rename ovn-northd.c to northd.c

2021-09-16 Thread Numan Siddique
On Fri, Sep 3, 2021 at 8:22 AM Mark Gray wrote: > > In order to seperate the northd processing logic from the ovn-northd > application logic, rename ovn-northd. In this way, we can recreate > ovn-northd.c with only the application logic. > > Signed-off-by: Mark Gray Acked-by: Numan Siddique Th

Re: [ovs-dev] [PATCH ovn v4 7/7] northd: Add functionality to runtime node

2021-09-16 Thread Mark Gray
On 16/09/2021 08:08, Han Zhou wrote: > On Fri, Sep 3, 2021 at 5:22 AM Mark Gray wrote: >> Also, thanks to Han and Mark for reviewing! >> Update the runtime node to initialize and destroy some common data >> used by multiple functions in northd. > > Hi Mark, > > It looks good overall as an init

Re: [ovs-dev] [PATCH ovn v4 7/7] northd: Add functionality to runtime node

2021-09-16 Thread Mark Gray
On 16/09/2021 08:08, Han Zhou wrote: > On Fri, Sep 3, 2021 at 5:22 AM Mark Gray wrote: >> >> Update the runtime node to initialize and destroy some common data >> used by multiple functions in northd. > > Hi Mark, > > It looks good overall as an initiate step to employ the inc-proc engine for >

Re: [ovs-dev] [PATCH ovn v2 4/6] northd, utils: support for RouteTables in LRs

2021-09-16 Thread Numan Siddique
On Wed, Sep 15, 2021 at 8:36 PM Vladislav Odintsov wrote: > > Hi Numan, > > thanks for the suggestion. I’ll update patch with requested change. > Have you looked at ovn-ic changes? Should I wait for a review of that patch > and submit v3 after that? Sorry. I didn't get a chance. I was hoping H

Re: [ovs-dev] [ovn] problem: long tcp session instantiation with stateful ACLs

2021-09-16 Thread Vladislav Odintsov
Sorry, by OOT I meant non-inbox kmod. I’ve tried to use inbox kernel module (from kernel package) and problem resolved. Regards, Vladislav Odintsov > On 16 Sep 2021, at 17:17, Vladislav Odintsov wrote: > > Hi Dumitru, > > I’ve tried to exclude OOT OVS kernel module. > With OVN 20.06.3 + OVS 2

Re: [ovs-dev] [ovn] problem: long tcp session instantiation with stateful ACLs

2021-09-16 Thread Vladislav Odintsov
Hi Dumitru, I’ve tried to exclude OOT OVS kernel module. With OVN 20.06.3 + OVS 2.13.4 the problem solved. Could you please try with OOT kmod? For me it looks like a bug in OOT OVS kernel module code. Thanks. Regards, Vladislav Odintsov > On 16 Sep 2021, at 11:02, Dumitru Ceara wrote: > > O

Re: [ovs-dev] [PATCH v3 ovn] controller: add datapath meter capability check

2021-09-16 Thread Mark Gray
On 16/09/2021 14:46, Lorenzo Bianconi wrote: >> On 16/09/2021 04:42, Mark Michelson wrote: >>> Hi Lorenzo, I have some comments down below. >>> >> >> Thanks for your changes so far Lorenzo. > > Hi Mark, > > thx for the review > >> >>> On 9/9/21 7:27 PM, Lorenzo Bianconi wrote: Dump datapath

Re: [ovs-dev] [PATCH v3 ovn] controller: add datapath meter capability check

2021-09-16 Thread Lorenzo Bianconi
> On 16/09/2021 04:42, Mark Michelson wrote: > > Hi Lorenzo, I have some comments down below. > > > > Thanks for your changes so far Lorenzo. Hi Mark, thx for the review > > > On 9/9/21 7:27 PM, Lorenzo Bianconi wrote: > >> Dump datapath meter capabilities before configuring meters in > >> ovn

Re: [ovs-dev] [PATCH] igmp: always check and mask igmp packets.

2021-09-16 Thread Eelco Chaudron
On 16 Sep 2021, at 14:41, Aaron Conole wrote: > Eelco Chaudron writes: > >> Hi Aaron, >> >> >> I think this issue is related to the faulty patch introduced by Ben in 2018, >> which I just emailed about ;) >> >> https://mail.openvswitch.org/pipermail/ovs-dev/2021-September/387689.html > > Okay,

Re: [ovs-dev] [PATCH] igmp: always check and mask igmp packets.

2021-09-16 Thread Ilya Maximets
On 9/15/21 21:04, Aaron Conole wrote: > When OVS starts with default settings, it will have no existing datapath > flows configured, and it will not explicitly handle IGMP packets. This > means that all traffic will hit the datapath, and then follow the > xlate_normal processing path. > > Unfortu

[ovs-dev] [PATCH ovn] controller: add memory accounting for if_status_mgr module

2021-09-16 Thread Lorenzo Bianconi
Introduce memory accounting for data structures in ovn-controller if_status_mgr module. Signed-off-by: Lorenzo Bianconi --- controller/if-status.c | 23 +++ controller/if-status.h | 3 +++ controller/ovn-controller.c | 1 + 3 files changed, 27 insertions(+) diff

Re: [ovs-dev] [PATCH] cirrus: Reduce memory requirements for FreeBSD VMs.

2021-09-16 Thread Aaron Conole
Ilya Maximets writes: > According to memory usage graphs, our builds are using 3GB at most. > Reducing memory requirements to 4GB to have some room. This change > doesn't affect time needed to finish the build, but should have a > slight positive effect on scheduling time on a community cluster.

Re: [ovs-dev] [PATCH] igmp: always check and mask igmp packets.

2021-09-16 Thread Aaron Conole
Eelco Chaudron writes: > Hi Aaron, > > > I think this issue is related to the faulty patch introduced by Ben in 2018, > which I just emailed about ;) > > https://mail.openvswitch.org/pipermail/ovs-dev/2021-September/387689.html Okay, I'll take time to read through that. > > I also did some tes

Re: [ovs-dev] Build failure: attribute(target("avx512vpopcntdq")) is unknown

2021-09-16 Thread Ilya Maximets
On 9/16/21 13:46, Van Haaren, Harry wrote: >> -Original Message- >> From: Ilya Maximets >> Sent: Wednesday, September 15, 2021 1:08 PM >> To: ovs-dev ; Van Haaren, Harry >> ; Stokes, Ian ; Ferriter, >> Cian >> Cc: i.maxim...@ovn.org; Eelco Chaudron ; Flavio >> Leitner >> Subject: Build f

[ovs-dev] [PATCH] cirrus: Reduce memory requirements for FreeBSD VMs.

2021-09-16 Thread Ilya Maximets
According to memory usage graphs, our builds are using 3GB at most. Reducing memory requirements to 4GB to have some room. This change doesn't affect time needed to finish the build, but should have a slight positive effect on scheduling time on a community cluster. And it's also not cool from our

Re: [ovs-dev] Build failure: attribute(target("avx512vpopcntdq")) is unknown

2021-09-16 Thread Van Haaren, Harry
> -Original Message- > From: Ilya Maximets > Sent: Wednesday, September 15, 2021 1:08 PM > To: ovs-dev ; Van Haaren, Harry > ; Stokes, Ian ; Ferriter, > Cian > Cc: i.maxim...@ovn.org; Eelco Chaudron ; Flavio > Leitner > Subject: Build failure: attribute(target("avx512vpopcntdq")) is unkn

Re: [ovs-dev] [PATCH ovn] ovn-northd: Don't generate identical flows for same LBs with different protocol.

2021-09-16 Thread Ilya Maximets
On 9/16/21 07:28, Han Zhou wrote: > > > On Wed, Sep 1, 2021 at 5:42 AM Dumitru Ceara > wrote: >> >> Hi Ilya, >> >> On 8/27/21 5:24 PM, Ilya Maximets wrote: >> > It's common for CMS (e.g., ovn-kubernetes) to create 3 identical load >> > balancers, one per protocol (tcp,

Re: [ovs-dev] [PATCH ovn] ovn.at: Fix flaky test "controller I-P handling with monitoring disabled".

2021-09-16 Thread Xavier Simonart
Hi Mark Thanks for looking into this. Yes and no... I do not think that the patch itself will help, but it pointed me to the existence of Logical_Switch_Port.up, which in this case should do the trick. I will update the patch: instead of looking at the flows, I will use something like *wait_colu

Re: [ovs-dev] [PATCH v2] dpif-netlink: Fix feature negotiation for older kernels

2021-09-16 Thread Dumitru Ceara
On 9/16/21 12:04 PM, Mark Gray wrote: > On 16/09/2021 09:40, Dumitru Ceara wrote: >> On 9/15/21 5:08 PM, Mark Gray wrote: >>> Older kernels do not reject unsupported features. This can lead >>> to a situation in which 'ovs-vswitchd' believes that a feature is >>> supported when, in fact, it is not.

Re: [ovs-dev] [PATCH v2] dpif-netlink: Fix feature negotiation for older kernels

2021-09-16 Thread Mark Gray
On 16/09/2021 09:40, Dumitru Ceara wrote: > On 9/15/21 5:08 PM, Mark Gray wrote: >> Older kernels do not reject unsupported features. This can lead >> to a situation in which 'ovs-vswitchd' believes that a feature is >> supported when, in fact, it is not. >> >> This patch probes for this by attempt

Re: [ovs-dev] [PATCH] rconn: Add additional coverage counters rconn_run and rconn_retry

2021-09-16 Thread Mark Gray
On 15/09/2021 22:49, Ilya Maximets wrote: > On 7/29/21 16:22, Mark Gray wrote: >> Add counters to measure the number of times rconn_run() is >> executed and the number of times rconn_send() must retry >> due to an overflow at the vconn layer. >> >> These counters allow for more effective debugging

Re: [ovs-dev] [PATCH ovn] ovn.at: Fix flaky test "controller I-P handling with monitoring disabled".

2021-09-16 Thread Mark Gray
On 15/09/2021 09:52, Xavier Simonart wrote: > Test was waiting for port to be up in SBDB before checking number of flows Would this feature prevent this? 5c3371922994 ("if-status: Add OVS interface status management module.") > in OVS. However, there is no guarantee that all flows are installed

Re: [ovs-dev] [PATCH v3 ovn] controller: add datapath meter capability check

2021-09-16 Thread Mark Gray
On 16/09/2021 04:42, Mark Michelson wrote: > Hi Lorenzo, I have some comments down below. > Thanks for your changes so far Lorenzo. > On 9/9/21 7:27 PM, Lorenzo Bianconi wrote: >> Dump datapath meter capabilities before configuring meters in >> ovn-controller >> >> Signed-off-by: Lorenzo Bianconi

Re: [ovs-dev] [PATCH v2] dpif-netlink: Fix feature negotiation for older kernels

2021-09-16 Thread Dumitru Ceara
On 9/15/21 5:08 PM, Mark Gray wrote: > Older kernels do not reject unsupported features. This can lead > to a situation in which 'ovs-vswitchd' believes that a feature is > supported when, in fact, it is not. > > This patch probes for this by attempting to set a known unsupported > feature. > > R

[ovs-dev] [PATCH] system-offloads-traffic.at: Add sFlow offload test cases

2021-09-16 Thread Chris Mi via dev
Add two sFlow offload test caes: 3: sflow offloads with sampling=1 - ping between two ports - offloads enabled ok 4: sflow offloads with sampling=2 - ping between two ports - offloads enabled ok Signed-off-by: Chris Mi --- tests/system-offloads-traffic.at | 84

Re: [ovs-dev] [PATCH] igmp: always check and mask igmp packets.

2021-09-16 Thread Eelco Chaudron
Hi Aaron, I think this issue is related to the faulty patch introduced by Ben in 2018, which I just emailed about ;) https://mail.openvswitch.org/pipermail/ovs-dev/2021-September/387689.html I also did some tests and removing the faulty patch, as suggested, is solving your problem. Your patc

Re: [ovs-dev] [ovn] problem: long tcp session instantiation with stateful ACLs

2021-09-16 Thread Dumitru Ceara
On 9/16/21 2:50 AM, Vladislav Odintsov wrote: > Hi Dumitru, > > thanks for your reply. > > Regards, > Vladislav Odintsov > >> On 15 Sep 2021, at 11:24, Dumitru Ceara wrote: >> >> Hi Vladislav, >> >> On 9/13/21 6:14 PM, Vladislav Odintsov wrote: >>> Hi Numan, >>> >>> I’ve checked with OVS 2.16.0

Re: [ovs-dev] [PATCH ovn v4 7/7] northd: Add functionality to runtime node

2021-09-16 Thread Han Zhou
On Fri, Sep 3, 2021 at 5:22 AM Mark Gray wrote: > > Update the runtime node to initialize and destroy some common data > used by multiple functions in northd. Hi Mark, It looks good overall as an initiate step to employ the inc-proc engine for ovn-northd. It is great that it achieves the no-inpu