[ovs-dev] [PATCH ovn v4 0/4] Add multiple routing tables support to Logical Routers

2021-09-19 Thread Vladislav Odintsov
This patch series extends Logical Router's routing functionality. Now user may create multiple routing tables within a Logical Router and assign them to Logical Router Ports. Traffic coming from Logical Router Port with assigned route_table is checked against global routes if any (Logical_Router_S

[ovs-dev] [PATCH ovn v4 4/4] ic: don't learn routes which have local GW

2021-09-19 Thread Vladislav Odintsov
In case we have ovn-ic-interconnected Logical_Routers and install same ip_prefix route with GW in local AZ in each LR in each AZ, this route would be learned in other AZs and L3 loop is possible. There could be next routes output: [az1 ~]$ ovn-nbctl lr-route-list lr0 IPv4 Routes Route Table global

[ovs-dev] [PATCH ovn v4 1/4] ic: process only local port_bindings

2021-09-19 Thread Vladislav Odintsov
This commit adds a small optimization by utilizing ovsdb_index to iterate over port_bindings. Prior to this change each iteration checked availability_zone and continued processing only if port_binding belons to local AZ. Now we run against port_bindings from local AZ only and don't check availabi

[ovs-dev] [PATCH ovn v4 2/4] northd, utils: support for RouteTables in LRs

2021-09-19 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- northd/northd.c | 159 --- northd/ovn-northd.8.xml | 63 -- ovn-nb.ovsschema| 5 +- ovn-nb.xml | 30 +++ tests/ovn-ic.at | 4 + tests/ovn-nbctl.at | 196 +- tests/ovn-northd.at

[ovs-dev] [PATCH ovn v4 3/4] ic: add support for routing tables in adv/learn routes

2021-09-19 Thread Vladislav Odintsov
Previously support for multiple routing tables was added to northd code. This commit expands support for multiple routing tables by adding support of advertising and learning routes with their routing table information. To utilize such feature, user must: 1. create Logical Router in each AZ; 2. cr

Re: [ovs-dev] [PATCH ovn v4 1/4] ic: process only local port_bindings

2021-09-19 Thread 0-day Robot
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #48 FILE: ic/ovn-ic.c:1398:

Re: [ovs-dev] [PATCH ovn v4 2/4] northd, utils: support for RouteTables in LRs

2021-09-19 Thread 0-day Robot
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around oper

Re: [ovs-dev] [PATCH ovn v4 3/4] ic: add support for routing tables in adv/learn routes

2021-09-19 Thread 0-day Robot
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #376 FILE: ic/ovn-ic.c:1340