Re: [ovs-dev] [PATCH ovn] committer-responsibilities.rst: Add pre-push hook.

2021-10-07 Thread Han Zhou
On Thu, Oct 7, 2021 at 11:21 AM Numan Siddique wrote: > > On Thu, Oct 7, 2021 at 12:56 PM Han Zhou wrote: > > > > Copied from the same document in OVS repo and changed the branch name > > to "main". > > > > Signed-off-by: Han Zhou > > Thanks for fixing this. > > Acked-by: Numan Siddique Thank

Re: [ovs-dev] [PATCH ovn] committer-responsibilities.rst: Add pre-push hook.

2021-10-07 Thread Numan Siddique
On Thu, Oct 7, 2021 at 12:56 PM Han Zhou wrote: > > Copied from the same document in OVS repo and changed the branch name > to "main". > > Signed-off-by: Han Zhou Thanks for fixing this. Acked-by: Numan Siddique Numan > --- > .../internals/committer-responsibilities.rst | 50

[ovs-dev] [PATCH ovn] tests: fix flaky "ovn-ic -- gateway sync" test

2021-10-07 Thread Vladislav Odintsov
Sometimes when ovn daemons in test sandbox were running slower than usual (more often in ASAN tests), test 'ovn-ic -- gateway sync' failed if chassis was not created yet. This patch fixes such situation by adding await for chassis to appear. Test fail example: # ../../../tests/ovn-ic.at:119:

Re: [ovs-dev] [PATCH ovn] tests: fix flaky "ovn-ic -- gateway sync" test

2021-10-07 Thread 0-day Robot
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless

Re: [ovs-dev] [PATCH v4 1/2] ovs-save: Save igmp flows in ofp_parse syntax

2021-10-07 Thread Salvatore Daniele
Just a friendly ping to bring this patch back to the queue. Perhaps addressing igmp in ofputil_normalize_match is outside the scope of this patch set, however, I do think the workaround in ovs-save will be needed to allow flow-dumps containing 'igmp' to be restored. Open to any thoughts! On

[ovs-dev] [PATCH ovn] tests: fix flaky "ovn-ic -- gateway sync" test

2021-10-07 Thread Vladislav Odintsov
Sometimes when ovn-ic daemon was running less quick that usual (more often in ASAN tests), test 'ovn-ic -- gateway sync' failed if chassis was not created yet. This patch fixes such situation by adding await for chassis to appear. ../../../tests/ovn-ic.at:119: ovn_as az2 ovn-sbctl show | sort -r

Re: [ovs-dev] [PATCH ovn] committer-responsibilities.rst: Add pre-push hook.

2021-10-07 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 87 characters long (recommended limit is 79) #59 FILE:

Re: [ovs-dev] [OVN] branch name renamed from 'master' to 'main'

2021-10-07 Thread Han Zhou
On Tue, Oct 5, 2021 at 10:40 AM Numan Siddique wrote: > > Hello everyone, > > The default branch of OVN has been renamed from 'master' to 'main'. I > had brought this up > for discussion in our weekly upstream OVN meeting a couple of weeks > ago and the attendees were supportive of it. > > I

[ovs-dev] [PATCH ovn] committer-responsibilities.rst: Add pre-push hook.

2021-10-07 Thread Han Zhou
Copied from the same document in OVS repo and changed the branch name to "main". Signed-off-by: Han Zhou --- .../internals/committer-responsibilities.rst | 50 +++ 1 file changed, 50 insertions(+) diff --git a/Documentation/internals/committer-responsibilities.rst

Re: [ovs-dev] [PATCH v5 1/3] conntrack: restore the origin sport for each round with new address

2021-10-07 Thread Paolo Valerio
Hi Wenxu, sorry for the late review. This patch is mostly a preparation for the #3. Your last patch needs that both src and dst get restored. My previous suggestion was to squash patch #1 with #3 as it mostly made sense in that context, considering that without #3 restoring dst was redundant in

[ovs-dev] Building OVN with jemalloc

2021-10-07 Thread Seena Fallah
Hi, When building OVN with jemalloc and ddlog it will face an issue with jemalloc: Compiling const-random v0.1.13 Running `rustc --crate-name const_random --edition=2018 /root/.cargo/registry/src/github.com-1ecc6299db9ec823/const-random-0.1.13/src/ lib.rs --error-format=json

Re: [ovs-dev] [ovs-discuss] [OVN] branch name renamed from 'master' to 'main'

2021-10-07 Thread Numan Siddique
On Thu, Oct 7, 2021 at 9:36 AM Dumitru Ceara wrote: > > On 10/7/21 2:26 PM, Aaron Conole wrote: > > Aaron Conole writes: > > > >> Dumitru Ceara writes: > >> > >>> On 10/5/21 7:39 PM, Numan Siddique wrote: > Hello everyone, > >>> > >>> Hi Numan, > >>> > >>> +Aaron > > > > I re-started those

Re: [ovs-dev] [ovs-discuss] [OVN] branch name renamed from 'master' to 'main'

2021-10-07 Thread Dumitru Ceara
On 10/7/21 2:26 PM, Aaron Conole wrote: > Aaron Conole writes: > >> Dumitru Ceara writes: >> >>> On 10/5/21 7:39 PM, Numan Siddique wrote: Hello everyone, >>> >>> Hi Numan, >>> >>> +Aaron > > I re-started those builds that would be associated with the series that > didn't get any tests.

Re: [ovs-dev] [PATCH ovn] ovn-controller: Avoid infinite replying for TCP/ICMP connection reset messages

2021-10-07 Thread Mark Gray
On 06/10/2021 16:28, mh...@redhat.com wrote: > From: Mohammad Heib > > When the ovn controller receives an ip packet that targets a lport that has > ACL > rule to reject ip packets, the controller will reply with TCP_RST or icmp4/6 > unreachable packet > to notify the sender that the

Re: [ovs-dev] ovsdb failures in cluster mode in IPv6 setup

2021-10-07 Thread Riccardo Ravaioli
If it helps, I did a packet capture in both IPv4 and IPv6 setups: - in IPv4, I see the remove_server_request and remove_server_reply messages for the deleted db server; - in IPv6, these messages do not appear. I see them neither on the affected node nor on a different node where another db server

[ovs-dev] [PATCH RFC 5/5] Tunnel: Add self tests for MAC learning and ageing.

2021-10-07 Thread Paolo Valerio
Tests for both ipv4 and ipv6 have been added. Signed-off-by: Paolo Valerio --- tests/tunnel-push-pop-ipv6.at | 66 + tests/tunnel-push-pop.at | 65 2 files changed, 131 insertions(+) diff --git

[ovs-dev] [PATCH RFC 4/5] Native tunnel: Do not refresh the entry while revalidating.

2021-10-07 Thread Paolo Valerio
This is a minor issue but visible e.g. when you try to flush the neigh cache while the ARP flow is still present in the datapath, triggering the revalidation of the datapath flows which subsequntly refreshes/adds the entry in the cache. Signed-off-by: Paolo Valerio --- lib/tnl-neigh-cache.c

[ovs-dev] [PATCH RFC 1/5] Native tunnel: Read/write expires atomically.

2021-10-07 Thread Paolo Valerio
Signed-off-by: Paolo Valerio --- lib/tnl-neigh-cache.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/lib/tnl-neigh-cache.c b/lib/tnl-neigh-cache.c index 5bda4af7e..a37456e6d 100644 --- a/lib/tnl-neigh-cache.c +++ b/lib/tnl-neigh-cache.c @@

[ovs-dev] [PATCH RFC 3/5] Tunnel: Snoop ingress packets and update neigh cache if needed.

2021-10-07 Thread Paolo Valerio
In case of native tunnel with bfd enabled, if the MAC address of the remote end's interface changes (e.g. because it got rebooted, and the MAC address is allocated dinamically), the BFD session will never be re-established. This happens because the local tunnel neigh entry doesn't get updated,

[ovs-dev] [PATCH RFC 2/5] Native tunnel: Add tnl/neigh/ageing command.

2021-10-07 Thread Paolo Valerio
with the command is now possible to change the ageing time of the cache entries. For the existing entries the ageing time is updated only if the current expiration is greater than the new one. In any case, the next refresh will set it to the new value. This is intended mostly for debugging

[ovs-dev] [PATCH RFC 0/5] Native tunnel: Update neigh entries in tnl termination.

2021-10-07 Thread Paolo Valerio
The series is composed of the following patches: #1: expires is modified in different contexts (revalidator, pmd-rx, bfd-tx). It's probably not very racy for many reasons, but it seems a good idea to use an atomic here (especially with the introduction of #3). #2: introduces the

Re: [ovs-dev] [ovs-discuss] [OVN] branch name renamed from 'master' to 'main'

2021-10-07 Thread Aaron Conole
Aaron Conole writes: > Dumitru Ceara writes: > >> On 10/5/21 7:39 PM, Numan Siddique wrote: >>> Hello everyone, >> >> Hi Numan, >> >> +Aaron I re-started those builds that would be associated with the series that didn't get any tests. I guess it should go through now. Please let me know if

Re: [ovs-dev] [PATCH ovn v6 2/4] northd, utils: support for RouteTables in LRs

2021-10-07 Thread 0-day Robot
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch' to see the

Re: [ovs-dev] [ovs-discuss] [OVN] branch name renamed from 'master' to 'main'

2021-10-07 Thread Aaron Conole
Dumitru Ceara writes: > On 10/5/21 7:39 PM, Numan Siddique wrote: >> Hello everyone, > > Hi Numan, > > +Aaron > >> >> The default branch of OVN has been renamed from 'master' to 'main'. I >> had brought this up >> for discussion in our weekly upstream OVN meeting a couple of weeks >> ago and

[ovs-dev] [PATCH v3 4/4] netdev-offload-dpdk: Add support for matching on gre fields

2021-10-07 Thread Nir Anteby via dev
Add parsing gre match fields. Signed-off-by: Nir Anteby --- NEWS | 2 + lib/netdev-offload-dpdk.c | 97 +++ 2 files changed, 99 insertions(+) diff --git a/NEWS b/NEWS index 90f4b15..fd02d7d 100644 --- a/NEWS +++ b/NEWS @@ -10,6

[ovs-dev] [PATCH v3 3/4] netdev-offload-dpdk: Support tnl_pop for gre tunnel

2021-10-07 Thread Nir Anteby via dev
Add support for tnl_pop action for gre vport. Signed-off-by: Nir Anteby --- lib/netdev-offload-dpdk.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index 10924de..5c721fe 100644 --- a/lib/netdev-offload-dpdk.c +++

[ovs-dev] [PATCH v3 2/4] netdev-dpdk: Add flow_api support for netdev gre vports

2021-10-07 Thread Nir Anteby via dev
Add the acceptance of GRE devices to netdev_dpdk_flow_api_supported() API, to allow offloading of DPDK GRE devices. Signed-off-by: Nir Anteby --- lib/netdev-dpdk.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index

[ovs-dev] [PATCH v3 0/4] netdev datapath hardware offload support for GRE flows

2021-10-07 Thread Nir Anteby via dev
V1: Add hardware offload support for GRE flows (experimental). Available only if DPDK experimantal APIs enabled during the build. V2: rebased version v3: fixed rebased compilation CI result : https://github.com/nanteby/ovs/actions/runs/1315625757 Nir Anteby (4): netdev-offload-dpdk:

[ovs-dev] [PATCH v3 1/4] netdev-offload-dpdk: Refactor get_vport_netdev()

2021-10-07 Thread Nir Anteby via dev
Refactor the function as a pre-step towards supporting more tunnel types. Signed-off-by: Nir Anteby --- lib/netdev-offload-dpdk.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index

Re: [ovs-dev] [ovs-discuss] [OVN] branch name renamed from 'master' to 'main'

2021-10-07 Thread Dumitru Ceara
On 10/5/21 7:39 PM, Numan Siddique wrote: > Hello everyone, Hi Numan, +Aaron > > The default branch of OVN has been renamed from 'master' to 'main'. I > had brought this up > for discussion in our weekly upstream OVN meeting a couple of weeks > ago and the attendees were supportive of it. >