Re: [ovs-dev] [PATCH v15 0/7] Add offload support for sFlow

2021-10-11 Thread Eelco Chaudron
On 9 Oct 2021, at 10:16, Chris Mi wrote: > On 10/1/2021 5:43 PM, Eelco Chaudron wrote: >> >> On 1 Oct 2021, at 11:35, Eelco Chaudron wrote: >> >>> Hi Chris, >>> >>> I just started to review this patchset, but as some of the v14 discussions >>> have not finished, I’ll copy them over to v15. This

Re: [ovs-dev] [PATCH v15 5/7] dpif-offload-netlink: Implement dpif-offload-provider API

2021-10-11 Thread Chris Mi via dev
On 10/1/2021 7:57 PM, Eelco Chaudron wrote: Some comments on user-facing log messages, the rest look ok. //Eelco On 15 Sep 2021, at 14:43, Chris Mi wrote: Implement dpif-offload API for netlink datapath. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- lib/automake.mk

Re: [ovs-dev] [PATCH v15 4/7] netdev-offload-tc: Introduce group ID management API

2021-10-11 Thread Chris Mi via dev
On 10/1/2021 6:20 PM, Eelco Chaudron wrote: One nit, rest looks good. Thanks for removing the expired list handling, as it looks way cleaner now! //Eelco On 15 Sep 2021, at 14:43, Chris Mi wrote: When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunne

Re: [ovs-dev] [Phishing Risk] [External] Re: [PATCH] ipf: release unhandled packets from the batch

2021-10-11 Thread Wan Junjie
On Wed, Oct 6, 2021 at 4:26 PM David Marchand wrote: > > On Tue, Oct 5, 2021 at 8:19 PM Aaron Conole wrote: > > > > Since 640d4db788ed ("ipf: Fix a use-after-free error, ...") the ipf > > framework unconditionally allocates a new dp_packet to track > > individual fragments. This prevents a use-a

Re: [ovs-dev] [PATCH v7] Encap & Decap actions for MPLS packet type.

2021-10-11 Thread 0-day Robot
Bleep bloop. Greetings Martin Varghese, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operato

[ovs-dev] [PATCH v7] Encap & Decap actions for MPLS packet type.

2021-10-11 Thread Martin Varghese
From: Martin Varghese The encap & decap actions are extended to support MPLS packet type. Encap & decap actions adds and removes MPLS header at start of the packet. The existing PUSH MPLS & POP MPLS actions inserts & removes MPLS header between ethernet header and the IP header. Though this beha

Re: [ovs-dev] What's the problem of high cpu usage of pmd thread in ovs-dpdk version 2.13

2021-10-11 Thread Ilya Maximets
On 10/9/21 09:38, Simon Jones wrote: > BTW, if this is not problem? PM in PMD stands for "Poll Mode". DPDK provides poll mode drivers for network devices. It means that there are no interrupts or any other wake up mechanism to notify that there are some packets recevied by the hardware, and the

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Avoid infinite replying for TCP/ICMP connection reset messages

2021-10-11 Thread Mark Gray
On 11/10/2021 10:01, mh...@redhat.com wrote: > From: Mohammad Heib > > When the ovn controller receives an ip packet that targets a lport that has > ACL > rule to reject ip packets, the controller will reply with TCP_RST or icmp4/6 > unreachable packet > to notify the sender that the destinatio

[ovs-dev] [PATCH ovn] ovn-northd: Doc: Update OVN tables number

2021-10-11 Thread mheib
From: Mohammad Heib Update old OVN tables numbers to match the correct tables number Signed-off-by: Mohammad Heib --- northd/northd.c | 6 +++--- northd/ovn-northd.8.xml | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/northd/northd.c b/northd/northd.c index 32a

Re: [ovs-dev] [PATCH] datapath-windows: Add file digest algorithm for signtool

2021-10-11 Thread alinserdean
-Original Message- From: Aaron Conole Sent: Monday, October 11, 2021 4:22 PM To: Alin-Gabriel Serdean Cc: d...@openvswitch.org Subject: Re: [PATCH] datapath-windows: Add file digest algorithm for signtool Alin-Gabriel Serdean writes: > > This patch specifies the file digest algorithm

Re: [ovs-dev] [PATCH v6] Encap & Decap actions for MPLS packet type.

2021-10-11 Thread Martin Varghese
On Fri, Oct 08, 2021 at 03:20:09PM +0200, Eelco Chaudron wrote: > Thanks Martin, some minor comments. > Thanks Eelco. I will send out the v7 soon. > //Eelco > > On 30 Sep 2021, at 3:59, Martin Varghese wrote: > > > From: Martin Varghese > > > > The encap & decap actions are extended to support

Re: [ovs-dev] [PATCH] datapath-windows: Add file digest algorithm for signtool

2021-10-11 Thread Aaron Conole
Alin-Gabriel Serdean writes: > This patch specifies the file digest algorithm for signtool on the package > and ovsext VS projects. > > Fixes broken appveyor build. > > Signed-off-by: Alin-Gabriel Serdean > --- Acked-by: Aaron Conole ___ dev mailing

Re: [ovs-dev] [OVN Patch v3] northd: Optimize dp/lflow postprocessing

2021-10-11 Thread Mark Gray
On 11/10/2021 13:57, anton.iva...@cambridgegreys.com wrote: > From: Anton Ivanov > > 1. Compute dp group hash only if there will be dp group processing. > 2. Remove hmapx interim storage and related hmapx computation for > single dp flows and replace it with a pre-sized hmap. > > Signed-off-by:

[ovs-dev] [OVN Patch v3] northd: Optimize dp/lflow postprocessing

2021-10-11 Thread anton . ivanov
From: Anton Ivanov 1. Compute dp group hash only if there will be dp group processing. 2. Remove hmapx interim storage and related hmapx computation for single dp flows and replace it with a pre-sized hmap. Signed-off-by: Anton Ivanov --- northd/northd.c | 50 --

[ovs-dev] problem: long tcp session instantiation with conntrack and OOT ovs kmod

2021-10-11 Thread Vladislav Odintsov
Hi Greg, Pravin, I was suggested to contact you with my OVS/conntrack/OOT KMOD problem. Could you please look at this and give any thoughts. Initially I posted this question to OVN dev mail list [1] and it seems that OVN is not involved in my issue. I was able to reproduce the problem with only

Re: [ovs-dev] [PATCH ovn] sbctl: add the capability to configure static mac_bindings entries

2021-10-11 Thread Mark Gray
On 28/09/2021 19:28, Lorenzo Bianconi wrote: > Introduce the two following commands to configure and dump static > L2 address bindings: > > $ovn-sbctl set-mac-binding 192.168.1.100 00:11:22:33:44:55 vif0 > $ovn-sbctl list-mac-binding > [ 192.168.1.100 00:11:22:33:44:55 S ] Is there any reason why

Re: [ovs-dev] [OVN Patch v2] northd: Optimize dp/lflow postprocessing

2021-10-11 Thread Mark Gray
On 08/10/2021 17:03, anton.iva...@cambridgegreys.com wrote: > From: Anton Ivanov > > 1. Compute dp group hash only if there will be dp group processing. > 2. Remove hmapx interim storage and related hmapx computation for > single dp flows and replace it with a pre-sized hmap. > > Signed-off-by:

Re: [ovs-dev] [PATCH ovn] controller: do not mark bfd and ipv6_pd msgs as local-only

2021-10-11 Thread Dumitru Ceara
On 10/11/21 12:01 PM, Lorenzo Bianconi wrote: >> On 10/9/21 1:05 AM, Ihar Hrachyshka wrote: >>> This is correct, thank you for fixing it. >>> >>> One comment and one question: >>> >>> 1) While the referred patch that suppressed LOCAL_ONLY traffic exposed >>> the issue, it was always a bug, though a

Re: [ovs-dev] [PATCH ovn] controller: do not mark bfd and ipv6_pd msgs as local-only

2021-10-11 Thread Lorenzo Bianconi
> On 10/9/21 1:05 AM, Ihar Hrachyshka wrote: > > This is correct, thank you for fixing it. > > > > One comment and one question: > > > > 1) While the referred patch that suppressed LOCAL_ONLY traffic exposed > > the issue, it was always a bug, though affecting a tiny minority of > > scenarios. >

[ovs-dev] [PATCH ovn v2] ovn-controller: Avoid infinite replying for TCP/ICMP connection reset messages

2021-10-11 Thread mheib
From: Mohammad Heib When the ovn controller receives an ip packet that targets a lport that has ACL rule to reject ip packets, the controller will reply with TCP_RST or icmp4/6 unreachable packet to notify the sender that the destination is not available. In turn, the receiver host will receive

Re: [ovs-dev] [PATCH ovn] controller: do not mark bfd and ipv6_pd msgs as local-only

2021-10-11 Thread Dumitru Ceara
On 10/9/21 1:05 AM, Ihar Hrachyshka wrote: > This is correct, thank you for fixing it. > > One comment and one question: > > 1) While the referred patch that suppressed LOCAL_ONLY traffic exposed > the issue, it was always a bug, though affecting a tiny minority of > scenarios. > > For example f