Re: [ovs-dev] [PATCH ovn v6 2/4] northd, utils: support for RouteTables in LRs

2021-10-13 Thread Han Zhou
On Tue, Oct 5, 2021 at 1:26 PM Vladislav Odintsov wrote: > > This patch extends Logical Router's routing functionality. > Now user may create multiple routing tables within a Logical Router > and assign them to Logical Router Ports. > > Traffic coming from Logical Router Port with assigned route_t

Re: [ovs-dev] [PATCH ovn v6 1/4] ic: process only local port_bindings

2021-10-13 Thread Han Zhou
On Tue, Oct 5, 2021 at 1:25 PM Vladislav Odintsov wrote: > > This commit adds a small optimization by utilizing ovsdb_index > to iterate over port_bindings. > Prior to this change each iteration checked availability_zone > and continued processing only if port_binding belons to local AZ. > > Now w

[ovs-dev] [PATCH] [python] Allow custom transaction ops to be added

2021-10-13 Thread Terry Wilson
It can be useful to be able to send raw transaction operations through the Idl's connection. For example, to clean up MAC_Binding entries for floating IPs without having to monitor the MAC_Binding table which can be quite large. Signed-off-by: Terry Wilson --- python/ovs/db/idl.py | 18 +

Re: [ovs-dev] [PATCH v2] python: replace pyOpenSSL with ssl

2021-10-13 Thread Terry Wilson
On Wed, Oct 6, 2021 at 1:50 PM Timothy Redaelli wrote: > > Currently, pyOpenSSL is half-deprecated upstream and so it's removed on > some distributions (for example on CentOS Stream 9, > https://issues.redhat.com/browse/CS-336), but since OVS only > supports Python 3 it's possible to replace pyOpe

[ovs-dev] [PATCH ovn 2/3] CoPP: add self-test for bfd controller action

2021-10-13 Thread Lorenzo Bianconi
Introduce CoPP selftest for bfd controller action Signed-off-by: Lorenzo Bianconi --- tests/system-ovn.at | 29 + 1 file changed, 29 insertions(+) diff --git a/tests/system-ovn.at b/tests/system-ovn.at index bd425f54b..12f072b72 100644 --- a/tests/system-ovn.at +++ b

[ovs-dev] [PATCH ovn 3/3] CoPP: add self-test for tcp-reset controller action

2021-10-13 Thread Lorenzo Bianconi
Introduce CoPP selftest for tcp-reset controller action Signed-off-by: Lorenzo Bianconi --- tests/ovn-northd.at | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at index 3bcbdf4a9..c180ba65e 100644 --- a/tests/ovn-northd.at +++ b/tests/ovn-n

[ovs-dev] [PATCH ovn 1/3] CoPP: add self-test for icmp{4, 6}_error controller action

2021-10-13 Thread Lorenzo Bianconi
Introduce CoPP selftest for icmp{4,6}_error controller action Signed-off-by: Lorenzo Bianconi --- tests/ovn-northd.at | 23 +++ tests/system-ovn.at | 21 + 2 files changed, 44 insertions(+) diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at index 8b90

[ovs-dev] [PATCH ovn 0/3] Introduce more CoPP self-tests

2021-10-13 Thread Lorenzo Bianconi
Lorenzo Bianconi (3): CoPP: add self-test for icmp{4,6}_error controller action CoPP: add self-test for bfd controller action CoPP: add self-test for tcp-reset controller action tests/ovn-northd.at | 34 ++ tests/system-ovn.at | 50 +++

Re: [ovs-dev] [PATCH ovs] lib: export calc_percentile function

2021-10-13 Thread Aaron Conole
Xavier Simonart writes: > export calc_percentile function (and percentile struct) so that > it can be used in other libraries such as OVN. > > Signed-off-by: Xavier Simonart > --- What is the intent to use this in other libraries? It would be nice to understand why just running the existing st

Re: [ovs-dev] [PATCH branch-2.14] python: idl: Avoid sending transactions when the DB is not synced up.

2021-10-13 Thread Terry Wilson
On Wed, Oct 13, 2021 at 11:13 AM Terry Wilson wrote: > > This ports the C IDL change f50714b to the Python IDL: > > Until now the code here would happily try to send transactions to the > database server even if the database connection was not in the correct > state. In some cases this could lead

[ovs-dev] [PATCH branch-2.14] python: idl: Avoid sending transactions when the DB is not synced up.

2021-10-13 Thread Terry Wilson
This ports the C IDL change f50714b to the Python IDL: Until now the code here would happily try to send transactions to the database server even if the database connection was not in the correct state. In some cases this could lead to strange behavior, such as sending a database transaction for

Re: [ovs-dev] [PATCH v3 3/4] netdev-offload-dpdk: Support tnl_pop for gre tunnel

2021-10-13 Thread Maxime Coquelin
On 10/7/21 13:05, Nir Anteby via dev wrote: Add support for tnl_pop action for gre vport. Signed-off-by: Nir Anteby --- lib/netdev-offload-dpdk.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index 10924de..5c721fe 1

Re: [ovs-dev] [PATCH] tunnel-push-pop.at: Mask source port in tunnel header.

2021-10-13 Thread Ilya Maximets
On 10/13/21 17:08, Timothy Redaelli wrote: > On Tue, 12 Oct 2021 15:33:07 +0200 > Ilya Maximets wrote: > >> Source port is based on a packet hash and hash depends on a chosen >> implementation. Masking it to avoid test failures with '-msse4.2'. >> >> Fixes: 7e6b41ac8d9d ("dpif-netdev: Fix crash

Re: [ovs-dev] [PATCH v3 0/6] MFEX Optimizations IPv6 + Hashing

2021-10-13 Thread Ilya Maximets
On 10/5/21 16:45, Stokes, Ian wrote: > 9/21/21 12:23, Kumar Amber wrote: >>> --- >>> v3: >>> - rebase to master. >>> v2: >>> - fix the CI build. >>> - fix check-patch for co-author. >>> --- >>> >>> The patch-set introduces AVX512 optimizations of IPv6 >>> traffic profiles and hashing improvements f

Re: [ovs-dev] [PATCH] tunnel-push-pop.at: Mask source port in tunnel header.

2021-10-13 Thread Timothy Redaelli
On Tue, 12 Oct 2021 15:33:07 +0200 Ilya Maximets wrote: > Source port is based on a packet hash and hash depends on a chosen > implementation. Masking it to avoid test failures with '-msse4.2'. > > Fixes: 7e6b41ac8d9d ("dpif-netdev: Fix crash when PACKET_OUT is metered.") > Reported-by: Kumar A

Re: [ovs-dev] [PATCH v3 0/6] MFEX Optimizations IPv6 + Hashing

2021-10-13 Thread Ilya Maximets
On 9/28/21 19:13, Van Haaren, Harry wrote: >> -Original Message- >> From: Ilya Maximets >> Sent: Tuesday, September 21, 2021 1:45 PM >> To: Amber, Kumar ; ovs-dev@openvswitch.org >> Cc: ktray...@redhat.com; i.maxim...@ovn.org; Stokes, Ian >> ; f...@sysclose.org; echau...@redhat.com; Van Ha

Re: [ovs-dev] [PATCH v3 2/4] netdev-dpdk: Add flow_api support for netdev gre vports

2021-10-13 Thread Maxime Coquelin
On 10/7/21 13:05, Nir Anteby via dev wrote: Add the acceptance of GRE devices to netdev_dpdk_flow_api_supported() API, to allow offloading of DPDK GRE devices. Signed-off-by: Nir Anteby --- lib/netdev-dpdk.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/

Re: [ovs-dev] [PATCH] dpif:Fix typo in function pointer name bond-add

2021-10-13 Thread Kevin Traynor
Suggested title: dpif: Fix function pointer check for bond_add. On 12/10/2021 09:11, Somnath Chatterjee via dev wrote: There was wrong typo in function pointer check in dpif_bond_add() before calling bond_add() Fixes: 9df65060cf4c ("userspace: Avoid dp_hash recirculation for balance-tcp bond

Re: [ovs-dev] [PATCH v3 1/4] netdev-offload-dpdk: Refactor get_vport_netdev()

2021-10-13 Thread Maxime Coquelin
On 10/7/21 13:05, Nir Anteby via dev wrote: Refactor the function as a pre-step towards supporting more tunnel types. Signed-off-by: Nir Anteby --- lib/netdev-offload-dpdk.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) Reviewed-by: Maxime Coquelin Tha

Re: [ovs-dev] [PATCH] [python] Avoid alloc of an attr dict/row+column

2021-10-13 Thread Timothy Redaelli
On Tue, 12 Oct 2021 14:13:31 -0500 Terry Wilson wrote: > Python objects normally have a dictionary named __dict__ allocated > for handling dynamically assigned attributes. Depending on > architecture and Python version, that empty dict may be between > 64 and 280 bytes. > > Seeing as Atom and Da

Re: [ovs-dev] [PATCH] github: Remove workaround fixing up /etc/hosts.

2021-10-13 Thread David Marchand
On Fri, Oct 8, 2021 at 1:58 PM Dumitru Ceara wrote: > > The issue that was worked around has been fixed in the meantime: > https://github.com/actions/virtual-environments/issues/3353 > > Signed-off-by: Dumitru Ceara Fairly trivial and ovsrobot already confirmed it was ok. I had a look at a buil

Re: [ovs-dev] [PATCH] dpif-netdev: Fix use-after-free on PACKET_OUT of IP fragments.

2021-10-13 Thread Ilya Maximets
On 10/12/21 23:12, Aaron Conole wrote: > Ilya Maximets writes: > >> IP fragmentation engine may not only steal the packet but also add >> more. For example, after receiving the last fragment, it will >> add all previous fragments to a batch. Unfortunately, it will also >> free the original last

Re: [ovs-dev] [PATCH] tunnel-push-pop.at: Mask source port in tunnel header.

2021-10-13 Thread Ilya Maximets
On 10/12/21 17:18, Alin-Gabriel Serdean wrote: > Acked-by: Alin-Gabriel Serdean Thanks! I applied this patch and backported down to 2.12. Best regards, Ilya Maximets. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listi

Re: [ovs-dev] [PATCH] AUTHORS: Update email for Alin Serdean

2021-10-13 Thread Ilya Maximets
On 10/7/21 05:18, Alin-Gabriel Serdean wrote: > Signed-off-by: Alin-Gabriel Serdean > --- > .mailmap| 4 ++-- > AUTHORS.rst | 2 +- > MAINTAINERS.rst | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/.mailmap b/.mailmap > index 824af56b2..6cefe3cd4 100644 >

[ovs-dev] [PATCH v1 1/1] datapath-windows: add layers when adding the deferred actions

2021-10-13 Thread Wilson Peng
Currently the layers info propogated to ProcessDeferredActions may be incorrect. Because of this, any subsequent usage of layers might result in undesired behavior. Accordingly in this patch it will add the related layers in the deferred action to make sure the layers consistent with the related N

Re: [ovs-dev] [PATCH v3] [python] Avoid sending transactions when the DB is not synced up

2021-10-13 Thread Dumitru Ceara
On 10/12/21 9:24 PM, Ilya Maximets wrote: > Dumitru, sorry, I messed up and didn't include the suggested comment. > Feel free to submit a separate patch for that if you think it's needed. It was a nit, I'm not sure it's worth a separate patch. It's OK, thanks! ___