Re: [ovs-dev] [PATCH v2] python: replace pyOpenSSL with ssl

2021-10-21 Thread Ilya Maximets
On 10/6/21 20:49, Timothy Redaelli wrote: > Currently, pyOpenSSL is half-deprecated upstream and so it's removed on > some distributions (for example on CentOS Stream 9, > https://issues.redhat.com/browse/CS-336), but since OVS only > supports Python 3 it's possible to replace pyOpenSSL with "impor

[ovs-dev] [PATCH v2 ovn 2/3] CoPP: add self-test for bfd controller action

2021-10-21 Thread Lorenzo Bianconi
Introduce CoPP selftest for bfd controller action Signed-off-by: Lorenzo Bianconi --- tests/system-ovn.at | 28 1 file changed, 28 insertions(+) diff --git a/tests/system-ovn.at b/tests/system-ovn.at index d003843c3..77c811946 100644 --- a/tests/system-ovn.at +++ b/

[ovs-dev] [PATCH v2 ovn 3/3] CoPP: add self-test for tcp-reset controller action

2021-10-21 Thread Lorenzo Bianconi
Introduce CoPP selftest for tcp-reset controller action Signed-off-by: Lorenzo Bianconi --- tests/ovn-northd.at | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at index 3ff0029f8..afc005156 100644 --- a/tests/ovn-northd.at +++ b/tests/ovn-n

[ovs-dev] [PATCH v2 ovn 1/3] CoPP: add self-test for icmp{4, 6}_error controller action

2021-10-21 Thread Lorenzo Bianconi
Introduce CoPP selftest for icmp{4,6}_error controller action Remove sleep in CoPP test and rely on tcpdump "-l" option. Signed-off-by: Lorenzo Bianconi --- tests/ovn-northd.at | 23 +++ tests/system-ovn.at | 43 --- 2 files changed, 51

[ovs-dev] [PATCH v2 ovn 0/3] Introduce more CoPP self-tests

2021-10-21 Thread Lorenzo Bianconi
Changes since v1: - add more comments - remove active sleep - cosmetics Lorenzo Bianconi (3): CoPP: add self-test for icmp{4,6}_error controller action CoPP: add self-test for bfd controller action CoPP: add self-test for tcp-reset controller action tests/ovn-northd.at | 34 +++

Re: [ovs-dev] [PATCH branch-2.16 0/2] Release patches for v2.16.1.

2021-10-21 Thread Ilya Maximets
On 10/21/21 19:20, Aaron Conole wrote: > Ilya Maximets writes: > >> This version includes important bug fixes for fairly severe and >> user-visible issues. There is no point in postponing release >> any longer. >> >> Ilya Maximets (2): >> Set release date for 2.16.1. >> Prepare for 2.16.2. >

Re: [ovs-dev] [PATCH ovn v2] Add a northbound interface to program MAC_Binding table

2021-10-21 Thread 0-day Robot
References: <20211021215452.6037-1-svc.eng.git-m...@nutanix.com> Bleep bloop. Greetings svc.eng.git-mail, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks wh

Re: [ovs-dev] [PATCH ovn v1] Add a northbound interface to program MAC_Binding table

2021-10-21 Thread svc . eng . git-mail
Thank you for the review. I’ve incorporated the changes suggested by Lorenzo and Mark and sent out v2 of the patch. Thank You, Karthik C On 10/14/21, 9:55 AM, "Lorenzo Bianconi" wrote: > From: Karthik Chandrashekar > mailto:karthi...@nutanix.com>> > > Add a new NB MAC_Binding table. This allow

Re: [ovs-dev] [PATCH branch-2.14] python: idl: Avoid sending transactions when the DB is not synced up.

2021-10-21 Thread Ilya Maximets
On 10/13/21 18:16, Terry Wilson wrote: > On Wed, Oct 13, 2021 at 11:13 AM Terry Wilson wrote: >> >> This ports the C IDL change f50714b to the Python IDL: >> >> Until now the code here would happily try to send transactions to the >> database server even if the database connection was not in the c

[ovs-dev] [PATCH ovn v2] Add a northbound interface to program MAC_Binding table

2021-10-21 Thread svc . eng . git-mail
From: Karthik Chandrashekar Add a new NB MAC_Binding table. This allows programming of static mac_bindings for a logical_router. OVN northd is responsible for propagating these static entries to the existing SB MAC_Binding table. Signed-off-by: Karthik Chandrashekar --- controller/pinctrl.c

Re: [ovs-dev] [PATCH] github: Stick to python 3.9.

2021-10-21 Thread Ilya Maximets
On 10/21/21 21:23, Aaron Conole wrote: > Ilya Maximets writes: > >> Since recently actions/setup-python@v2 started to pull python 3.10.0 >> which seems to be incompatible with the meson 0.47.1 which we're using >> to build DPDK. >> >> This broke CI on 2.16 and master branches: >> https://github

Re: [ovs-dev] [PATCH v7] dpdk: Support running PMD threads on any core.

2021-10-21 Thread David Marchand
On Thu, Oct 21, 2021 at 1:04 PM Ilya Maximets wrote: > >> So I assume the deprecated-declaration is required above because > >> rte_mp_disable() is experimental (if memory serves correct it triggers > >> deprecated) > >> > >> I'm surprised to see this is still experimental, if it was introduced

Re: [ovs-dev] [PATCH] github: Stick to python 3.9.

2021-10-21 Thread Aaron Conole
Ilya Maximets writes: > Since recently actions/setup-python@v2 started to pull python 3.10.0 > which seems to be incompatible with the meson 0.47.1 which we're using > to build DPDK. > > This broke CI on 2.16 and master branches: > https://github.com/ovsrobot/ovs/runs/3967167374 > > Sticking th

[ovs-dev] [PATCH] github: Stick to python 3.9.

2021-10-21 Thread Ilya Maximets
Since recently actions/setup-python@v2 started to pull python 3.10.0 which seems to be incompatible with the meson 0.47.1 which we're using to build DPDK. This broke CI on 2.16 and master branches: https://github.com/ovsrobot/ovs/runs/3967167374 Sticking the version to 3.9 for now to avoid the

Re: [ovs-dev] [PATCH ovn] ipsec: Update documentation for RHEL and CentOS

2021-10-21 Thread 0-day Robot
Bleep bloop. Greetings Mark Gray, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 90 characters long (recommended limit is 79) #23 FILE: Documentation/tutorials/ovn

[ovs-dev] [PATCH ovn] ipsec: Update documentation for RHEL and CentOS

2021-10-21 Thread Mark Gray
Similarly to Fedora, we may also need to open firewall ports to enable IPsec. Update the documentation to reflect this. Signed-off-by: Mark Gray --- Documentation/tutorials/ovn-ipsec.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/tutorials/ovn-ipsec.rst b/

Re: [ovs-dev] [PATCH branch-2.16 0/2] Release patches for v2.16.1.

2021-10-21 Thread Aaron Conole
Ilya Maximets writes: > This version includes important bug fixes for fairly severe and > user-visible issues. There is no point in postponing release > any longer. > > Ilya Maximets (2): > Set release date for 2.16.1. > Prepare for 2.16.2. > > NEWS | 6 +- > configure.ac

Re: [ovs-dev] [PATCH branch-2.15 0/2] Release patches for v2.15.2.

2021-10-21 Thread Aaron Conole
Ilya Maximets writes: > This version includes important bug fixes for fairly severe and > user-visible issues. There is no point in postponing release > any longer. > > Ilya Maximets (2): > Set release date for 2.15.2. > Prepare for 2.15.3. > > NEWS | 6 +- > configure.ac

Re: [ovs-dev] [PATCH branch-2.14 0/2] Release patches for v2.14.3.

2021-10-21 Thread Aaron Conole
Ilya Maximets writes: > This version includes important bug fixes for fairly severe and > user-visible issues. There is no point in postponing release > any longer. > > Ilya Maximets (2): > Set release date for 2.14.3. > Prepare for 2.14.4. > > NEWS | 6 +- > configure.ac

Re: [ovs-dev] [PATCH branch-2.13 0/2] Release patches for v2.13.5.

2021-10-21 Thread Aaron Conole
Ilya Maximets writes: > This version includes important bug fixes for fairly severe and > user-visible issues. There is no point in postponing release > any longer. > > Ilya Maximets (2): > Set release date for 2.13.5. > Prepare for 2.13.6. > > NEWS | 6 +- > configure.ac

Re: [ovs-dev] [PATCH branch-2.12 0/2] Release patches for v2.12.4.

2021-10-21 Thread Aaron Conole
Ilya Maximets writes: > This version includes important bug fixes for fairly severe and > user-visible issues. There is no point in postponing release > any longer. > > This will also be the last official release for OVS 2.12. > > Ilya Maximets (2): > Set release date for 2.12.4. > Prepare f

Re: [ovs-dev] [PATCH branch-2.12 0/2] Release patches for v2.12.4.

2021-10-21 Thread Ilya Maximets
On 10/21/21 18:45, Alin-Gabriel Serdean wrote: > Acked-by: Alin-Gabriel Serdean > > -Original Message- > From: dev On Behalf Of Ilya Maximets > Sent: Thursday, October 21, 2021 7:22 PM > To: ovs-dev@openvswitch.org > Cc: Flavio Leitner ; Ilya Maximets > Subject: [ovs-dev] [PATCH branch-

Re: [ovs-dev] [PATCH branch-2.12 0/2] Release patches for v2.12.4.

2021-10-21 Thread Stokes, Ian
> This version includes important bug fixes for fairly severe and > user-visible issues. There is no point in postponing release > any longer. > > This will also be the last official release for OVS 2.12. > > Ilya Maximets (2): > Set release date for 2.12.4. > Prepare for 2.12.5. > > NEWS

Re: [ovs-dev] [PATCH branch-2.12 0/2] Release patches for v2.12.4.

2021-10-21 Thread Alin-Gabriel Serdean
Acked-by: Alin-Gabriel Serdean -Original Message- From: dev On Behalf Of Ilya Maximets Sent: Thursday, October 21, 2021 7:22 PM To: ovs-dev@openvswitch.org Cc: Flavio Leitner ; Ilya Maximets Subject: [ovs-dev] [PATCH branch-2.12 0/2] Release patches for v2.12.4. This version includes i

Re: [ovs-dev] [PATCH branch-2.14 0/2] Release patches for v2.14.3.

2021-10-21 Thread Stokes, Ian
> This version includes important bug fixes for fairly severe and > user-visible issues. There is no point in postponing release > any longer. > > Ilya Maximets (2): > Set release date for 2.14.3. > Prepare for 2.14.4. > > NEWS | 6 +- > configure.ac | 2 +- > debian/cha

Re: [ovs-dev] [PATCH branch-2.16 0/2] Release patches for v2.16.1.

2021-10-21 Thread Stokes, Ian
> This version includes important bug fixes for fairly severe and > user-visible issues. There is no point in postponing release > any longer. > Acked Regards Ian > Ilya Maximets (2): > Set release date for 2.16.1. > Prepare for 2.16.2. > > NEWS | 6 +- > configure.ac

Re: [ovs-dev] [PATCH branch-2.13 0/2] Release patches for v2.13.5.

2021-10-21 Thread Stokes, Ian
> This version includes important bug fixes for fairly severe and > user-visible issues. There is no point in postponing release > any longer. > > Ilya Maximets (2): > Set release date for 2.13.5. > Prepare for 2.13.6. > > NEWS | 6 +- > configure.ac | 2 +- > debian/cha

Re: [ovs-dev] [PATCH branch-2.15 0/2] Release patches for v2.15.2.

2021-10-21 Thread Stokes, Ian
> This version includes important bug fixes for fairly severe and > user-visible issues. There is no point in postponing release > any longer. > Acked Regards Ian > Ilya Maximets (2): > Set release date for 2.15.2. > Prepare for 2.15.3. > > NEWS | 6 +- > configure.ac

[ovs-dev] [PATCH branch-2.16 0/2] Release patches for v2.16.1.

2021-10-21 Thread Ilya Maximets
This version includes important bug fixes for fairly severe and user-visible issues. There is no point in postponing release any longer. Ilya Maximets (2): Set release date for 2.16.1. Prepare for 2.16.2. NEWS | 6 +- configure.ac | 2 +- debian/changelog | 8 +++- 3

[ovs-dev] [PATCH branch-2.16 2/2] Prepare for 2.16.2.

2021-10-21 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 8cefdbd1d..7a6de3da8 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.16.2 - xx xxx +-

[ovs-dev] [PATCH branch-2.16 1/2] Set release date for 2.16.1.

2021-10-21 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index f2497d5ce..8cefdbd1d 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.16.1 - xx xxx +v2.16.1 - 21 Oct 2021 ---

[ovs-dev] [PATCH branch-2.15 2/2] Prepare for 2.15.3.

2021-10-21 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 05161e8e9..d0f0cc8d8 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.15.3 - xx xxx +-

[ovs-dev] [PATCH branch-2.15 1/2] Set release date for 2.15.2.

2021-10-21 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 154a299d9..05161e8e9 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.15.2 - xx xxx +v2.15.2 - 21 Oct 2021 ---

[ovs-dev] [PATCH branch-2.15 0/2] Release patches for v2.15.2.

2021-10-21 Thread Ilya Maximets
This version includes important bug fixes for fairly severe and user-visible issues. There is no point in postponing release any longer. Ilya Maximets (2): Set release date for 2.15.2. Prepare for 2.15.3. NEWS | 6 +- configure.ac | 2 +- debian/changelog | 8 +++- 3

[ovs-dev] [PATCH branch-2.14 2/2] Prepare for 2.14.4.

2021-10-21 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 2a826cdab..7d8d6931c 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.14.4 - xx xxx +-

[ovs-dev] [PATCH branch-2.14 1/2] Set release date for 2.14.3.

2021-10-21 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 7dd7d882b..2a826cdab 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.14.3 - xx xxx +v2.14.3 - 21 Oct 2021 ---

[ovs-dev] [PATCH branch-2.14 0/2] Release patches for v2.14.3.

2021-10-21 Thread Ilya Maximets
This version includes important bug fixes for fairly severe and user-visible issues. There is no point in postponing release any longer. Ilya Maximets (2): Set release date for 2.14.3. Prepare for 2.14.4. NEWS | 6 +- configure.ac | 2 +- debian/changelog | 8 +++- 3

[ovs-dev] [PATCH branch-2.13 2/2] Prepare for 2.13.6.

2021-10-21 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 6342100b3..840909735 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.13.6 - xx xxx +-

[ovs-dev] [PATCH branch-2.13 1/2] Set release date for 2.13.5.

2021-10-21 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 0ae1076ee..6342100b3 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.13.5 - xx xxx +v2.13.5 - 21 Oct 2021 ---

[ovs-dev] [PATCH branch-2.13 0/2] Release patches for v2.13.5.

2021-10-21 Thread Ilya Maximets
This version includes important bug fixes for fairly severe and user-visible issues. There is no point in postponing release any longer. Ilya Maximets (2): Set release date for 2.13.5. Prepare for 2.13.6. NEWS | 6 +- configure.ac | 2 +- debian/changelog | 8 +++- 3

[ovs-dev] [PATCH branch-2.12 2/2] Prepare for 2.12.5.

2021-10-21 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 56ac1e70d..56a2cd27a 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.12.5 - xx xxx +-

[ovs-dev] [PATCH branch-2.12 1/2] Set release date for 2.12.4.

2021-10-21 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index db6ba9e73..56ac1e70d 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.12.4 - xx xxx +v2.12.4 - 21 Oct 2021 ---

[ovs-dev] [PATCH branch-2.12 0/2] Release patches for v2.12.4.

2021-10-21 Thread Ilya Maximets
This version includes important bug fixes for fairly severe and user-visible issues. There is no point in postponing release any longer. This will also be the last official release for OVS 2.12. Ilya Maximets (2): Set release date for 2.12.4. Prepare for 2.12.5. NEWS | 6 +-

Re: [ovs-dev] [PATCH ovn v7 00/12] Introduce infrastructure for plug providers

2021-10-21 Thread Frode Nordahl
On Thu, Oct 21, 2021 at 3:34 AM Numan Siddique wrote: > > On Wed, Oct 20, 2021 at 9:32 PM Numan Siddique wrote: > > > > On Tue, Oct 19, 2021 at 6:15 AM Frode Nordahl > > wrote: > > > > > > Introduce infrastructure for plug providers and add feature to > > > ovn-controller to add and remove ports

Re: [ovs-dev] [PATCH] ovs-tcpdump: Improve performance with dummy interface

2021-10-21 Thread Aaron Conole
Hi Mike, Thanks for the patch - comments below. Mike Pattrick writes: > Currently the ovs-tcpdump utility creates a virtual tunnel to send > packets to. This method functions perfectly fine, however, it can > greatly impact the performance of the monitored port. > > It has been reported to redu

Re: [ovs-dev] [PATCH v3 4/4] netdev-offload-dpdk: Add support for matching on gre fields

2021-10-21 Thread Maxime Coquelin
On 10/7/21 13:05, Nir Anteby via dev wrote: Add parsing gre match fields. Signed-off-by: Nir Anteby --- NEWS | 2 + lib/netdev-offload-dpdk.c | 97 +++ 2 files changed, 99 insertions(+) Reviewed-by: Maxime Coquelin Th

Re: [ovs-dev] [PATCH v4 3/4] netdev-offload-dpdk: Support tnl_pop for gre tunnel

2021-10-21 Thread Maxime Coquelin
On 10/21/21 11:18, Nir Anteby via dev wrote: Add support for tnl_pop action for gre vport. Signed-off-by: Nir Anteby --- lib/netdev-offload-dpdk.c | 12 1 file changed, 12 insertions(+) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index af56491..a2d7c85

Re: [ovs-dev] [PATCH v4 1/4] netdev-offload-dpdk: Refactor get_vport_netdev()

2021-10-21 Thread Maxime Coquelin
On 10/21/21 11:18, Nir Anteby via dev wrote: Refactor the function as a pre-step towards supporting more tunnel types. Signed-off-by: Nir Anteby --- lib/netdev-offload-dpdk.c | 35 +++ 1 file changed, 15 insertions(+), 20 deletions(-) Reviewed-by: Maxime

Re: [ovs-dev] [PATCH v2] dpif:Fix function pointer check for bond_add.

2021-10-21 Thread Kevin Traynor
On 21/10/2021 08:04, Somnath Chatterjee wrote: There was typo in function pointer check in dpif_bond_add() before calling bond_add() Fixes: 9df65060cf4c ("userspace: Avoid dp_hash recirculation for balance-tcp bond mode.") Signed-off-by: Somnath Chatterjee Acked-by: Kevin Traynor --- li

Re: [ovs-dev] [PATCH v2] dpcls: Change info-get function to fetch dpcls usage stats.

2021-10-21 Thread Van Haaren, Harry
> -Original Message- > From: Eelco Chaudron > Sent: Thursday, October 21, 2021 1:04 PM > To: Amber, Kumar > Cc: ovs-dev@openvswitch.org; ktray...@redhat.com; i.maxim...@ovn.org; > Stokes, Ian ; f...@sysclose.org; Van Haaren, Harry > > Subject: Re: [PATCH v2] dpcls: Change info-get functi

Re: [ovs-dev] [PATCH v2] dpcls: Change info-get function to fetch dpcls usage stats.

2021-10-21 Thread Eelco Chaudron
Hi Kumar, See inline comments below… //Eelco On 20 Oct 2021, at 6:52, Kumar Amber wrote: > Modified the dplcs info-get command output to include > the count for different dpcls implementations. > > $ovs-appctl dpif-netdev/subtable-lookup-prio-get > > Available dpcls implementations: > autova

Re: [ovs-dev] [PATCH ovn 1/3] CoPP: add self-test for icmp{4, 6}_error controller action

2021-10-21 Thread Lorenzo Bianconi
> On 13/10/2021 17:46, Lorenzo Bianconi wrote: > > Introduce CoPP selftest for icmp{4,6}_error controller action > > > > Signed-off-by: Lorenzo Bianconi > > --- > > tests/ovn-northd.at | 23 +++ > > tests/system-ovn.at | 21 + > > 2 files changed, 44 inser

Re: [ovs-dev] [PATCH v7] dpdk: Support running PMD threads on any core.

2021-10-21 Thread Ilya Maximets
On 10/21/21 12:41, Kevin Traynor wrote: > On 20/10/2021 16:13, Stokes, Ian wrote: >>> Previously in OVS, a PMD thread running on cpu X used lcore X. >>> This assumption limited OVS to run PMD threads on physical cpu < >>> RTE_MAX_LCORE. >>> >>> DPDK 20.08 introduced a new API that associates a non-

Re: [ovs-dev] [PATCH v7] dpdk: Support running PMD threads on any core.

2021-10-21 Thread Kevin Traynor
On 15/10/2021 15:29, David Marchand wrote: Previously in OVS, a PMD thread running on cpu X used lcore X. This assumption limited OVS to run PMD threads on physical cpu < RTE_MAX_LCORE. DPDK 20.08 introduced a new API that associates a non-EAL thread to a free lcore. This new API does not change

Re: [ovs-dev] [PATCH v7] dpdk: Support running PMD threads on any core.

2021-10-21 Thread Kevin Traynor
On 20/10/2021 16:13, Stokes, Ian wrote: Previously in OVS, a PMD thread running on cpu X used lcore X. This assumption limited OVS to run PMD threads on physical cpu < RTE_MAX_LCORE. DPDK 20.08 introduced a new API that associates a non-EAL thread to a free lcore. This new API does not change th

Re: [ovs-dev] [RFC 00/11] python: introduce flow parsing library

2021-10-21 Thread Eelco Chaudron
On 1 Sep 2021, at 12:00, Adrian Moreno wrote: > While troubleshooting or developing new features in OVS, a considerable > amount of time is spent analyzing flows (whether that's Openflow flows > or datapath flows). Currently, OVS has tools to dump flows with > different levels of verbosity as w

[ovs-dev] [PATCH v5 ovn] controller: add memory accounting for local_datapath

2021-10-21 Thread Lorenzo Bianconi
Similar to if-status-mgr, track memory allocated for local_datapath. Signed-off-by: Lorenzo Bianconi --- Changes since v4: - local_datapath_peer_port_add routine and remove duplicated code - get rid of local_datapath_ext_port_mem_update and use open-coding instead --- controller/binding.c

[ovs-dev] [PATCH v4 2/4] netdev-dpdk: Add flow_api support for netdev gre vports

2021-10-21 Thread Nir Anteby via dev
Add the acceptance of GRE devices to netdev_dpdk_flow_api_supported() API, to allow offloading of DPDK GRE devices. Signed-off-by: Nir Anteby Reviewed-by: Maxime Coquelin --- lib/netdev-dpdk.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/net

[ovs-dev] [PATCH v4 0/4] netdev datapath hardware offload support for GRE flows

2021-10-21 Thread Nir Anteby via dev
V1: Add hardware offload support for GRE flows (experimental). Available only if DPDK experimantal APIs enabled during the build. V2: Rebase version v3: Fixed rebase compilation v4: *Rebase version *Fixed bug found by maxime.coque...@redhat.com, vport is always null *The feature will work

[ovs-dev] [PATCH v4 1/4] netdev-offload-dpdk: Refactor get_vport_netdev()

2021-10-21 Thread Nir Anteby via dev
Refactor the function as a pre-step towards supporting more tunnel types. Signed-off-by: Nir Anteby --- lib/netdev-offload-dpdk.c | 35 +++ 1 file changed, 15 insertions(+), 20 deletions(-) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index

[ovs-dev] [PATCH v4 4/4] netdev-offload-dpdk: Add support for matching on gre fields

2021-10-21 Thread Nir Anteby via dev
Add parsing gre match fields. Signed-off-by: Nir Anteby Reviewed-by: Maxime Coquelin --- NEWS | 2 + lib/netdev-offload-dpdk.c | 97 +++ 2 files changed, 99 insertions(+) diff --git a/NEWS b/NEWS index 90f4b15..fd02d7d 100644 --

[ovs-dev] [PATCH v4 3/4] netdev-offload-dpdk: Support tnl_pop for gre tunnel

2021-10-21 Thread Nir Anteby via dev
Add support for tnl_pop action for gre vport. Signed-off-by: Nir Anteby --- lib/netdev-offload-dpdk.c | 12 1 file changed, 12 insertions(+) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index af56491..a2d7c85 100644 --- a/lib/netdev-offload-dpdk.c +++ b/lib/ne

[ovs-dev] [PATCH] ovsdb-idl: Use functions to apply diff in place.

2021-10-21 Thread Dumitru Ceara
On large scale deployments with records that contain large sets, this significantly improves client side performance as it avoids comparing full contents of the old and new rows. Signed-off-by: Dumitru Ceara --- lib/ovsdb-idl.c | 68 + 1 file chang

Re: [ovs-dev] [PATCH v4 ovn 3/3] controller: add memory accounting for local_datapath

2021-10-21 Thread Lorenzo Bianconi
On Oct 18, Dumitru Ceara wrote: > On 10/14/21 5:17 PM, Lorenzo Bianconi wrote: > > Similar to if-status-mgr, track memory allocated for local_datapath. > > > > Signed-off-by: Lorenzo Bianconi > > --- > > controller/binding.c| 6 ++-- > > controller/local_data.c | 66

[ovs-dev] [PATCH ovn v1 5/5] ovn_detrace.py: add helper to create CookieHandlers

2021-10-21 Thread Adrian Moreno
That way external programs can use such handlers to create all the supported handlers. Signed-off-by: Adrian Moreno --- utilities/ovn_detrace.py.in | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/utilities/ovn_detrace.py.in b/utilities/ovn_de

[ovs-dev] [PATCH ovn v1 2/5] ovn-detrace: use configurable printer object

2021-10-21 Thread Adrian Moreno
Intead of declaring global printing functions, use a configurable printer object that has to declare print_p and print_h. That way external programs that may want to use ovn-detrace can obtain the information provided by ovn-detrace by just re-implementing the printer object Signed-off-by: Adrian

[ovs-dev] [PATCH ovn v1 3/5] ovn-detrace: rename ovn-detrace to ovn_detrace.py

2021-10-21 Thread Adrian Moreno
For external python programs to be able to load ovn-detrace as a python module easily, it should end in .py and should have underscores. Move ovn-detrace to ovn_detrace.py and create a symlink with the old name for backwards compatibility. Signed-off-by: Adrian Moreno --- debian/ovn-common.inst

[ovs-dev] [PATCH ovn v1 4/5] ovn-detrace: expose version as global variable

2021-10-21 Thread Adrian Moreno
That way importers can check it to determine whether a particular feature exists or not. Signed-off-by: Adrian Moreno --- utilities/ovn_detrace.py.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/utilities/ovn_detrace.py.in b/utilities/ovn_detrace.py.in index d26efbd16.

[ovs-dev] [PATCH ovn v1 1/5] manpages.mk: fix dependencies path

2021-10-21 Thread Adrian Moreno
Currently, if "make" is run after the project is built, the root manpage (ovn-detrace.1) is rebuilt unnecessarily. The reason is that its dependencies are wrong: files such as lib/common.man or lib/ovs.tmac do not exist in the project's root path so "make" will constantly rebuild the manpage targe

[ovs-dev] [PATCH ovn v1 0/5] Facilitate external use of ovn-detrace

2021-10-21 Thread Adrian Moreno
ovn-detrace is a very useful tool for debugging OVN issues. It's core logic (mapping openflow cookies / ports with OVN objects) can be used for a variety of troubleshooting tools. Therefore, it would be desirable to make use of such logic from an external python program. This could be done by cre

Re: [ovs-dev] [PATCH v16 3/8] dpif-offload-provider: Introduce dpif-offload-provider layer

2021-10-21 Thread Chris Mi via dev
On 10/21/2021 4:27 PM, Eelco Chaudron wrote: On 21 Oct 2021, at 10:00, Chris Mi wrote: On 10/15/2021 9:42 PM, Eelco Chaudron wrote: Small comments inline, and Ilya please take a look at the first comment/request. //Eelco On 12 Oct 2021, at 10:19, Chris Mi wrote: Some offload actions requ

Re: [ovs-dev] [PATCH v16 3/8] dpif-offload-provider: Introduce dpif-offload-provider layer

2021-10-21 Thread Eelco Chaudron
On 21 Oct 2021, at 10:00, Chris Mi wrote: > On 10/15/2021 9:42 PM, Eelco Chaudron wrote: >> Small comments inline, and Ilya please take a look at the first >> comment/request. >> >> //Eelco >> >> >> On 12 Oct 2021, at 10:19, Chris Mi wrote: >> >>> Some offload actions require functionality that

[ovs-dev] [PATCH v17 0/8] Add offload support for sFlow

2021-10-21 Thread Chris Mi via dev
This patch set adds offload support for sFlow. Psample is a genetlink channel for packet sampling. TC action act_sample uses psample to send sampled packets to userspace. When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to k

[ovs-dev] [PATCH v17 5/8] dpif-offload-netlink: Implement dpif-offload-provider API

2021-10-21 Thread Chris Mi via dev
Implement dpif-offload API for netlink datapath. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein Acked-by: Eelco Chaudron --- lib/automake.mk | 1 + lib/dpif-netdev.c | 3 +- lib/dpif-netlink.c | 11 +- lib/dpif-offload-netlink.c | 207 ++

[ovs-dev] [PATCH v17 8/8] system-offloads-traffic.at: Add sFlow offload test cases

2021-10-21 Thread Chris Mi via dev
Add two sFlow offload test caes: 3: sflow offloads with sampling=1 - ping between two ports - offloads enabled ok 4: sflow offloads with sampling=2 - ping between two ports - offloads enabled ok Signed-off-by: Chris Mi Acked-by: Eelco Chaudron --- tests/system-offloads-traffic.at | 101 +

[ovs-dev] [PATCH v17 7/8] netdev-offload-tc: Add offload support for sFlow

2021-10-21 Thread Chris Mi via dev
Create a unique group ID to map the sFlow info when offloading sFlow action to TC. When showing the offloaded datapath flows, translate the group ID from TC sample action to sFlow info using the mapping. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein --- NEWS| 1 +

[ovs-dev] [PATCH v17 6/8] ofproto: Introduce API to process sFlow offload packet

2021-10-21 Thread Chris Mi via dev
Process sFlow offload packet in handler thread if handler id is 0. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein Acked-by: Eelco Chaudron --- ofproto/ofproto-dpif-upcall.c | 73 +++ 1 file changed, 73 insertions(+) diff --git a/ofproto/ofproto-dpif-upcall.

[ovs-dev] [PATCH v17 2/8] ovs-kmod-ctl: Load kernel module psample

2021-10-21 Thread Chris Mi via dev
Load kernel module psample to receive sampled packets from TC. Before removing kernel module psample, remove act_sample first. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein Acked-by: Eelco Chaudron --- utilities/ovs-kmod-ctl.in | 14 ++ 1 file changed, 14 insertions(+) diff -

[ovs-dev] [PATCH v17 3/8] dpif-offload-provider: Introduce dpif-offload-provider layer

2021-10-21 Thread Chris Mi via dev
Some offload actions require functionality that is not netdev based, but dpif. For example, sFlow action requires to create a psample netlink socket to receive the sampled packets from TC or kernel driver. Create dpif-offload-provider layer to support such actions. Signed-off-by: Chris Mi Review

[ovs-dev] [PATCH v17 4/8] netdev-offload-tc: Introduce group ID management API

2021-10-21 Thread Chris Mi via dev
When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to kernel instead of the sFlow info. psample will send this ID and sampled packet to userspace. Using the ID, userspace can recover the sFlow info and send sampled packet to the

[ovs-dev] [PATCH v17 1/8] compat: Add psample and tc sample action defines for older kernels

2021-10-21 Thread Chris Mi via dev
Update kernel UAPI to support psample and the tc sample action. Signed-off-by: Chris Mi Reviewed-by: Eli Britstein Acked-by: Eelco Chaudron --- include/linux/automake.mk| 4 ++- include/linux/psample.h | 62 include/linux/tc_act/tc_sample.h |

Re: [ovs-dev] [PATCH v16 3/8] dpif-offload-provider: Introduce dpif-offload-provider layer

2021-10-21 Thread Chris Mi via dev
On 10/15/2021 9:42 PM, Eelco Chaudron wrote: Small comments inline, and Ilya please take a look at the first comment/request. //Eelco On 12 Oct 2021, at 10:19, Chris Mi wrote: Some offload actions require functionality that is not netdev based, but dpif. For example, sFlow action requires to

Re: [ovs-dev] [PATCH v16 7/8] netdev-offload-tc: Add offload support for sFlow

2021-10-21 Thread Chris Mi via dev
On 10/15/2021 8:57 PM, Eelco Chaudron wrote: See some small comments below... On 12 Oct 2021, at 10:19, Chris Mi wrote: Create a unique group ID to map the sFlow info when offloading sFlow action to TC. When showing the offloaded datapath flows, translate the group ID from TC sample action to

[ovs-dev] [PATCH v2] dpif:Fix function pointer check for bond_add.

2021-10-21 Thread Somnath Chatterjee via dev
There was typo in function pointer check in dpif_bond_add() before calling bond_add() Fixes: 9df65060cf4c ("userspace: Avoid dp_hash recirculation for balance-tcp bond mode.") Signed-off-by: Somnath Chatterjee --- lib/dpif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/li